Commit Graph

101 Commits

Author SHA1 Message Date
Johannes Meyer 3dce0e434a Add more sophisticated fix for keeping the focus after an autorefresh
fixes #8350
2015-02-17 09:24:38 +01:00
Marius Hein ea57e7a786 History: Do not write abort requests to browser history
Remove req.historyTriggered and introduce req.addToHistory.
2015-02-16 15:56:50 +01:00
Marius Hein ae68e8aec4 Ajax onFailure: Write component URL to container
This is needed that history can push the correct detail url
2015-02-16 14:11:11 +01:00
Thomas Gelf d10beb7604 js: no console.log. please! 2015-02-09 15:26:55 +01:00
Matthias Jentsch b56eb7b669 Fix keyboard navigation
Store current focus position before reload and apply it after rendering.

fixes #8350
2015-02-04 18:01:06 +01:00
Eric Lippmann 6bae2e0a53 Note that our license is GPL v2 or any later version in our license header instead of pointing to the license's URL 2015-02-04 10:52:27 +01:00
Eric Lippmann 5b4fab0750 Add license header
This time without syntax errors hopefully :)
2015-02-03 16:27:59 +01:00
Eric Lippmann 5fa2e3cfdc Revert "Add license header"
This reverts commit 338d067aba.
2015-02-03 16:16:26 +01:00
Eric Lippmann 338d067aba Add license header
fixes #7788
2015-02-03 15:51:04 +01:00
Johannes Meyer 8bb0e4e0a0 Failure requests: Fix auto refresh and history II
Allow to change url's in history and stop auto auto refresh if
the container URL is not up to date.

Use variable after ajax call and the check is more robust.
2015-02-02 16:52:36 +01:00
Marius Hein bc69a3b20f Revert "Failure requests: Fix auto refresh and history"
This reverts commit 8c758a9f12.
2015-02-02 16:40:05 +01:00
Marius Hein 67a426580d loader: Remove gray out on complete handler
A failure did not remove the impact class which colorize
the background gray.
2015-02-02 15:20:12 +01:00
Marius Hein 6555a2ec0a Menu: Move request handling to complete
If a failure occur the menu is still working.
2015-02-02 15:03:36 +01:00
Marius Hein 8c758a9f12 Failure requests: Fix auto refresh and history
Allow to change url's in history and stop auto auto refresh if
the container URL is not up to date.
2015-02-02 13:32:40 +01:00
Marius Hein 190c1e8f04 Revert "Revert "Dashboard: Always replace title""
This reverts commit d1f13819e4.

Please do not ask. This was no syntax error.
2015-02-02 12:04:28 +01:00
Marius Hein d1f13819e4 Revert "Dashboard: Always replace title"
This reverts commit c0c0e7d9e5.

Syntax error
2015-02-02 12:01:40 +01:00
Marius Hein c0c0e7d9e5 Dashboard: Always replace title
This is needed if an error occurs and the exception title was rendered
into the container.
2015-02-02 12:00:08 +01:00
Marius Hein 7b8332ccd8 Notifications do not disappear after autorefresh
This is not affected anymore because the errors goes directly
into the container. But this commit fixes the codes if someone
use the notifications in the loader. Also remove unused
variable this.exception.

fixes #6278
2015-01-30 15:25:12 +01:00
Marius Hein 6ec2ee753d Render error messages in the container itself
fixes #6280
2015-01-30 14:50:25 +01:00
Thomas Gelf 95f9bebdc5 js/loader: support multi-container redirection
Redirections to #!-separated URLs (multiple containers) should also
work when not re-rendering the whole layout.
2014-11-01 01:23:55 +01:00
Thomas Gelf 6298d303c4 js/loader: trigger 'beforerender' container event 2014-11-01 01:12:59 +01:00
Thomas Gelf f25f4f06d8 js/loader: disable click handler block on refresh
This used to be ways too slow when many elements where involved. Left
the old code there as a reminder. In case we really need it we should
use something faster like an overlay or so.
2014-11-01 01:11:12 +01:00
Matthias Jentsch 6124f984ee Adjust scroll position on container after triggering the 'rendered' event
Prevent behaviors from altering the current scroll-position on page reload when refreshing or changing the focus.

fixes #7269
2014-10-14 15:50:15 +02:00
Matthias Jentsch ee63dfd310 Update navigation when the url of the main column changes 2014-10-01 17:47:21 +02:00
Matthias Jentsch fa2c9e46ed Cleanup comments and whitespaces 2014-10-01 16:48:38 +02:00
Matthias Jentsch ef2f332869 Do not refresh a container when form input was changed or a form element is focused
Listen for changes in form elements and abort all reloads that contain a form with
at least one changed form element. Do not refresh containers that contain a focused form
element, except of elements with autofocus, to preserve form elements with a dropdown.
Only focus autofocus elements when there is currently no other selection.

refs #7146
refs #5537
fixes #7162
2014-09-19 15:48:44 +02:00
Matthias Jentsch 7f0a2d540b Tell navigation behavior about changes in active menus
fixes #7181
2014-09-12 15:01:25 +02:00
Matthias Jentsch ad53f7ad3d Use EventEmitter class as a way to delegate events from behaviors to the dom 2014-09-12 09:09:21 +02:00
Matthias Jentsch b7c207a9cb Do not drop preselection in the navigation on reload 2014-09-09 15:32:07 +02:00
Thomas Gelf ef847801f2 js/loader.js: preserve scrolling position...
...on autorefresh and reset it otherwise.

fixes #6285
fixes #6988
2014-09-02 20:11:37 +02:00
Thomas Gelf f12a5741b8 js/loader: postpone redirection handling
Redirections should not be executed unless the original request has been
terminated and removed from pending requests.

fixes #6989
2014-09-02 19:05:49 +02:00
Thomas Gelf 512e7d516b js/loader: Handle __SELF__ in redirection URLs
That's one more step to smoothly handle #! URLs, especially when you
are not yet authenticated.

refs #6935
2014-08-19 10:00:29 +02:00
Johannes Meyer 3105c2059e Remove license headers from all files
refs #6309
2014-07-15 13:43:52 +02:00
Thomas Gelf 329b1cf960 js/loader: correctly get rid of data
I'm unsure whether this is a jQuery bug or not. The removeData()
function has no effect unless there is a matching data attribute.
Makes IMO no sense, as adding the attribute automagically adds data,
so why should removing it differ.

This patch makes sure that the corresponding attribute is removed too.
Fixes "dashboard sometimes flickering on refresh".

refs #6536
2014-07-08 20:10:44 +02:00
Thomas Gelf bbc0c36225 js/loader: remove pending request on form redirect
Our redirection helper catching forms redirecting to their source
while being shown right-hand left a pending request. Abort was triggered,
but had no effect as the request has already been completed.

fixes #6619
2014-07-07 20:12:49 +02:00
Thomas Gelf 590db51255 js/loader: handle form redirections automagically
An XHR redirection in a right-side container pointing to the URL
shown on the left should close it's own container and refresh the
lefthand one.

refs #6436
fixes #6435
2014-06-30 16:19:05 +02:00
Thomas Gelf 30106a9cbd js/loader: autorefresh requests should run parallel
The check whether a request was already running failed as soon as
another request was activ. Now they run as they should.
2014-06-25 20:15:44 +02:00
Thomas Gelf 0604d30348 js/loader: stop pending subcontainer requests
When redrawing a container we should cancel it's subcontainers pending
requests. This also fixes stopPendingRequestsFor(), it didn't really
work before.
2014-06-24 07:01:37 +02:00
Thomas Gelf 473a705e2e Assign unique ids to dashlets and subcontainers
Without this we have no chance to cancel pending requests for dashlets.

fixes #6552
2014-06-24 06:40:08 +02:00
Thomas Gelf 6f19bb13b8 js/loader: ignore focus on autosubmitting elements
Autorefresh response is not rendered while your focus sits in a form.
This is not so useful for autosubmitting elements, let's ignore them.
2014-06-23 14:04:02 +02:00
Thomas Gelf 23ed744747 params/_render: replace it everywhere
Cleaning up controllers and JS, using headers only and respecting
history.
2014-06-22 20:07:44 +02:00
Thomas Gelf aded901aa5 js/loader: reload CSS BEFORE redirecting 2014-06-22 20:01:10 +02:00
Thomas Gelf 41b8b8cf31 js/loader: remove history-related noisy log entry 2014-06-22 19:58:58 +02:00
Thomas Gelf 180a6f08f5 js/loader: notifications should survive new layout
Once replacing the whole layout we used to override notifications.
This is now fixed, they are going to be detached and re-attached
before and after re-rendering the page content.
2014-06-22 19:55:50 +02:00
Thomas Gelf 78193137f0 config/modules: show metadata, improve usability
Well... I didn't want to commit this before creating single-button
forms for enabling/disabling modules. However part of this accidentally
made it through, so let's finish it.

Still some work to do, but it already looks far better like this.

refs #4095
2014-06-21 02:27:27 +02:00
Thomas Gelf 747083d322 JS/history: handle also requests out of containers
On login/logout (not only) we have requests not rendered to containers.
History handling only cared about them and failed.

fixes #6466
2014-06-21 01:57:59 +02:00
Thomas Gelf a79f786546 JS/loader: add icon cache prototype
Just playing around, I'm still unsure whether this really helps. The
motivation behind this patch are icons loaded again after not being
displayed for a little while.

Remains disabled unless we know whether and for which scenarios
(cache disabled, HTTPS...) this really helps.
2014-06-20 16:18:10 +02:00
Thomas Gelf 06a8803242 JS/loader: add failed requests to history
It's confusing if they are handled differently
2014-06-20 16:16:04 +02:00
Thomas Gelf bd57f8f02a JS/loader: don't autorefresh while editing
We would loose our focus if autorefresh takes place. So we don't render
the new content in case a form field in the very same container carries
the focus. It would be great to have a better solution one far day, but
for now it plays fine like this.
2014-06-20 13:52:05 +02:00
Thomas Gelf 28c61c2595 JS/XHR: last commit was missing the JS part 2014-06-20 13:22:53 +02:00