Commit Graph

242 Commits

Author SHA1 Message Date
Johannes Meyer 6c70a53309 Avoid to instantiate custom form element validators directly
refs #8415
2015-02-12 09:11:02 +01:00
Eric Lippmann 6bae2e0a53 Note that our license is GPL v2 or any later version in our license header instead of pointing to the license's URL 2015-02-04 10:52:27 +01:00
Eric Lippmann 5b4fab0750 Add license header
This time without syntax errors hopefully :)
2015-02-03 16:27:59 +01:00
Eric Lippmann 5fa2e3cfdc Revert "Add license header"
This reverts commit 338d067aba.
2015-02-03 16:16:26 +01:00
Eric Lippmann 338d067aba Add license header
fixes #7788
2015-02-03 15:51:04 +01:00
Johannes Meyer 50fc85d7ff Rename authentication type "autologin" to "external"
refs #8274
2015-01-27 09:49:36 +01:00
Johannes Meyer 359336243c Save "none" instead of "null" when choosing to not to store preferences
refs #8234
2015-01-23 16:25:24 +01:00
Johannes Meyer 2a543bb5ae Rename the preference setting `type' to `store'
refs #8234
2015-01-23 16:25:23 +01:00
Johannes Meyer 14a4aaeb77 Revert "Fix that when chosing to not to store preferences an invalid config is created"
This reverts commit 6284da451e.
2015-01-23 15:23:43 +01:00
Johannes Meyer 6284da451e Fix that when chosing to not to store preferences an invalid config is created
fixes #8234
2015-01-23 14:42:09 +01:00
Johannes Meyer 2d957205ef Using $this when not in object context, doesn't work.
refs #7551
2015-01-19 13:47:53 +01:00
Johannes Meyer dbd69ba693 Replace t() and mt() with translate() in the application's forms
refs #7551
2015-01-19 11:26:23 +01:00
Eric Lippmann f0fe6246ac Use '/var/log/icingaweb2/icingaweb2.log' as default path when logging to file 2014-12-29 16:02:40 +01:00
Eric Lippmann 5bc2144b18 Use 'icingaweb2' as default application prefix for logging to syslog 2014-12-29 16:01:07 +01:00
Eric Lippmann cfb52eeadb Do not use a default regular expression for stripping off parts of a username when configuring an auto-login backend
There's no safe default for this.
2014-12-29 15:56:32 +01:00
Eric Lippmann e1bedc9afe Use Icinga 2's default Livestatus socket path as default when configuring a livestatus resource 2014-12-29 15:55:57 +01:00
Johannes Meyer ebf908b1b5 Make db requirement checks more sensitive
fixes #7837
2014-12-01 15:38:10 +01:00
Johannes Meyer 1cbdd2b51c Fix that hidden elements are getting ovewritten when validating a form
This works by "disabling" hidden elements which causes the browser not
to submit them. Due to a bug in Zend we need to manually ensure that
Form::isValid does not overwrite the value of disabled elements with null.

fixes #7717
2014-11-18 15:06:46 +01:00
Johannes Meyer 7621f6642d Adjust usages of Icinga\Application\Config
refs #7147
2014-11-18 13:11:52 +01:00
Johannes Meyer 812f9af949 Change modulePath setting to module_path
fixes #7694
2014-11-17 10:10:08 +01:00
Johannes Meyer ddf2ef5cc9 Remove $request parameter from Form::onSuccess and Form::onRequest
fixes #7552
2014-11-14 14:59:29 +01:00
Johannes Meyer 775c20d9ad Rename namespace Icinga\Form to Icinga\Forms
refs #7553
2014-11-14 10:57:14 +01:00
Johannes Meyer 1c4a5ce86f Leave it up to Icinga\Web\Form to instantiate our own form elements 2014-11-14 10:15:27 +01:00
Eric Lippmann ac2ec83852 Merge branch 'master' into feature/localization-form-6073
Conflicts:
	library/Icinga/Application/ApplicationBootstrap.php
	test/php/library/Icinga/User/Store/DbStoreTest.php
2014-11-13 17:03:41 +01:00
Eric Lippmann bfa834fc3b Remove constant ICINGAWEB_APPDIR
We should avoid use of constants.
2014-11-13 09:33:31 +01:00
Alexander Fuhr 8d4e56a1fe Remove timezone element from the ApplicationConfigForm 2014-11-12 12:09:47 +01:00
Johannes Meyer c3e28a42fb Remove configuration option for setting the access mode on new files 2014-11-12 09:40:07 +01:00
Johannes Meyer af99f62843 Prefer Icinga\Application\Config over Zend_Config
refs #7163
2014-11-11 12:11:14 +01:00
Johannes Meyer 9d292269b1 Merge branch 'master' into feature/setup-wizard-7163
Conflicts:
	application/forms/Config/Resource/LdapResourceForm.php
	test/php/application/forms/Config/Authentication/LdapBackendFormTest.php
2014-11-11 09:44:11 +01:00
Johannes Meyer 9a5d01b3fd Check the mysql or pgsql extension instead of just pdo, really 2014-11-07 14:31:20 +01:00
Johannes Meyer 7b99b74ae1 Prefer Icinga\Application\Config instead of Zend_Config
refs #7147
2014-11-07 13:53:03 +01:00
Alexander Fuhr 2e24c53224 Merge branch 'master' into feature/localization-form-6073
Conflicts:
	application/forms/Config/GeneralForm.php
	application/forms/Preference/GeneralForm.php
	library/Icinga/Application/Web.php
2014-11-05 13:27:45 +01:00
Johannes Meyer 5a169ee656 Fix "PreservingIniWriter not found"
The class was renamed a few commits ago to "IniWriter"
2014-11-04 14:35:57 +01:00
Johannes Meyer 170ded6510 Merge branch 'master' into feature/setup-wizard-7163
Conflicts:
	library/Icinga/Authentication/Backend/LdapUserBackend.php
	library/Icinga/File/Ini/IniWriter.php
2014-11-04 14:22:53 +01:00
Eric Lippmann 16352fc10c Move Logger to the Application namespace
fixes #7148
2014-10-31 10:27:17 +01:00
Johannes Meyer f5c4708ae2 Add a default file mode for new configuration files
The file mode which can be configured in the general configuration is now
used when creating new configuration files with the PreservingIniWriter.
2014-10-21 17:02:21 +02:00
Johannes Meyer 3a3d29ea4f Add more detailed explanations when configuring authentication backends
refs #7163
fixes #7411
2014-10-21 16:15:04 +02:00
Johannes Meyer 8c62c66a4e Make regular expression pattern in autologin backend being fully optional 2014-10-20 15:14:14 +02:00
Johannes Meyer 768d8da4f8 Fix that syslog or file config elements are not shown in case of no default 2014-10-17 13:11:25 +02:00
Johannes Meyer 9f127be1dc Merge branch 'master' into feature/setup-wizard-7163
Conflicts:
	application/forms/Config/General/LoggingConfigForm.php
2014-10-17 13:04:59 +02:00
Eric Lippmann 5ca97c14d6 logging config: Support 'log' 'none' 2014-10-16 16:13:00 +02:00
Eric Lippmann f9e7e6d888 general config: Don't keep unused configuration directives 2014-10-16 11:20:16 +02:00
Johannes Meyer 1daeaef1c5 Fix that it is not possible to create an autologin auth backend
Occured only when no database resource nor a ldap resource exists.
2014-10-15 10:51:18 +02:00
Johannes Meyer 00ffb34829 Fix incorrect form fields being displayed when no database resource exists 2014-10-15 10:48:50 +02:00
Johannes Meyer 94f8745fc0 Fix authentication backend validation 2014-10-15 10:46:40 +02:00
Johannes Meyer 8f7348b823 Revert "Fix backend validation of LdapBackendForm"
This reverts commit 0777848a84.
2014-10-15 08:49:17 +02:00
Matthias Jentsch 0777848a84 Fix backend validation of LdapBackendForm 2014-10-14 14:44:51 +02:00
Matthias Jentsch 771149e8d6 Move optional base_dn to end of form 2014-10-14 14:44:31 +02:00
Matthias Jentsch e3164a275f Clarify the new meaning of an ldap resource's `root_dn' directive 2014-10-09 10:13:26 +02:00
Matthias Jentsch 04e83a53c5 Add `base_dn' directive to LDAP backend config 2014-10-09 10:10:09 +02:00
Johannes Meyer 1cbe2451a8 Merge branch 'master' into feature/setup-wizard-7163
Conflicts:
	application/forms/Config/Resource/StatusdatResourceForm.php
2014-10-08 16:34:31 +02:00
Eric Lippmann 1b23fd7fbe monitoring: Don't support status.dat as backend
Icinga Web 2 will not support status.dat for now and maybe forever.
2014-10-07 13:22:07 +02:00
Johannes Meyer 0793033559 Add translation contexts to ambiguous form element labels 2014-10-02 16:34:44 +02:00
Johannes Meyer ab93969944 Add missing platform checks to DbResourceForm 2014-09-29 14:46:27 +02:00
Johannes Meyer a5454e5702 Improve form element description 2014-09-29 11:24:23 +02:00
Johannes Meyer 2c44fe34a7 Fix that ldap auth validation does not send a BIND request 2014-09-29 11:22:43 +02:00
Johannes Meyer 7e00e83772 Make the loglevel ERROR being the default
refs #7163
2014-09-29 11:21:15 +02:00
Johannes Meyer 380ffe45b9 Add some redundancy to get more implicitness
Although this commit does not seem reasonable
at first the "big" picture proves its necessity!

refs #7163
2014-09-29 11:20:39 +02:00
Johannes Meyer 4f688fa544 Let the form decide where to get the resource configuration from
refs #7163
2014-09-29 11:06:16 +02:00
Johannes Meyer 0e92e333aa Make isValid* calls of configuration forms being static
This allows a more flexible usage as there is no need to access instance
formdata when validating such configuration.
2014-09-29 11:02:45 +02:00
Johannes Meyer 80c42ce499 Fix autosubmit of Icinga\Form\Config\General\LoggingConfigForm 2014-09-24 10:46:35 +02:00
Johannes Meyer ceeb3a9ff8 Fix createElements() not returning self where applicable
refs #5525
2014-09-09 13:24:39 +02:00
Johannes Meyer 31978e1236 Fix LdapBackendFormTest
refs #5525
2014-09-09 10:36:42 +02:00
Johannes Meyer f53519c54d Rename ConfigForm::setConfig() to ConfigForm::setIniConfig()
We do not want to override Zend_Form::setConfig() so this renaming is
required. set*Ini*Config() because ConfigForm::save() utilizes an ini-writer
to persist the configuration to disk.

refs #5525
2014-09-08 13:31:25 +02:00
Johannes Meyer 930e6e7d71 We shouldn't require Form::createElements() to return self
refs #5525
2014-09-08 09:24:53 +02:00
Johannes Meyer 54a834266c Form::createElements() should add elements instead of returning them
In case createElements() would still return the elements while requiring
the caller to add them to the form all form dependent configurations get
lost. (displaygroups, belongTo, ...) Wizards or parent forms can still
retrieve only input relevant fields by just calling createElements() and
getElements().

refs #5525
2014-09-03 12:21:31 +02:00
Johannes Meyer 5ce9bef689 Replace usages of the `helptext' form element option with `description'
refs #5525
2014-09-02 17:03:51 +02:00
Johannes Meyer 95c839a8bd Remove remaining usages of the ElementWrapper- and HelpText-Decorator
refs #5525
2014-09-02 16:50:59 +02:00
Johannes Meyer 2d86e6ba3b Rename ResourceForm and make it use handleRequest() & Co.
refs #5525
2014-09-02 16:25:03 +02:00
Johannes Meyer 5b14d8fed3 Fix that the force_creation checkbox disappears after another error
Once the user enters invalid data after he tried to save a backend without
success (because the backend was not successfully validated) the shown
checkbox disappeared in this case regardless of whether it was checked
or not.

refs #5525
2014-09-02 16:25:03 +02:00
Johannes Meyer 39bb01b433 Rename Icinga\Web\Form::onShow() to onRequest()
onShow() is misleading because at the time this method is being called the
form is neither shown nor created.

refs #5525
2014-09-02 16:19:45 +02:00
Johannes Meyer deebb64869 Adjust Icinga\Form\Config\General* to use handleRequest() & Co.
refs #5525
2014-09-01 16:16:56 +02:00
Johannes Meyer 0e63e36ec0 Move Icinga\Form\Config\ConfirmRemovalForm to Icinga\Form
This is a generic form not necessarily being used just for configuration
purposes.

refs #5525
2014-09-01 15:11:09 +02:00
Johannes Meyer fb5685bac3 Merge branch 'master' into bugfix/rebuild-form-builder-5525
Conflicts:
	application/forms/Config/Authentication/BaseBackendForm.php
	application/forms/Config/Authentication/DbBackendForm.php
	application/forms/Config/Authentication/LdapBackendForm.php
	application/forms/Config/Authentication/ReorderForm.php
	application/forms/Config/LoggingForm.php
	application/forms/Config/ResourceForm.php
	application/forms/Preference/GeneralForm.php
	library/Icinga/Application/Config.php
	library/Icinga/Web/Form.php
	modules/monitoring/application/controllers/ConfigController.php
	modules/monitoring/application/forms/Config/Backend/CreateBackendForm.php
	modules/monitoring/application/forms/Config/Instance/CreateInstanceForm.php
	modules/monitoring/application/forms/Config/Instance/EditInstanceForm.php
	modules/monitoring/application/forms/Config/SecurityForm.php
2014-08-29 16:05:56 +02:00
Johannes Meyer ae35650c7e Adjust authentication backend forms to suit.. some form implementation
refs #5525
2014-08-29 15:16:13 +02:00
Marius Hein e345aa257a Platform: Drop *Available function
Create a function extensionLoaded and change usages.

refs #5514
2014-08-28 12:14:55 +02:00
Marius Hein 436a4d2965 ResourceConfig: Chance createResouce to create
Not useful everywhere. Changed on the best suitable places.

refs #5514
2014-08-28 12:14:55 +02:00
Marius Hein 22e17e9901 ResourceFactory: Move available function to platform
refs #5514
2014-08-28 12:14:54 +02:00
Alexander Klimov 45638b218c Throw IcingaException rather than Exception
fixes #7014
2014-08-27 16:03:15 +02:00
Alexander Klimov 7ff51caed0 Remove leading backslashes from the targets of use statements
- use \Exception;
+ use Exception;
2014-08-27 15:51:49 +02:00
Eric Lippmann 1dea19504f Revert "Remove leading backslashes from the targets of use statements"
This reverts commit 87a5967501.

At least 'modules/doc/run.php' issues a warning about "The use statement with non-compound name 'Zend_Controller_Router_Route' has no effect"
2014-08-27 12:24:11 +02:00
Alexander Klimov 87a5967501 Remove leading backslashes from the targets of use statements
- use \Exception;
+ use Exception;
2014-08-27 11:16:44 +02:00
Johannes Meyer 7b221e2aba It should not be a form's responsibility how its submit button should look..
...in case it's a standard button. No need to be DRY here.

refs #5525
2014-08-22 15:20:54 +02:00
Johannes Meyer a0b2c0b454 Fix another documentation block 2014-08-22 12:18:26 +02:00
Johannes Meyer 75a0c17933 Ensure that all forms have a name
refs #5525
2014-08-22 12:15:02 +02:00
Johannes Meyer 2b879b344f Do not populate using createElements() and fix documentation blocks
refs #5525
2014-08-22 12:04:14 +02:00
Johannes Meyer bc05d2ee64 Merge LoggingForm into GeneralForm
fixes #6933
2014-08-22 11:05:20 +02:00
Johannes Meyer bb7972aa39 Merge branch 'master' into bugfix/rebuild-form-builder-5525
Conflicts:
	application/controllers/AuthenticationController.php
	application/controllers/ConfigController.php
	application/forms/Authentication/LoginForm.php
	application/forms/Preference/GeneralForm.php
	modules/monitoring/application/controllers/ChartController.php
2014-08-20 13:13:50 +02:00
Johannes Meyer 4ddc0e718b Report the default language also as being available for setting up the locale
fixes #6905
2014-08-14 10:48:52 +02:00
Johannes Meyer fe63ce664f Make use if 'ignore´ instead of explicitly unsetting array keys
refs #5525
2014-08-12 13:57:28 +02:00
Johannes Meyer a627571b87 Drop obsolete button elements
refs #5525
2014-08-11 10:46:45 +02:00
Johannes Meyer f0a99274e6 Access backend information by using getValue() instead of getConfig()
refs #5525
2014-08-11 10:46:08 +02:00
Johannes Meyer 5203f82b80 Fix message translation 2014-08-11 10:44:21 +02:00
Johannes Meyer a37e65be52 Fix coding style 2014-08-11 10:43:54 +02:00
Johannes Meyer d260c3fb94 Do not overwrite __construct() in forms, there's init() for that purpose
refs #5525
2014-08-11 10:39:13 +02:00
Johannes Meyer c36e30af1e Remove DbBackendForm::getConfig as it's not used anywhere
refs #5525
2014-08-11 09:13:41 +02:00
Alexander Klimov 4e1e845675 DbBackendForm: replace create with createElements and getResources with __construct
refs #5525
2014-07-29 12:22:43 +02:00
Alexander Klimov 5e6ef57590 LdapBackendForm: replace create with createElements and getResources with __construct
refs #5525
2014-07-29 12:21:58 +02:00
Alexander Klimov ed10e49bb6 Add AutologinBackendForm
fixes #6434
2014-07-25 14:51:42 +02:00
Johannes Meyer 26a78dc387 Remove properties from ConfirmRemovalForm and update it
Which object should be removed needs not to be a part of a form but is
accessible from the url's query string which should be in the action of the
form.

refs #5525
2014-07-24 16:20:01 +02:00