bb99358a21
Renamed MonitoringView to AbstractView
2013-09-17 10:41:02 +02:00
258d7dbafb
Did measurements, leads to new index suggestions
2013-09-17 10:38:14 +02:00
cc4cf42d0e
Some TODO
2013-09-17 10:38:14 +02:00
4b62297b3e
Searching for 'unhandled' is more interesting than 'handled', other small fixes
2013-09-17 10:38:14 +02:00
344a99bbb8
service_hard_state is the current hard state
2013-09-17 10:38:14 +02:00
b9805e579e
A service is considered handled once the host is not UP
2013-09-17 10:38:14 +02:00
781fb394ac
More cleanup, timestamp fixes
2013-09-17 10:38:14 +02:00
cd37f47d1b
Last/next check are timestamps, give NULL when it doesn't make sense
2013-09-17 10:38:14 +02:00
200731aedc
Some more readability
2013-09-17 10:38:14 +02:00
d5c86c5328
Readability, small fixes
2013-09-17 10:38:13 +02:00
76ecc9184d
hgo.name1 needs objects table to be around
2013-09-17 10:38:13 +02:00
93e54fac62
Trying hard to get aggregations done right
2013-09-17 10:38:13 +02:00
7e83099ef7
One more thing TODO
2013-09-17 10:38:13 +02:00
3cd947ab29
A bunch of aggregating columns are interesting once joined with services
2013-09-17 10:36:05 +02:00
86248d7bcb
hostgroup. Without the 's'. And case insensitive
2013-09-17 10:36:05 +02:00
6d27b688fe
Added hostgroups column alias. Not sure about the 's'
2013-09-17 10:36:05 +02:00
eaaa7205c9
Have been using former namespace, fixed
2013-09-17 10:36:05 +02:00
cf26e3b106
Ido\AllcontactsQuery joins contacts directly and through contactgroups
2013-09-17 10:36:04 +02:00
d9f1c4678b
Ido\ContactgroupQuery needs a conservative count approach
2013-09-17 10:36:04 +02:00
521ef8cc47
Added a few columns to Ido\ContactgroupQuery, fixed joins
2013-09-16 17:02:30 +02:00
23235e4513
Added a few columns to Ido/ContactQuery
2013-09-16 17:02:30 +02:00
fbdfa7a59e
StatehistoryQuery, initial commit
2013-09-16 17:02:30 +02:00
07badc377e
NotificationhistoryQuery, initial commit
2013-09-16 17:02:30 +02:00
4330122221
DowntimestartQuery and DowntimeendQuery, initial commit
2013-09-16 17:02:30 +02:00
eef5f6ae18
CommenthistoryQuery, initial commit
2013-09-16 17:02:30 +02:00
d15481b643
Preparing base query before creating alias indexes.
...
* This allows the joinBaseTables functions to adjust columns in time
2013-09-16 17:02:30 +02:00
bd983c7478
Default joinBaseTables implementation, can simplify simple queries
2013-09-16 17:02:30 +02:00
f3eedd919f
No more need for special treatment for some columns, as we can create filter* functions
2013-09-16 17:02:30 +02:00
830b178e37
Fixed hardcoded default columns
2013-09-16 17:02:29 +02:00
1c2142be27
Prepared filter support for aggregated columns (where VS having)
2013-09-16 17:02:29 +02:00
df07735e9a
Prepared more Oracle-specific id-columns
2013-09-16 17:01:47 +02:00
d44c15eea0
Filter handling cleanup and small improvements:
...
* a pipe (|) is now accepted as OR
* improved readability
* prepared for splitting logic - most of this could be backend-agnostic
* greater / less then is now possible
2013-09-16 17:01:47 +02:00
5467950e79
Shortcut for creating subqueries
2013-09-16 17:01:47 +02:00
8baa2dec54
Command: Rename getParameters to getArguments
...
refs #4580
2013-09-16 14:46:18 +02:00
a47db3497e
Rename BaseCommand to Command
...
refs #4580
2013-09-16 14:44:59 +02:00
bf012fbd7e
Remove CommandType interface
...
Moved BaseCommand from the monitoring module to the application's library.
refs #4580
2013-09-16 14:39:14 +02:00
8e60e2dcd9
Fix group and children handling of ScheduleDowntimeCommand
...
refs #4580
2013-09-16 13:14:29 +02:00
7045148f93
Adjust submitpassivecheckresult command handling
...
refs #4580
2013-09-16 13:14:29 +02:00
fef8370d5f
Adjust reschedulecheck command handling
...
refs #4580
2013-09-16 13:14:28 +02:00
e9dc895b37
Adjust delay notification handling
...
refs #4580
2013-09-16 13:14:28 +02:00
36424b508b
Adjust custom notification handling
...
refs #4580
2013-09-16 13:14:28 +02:00
52079b2e73
Adjust schedule downtime handling
...
refs #4580
2013-09-16 13:14:28 +02:00
ba7f455643
Adjust schedule downtime handling (WIP)
...
refs #4580
2013-09-16 13:14:28 +02:00
8022bf57af
Some doc fixes and other improvements
...
refs #4580
2013-09-16 13:14:28 +02:00
c09dad98f9
Views: Remove $trimArea since it's not used
2013-09-06 16:39:47 +02:00
c47778f10e
Capitalize monitoring properties, e.g. Current Attempt
2013-09-05 14:49:37 +02:00
a5908c9553
CS: Replace multiple empty lines with one
...
find application/ library/Icinga/ test/ modules/ -name *.php | xargs sed -i '/^$/N;/^\n$/D'
2013-09-04 18:36:10 +02:00
35fd9fd391
CS: Remove whitespaces at end of line
...
find application/ library/ test/ modules/ -name *.php | xargs sed -i 's/\s\+$//'
2013-09-04 18:27:16 +02:00
7f4e1936f7
Fix trigger downtime default value issing, docstring fixes
...
refs #4580
2013-09-04 18:08:00 +02:00
b74e264f01
Refactor comment command handling
...
- Refactored Comment class
- Dropped IComment interface
- Added AddCommentCommand class
- Updated CommentForm
refs #4580
2013-09-04 18:08:00 +02:00
9a476f16f4
Re-refactor dispatch process of commands and acknowledgement handling
...
refs #4580
2013-09-04 18:08:00 +02:00
1593406f31
Refactor Acknowledgement command handling
...
#refs 4580
2013-09-04 18:07:59 +02:00
79eb6588c5
Restructure dispatch process of commands
...
refs #4580
2013-09-04 18:07:59 +02:00
95d7a8a553
Fix triggered_by field in ScheduleDowntimeForm is not a select box
...
refs #4496
2013-09-04 18:07:59 +02:00
2b10782d6b
Fix use \Monitoring without Icinga\Module prefix
...
refs #4601
2013-09-04 16:08:20 +02:00
e915119845
Fix grid styling and add links for hosts and service
...
refs #4601
2013-09-04 15:22:01 +02:00
d27e34cef8
Codestyle and Test fixes for SortBox
...
refs #4601
2013-09-04 15:22:00 +02:00
57e66c247a
Add sort widget, change js path from module to app, small style fixes
...
refs #4601
2013-09-04 15:22:00 +02:00
1b858cbdb4
Monitoring: Fix remaining usages of namespace Monitoring without Icinga\Module prefix
...
refs #4586
2013-09-04 11:21:12 +02:00
3e4d1aa2fb
Monitoring/Tests: Replace BaseFormTest with BaseTestCase
...
refs #4586
2013-09-04 11:21:12 +02:00
e3044b8b62
Tests/Monitoring: Remove ScheduleDowntimeFormTest since it's being refactored in another branch
...
refs #4586
2013-09-04 11:21:12 +02:00
a89631fd92
Tests/Monitoring: Remove useless test ConfirmationFormTest
...
refs #4586
2013-09-04 11:21:12 +02:00
74b9731df5
Remove auto class requirement from BaseTestCase::createForm()
...
The tests for the respective forms must require the form class.
refs #4586
2013-09-04 11:21:12 +02:00
8a062ff3e5
Fix tests after renaming the namespace
...
refs #4586
2013-09-04 11:21:12 +02:00
c86874d4ba
Rename namespace Monitoring to Icingæ\Module\Monitoring
...
refs #4586
2013-09-04 11:21:11 +02:00
23f0962da1
Adjust command forms and tests
...
Made those command forms using the DateTimePicker
element compatible with its new validation.
refs #4581
2013-09-03 09:27:02 +02:00
9f923b4940
Fix pagination and remove ModuleController, rename handlesAuth
...
This commit introduces the following changes:
- Count is now performed after joins are added to the selection query,
therefore returning the correct number
- MonitoringControllerTest now needn't to mock ModuleActionController (which is now removed)
- handlesAuthentication is now requiresAuthentication
- Redirection to login is now directly handled in the ActionController constructor,
so we don't need to overwrite the preDispatch method
refs #4589
refs #4591
refs #4572
2013-09-02 18:42:05 +02:00
24ecbb56d7
Fix incorrect checkresult type selection
...
When submitting a passive checkresult for hosts only their correct
result types are added to the selection.
refs #4600
2013-09-02 17:24:42 +02:00
d0ac97f335
Configure fixes, regression test for 4606
...
The configure routine still has to be improved, right now unused
authentication backends are commented out
refs #4491
refs #4606
refs #4640
2013-08-29 11:48:32 +02:00
b5812fd56c
Fix installation via configure/make
...
The installation routine uses the .htaccess file right now, as
this is used in the 'dump' /var/www installation.
refs #4491
2013-08-29 11:47:10 +02:00
4527aaf57a
Smaller fixes in phpdoc style
...
refs #4566
2013-08-28 14:42:31 +02:00
13e4efa221
Make use of the helptext decorator if suitable
...
Refactored some uses of the form element Note so that
each one is properly attached to its input element.
refs #4566
2013-08-28 08:57:46 +02:00
2f610b70ac
Fix icon identifer and capitalization
...
refs #4550
refs #4584
2013-08-23 10:58:58 +02:00
895976550c
Fix templates, capitalization and icons in php files
...
refs #4550
refs #4584
2013-08-23 10:28:48 +02:00
015a914aab
Fix template code style, use Bootstrap 3, remove icons
...
- Icons have now the {{XY_ICON}} format
- custom classes are removed
- A few typos are fixed
- Capitalization
refs #4550
refs #4621
refs #4584
2013-08-23 10:28:48 +02:00
872fa2ac6c
HTML Style fixes and class removals
...
refs #4550
2013-08-23 10:28:47 +02:00
bff45a1eb2
Template cleanup and validation part 1
...
refs #4550
2013-08-23 10:27:16 +02:00
1378ca9844
Remove and reorganize stylesheets, add boostrap 3
...
refs #4550
2013-08-23 10:27:16 +02:00
95ad8da2a3
Fix class not found exception when trying to send commands
...
This has already been fixed but got lost during a rebase,
so no ticket ref exists.
2013-08-21 16:48:12 +02:00
edb06ea8ea
CS: Fix viloations for touched files in branch feature/backend-configuration-ui-3776
...
refs #3776
2013-08-21 14:22:31 +02:00
585f69fe8f
Monitoring/Configuration: Show ido, Ido as IDO
...
refs #3776
2013-08-21 14:22:30 +02:00
cd1fb2e4b5
Capitalization, smaleler codestyle fixes
...
refs #3776
2013-08-21 14:22:30 +02:00
83d053965f
Implement monitoring instance and backend configuration forms
...
refs #3776
2013-08-21 14:22:30 +02:00
a6ff6ecadd
Fix Codestyle/PHPDoc, fix configPath being Overwritten
...
Also removed possibility to disable debugging as there's no use case for this
refs #4525
refs #4598
2013-08-21 14:22:30 +02:00
972bc9853e
Configuration interfaces for logging, authentication and general configuration
...
- Added HelpText decorator
- Added Time and DateFormatValidator
- Added tests
refs #3777
2013-08-21 14:22:30 +02:00
17c1e5a449
Add tests, move BaseFormTest away from modules/monitoring
...
refs #3777
2013-08-21 14:18:53 +02:00
26a5018d16
Add Forms and conditional hidden
...
refs #3777
2013-08-21 14:18:53 +02:00
d7358c65be
Remove QUrl and QLink, add Href
...
refs #4516
2013-08-21 09:44:01 +02:00
6765648380
Monitoring: Fix nonexistent Icinga\Backend usage in CommandController
2013-08-21 09:44:01 +02:00
d574a26db3
Monitoring: Fix nonexistent Icinga\Backend usage in CommandController
2013-08-20 16:19:34 +02:00
d1cc1fb61f
Codestyle and doc strings for list controller
...
refs #4583
2013-08-20 15:45:44 +02:00
df864d2738
Remove unused summary components
...
refs #4583
2013-08-20 15:38:00 +02:00
ff1ed128ef
Remove filter boxes from monitoring' list views since they're not working
...
refs #4583
2013-08-20 15:14:58 +02:00
ad84e9e9cf
Remove unimplemented list views (concat-, host-, and servicegroups)
...
refs #4583
2013-08-20 15:14:57 +02:00
207c47ae64
Nav: Remove tabs from ListController since their links are redundant to the main menu
...
refs #4583
2013-08-20 15:14:57 +02:00
bda3537c36
Comment out error-prone checktime test
...
The check time test for the host list easily fails when the db access
is slower than 1s, so it's commented out here
refs #4575
2013-08-19 20:16:40 +02:00
3a8a3b8f2c
Monitoring backend: Change database objects to DbAdapterFactory
...
refs #4575
2013-08-19 18:29:26 +02:00
eddbbd5f5b
Monitoring backend: Move backends.ini to module configuration
...
refs #4575
2013-08-19 18:29:26 +02:00
f081531585
Phpdoc and small text fixes
...
refs #4524
2013-08-16 17:38:50 +02:00
a45409c5f3
Monitoring/Commands/Forms/Tests: Follow our Coding Standards
...
refs #4524
2013-08-16 17:38:50 +02:00
5e85dd1c06
Monitoring/Commands: Fix reschedule next check form tests
...
refs #4524
2013-08-16 17:38:50 +02:00
26f7b740c5
Monitoring/Commands: Fix delay notification form tests
...
refs #4524
2013-08-16 17:38:50 +02:00
9f1da2db1a
Monitoring/Commands: Add help messages to the submit passive check result form
...
refs #4524
2013-08-16 17:38:50 +02:00
b46df485ae
Monitoring/Commands: Add help messages to the schedule downtime form
...
refs #4524
2013-08-16 17:38:50 +02:00
48a393894c
Monitoring/Commands: Add help messages to the reschedule next check form
...
refs #4524
2013-08-16 17:38:50 +02:00
bcdda6c0c6
Monitoring/Commands: Add help messages to the delay notification form
...
refs #4524
2013-08-16 17:38:50 +02:00
329d63839b
Monitoring/Commands: Fix tests
...
refs #4524
2013-08-16 17:38:50 +02:00
3d3fbb123d
Monitoring/Commands: Add help messages to the custom notification form
...
refs #4524
2013-08-16 17:38:50 +02:00
9c047f5b72
Monitoring/Commands: Fix typos in forms
...
refs #4524
2013-08-16 17:38:49 +02:00
0af63ea751
Monitoring/Commands: Add help messages to the add comment form
...
refs #4524
2013-08-16 17:38:49 +02:00
fb71ecc5ca
Monitoring/Commands: Add help messages to the problem acknowledgement form
...
refs #4524
2013-08-16 17:38:49 +02:00
83fb198cd2
CS: Fix violations in MonitoringProperties, NotificationView and StatusQuery
...
refs #4187
2013-08-16 16:32:31 +02:00
e5f3a063fb
NotificationQuery: Fix PostgreSQL icompatibility
...
refs #4187
2013-08-16 16:23:15 +02:00
f4b8b369a8
StatusQuery: Use pipes as concat
...
PostgreSQL does not support CONCAT()
refs #4187
2013-08-16 16:23:15 +02:00
3c56f5c53a
Remove qUrl, use ListController::query, proper default sorting
...
refs #4187
2013-08-16 16:23:15 +02:00
baaf5b81d9
Add mouse-over effect and host/service detail popup
...
refs #4187
2013-08-16 16:23:14 +02:00
f89d641b06
Add notification queries and display notification details
...
The notification queries to fetch all required details are now implemented
and are used to display data in the overview. Still missing is the host/service
detail popup and some quicklinks. (Contact, Notification command)
refs #4187
2013-08-16 16:23:14 +02:00
3c2122515a
Basic structure for the notification overview
...
refs #4187
2013-08-16 16:23:14 +02:00
0b479e3796
Code style fixes, fix documentation, fix tab parameters not being overwritten
...
refs #4512
2013-08-16 15:08:28 +02:00
b28c7f2f4c
Refactor test, tabs and controller
...
- Remove unused methods,
- Code style
- Documentation for widgets
- Tabextensions instead of hardcoded tab actions
- Add tests for tabs
- Add missing phpdoc for touched files
- Fix tests
refs #4512
refs #4541
refs #4540
2013-08-16 15:08:28 +02:00
6d98b923ca
CS: Fix docstrings in Icinga/Application/Modules/Module.php and Manager.php
...
refs #4530
2013-08-14 16:08:15 +02:00
392e568bf8
Code style fixes: License header, phpdoc tags, psr-2 compliance
...
refs #4530
2013-08-14 16:08:15 +02:00
be29b8ff8f
Make ConfigController and PreferenceController extensible by convention
...
- Rename ConfigurationController to ConfigController
- ConfigController and PreferenceController are now subclasses of
BaseConfigController and BasePreferenceController
- Module and Application Config/Preference Tabs are detected via
the ControllerTabCollector
- Moved Controller classes to Icinga/Web/Controller (this is why
so many files are modified)
refs #4530
2013-08-14 16:08:15 +02:00
bd140f2828
CC: Fix phpcs errors of files changed in feature/datetime-element-4440
...
refs #4440
2013-08-12 16:43:10 +02:00
7dea7fcad0
Monitoring/Forms: Replace PHP DateTime usage with DateTimeFactory
...
refs #4440
2013-08-12 16:43:10 +02:00
4d98b64a1b
Monitoring/Forms: Fix docstrings
...
refs #4440
2013-08-12 16:43:09 +02:00
7c732ef682
Monitoring/Tests: Fix DateTimePicker element usage
...
refs #4440
2013-08-12 16:43:08 +02:00
1a2ea656fd
Monitoring/Forms: Don't use DateTime as PhpDateTime
...
refs #4440
2013-08-12 16:43:08 +02:00
1f10cb3124
Framework: Rename DateTime form element to DateTimePicker
...
refs #4440
2013-08-12 16:43:08 +02:00
93ae6d6811
Framework: mv Icinga\Config\Config to Icinga\Application\Config
...
refs #4543
2013-08-12 15:02:25 +02:00
237f7f1e60
Fix service compact view, remove dashboard.ini trash
...
refs #4192
2013-08-08 16:33:42 +02:00
2a2966fc56
Fix Config.php relocation, fix header.phtml crashing due to old tab rendering
...
refs #4192
2013-08-07 17:51:52 +02:00
488310df37
Fix style and docstrings, exception when removing the last tab
...
refs #4192
2013-08-07 17:45:09 +02:00
2b25757e20
Add documentation, add errorhandling and sizing
...
The optional width/height parameter can be set in the ini to change the dashboard components
size, documentation has been added and in the error case a message with the configuration is shown
refs #4192
2013-08-07 17:44:30 +02:00
f8bb478f0e
Update dashboard implementation
...
fix javascript naming (icinga-url to icingaurl), fix add form, add remove
button, code style changes
refs #4192
2013-08-07 17:43:37 +02:00
b3e0d5e8ce
Remove AbstractWidget and make Widget an interface
...
As Widget's already denote an abstract concept, the name
'AbstractWidget' is redundant. Also this class didn't do anything except
fetching a view via a singleton (which is now injected into the render method)
and bypassing the PHP class properties by creating a 'properties' array which is
filled with magic getters and setters (which now are simply php class properties)
Further changes:
- toString is removed, as this incorporated a lot of
application logic which would cause unrecoverable
errors when throwing exceptions
- renderToHtml is now just render and the view dependency must be
passed, as a widget shouldn't be responsible for getting
view instance (this means that <?= $this->tabs ?> is now
<?= $this->tabs->render($this); ?> in the templates
- Controllers don't have $this->widget anymore as Widgets are
directly instanciated with their class, allowing better code completion
and avoiding hidden dependencies, also Widget::create is now removed
in favor of direct instanciation.
refs #4192
2013-08-07 17:41:43 +02:00
56e47fd084
Add an ini writer for configuration files
...
Add an ini writer that respects the file structure and the comments that may be
already present in the config file. Move Application/Config.php into
Config/Config.php.
refs #4352
2013-08-07 15:58:42 +02:00
290c8c5225
CC: Add newline to end of file where missing
...
Following command was used:
$ find application/ library/Icinga/ modules/ -name *.php | xargs sed -i -e :a -e '/./,$!d;/^\n*$/{$d;N;};/\n$/ba;$a\'
2013-08-07 10:27:50 +02:00
ff62a82895
Fix dynamic form validation behaviour, fix documentaion, fix correct isValid() call
...
- When a dynamic form is modified, no validation is performed, but
the form is being populated with $this->populate.
- changed parent::isValid to $this->isValid, otherwise no custom validation
logic could be implemented
- Updated documentation
- Fix CSRF protection by removing the time
refs #4439
2013-08-06 15:08:54 +02:00
66592ecabf
Enable dynamic form elements
...
Expire time of the AcknowledgeForm and hours as well as
minutes of the ScheduleDowntimeForm are now dynamic.
refs #4439
2013-08-06 15:06:20 +02:00
584198f00c
Fix hostlist test
...
refs #4516
2013-08-06 14:06:25 +02:00
15999eb880
Change _forward to redirect() to keep url history updates
...
refs #4382
2013-08-06 13:39:10 +02:00
d78a5338df
Rename ConfirmationForm and ConfirmationWithIdentifierForm
...
Rename ConfirmationForm to CommandForm and
ConfirmationWithIdentifierForm to CommandWithIdentifierForm.
refs #4439
2013-08-06 11:14:56 +02:00
5533b632ed
Fix code style and make form name non mandatory
...
refs #4439
2013-08-06 11:11:29 +02:00
f26af0eb12
Update command form tests
...
Update command form tests so that they reflect the new dynamic
functionality and the correct purpose of "isSubmittedAndValid".
refs #4439
2013-08-06 11:11:28 +02:00
8efbe6f613
Move submit and cancel handling
...
Move submit and cancel handling from ConfirmationForm to Form.
refs #4439
2013-08-06 11:11:28 +02:00
fa7379adc7
Enable dynamic form elements
...
Expire time of the AcknowledgeForm and hours as well as
minutes of the ScheduleDowntimeForm are now dynamic.
refs #4439
2013-08-06 11:09:42 +02:00
98e7ab02db
Implement dynamic form elements
...
Rename "isPostAndValid" to "isSubmittedAndValid" and refactor it.
Add possibility for specific form elements to auto-submit their form.
refs #4439
2013-08-06 11:09:42 +02:00
c9c5e6ef3c
Send commands: Review fixes
...
refs #4441
2013-08-06 09:32:27 +02:00
029ff17cec
Add documentation for instances.ini
...
refs #4441
2013-08-06 09:27:37 +02:00
Thomas Gelf
Eric Lippmann
Johannes Meyer
Jannis Moßhammer
Marius Hein
Matthias Jentsch