Commit Graph

497 Commits

Author SHA1 Message Date
Alexander A. Klimov 99866bfdbe IniWriterTest: make recently added tests more expressive
refs #11743
2016-10-17 13:51:58 +02:00
Alexander A. Klimov 58b2e6c00f Add unit tests for the fixed IniWriter implementation
refs #11743
2016-10-12 13:41:42 +02:00
Eric Lippmann 529ba8ed8a Use the query's iterator instead fetchAll() on CSV export
fixes #12723
2016-10-11 09:53:21 +02:00
Thomas Gelf 2b50f6ff10 FilterExpression: render boolean true as such
fixes #12299
2016-08-03 13:03:08 +00:00
Eric Lippmann 54b43efb33 Fix exception if module.info contains newlines that are not part of the module's description
fixes #11831
2016-06-06 16:21:10 +02:00
Alexander A. Klimov 589da9bcd1 monitoring: Apply custom variable restrictions
refs #10965
2016-04-13 15:43:42 +02:00
Alexander A. Klimov 474803fee4 Change all license headers to only reflect a file's year of creation
refs #11000
2016-02-08 15:41:00 +01:00
Eric Lippmann 7fd575080e PHP7: Rename String to StringHelper
refs #10251
2016-01-27 16:46:55 +01:00
Eric Lippmann f876ed00f0 Revert "Fix test Icinga/File/CsvTest.php because the method being tested has been changed"
This reverts commit 23baa0dc83.
2016-01-27 15:45:37 +01:00
Eric Lippmann 2e3082a75a Skip Hook tests 2015-11-16 13:18:03 +01:00
Eric Lippmann 8f8d251fd7 Use old class loader for tests (WIP)
:D
2015-11-13 17:33:23 +01:00
Johannes Meyer 85e7e7920a Url: Fix detection of the current base url when stripping it from a given path 2015-10-01 10:42:28 +02:00
Johannes Meyer 7321d67b4f Url: Consider urls with a leading slash as absolute..
..and make it possible to have a url without a base.

refs #5600
2015-09-22 14:14:41 +02:00
Johannes Meyer d1fa5e8fce DashboardTest: Drop test testLoadPaneItemsProvidedByEnabledModules
refs #5600
2015-09-16 14:44:31 +02:00
Eric Lippmann bb80347a36 Fix failing form test
Form::isSubmitted() now also checks the request method.
2015-09-07 13:56:03 +02:00
Eric Lippmann 234dc951d2 Remove the is_dir check from the ClassLoader
refs #5786
2015-08-18 09:32:00 +02:00
Eric Lippmann 5ecde41ba3 Rename LoaderTest to ClassLoaderTest
refs #5786
2015-08-18 09:31:26 +02:00
Eric Lippmann 13fc7e16f2 Rename Loader to ClassLoader
refs #5786
2015-08-18 09:06:58 +02:00
Eric Lippmann 7563a7a0ba Rename Loader::unRegister() to Loader::register() 2015-08-17 14:34:39 +02:00
Matthias Jentsch fe805c82ca Support multi line values in INI files 2015-08-10 15:15:40 +02:00
Matthias Jentsch aa3cc9847d Fix issue that bricked the dashboard when quotes in dashlets
Escape more special chars in IniWriter, support reading escaped readers in IniParser and add tests for all important escape cases.
2015-08-07 12:55:19 +02:00
Matthias Jentsch f8e2dc850c Drop IniEditor and clean up IniWriter
Replace the ini editor code with a new parser implementation that manipulates a DOM. Do not support capabillities that are no longer needed, like nested configurations, section inheritance, section-less properties.
2015-08-05 18:10:17 +02:00
Matthias Jentsch bc14e227ec Remove unused unit tests for extending sections 2015-08-04 15:17:21 +02:00
Matthias Jentsch d88c628b6b Escape section names before applying regex
refs #9530
2015-08-04 13:14:46 +02:00
Eric Lippmann 7cfc78558d Merge branch 'master' into feature/secure-modules-9644
Conflicts:
	library/Icinga/Exception/IcingaException.php
2015-07-28 13:42:02 +02:00
Johannes Meyer 2c4b6eb915 ResourceConfigForm: Replace isValid- with inspectResource()
refs #7588
2015-07-24 14:24:11 +02:00
Johannes Meyer 75a48a3b35 Drop LdapBackendFormTest
It's redundant now, we should test the inspection code directly instead.
2015-07-24 10:51:46 +02:00
Johannes Meyer f8f8a4c848 Drop DbBackendFormTest
It's redundant now, we should test the inspection code directly instead.
2015-07-24 10:51:33 +02:00
Eric Lippmann 75147d6c62 Provide a test user in the SearchDashboardTest
refs #9644
2015-07-23 13:01:05 +02:00
Eric Lippmann b38b3b35b7 Provide a test user in the DashboardTest
refs #9644
2015-07-23 13:00:23 +02:00
Eric Lippmann 910dee199f Fix form test 2015-07-22 14:21:53 +02:00
Johannes Meyer cecd94be50 Merge branch 'master' into feature/support-for-file-uploads-8758 2015-07-22 08:47:24 +02:00
Johannes Meyer b4214dcf32 FormTest: getRedirectUrl now returns an instance of Icinga\Web\Url 2015-07-21 16:49:59 +02:00
Matthias Jentsch 9ba4189617 fix coding guideline violations 2015-07-16 16:27:28 +02:00
Matthias Jentsch 6d209ee203 Fix unit DB Form unit tests broken by inspection
refs #9641
2015-07-16 16:22:13 +02:00
Matthias Jentsch 31618ce2cf Fix unit DB Form unit tests broken by inspection
refs #9641
2015-07-16 16:15:27 +02:00
Matthias Jentsch da5ceb0e73 Fix broken unit tests
Fix unit tests that were broken by API changes to the resource form classes and contemplate life choices.

refs #9630
2015-07-16 12:54:37 +02:00
Johannes Meyer a8ac420897 LdapConnection: Establish a connection lazily 2015-07-10 09:51:39 +02:00
Johannes Meyer c3ad7b211a Ldap\Connection: Rename to LdapConnection
refs #8954
2015-06-24 09:05:29 +02:00
Johannes Meyer 77148b6892 IniWriterTest: Remove forgotten var_dump()
...
2015-06-23 16:59:55 +02:00
Johannes Meyer 6ef0af8927 Fix LdapResourceFormTest 2015-06-23 16:56:34 +02:00
Matthias Jentsch 3600e1088c Fix key and value sanitazion in ini writer 2015-06-08 13:11:40 +02:00
Johannes Meyer e66f8731af UserBackendConfigForm: Allow to configure user backends of type msldap
fixes #9355
2015-06-05 17:20:31 +02:00
Johannes Meyer 267e71f38b User: Consider the required permission more important if it has a wildcard
refs #9202
2015-06-02 12:01:02 +02:00
Johannes Meyer cd0c418854 Merge branch 'master' into feature/user-and-group-management-8826 2015-06-02 10:44:13 +02:00
Johannes Meyer 2490d0ae67 ConfigController: We're configuring user backends from now on
refs #8826
2015-06-02 09:58:57 +02:00
Matthias Jentsch 4c6a2b4f06 Fix ini writer unit tests
refs #8706
2015-06-01 16:46:52 +02:00
Johannes Meyer ec556edc65 Merge branch 'master' into feature/user-and-group-management-8826 2015-05-26 09:28:35 +02:00
Eric Lippmann 54577d04bd Merge branch 'master' into bugfix/time-formatting-6778
Conflicts:
	modules/monitoring/application/views/scripts/list/comments.phtml
	modules/monitoring/application/views/scripts/list/hostgroups.phtml
	modules/monitoring/application/views/scripts/process/info.phtml
	modules/monitoring/application/views/scripts/show/components/downtime.phtml
	modules/monitoring/application/views/scripts/show/components/notifications.phtml
	modules/monitoring/public/css/module.less
2015-05-21 14:57:01 +02:00
Johannes Meyer fb07f0b94c Merge branch 'master' into feature/user-and-group-management-8826
Conflicts:
	library/Icinga/Authentication/Backend/LdapUserBackend.php
	library/Icinga/Protocol/Ldap/Query.php
2015-05-19 14:14:03 +02:00
Eric Lippmann 5b3957baca Drop the DateTimeRendererTest
refs #6778
2015-05-19 12:46:33 +02:00
Eric Lippmann 15b2e873b2 Drop the DateTimeFactoryTest
refs #6778
2015-05-19 11:27:56 +02:00
Eric Lippmann 82ee1d6e60 Merge branch 'master' into bugfix/significant-whitespaces-8777
Conflicts:
	library/Icinga/Web/Widget/FilterEditor.php
2015-05-18 13:35:28 +02:00
Johannes Meyer c91d3e52ac Merge branch 'master' into feature/user-and-group-management-8826 2015-05-12 15:39:02 +02:00
Alexander Fuhr 891ce0fe57 UserTest: Fix wrong assert condition for wildcard 2015-05-07 17:19:00 +02:00
Johannes Meyer e228404bf4 Adjust ConfigObjectTest as ConfigObjects are not countable anymore
They are of course still indirectly countable, by using Config::count() or
ConfigObject::select()::count().
2015-05-05 15:36:15 +02:00
Alexander Fuhr 612fefba9c Fix the permission wildcards assertion
fixes #9202
2015-05-05 12:36:26 +02:00
Johannes Meyer 9163fb0f0f Drop Icinga\Protocol\Ldap\ConnectionTest
...located at *test*/php/library/Icinga/Protocol/Ldap/.
2015-05-04 13:40:54 +02:00
Johannes Meyer 100d475b58 Fix ldap ConnectionTest
If I ever have to look at this test again, I'll drop it.

refs #8826
2015-05-04 13:25:07 +02:00
Johannes Meyer c441117324 LdapUserBackend: Extend Repository and implement UserBackendInterface
refs #8826
2015-05-04 12:18:25 +02:00
Johannes Meyer 99ac0b78ea DbUserBackend: Extend DbRepository and implement UserBackendInterface
refs #8826
2015-05-04 12:15:05 +02:00
Johannes Meyer 5baa0590b1 Ldap\Query: Extend SimpleQuery and add missing documentation
refs #8826
refs #8955
2015-05-04 11:26:27 +02:00
Johannes Meyer d09ea2845d Merge branch 'master' into feature/user-and-group-management-8826 2015-04-30 15:20:40 +02:00
Johannes Meyer 034421d0cb Fix form tests utilizing Mockery's partial mock functionality
Since an update of Mockery, partial mocks do not call the constructor
of their mocked classes anymore without explicitly passing a non empty
array. This is a regression of the following bug:
https://github.com/padraic/mockery/issues/144
2015-04-30 15:20:19 +02:00
Johannes Meyer adae7b34c1 Fix DbBackendFormTest and LdapBackendFormTest
refs #8826
2015-04-22 10:36:37 +02:00
Eric Lippmann 09acddb3b7 Fix filter tests not taking whitespaces into account
refs #8777
2015-04-08 10:18:42 +02:00
Louis Sautier 083c1a9e6b Fix some spelling errors in comments and messages
fixes #8633

Signed-off-by: Gunnar Beutner <gunnar@beutner.name>
2015-03-08 15:32:22 +01:00
Johannes Meyer 5c371a6d0b Fix form tests 2015-03-04 09:43:37 +01:00
Matthias Jentsch e4f71eacd6 Add unit tests for ldap connection behavior
It is important that we test handling of protocol extensions properly, to prohibit errors that are difficult to reproduce like this in the future.

fixes #7993
2015-02-27 17:11:12 +01:00
Eric Lippmann 6bae2e0a53 Note that our license is GPL v2 or any later version in our license header instead of pointing to the license's URL 2015-02-04 10:52:27 +01:00
Eric Lippmann 5b4fab0750 Add license header
This time without syntax errors hopefully :)
2015-02-03 16:27:59 +01:00
Eric Lippmann 5fa2e3cfdc Revert "Add license header"
This reverts commit 338d067aba.
2015-02-03 16:16:26 +01:00
Eric Lippmann 338d067aba Add license header
fixes #7788
2015-02-03 15:51:04 +01:00
Johannes Meyer 625fa4d738 Use shipped Zend framework in the testsuite as well 2014-11-27 11:37:18 +01:00
Alexander Klimov a3fa31c35a PHP tests: don't require Hamcrest 2014-11-26 13:51:48 +01:00
Marius Hein bfa7320d85 Dashboard: Fix tests
refs #7751
2014-11-20 12:48:05 +01:00
Marius Hein 8c3dbb2b45 Dashbosrd: Fix tests
refs #4537
2014-11-18 17:26:28 +01:00
Johannes Meyer 7621f6642d Adjust usages of Icinga\Application\Config
refs #7147
2014-11-18 13:11:52 +01:00
Johannes Meyer 0c84bf614d Split config functionality into two classes
There is now Icinga\Application\Config as our ini configuration handler and
Icinga\Data\ConfigObject as our general configuration container.

refs #7147
2014-11-18 13:02:56 +01:00
Johannes Meyer ddf2ef5cc9 Remove $request parameter from Form::onSuccess and Form::onRequest
fixes #7552
2014-11-14 14:59:29 +01:00
Johannes Meyer 586b4f463b Let our module autloader know that we renamed our form namespaces
refs #7553
2014-11-14 11:30:44 +01:00
Johannes Meyer 775c20d9ad Rename namespace Icinga\Form to Icinga\Forms
refs #7553
2014-11-14 10:57:14 +01:00
Eric Lippmann ac2ec83852 Merge branch 'master' into feature/localization-form-6073
Conflicts:
	library/Icinga/Application/ApplicationBootstrap.php
	test/php/library/Icinga/User/Store/DbStoreTest.php
2014-11-13 17:03:41 +01:00
Alexander Fuhr b8113b688b Update User\Store\IniStoreTest 2014-11-12 17:13:15 +01:00
Alexander Fuhr 8bb318eb72 Update User\Store\DbStoreTest 2014-11-12 17:12:05 +01:00
Johannes Meyer 7aae291f69 Merge branch 'master' into feature/setup-wizard-7163 2014-11-12 10:08:28 +01:00
Johannes Meyer a6af51f402 Fix that Config::fromSection cannot return the actual value
refs #7147
2014-11-11 15:51:54 +01:00
Matthias Jentsch fdfad34e5c Do not normalize configuration keys to nested arrays in IniWriter
More than one nesting level (the section) is no longer allowed in configuration files. Dots in keys are now
part of the key and will not lead to a nested configuration.

fixes #7120
2014-11-11 15:05:34 +01:00
Johannes Meyer af99f62843 Prefer Icinga\Application\Config over Zend_Config
refs #7163
2014-11-11 12:11:14 +01:00
Johannes Meyer 9d292269b1 Merge branch 'master' into feature/setup-wizard-7163
Conflicts:
	application/forms/Config/Resource/LdapResourceForm.php
	test/php/application/forms/Config/Authentication/LdapBackendFormTest.php
2014-11-11 09:44:11 +01:00
Johannes Meyer 7b99b74ae1 Prefer Icinga\Application\Config instead of Zend_Config
refs #7147
2014-11-07 13:53:03 +01:00
Johannes Meyer 4537b2932e Fix that current(), key(), etc does not work with Config objects 2014-11-07 13:37:09 +01:00
Johannes Meyer 83f386f92a Do not extend Zend_Config in Icinga\Application\Config
refs #7147
fixes #7580
2014-11-06 15:41:31 +01:00
Johannes Meyer 170ded6510 Merge branch 'master' into feature/setup-wizard-7163
Conflicts:
	library/Icinga/Authentication/Backend/LdapUserBackend.php
	library/Icinga/File/Ini/IniWriter.php
2014-11-04 14:22:53 +01:00
Eric Lippmann b38e3affb9 Move INI writer classes to the File namespace
fixes #7150
2014-10-31 10:54:53 +01:00
Eric Lippmann 16352fc10c Move Logger to the Application namespace
fixes #7148
2014-10-31 10:27:17 +01:00
Johannes Meyer c1bff9a26e Merge branch 'master' into feature/setup-wizard-7163 2014-10-30 10:38:21 +01:00
Eric Lippmann 1b83ec3ce2 Preferences: Fix saving preferences when using a database store
Our DbSelect::where() is not (or no longer?) compatible w/ Zend_Db_Select::where().
DbStore::load() now uses Zend_Db_Select but we should definitely think about our
DbSelect::where() implementation.

fixes #7353
2014-10-30 09:49:21 +01:00
Johannes Meyer 9f127be1dc Merge branch 'master' into feature/setup-wizard-7163
Conflicts:
	application/forms/Config/General/LoggingConfigForm.php
2014-10-17 13:04:59 +02:00
Eric Lippmann 501aca42b9 Logger: Fix the StreamWriterTest 2014-10-16 15:58:37 +02:00