ca5ef2da2b
Merge Queryable into QueryInterface
...
A *Query*Interface describes an object as being queryable, now.
refs #8826
2015-05-04 11:07:50 +02:00
ab0b478e4f
Icinga\Web\Widget\Tabextension\DashboardAction::apply(): translate label "Add To Dashboard"
2015-04-30 17:49:42 +02:00
ffe23a184f
Don't display "Add To Dashboard" on the dashboard
...
resolves #9026
2015-04-30 17:47:23 +02:00
7f28c0a237
Implement ProblemMenuItemRenderer
...
refs # 4139
2015-04-30 16:06:05 +02:00
d09ea2845d
Merge branch 'master' into feature/user-and-group-management-8826
2015-04-30 15:20:40 +02:00
3da144f199
Revert "Sort LDAP user list"
...
This reverts commit d4dc0177c0
2015-04-28 15:57:33 +02:00
7c0be30def
Handle and display multiline log messages correctly
2015-04-24 17:36:49 +02:00
ec82b3bc09
Implement Icinga\Protocol\File\LogFileIterator
2015-04-24 17:36:48 +02:00
3d53e6f9b5
Icinga\Protocol\File\FileReader::count(): call iterator_count() only once per instance and cache the returned value
2015-04-24 11:10:40 +02:00
5ba539b7c1
SyslogWriter: replace \n w/ 4 spaces in multiline log messages
2015-04-24 10:28:45 +02:00
a429617a95
Revert "Log each line of a multiline log message separatly"
...
This reverts commit 39042ab306
2015-04-24 10:17:35 +02:00
39042ab306
Log each line of a multiline log message separatly
...
resolves #9000
2015-04-23 17:44:00 +02:00
9cd7765d9e
If session_save_path() returns '', use sys_get_temp_dir()
...
resolves #8994
2015-04-22 17:26:15 +02:00
1daecbbca0
Don't use `false === ...' when `! ...' is enough
2015-04-22 17:04:31 +02:00
9393d11c0b
Display an error message when enabled modules cannot be read because /etc/icingaweb2 is not readable
...
resolves #9141
2015-04-22 16:44:00 +02:00
7960e911a6
UserGroupBackend: Add support for custom backends to fetch user groups
...
refs #8826
refs #9122
2015-04-22 09:52:08 +02:00
a2cd5d63f1
UserBackend: Wrap config directives as part of errors in single quotes
2015-04-22 09:36:45 +02:00
a1d8ed6e8f
UserBackend: Utilize ResourceFactory::create
2015-04-22 09:35:41 +02:00
c9dcddb134
UserGroupBackend: Add missing and fix existing method documentation
2015-04-22 09:35:06 +02:00
847c02ed8e
UserBackend: Add support for custom authentication backends
...
refs #8826
refs #8877
2015-04-22 09:28:42 +02:00
33628cbf04
Icinga\Application\Modules\Module: Add missing documentation
2015-04-22 09:06:26 +02:00
b45e576722
UserBackend: Remove testing only related code
...
There are no tests for this class at all.
2015-04-21 14:15:43 +02:00
97caeb27f7
UserBackend: Add missing and fix existing method documentation
...
refs #8826
2015-04-21 13:59:35 +02:00
319ca3625c
LdapUserBackend: Drop redundant method hasUser
...
refs #8826
2015-04-21 13:15:40 +02:00
60a8654614
ExternalBackend: Drop redundant method hasUser
...
refs #8826
2015-04-21 13:15:06 +02:00
11f522d929
DbUserBackend: Drop redundant method hasUser
...
refs #8826
2015-04-21 13:14:50 +02:00
a7af546078
UserBackend: Drop abstract method hasUser
...
refs #8826
2015-04-21 13:14:27 +02:00
6ca68f438d
Move concrete UserBackend classes to Icinga\Authentication\User
...
refs #8826
2015-04-21 12:51:31 +02:00
39473e8939
Move UserGroupBackend to Icinga\Authentication\User
...
refs #8826
2015-04-21 12:42:21 +02:00
b51ce9c7ab
Move concrete UserGroupBackend classes to Icinga\Authentication\UserGroup
...
refs #8826
2015-04-21 12:38:57 +02:00
8058eb0215
Move UserGroupBackend class to Icinga\Authentication\UserGroup
...
refs #8826
2015-04-21 12:32:18 +02:00
d3964a31fb
MenuItemRenderer: add missing use clause
...
Otherwise this completely broke Icinga Web as soon as a single module
used a legacy icon.
refs #7658
2015-04-20 21:49:45 +02:00
d6e7061de3
Implement Icinga\Web\Widget\FilterEditor::setSearchColumns() for specifying custom search columns
2015-04-20 18:01:48 +02:00
5f3aafd3bd
Merge branch 'bugfix/menu-item-renderer-deduplication-7658'
...
fixes #7658
2015-04-20 17:15:21 +02:00
9ebf4742de
Use the MenuItemRenderer render() implemnetations
...
refs #7658
2015-04-20 17:07:34 +02:00
4eb5f75c62
Use default MenuItemRenderer as renderer if no custom renderer is set
...
refs #7658
2015-04-20 17:04:46 +02:00
f543321ac4
Replace MenuItemRenderer interface with a base class MenuItemRenderer
...
refs #7658
2015-04-20 17:02:42 +02:00
da7aa23820
Merge branch 'master' into bugfix/make-all-views-dashboard-compliant-7876
2015-04-20 15:20:23 +02:00
7bc07c4368
Force absolute nampesace for module menu item renderer
...
refs #7642
2015-04-20 13:21:37 +02:00
a9819907ed
Add namespaced item renderer class loader
...
refs #7642
2015-04-20 13:08:49 +02:00
593ea7add5
Move monitoring module renderers from global module to monitoring module
...
refs #7642
2015-04-20 13:02:12 +02:00
54a370ca22
Merge branch 'master' into bugfix/make-all-views-dashboard-compliant-7876
2015-04-20 11:15:04 +02:00
8dba5752dc
ModuleManager: Improve error messages when en-/disabling modules
2015-04-20 10:09:33 +02:00
2bd31ee395
Icinga\Web\Controller: Add helper functions to create control widgets
...
refs #7876
2015-04-17 16:08:41 +02:00
b52b507134
FilterEditor: Fix css
2015-04-17 10:05:48 +02:00
6898a4e0d5
Display icon tooltips without delay
...
Original functionality was broken when changing the icon library.
2015-04-16 18:32:47 +02:00
168577ff33
Use icon instead of the letter 'X' in close tab
2015-04-16 18:32:47 +02:00
675d070b86
Set the view property `compact' exactly once
...
refs #7876
2015-04-15 15:33:00 +02:00
ed2de3c4d0
Fix SortBox widget
...
refs #7876
2015-04-15 14:20:36 +02:00
d882ea11b4
Avoid to set an empty redirect url parameter when accessing icinga web 2
2015-04-15 11:00:47 +02:00
36fed03764
Do not log that the logging configuration is invalid on every request
...
Instead, log those messages *everytime* a subsequent message is being
logged.
refs #8957
2015-04-13 17:11:42 +02:00
67ad575cf5
Set the configured logging level even if the configured logging type is invalid
...
refs #8957
2015-04-13 17:09:49 +02:00
638c00d685
Merge branch 'master' into feature/non-collated-ido-queries-8613
2015-04-13 15:55:32 +02:00
a817d9070e
Move setupSortControl() from Monitoring_ListController to Icinga\Web\Controller
2015-04-10 11:36:25 +02:00
55e9407371
Use `service' instead of `service_description' when searching for services
...
refs #8613
2015-04-08 14:57:30 +02:00
e94c99e20e
Use `host' instead of `host_name' when searching for hosts
...
refs #8613
2015-04-08 14:57:08 +02:00
9596b4fdf7
Form: Make it possible to preserve default values during (auto)submission
2015-04-07 15:07:36 +02:00
967a2e82dc
Use (only) "@return $this" in fluent interfaces' documentation
2015-04-07 14:24:11 +02:00
6b63f3d8a2
Merge branch 'feature/require-mandatory-params-8886'
...
resolves #8886
2015-04-07 13:06:43 +02:00
dfd8c91827
Add PHPDoc to ActionController::$params
2015-04-07 12:25:46 +02:00
002e793a53
lib: Add Params::req()
...
Params::req() should be used for requiring a mandatory CLI parameter.
refs #8886
2015-04-07 12:20:37 +02:00
93b1a35de0
lib: Add UrlParams::req()
...
UrlParams::req() should be used for requiring a mandatory URL parameter.
refs #8886
2015-04-07 12:17:59 +02:00
0fc5801e5e
lib: Add MissingParameterException::getParameter and ::setParameter ...
...
... for getting/setting the name of the missing parameter which caused the exception.
refs #8886
2015-04-07 12:15:15 +02:00
e32eeb991e
Implement Icinga\Web\Widget\SortBox::create()
2015-04-07 11:37:06 +02:00
57ed849cee
Icinga\Web\Widget\SortBox::applyRequest(): return $this
2015-04-07 11:26:16 +02:00
4d795494fc
Fix MissingParameterException's PHPDoc
...
refs #8886
2015-04-07 10:48:37 +02:00
b0b95ab387
Fix that Icinga\Application\Logger::writesTo* is not functional
2015-04-07 10:31:57 +02:00
9ce9e0270c
Fix that LDAP encryption settings have no effect
...
I renamed the directive for the encryption setting from 'connection' to 'encryption' before releasing Beta3 but
I forgot to change the Connection class accordingly.
fixes #8953
2015-04-02 10:41:25 +02:00
5383999ef7
Add warning to links that open in a new window
...
Add warning on mouseover / focus as recommended by as recommended by WCAG20 G201
refs #7937
2015-03-19 10:49:28 +01:00
949438d753
lib: Add SimpleQuery::splitOrder() ...
...
... for supporting specifying the sort direction next to the column, e.g.
'service_display_name ASC'
refs #8716
2015-03-13 17:09:32 +01:00
63f87da53d
Session: reworked to avoid duplicate notifications
...
* clear session on initialization, store once on shutdown
* less static method calls
* fixes erraneous cli checks
2015-03-13 14:10:27 +01:00
0bc1416b10
Use the correct name for malformed LDAP attributes automatically
...
...or more purposefully: Guard lazy users from themselves. I hope I don't
have to explain why _this_ is not part of Icinga\Protocol\Ldap\Query...
resolves #8608
2015-03-13 11:17:43 +01:00
316d926811
Ldap/Query: re-add __toString
...
We stopped using __toString as it is unable to handle exceptions - and
this makes sense. However, that's IMO not a good reason to completely
drop __toString. Especially when debugging, benchmarking and similar you
often need a quick way to "dump" an object.
In that case you are often not in a mood to figure out whether that
specific class prefers create(), dump(), render() or whatever. We should
not base our view scripts on __toString - at least unless we do not catch
Exceptions in __toString methods, eventually "forwarding" them as triggered
error where needed.
2015-03-13 08:58:25 +01:00
e36c430bb3
Merge branch 'feature/protected-menu-8720'
...
resolves #8720
2015-03-13 04:26:19 +01:00
200982e4f5
Set form action automatically only if Form::setAction() has not been called
...
refs #8605
2015-03-13 03:59:43 +01:00
d8d0d88c95
Rename Capability::hasStartTLS to Capability::hasStartTls()
2015-03-13 00:29:00 +01:00
db08ccad4b
Fix encryption setting written to a LDAP reource's INI configuration
...
Use starttls for STARTTLS and ldaps for LDAPS.
2015-03-12 23:56:25 +01:00
86f3ce9133
Rename Ldap\Connetion::SSL to ::LDAPS
...
The SSL constant was used to denote LDAP over TLS/SSL. In fact both STARTTLS and LDAPS use encrypted TLS/SSL communication
w/ STARTTLS upgrading a plain text connection and LDAPS using a separate port. Thus speaking of SSL only for LDAPS and TLS only for STARTTLS
is not correct.
2015-03-12 23:56:08 +01:00
1b9ddaacac
Add PHPDoc to Ldap\Connection's encryption consts
2015-03-12 23:35:38 +01:00
17393a7b41
Remove unnecessary PHPDoc tags from Ldap\Connection
2015-03-12 23:30:04 +01:00
03f78a06fb
Optimize imports in the SearchDashboard
...
refs #8668
2015-03-12 18:48:59 +01:00
dc6b472ec9
Don't create search dashlets if the search string is empty
...
refs #8668
2015-03-12 18:47:34 +01:00
515fe3249f
Fix PHPDoc of SearchDashboard::search()
...
refs #8668
2015-03-12 18:44:23 +01:00
77cd48e6fe
We do not use the @package tag
2015-03-12 18:11:33 +01:00
6c5a6215ef
Render search results based on their priority
...
refs #8668
2015-03-12 18:11:06 +01:00
c1d5231619
Add priority param to Module::provideSearchUrl()
...
refs #8668
2015-03-12 17:55:29 +01:00
29d5fd351b
Merge branch 'bugfix/logout-external-8626'
...
fixes #8626
2015-03-12 16:47:49 +01:00
8563d5ed3f
PHPDoc: Use @var instead of @type
...
Becasue of too many kittens PSR-5 backed off of deprecating @var.
So that's the way we go too.
2015-03-12 16:08:47 +01:00
90971f2caf
Revert "Merge branch 'feature/organize-headings-7976'"
...
This reverts commit ea2a17a76ce72de8dfe1#7976
fixes #8647
2015-03-12 16:08:34 +01:00
093dfd627e
Security: Hide config menu items if the user lacks the required permission
...
refs #8720
2015-03-12 15:45:33 +01:00
da16bfcef3
Security: Use PermittedMenuItemFilter in the MenuRenderer
...
refs #8720
2015-03-12 15:45:30 +01:00
e6a60e214c
lib: Add PermittedMenuItemFilter ...
...
... for iterating over menu items the user is allowed to display
refs #8720
2015-03-12 15:45:27 +01:00
7f010102f6
Add wildcard support to the permission passed to User::can()
...
refs #8720
2015-03-12 15:45:25 +01:00
0c30356d52
Add Menu::getPermission() and Menu::setPermission()
...
Those two functions are required for filtering menu items based on a user's grants.
refs #8720
2015-03-12 15:44:43 +01:00
8295d6d9b0
Do not require the `connection' directive when creating a LDAP resource
2015-03-12 15:36:52 +01:00
359a5f54c3
Merge branch 'master' into feature/ldap-ssl-and-tls-support-7771
2015-03-12 15:18:53 +01:00
5de5a65df0
Do not suppress errors when a LDAP capability query fails
2015-03-12 15:18:00 +01:00
1b440a4f1b
Make SSL/TLS configurable for LDAP resources
...
refs #7771
2015-03-12 15:17:19 +01:00
749957c3b4
Fix too greedy __SELF__ login redirect on XHR
...
I introduced this bug some commits earlier. We only must redirect to __SELF__ on XHR
if a redirect URL was set.
refs #8626
2015-03-12 00:57:03 +01:00
2f752ed1ac
Respond with HTTP status code 403 when an XHR requires authentication
...
refs #8626
2015-03-11 22:32:04 +01:00
0806ab3ec9
Remove strict equality for $auth->isAuthenticated()
2015-03-11 22:26:03 +01:00
64ad54ebd6
Optimize imports in Web.php
2015-03-11 22:08:28 +01:00
a835cad31f
Remove a nonsense TODO from Web.php
...
TODOs for replacing Zend classes are unnecessary.
2015-03-11 22:06:23 +01:00
c54648244e
Remove newlines from Web.php
2015-03-11 22:05:23 +01:00
c47164601a
Don't alias Zend_Controller_Action_HelperBroker in Web.php
2015-03-11 22:03:49 +01:00
dfa7e20b74
Don't use Icinga\Authentication\Manager twice
2015-03-11 22:01:41 +01:00
9e81370551
Removed unused use ... in Web.php
2015-03-11 22:00:09 +01:00
32ca28bc46
Use @return $this for documenting fluent interfaces
2015-03-11 21:58:41 +01:00
ac2522af20
Merge branch 'master' into bugfix/logout-external-8626
2015-03-11 21:55:52 +01:00
7fe4b3d7ab
Fix PHPDoc of Web::detectLocale()
2015-03-11 21:55:04 +01:00
29d4ad69b9
Remove // @codeCoverageIgnoreEnd
...
This is obsolete.
2015-03-11 21:50:41 +01:00
bc1336b6f9
Fix stupid code in ActionController::redirectToLogin()
...
refs #8626
2015-03-11 21:49:20 +01:00
4ebfbf83ab
Leave note about __SELF__ in our action controller
...
refs #8626
2015-03-11 21:40:14 +01:00
d102a61e22
Fix Undefined index: HTTP_ACCEPT_LANGUAGE
...
fixes #8370
2015-03-11 20:50:05 +01:00
ba0154ab79
Tab: Use the title as caption if there is no label set yet
2015-03-11 10:21:06 +01:00
39a74c4f3d
LDAP-Auth backend config: Add support for custom LDAP filter rules
...
refs #8365
2015-03-11 09:52:14 +01:00
0758be4af1
Add support for dynamic ldap filter expressions
...
"Dynamic" is a more of a overstatement when describing this commit but
the current implementation is just the start. Once our ldap protocol stuff
supports our filter implementation this will be vastly improved.
refs #8365
2015-03-11 09:50:41 +01:00
2cf09ebc48
Revert "LdapResourceForm: Validate the host field and do not require a port"
...
This reverts commit a34d6026b3#7990
2015-03-11 08:00:20 +01:00
a34d6026b3
LdapResourceForm: Validate the host field and do not require a port
...
fixes #7990
2015-03-10 15:03:48 +01:00
d0383a241e
Use date and mktime instead of cal_days_in_month to count a month's days
...
fixes #8637
2015-03-10 12:30:22 +01:00
4badbc660b
Merge branch 'master' into feature/conditional-requirements-8508
2015-03-09 08:51:03 +01:00
083c1a9e6b
Fix some spelling errors in comments and messages
...
fixes #8633
Signed-off-by: Gunnar Beutner <gunnar@beutner.name>
2015-03-08 15:32:22 +01:00
d414d7e395
Fix that preferences can't be stored in a database
...
The mtime column is a column to update, not a column for the where condition.
fixes #8629
2015-03-08 10:19:17 +01:00
f45f00b022
Run a module's configuration script only in case it has been registered
...
fixes #8601
2015-03-06 13:25:04 +01:00
f3fa743022
Fix login when using a PostgreSQL database as authentication backend
...
fixes #8524
2015-03-06 11:03:45 +01:00
6cfa958bb8
Allow setting `requirement' on form elements
...
It's supposed to be used as description what
kind of value an element will accept.
refs #7947
2015-03-06 08:53:34 +01:00
b9811f8590
Form: Do not set the requiredSuffix as option but use its virtual setter
...
This removes the invalid attribute on each <label> tag once the
FormDescriptions decorator removes the suffix.
refs #7947
2015-03-05 15:13:38 +01:00
b8eedc21bb
Form: Explicitly set subform decorators
...
refs #7947
2015-03-05 15:12:02 +01:00
764f125778
Make the FormDescriptions decorator able to handle sub forms
...
refs #7947
2015-03-05 15:08:30 +01:00
ff263946c8
Form: Fix translation domain detection while running unit tests
2015-03-04 09:38:00 +01:00
6e61980dd2
Fix operator precedence when detecting the default locale
...
fixes #8370
2015-03-04 08:28:30 +01:00
e2887df03e
Form: It's a field, not a control
2015-03-03 15:01:09 +01:00
8510835fba
Fix accessibility of the Autosubmit decorator when applied to a form
...
refs #7935
2015-03-03 14:35:46 +01:00
c2339d156b
Improve aria-hidden handling in the icon and img view helper
2015-03-03 14:35:41 +01:00
747e51553e
Allow the Autosubmit decorator being used on forms as well
...
refs #7935
2015-03-03 13:33:26 +01:00
642fa44fce
Move a form's title into the markup of its form
2015-03-03 09:53:25 +01:00
b1d0c12df3
Form: Introduce setTitle() as alias for Zend_Form::setDescription()
2015-03-02 18:40:46 +01:00
ad288c08ca
Form: Add the Description decorator by default for native title support
2015-03-02 18:40:46 +01:00
cbd061aa41
Fix that the FormDescriptions decorator does not ignore Notes and Buttons
2015-03-02 18:40:46 +01:00
1eacaa4c48
Improve the display of the text cue on required form elements
...
Shows just a message at the top of the form if all elements are required
and a explaining message what the cue is standing for otherwise.
refs #7934
2015-03-02 13:48:35 +01:00
1a334f8d64
Add decorator FormDescriptions
...
This decorator displays a list of messages at the top of a form.
refs #7947
2015-03-02 13:45:24 +01:00
36d2d31035
Do not use page control unless explicitly announced
...
refs #8490
2015-02-27 17:10:55 +01:00
65821863fa
Don't crash on single ldap capability entries
...
refs #8490
2015-02-27 17:10:21 +01:00
e93a5f16d9
Move capability-related code of the ldap connection into a separate class
...
Achieve a better separation between the different concerns, more readable code and get rid of unused dead code.
2015-02-27 17:10:21 +01:00
7bb78330a9
Replace cancel icon with the trash icon...
...
...where the link's purpose is to remove something
2015-02-27 14:47:46 +01:00
74dfa6e72a
Fix invalid icon names passed to the icon view helper
2015-02-27 14:45:47 +01:00
96c132908d
Provide a warning on autosubmit form elements and a title for the apply btn
...
resolves #7935
2015-02-27 13:09:13 +01:00
4f0bddd7da
Do not add aria-label to icons and images with titles if aria-hidden is set
2015-02-27 12:12:24 +01:00
82017da85f
Help: Do not protect form element ids twice
2015-02-27 09:20:15 +01:00
c00e336ea8
Make the cue that is being appended to required form elements configurable
...
refs #7934
2015-02-27 09:08:05 +01:00
Johannes Meyer
Alexander A. Klimov
Alexander Fuhr
Thomas Gelf
Matthias Jentsch
Eric Lippmann
Louis Sautier