Jannis Moßhammer
9f923b4940
Fix pagination and remove ModuleController, rename handlesAuth
...
This commit introduces the following changes:
- Count is now performed after joins are added to the selection query,
therefore returning the correct number
- MonitoringControllerTest now needn't to mock ModuleActionController (which is now removed)
- handlesAuthentication is now requiresAuthentication
- Redirection to login is now directly handled in the ActionController constructor,
so we don't need to overwrite the preDispatch method
refs #4589
refs #4591
refs #4572
2013-09-02 18:42:05 +02:00
Johannes Meyer
24ecbb56d7
Fix incorrect checkresult type selection
...
When submitting a passive checkresult for hosts only their correct
result types are added to the selection.
refs #4600
2013-09-02 17:24:42 +02:00
Jannis Moßhammer
d0ac97f335
Configure fixes, regression test for 4606
...
The configure routine still has to be improved, right now unused
authentication backends are commented out
refs #4491
refs #4606
refs #4640
2013-08-29 11:48:32 +02:00
Jannis Moßhammer
895976550c
Fix templates, capitalization and icons in php files
...
refs #4550
refs #4584
2013-08-23 10:28:48 +02:00
Jannis Moßhammer
95ad8da2a3
Fix class not found exception when trying to send commands
...
This has already been fixed but got lost during a rebase,
so no ticket ref exists.
2013-08-21 16:48:12 +02:00
Eric Lippmann
edb06ea8ea
CS: Fix viloations for touched files in branch feature/backend-configuration-ui-3776
...
refs #3776
2013-08-21 14:22:31 +02:00
Jannis Moßhammer
cd1fb2e4b5
Capitalization, smaleler codestyle fixes
...
refs #3776
2013-08-21 14:22:30 +02:00
Jannis Moßhammer
83d053965f
Implement monitoring instance and backend configuration forms
...
refs #3776
2013-08-21 14:22:30 +02:00
Jannis Moßhammer
a6ff6ecadd
Fix Codestyle/PHPDoc, fix configPath being Overwritten
...
Also removed possibility to disable debugging as there's no use case for this
refs #4525
refs #4598
2013-08-21 14:22:30 +02:00
Jannis Moßhammer
26a5018d16
Add Forms and conditional hidden
...
refs #3777
2013-08-21 14:18:53 +02:00
Jannis Moßhammer
d7358c65be
Remove QUrl and QLink, add Href
...
refs #4516
2013-08-21 09:44:01 +02:00
Eric Lippmann
6765648380
Monitoring: Fix nonexistent Icinga\Backend usage in CommandController
2013-08-21 09:44:01 +02:00
Eric Lippmann
d574a26db3
Monitoring: Fix nonexistent Icinga\Backend usage in CommandController
2013-08-20 16:19:34 +02:00
Marius Hein
d1cc1fb61f
Codestyle and doc strings for list controller
...
refs #4583
2013-08-20 15:45:44 +02:00
Marius Hein
df864d2738
Remove unused summary components
...
refs #4583
2013-08-20 15:38:00 +02:00
Eric Lippmann
ad84e9e9cf
Remove unimplemented list views (concat-, host-, and servicegroups)
...
refs #4583
2013-08-20 15:14:57 +02:00
Eric Lippmann
207c47ae64
Nav: Remove tabs from ListController since their links are redundant to the main menu
...
refs #4583
2013-08-20 15:14:57 +02:00
Eric Lippmann
3d3fbb123d
Monitoring/Commands: Add help messages to the custom notification form
...
refs #4524
2013-08-16 17:38:50 +02:00
Jannis Moßhammer
3c56f5c53a
Remove qUrl, use ListController::query, proper default sorting
...
refs #4187
2013-08-16 16:23:15 +02:00
Johannes Meyer
f89d641b06
Add notification queries and display notification details
...
The notification queries to fetch all required details are now implemented
and are used to display data in the overview. Still missing is the host/service
detail popup and some quicklinks. (Contact, Notification command)
refs #4187
2013-08-16 16:23:14 +02:00
Johannes Meyer
3c2122515a
Basic structure for the notification overview
...
refs #4187
2013-08-16 16:23:14 +02:00
Jannis Moßhammer
0b479e3796
Code style fixes, fix documentation, fix tab parameters not being overwritten
...
refs #4512
2013-08-16 15:08:28 +02:00
Jannis Moßhammer
b28c7f2f4c
Refactor test, tabs and controller
...
- Remove unused methods,
- Code style
- Documentation for widgets
- Tabextensions instead of hardcoded tab actions
- Add tests for tabs
- Add missing phpdoc for touched files
- Fix tests
refs #4512
refs #4541
refs #4540
2013-08-16 15:08:28 +02:00
Eric Lippmann
6d98b923ca
CS: Fix docstrings in Icinga/Application/Modules/Module.php and Manager.php
...
refs #4530
2013-08-14 16:08:15 +02:00
Jannis Moßhammer
392e568bf8
Code style fixes: License header, phpdoc tags, psr-2 compliance
...
refs #4530
2013-08-14 16:08:15 +02:00
Jannis Moßhammer
be29b8ff8f
Make ConfigController and PreferenceController extensible by convention
...
- Rename ConfigurationController to ConfigController
- ConfigController and PreferenceController are now subclasses of
BaseConfigController and BasePreferenceController
- Module and Application Config/Preference Tabs are detected via
the ControllerTabCollector
- Moved Controller classes to Icinga/Web/Controller (this is why
so many files are modified)
refs #4530
2013-08-14 16:08:15 +02:00
Eric Lippmann
93ae6d6811
Framework: mv Icinga\Config\Config to Icinga\Application\Config
...
refs #4543
2013-08-12 15:02:25 +02:00
Jannis Moßhammer
237f7f1e60
Fix service compact view, remove dashboard.ini trash
...
refs #4192
2013-08-08 16:33:42 +02:00
Jannis Moßhammer
2b25757e20
Add documentation, add errorhandling and sizing
...
The optional width/height parameter can be set in the ini to change the dashboard components
size, documentation has been added and in the error case a message with the configuration is shown
refs #4192
2013-08-07 17:44:30 +02:00
Jannis Moßhammer
f8bb478f0e
Update dashboard implementation
...
fix javascript naming (icinga-url to icingaurl), fix add form, add remove
button, code style changes
refs #4192
2013-08-07 17:43:37 +02:00
Jannis Moßhammer
b3e0d5e8ce
Remove AbstractWidget and make Widget an interface
...
As Widget's already denote an abstract concept, the name
'AbstractWidget' is redundant. Also this class didn't do anything except
fetching a view via a singleton (which is now injected into the render method)
and bypassing the PHP class properties by creating a 'properties' array which is
filled with magic getters and setters (which now are simply php class properties)
Further changes:
- toString is removed, as this incorporated a lot of
application logic which would cause unrecoverable
errors when throwing exceptions
- renderToHtml is now just render and the view dependency must be
passed, as a widget shouldn't be responsible for getting
view instance (this means that <?= $this->tabs ?> is now
<?= $this->tabs->render($this); ?> in the templates
- Controllers don't have $this->widget anymore as Widgets are
directly instanciated with their class, allowing better code completion
and avoiding hidden dependencies, also Widget::create is now removed
in favor of direct instanciation.
refs #4192
2013-08-07 17:41:43 +02:00
Matthias Jentsch
56e47fd084
Add an ini writer for configuration files
...
Add an ini writer that respects the file structure and the comments that may be
already present in the config file. Move Application/Config.php into
Config/Config.php.
refs #4352
2013-08-07 15:58:42 +02:00
Eric Lippmann
290c8c5225
CC: Add newline to end of file where missing
...
Following command was used:
$ find application/ library/Icinga/ modules/ -name *.php | xargs sed -i -e :a -e '/./,$!d;/^\n*$/{$d;N;};/\n$/ba;$a\'
2013-08-07 10:27:50 +02:00
Marius Hein
15999eb880
Change _forward to redirect() to keep url history updates
...
refs #4382
2013-08-06 13:39:10 +02:00
Johannes Meyer
d78a5338df
Rename ConfirmationForm and ConfirmationWithIdentifierForm
...
Rename ConfirmationForm to CommandForm and
ConfirmationWithIdentifierForm to CommandWithIdentifierForm.
refs #4439
2013-08-06 11:14:56 +02:00
Johannes Meyer
98e7ab02db
Implement dynamic form elements
...
Rename "isPostAndValid" to "isSubmittedAndValid" and refactor it.
Add possibility for specific form elements to auto-submit their form.
refs #4439
2013-08-06 11:09:42 +02:00
Jannis Moßhammer
c2781f4969
Fix test cases for Confirmation forms
...
refs #4441
2013-08-06 09:27:37 +02:00
Jannis Moßhammer
81c2f3b9de
Add list of objects that are affected by a command
...
refs #4441
2013-08-06 09:27:37 +02:00
Jannis Moßhammer
b44de95caa
Call commandhandler from commandcontroller actions
...
The CommandController now implements the calls to the specific
command methods and sends commands to the icinga process
refs #4441
2013-08-06 09:27:37 +02:00
Jannis Moßhammer
2091f63c3b
Implement first commands, fix obsessing state
...
refs #4441
2013-08-06 09:27:37 +02:00
Matthias Jentsch
e47954b471
dd downtime overview
...
Add the downtime overview view, add the downtimes controller action, fix issues
with the the DowntimeQuery and add the new fields to the DowntimeView. Fix
issues in the ShowController that occur due to the changes in the DowntimeQuery.
refs #4188
2013-08-02 14:48:16 +02:00
Jannis Moßhammer
50ca1aec1a
Refactor URL class and test
...
The constructor of the class is now private, instantiation happens
with Url::fromRequest and Url::fromPath. Also updated all occurences
of Url and fixed the Qlink helper to not overwrite the baseUrl with null
values
refs #4381
2013-08-02 13:14:55 +02:00
Matthias Jentsch
ce95511890
Change default database to "icingaweb" and add installation instructions
...
Set the default database and user to "icingaweb" in the authentication.ini. Add
instructions about how to set up the databases to authentication.ini.
refs #3769
2013-07-26 13:10:00 +02:00
Jannis Moßhammer
6900507ebc
Merge branch 'feature/command-masks-4355' of ssh://git.icinga.org/icinga2-web
2013-07-24 12:49:43 +02:00
Marius Hein
2b3bef457d
Command masks: Small PSR fix, drop unused core, fix lazy render
...
refs #4355
2013-07-24 12:43:26 +02:00
Marius Hein
849eee2cf2
Command masks: Review changes [WIP]
...
refs #4355
2013-07-23 17:09:06 +02:00
Jannis Mosshammer
e8204f4755
Merge branch 'feature/service-detail-view-4181' of ssh://git.icinga.org/icinga2-web
...
Conflicts:
library/Icinga/Application/Logger.php
library/Icinga/Application/Web.php
library/Icinga/Authentication/Backend/LdapUserBackend.php
library/Icinga/Authentication/Credentials.php
library/Icinga/Authentication/Manager.php
library/Icinga/Authentication/PhpSession.php
library/Icinga/Authentication/Session.php
library/Icinga/Authentication/User.php
library/Icinga/Authentication/UserBackend.php
library/Icinga/Backend/AbstractBackend.php
library/Icinga/Backend/DataView/ObjectRemappingView.php
library/Icinga/Backend/Query.php
library/Icinga/Backend/Statusdat/DataView/StatusdatHostView.php
library/Icinga/Backend/Statusdat/HostgroupsummaryQuery.php
library/Icinga/Backend/Statusdat/HostlistQuery.php
library/Icinga/Backend/Statusdat/ServicegroupsummaryQuery.php
library/Icinga/Backend/Statusdat/ServicelistQuery.php
library/Icinga/Exception/ConfigurationError.php
library/Icinga/Exception/MissingParameterException.php
library/Icinga/Exception/NotImplementedError.php
library/Icinga/Exception/ProgrammingError.php
library/Icinga/Exception/SystemPermissionException.php
library/Icinga/Protocol/AbstractQuery.php
library/Icinga/Protocol/Commandpipe/Acknowledgement.php
library/Icinga/Protocol/Commandpipe/CommandPipe.php
library/Icinga/Protocol/Commandpipe/Comment.php
library/Icinga/Protocol/Commandpipe/Downtime.php
library/Icinga/Protocol/Commandpipe/Exception/InvalidCommandException.php
library/Icinga/Protocol/Commandpipe/IComment.php
library/Icinga/Protocol/Commandpipe/PropertyModifier.php
library/Icinga/Protocol/Ldap/Connection.php
library/Icinga/Protocol/Ldap/Exception.php
library/Icinga/Protocol/Ldap/LdapUtils.php
library/Icinga/Protocol/Ldap/Node.php
library/Icinga/Protocol/Ldap/Query.php
library/Icinga/Protocol/Ldap/Root.php
library/Icinga/Protocol/Statusdat/Exception/ParsingException.php
library/Icinga/Protocol/Statusdat/IReader.php
library/Icinga/Protocol/Statusdat/ObjectContainer.php
library/Icinga/Protocol/Statusdat/Parser.php
library/Icinga/Protocol/Statusdat/Query.php
library/Icinga/Protocol/Statusdat/Query/Expression.php
library/Icinga/Protocol/Statusdat/Query/Group.php
library/Icinga/Protocol/Statusdat/Query/IQueryPart.php
library/Icinga/Protocol/Statusdat/Reader.php
library/Icinga/Protocol/Statusdat/RuntimeStateContainer.php
library/Icinga/Protocol/Statusdat/View/AccessorStrategy.php
library/Icinga/Web/ActionController.php
library/Icinga/Web/Form.php
library/Icinga/Web/Hook/Configuration/ConfigurationTab.php
library/Icinga/Web/Hook/Configuration/ConfigurationTabBuilder.php
library/Icinga/Web/Hook/Configuration/ConfigurationTabInterface.php
library/Icinga/Web/Hook/Grapher.php
library/Icinga/Web/Hook/Toptray.php
library/Icinga/Web/ModuleActionController.php
library/Icinga/Web/Notification.php
library/Icinga/Web/Paginator/Adapter/QueryAdapter.php
library/Icinga/Web/Paginator/ScrollingStyle/SlidingWithBorder.php
library/Icinga/Web/Widget.php
modules/monitoring/application/views/helpers/MonitoringCommands.php
modules/monitoring/application/views/helpers/MonitoringFlags.php
modules/monitoring/application/views/helpers/MonitoringProperties.php
modules/monitoring/application/views/scripts/show/components/comments.phtml
modules/monitoring/application/views/scripts/show/components/downtime.phtml
modules/monitoring/application/views/scripts/show/components/flags.phtml
modules/monitoring/application/views/scripts/show/components/properties.phtml
modules/monitoring/application/views/scripts/show/header.phtml
modules/monitoring/application/views/scripts/show/host.phtml
modules/monitoring/application/views/scripts/show/service.phtml
modules/monitoring/library/Monitoring/Backend/AbstractBackend.php
modules/monitoring/library/Monitoring/Backend/Ido/Query/DowntimeQuery.php
modules/monitoring/library/Monitoring/Backend/Ido/Query/StatusQuery.php
modules/monitoring/library/Monitoring/Backend/Statusdat.php
modules/monitoring/library/Monitoring/Backend/Statusdat/Criteria/Order.php
modules/monitoring/library/Monitoring/Backend/Statusdat/DataView/StatusdatServiceView.php
modules/monitoring/library/Monitoring/Backend/Statusdat/Query/GroupsummaryQuery.php
modules/monitoring/library/Monitoring/Backend/Statusdat/Query/Query.php
modules/monitoring/library/Monitoring/Command/Meta.php
modules/monitoring/library/Monitoring/View/DowntimeView.php
modules/monitoring/test/php/application/views/helpers/MonitoringCommandsTest.php
modules/monitoring/test/php/application/views/helpers/MonitoringPropertiesTest.php
modules/monitoring/test/php/library/Command/MetaTest.php
2013-07-23 16:33:07 +02:00
Marius Hein
89e7fa6b2d
Command masks: Add validator and change validation flow
...
refs #4355
2013-07-23 14:47:40 +02:00
Marius Hein
c6ebe85782
Command masks: Implement list over all implemented commands [WIP]
...
refs #4355
2013-07-23 14:47:40 +02:00
Marius Hein
03f4a8eceb
Command masks: Implement missing forms [WIP]
...
Fixes phpcs issues, missing features, fix controller using
new config interface.
refs #4355
2013-07-23 14:47:40 +02:00