Commit Graph

276 Commits

Author SHA1 Message Date
Thomas Gelf ecaa12b0f4 Improved default sort bevahior 2013-09-17 10:42:27 +02:00
Thomas Gelf bb99358a21 Renamed MonitoringView to AbstractView 2013-09-17 10:41:02 +02:00
Thomas Gelf 258d7dbafb Did measurements, leads to new index suggestions 2013-09-17 10:38:14 +02:00
Thomas Gelf cc4cf42d0e Some TODO 2013-09-17 10:38:14 +02:00
Thomas Gelf 4b62297b3e Searching for 'unhandled' is more interesting than 'handled', other small fixes 2013-09-17 10:38:14 +02:00
Thomas Gelf 344a99bbb8 service_hard_state is the current hard state 2013-09-17 10:38:14 +02:00
Thomas Gelf b9805e579e A service is considered handled once the host is not UP 2013-09-17 10:38:14 +02:00
Thomas Gelf 781fb394ac More cleanup, timestamp fixes 2013-09-17 10:38:14 +02:00
Thomas Gelf cd37f47d1b Last/next check are timestamps, give NULL when it doesn't make sense 2013-09-17 10:38:14 +02:00
Thomas Gelf 200731aedc Some more readability 2013-09-17 10:38:14 +02:00
Thomas Gelf d5c86c5328 Readability, small fixes 2013-09-17 10:38:13 +02:00
Thomas Gelf 76ecc9184d hgo.name1 needs objects table to be around 2013-09-17 10:38:13 +02:00
Thomas Gelf 93e54fac62 Trying hard to get aggregations done right 2013-09-17 10:38:13 +02:00
Thomas Gelf 7e83099ef7 One more thing TODO 2013-09-17 10:38:13 +02:00
Thomas Gelf 3cd947ab29 A bunch of aggregating columns are interesting once joined with services 2013-09-17 10:36:05 +02:00
Thomas Gelf 86248d7bcb hostgroup. Without the 's'. And case insensitive 2013-09-17 10:36:05 +02:00
Thomas Gelf 6d27b688fe Added hostgroups column alias. Not sure about the 's' 2013-09-17 10:36:05 +02:00
Thomas Gelf eaaa7205c9 Have been using former namespace, fixed 2013-09-17 10:36:05 +02:00
Thomas Gelf cf26e3b106 Ido\AllcontactsQuery joins contacts directly and through contactgroups 2013-09-17 10:36:04 +02:00
Thomas Gelf d9f1c4678b Ido\ContactgroupQuery needs a conservative count approach 2013-09-17 10:36:04 +02:00
Thomas Gelf 521ef8cc47 Added a few columns to Ido\ContactgroupQuery, fixed joins 2013-09-16 17:02:30 +02:00
Thomas Gelf 23235e4513 Added a few columns to Ido/ContactQuery 2013-09-16 17:02:30 +02:00
Thomas Gelf fbdfa7a59e StatehistoryQuery, initial commit 2013-09-16 17:02:30 +02:00
Thomas Gelf 07badc377e NotificationhistoryQuery, initial commit 2013-09-16 17:02:30 +02:00
Thomas Gelf 4330122221 DowntimestartQuery and DowntimeendQuery, initial commit 2013-09-16 17:02:30 +02:00
Thomas Gelf eef5f6ae18 CommenthistoryQuery, initial commit 2013-09-16 17:02:30 +02:00
Thomas Gelf d15481b643 Preparing base query before creating alias indexes.
* This allows the joinBaseTables functions to adjust columns in time
2013-09-16 17:02:30 +02:00
Thomas Gelf bd983c7478 Default joinBaseTables implementation, can simplify simple queries 2013-09-16 17:02:30 +02:00
Thomas Gelf f3eedd919f No more need for special treatment for some columns, as we can create filter* functions 2013-09-16 17:02:30 +02:00
Thomas Gelf 830b178e37 Fixed hardcoded default columns 2013-09-16 17:02:29 +02:00
Thomas Gelf 1c2142be27 Prepared filter support for aggregated columns (where VS having) 2013-09-16 17:02:29 +02:00
Thomas Gelf df07735e9a Prepared more Oracle-specific id-columns 2013-09-16 17:01:47 +02:00
Thomas Gelf d44c15eea0 Filter handling cleanup and small improvements:
* a pipe (|) is now accepted as OR
* improved readability
* prepared for splitting logic - most of this could be backend-agnostic
* greater / less then is now possible
2013-09-16 17:01:47 +02:00
Thomas Gelf 5467950e79 Shortcut for creating subqueries 2013-09-16 17:01:47 +02:00
Eric Lippmann 8baa2dec54 Command: Rename getParameters to getArguments
refs #4580
2013-09-16 14:46:18 +02:00
Eric Lippmann a47db3497e Rename BaseCommand to Command
refs #4580
2013-09-16 14:44:59 +02:00
Eric Lippmann bf012fbd7e Remove CommandType interface
Moved BaseCommand from the monitoring module to the application's library.

refs #4580
2013-09-16 14:39:14 +02:00
Johannes Meyer 8e60e2dcd9 Fix group and children handling of ScheduleDowntimeCommand
refs #4580
2013-09-16 13:14:29 +02:00
Johannes Meyer 7045148f93 Adjust submitpassivecheckresult command handling
refs #4580
2013-09-16 13:14:29 +02:00
Johannes Meyer fef8370d5f Adjust reschedulecheck command handling
refs #4580
2013-09-16 13:14:28 +02:00
Johannes Meyer e9dc895b37 Adjust delay notification handling
refs #4580
2013-09-16 13:14:28 +02:00
Johannes Meyer 36424b508b Adjust custom notification handling
refs #4580
2013-09-16 13:14:28 +02:00
Johannes Meyer 52079b2e73 Adjust schedule downtime handling
refs #4580
2013-09-16 13:14:28 +02:00
Johannes Meyer ba7f455643 Adjust schedule downtime handling (WIP)
refs #4580
2013-09-16 13:14:28 +02:00
Johannes Meyer 8022bf57af Some doc fixes and other improvements
refs #4580
2013-09-16 13:14:28 +02:00
Eric Lippmann c09dad98f9 Views: Remove $trimArea since it's not used 2013-09-06 16:39:47 +02:00
Eric Lippmann c47778f10e Capitalize monitoring properties, e.g. Current Attempt 2013-09-05 14:49:37 +02:00
Eric Lippmann a5908c9553 CS: Replace multiple empty lines with one
find application/ library/Icinga/ test/ modules/ -name *.php | xargs sed -i '/^$/N;/^\n$/D'
2013-09-04 18:36:10 +02:00
Eric Lippmann 35fd9fd391 CS: Remove whitespaces at end of line
find application/ library/ test/ modules/ -name *.php | xargs sed -i 's/\s\+$//'
2013-09-04 18:27:16 +02:00
Jannis Moßhammer 7f4e1936f7 Fix trigger downtime default value issing, docstring fixes
refs #4580
2013-09-04 18:08:00 +02:00
Johannes Meyer b74e264f01 Refactor comment command handling
- Refactored Comment class
- Dropped IComment interface
- Added AddCommentCommand class
- Updated CommentForm

refs #4580
2013-09-04 18:08:00 +02:00
Johannes Meyer 9a476f16f4 Re-refactor dispatch process of commands and acknowledgement handling
refs #4580
2013-09-04 18:08:00 +02:00
Johannes Meyer 1593406f31 Refactor Acknowledgement command handling
#refs 4580
2013-09-04 18:07:59 +02:00
Johannes Meyer 79eb6588c5 Restructure dispatch process of commands
refs #4580
2013-09-04 18:07:59 +02:00
Johannes Meyer 95d7a8a553 Fix triggered_by field in ScheduleDowntimeForm is not a select box
refs #4496
2013-09-04 18:07:59 +02:00
Eric Lippmann 2b10782d6b Fix use \Monitoring without Icinga\Module prefix
refs #4601
2013-09-04 16:08:20 +02:00
Jannis Moßhammer e915119845 Fix grid styling and add links for hosts and service
refs #4601
2013-09-04 15:22:01 +02:00
Jannis Moßhammer d27e34cef8 Codestyle and Test fixes for SortBox
refs #4601
2013-09-04 15:22:00 +02:00
Jannis Moßhammer 57e66c247a Add sort widget, change js path from module to app, small style fixes
refs #4601
2013-09-04 15:22:00 +02:00
Eric Lippmann 1b858cbdb4 Monitoring: Fix remaining usages of namespace Monitoring without Icinga\Module prefix
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann 3e4d1aa2fb Monitoring/Tests: Replace BaseFormTest with BaseTestCase
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann e3044b8b62 Tests/Monitoring: Remove ScheduleDowntimeFormTest since it's being refactored in another branch
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann a89631fd92 Tests/Monitoring: Remove useless test ConfirmationFormTest
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann 74b9731df5 Remove auto class requirement from BaseTestCase::createForm()
The tests for the respective forms must require the form class.

refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann 8a062ff3e5 Fix tests after renaming the namespace
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann c86874d4ba Rename namespace Monitoring to Icingæ\Module\Monitoring
refs #4586
2013-09-04 11:21:11 +02:00
Johannes Meyer 23f0962da1 Adjust command forms and tests
Made those command forms using the DateTimePicker
element compatible with its new validation.

refs #4581
2013-09-03 09:27:02 +02:00
Jannis Moßhammer 9f923b4940 Fix pagination and remove ModuleController, rename handlesAuth
This commit introduces the following changes:
- Count is now performed after joins are added to the selection query,
  therefore returning the correct number
- MonitoringControllerTest now needn't to mock ModuleActionController (which is now removed)
- handlesAuthentication is now requiresAuthentication
- Redirection to login is now directly handled in the ActionController constructor,
  so we don't need to overwrite the preDispatch method

refs #4589
refs #4591
refs #4572
2013-09-02 18:42:05 +02:00
Johannes Meyer 24ecbb56d7 Fix incorrect checkresult type selection
When submitting a passive checkresult for hosts only their correct
result types are added to the selection.

refs #4600
2013-09-02 17:24:42 +02:00
Jannis Moßhammer d0ac97f335 Configure fixes, regression test for 4606
The configure routine still has to be improved, right now unused
authentication backends are commented out

refs #4491
refs #4606
refs #4640
2013-08-29 11:48:32 +02:00
Jannis Moßhammer b5812fd56c Fix installation via configure/make
The installation routine uses the .htaccess file right now, as
this is used in the 'dump' /var/www installation.

refs #4491
2013-08-29 11:47:10 +02:00
Jannis Moßhammer 4527aaf57a Smaller fixes in phpdoc style
refs #4566
2013-08-28 14:42:31 +02:00
Johannes Meyer 13e4efa221 Make use of the helptext decorator if suitable
Refactored some uses of the form element Note so that
each one is properly attached to its input element.

refs #4566
2013-08-28 08:57:46 +02:00
Marius Hein 2f610b70ac Fix icon identifer and capitalization
refs #4550
refs #4584
2013-08-23 10:58:58 +02:00
Jannis Moßhammer 895976550c Fix templates, capitalization and icons in php files
refs #4550
refs #4584
2013-08-23 10:28:48 +02:00
Jannis Moßhammer 015a914aab Fix template code style, use Bootstrap 3, remove icons
- Icons have now the {{XY_ICON}} format
- custom classes are removed
- A few typos are fixed
- Capitalization

refs #4550
refs #4621
refs #4584
2013-08-23 10:28:48 +02:00
Jannis Moßhammer 872fa2ac6c HTML Style fixes and class removals
refs #4550
2013-08-23 10:28:47 +02:00
Jannis Moßhammer bff45a1eb2 Template cleanup and validation part 1
refs #4550
2013-08-23 10:27:16 +02:00
Jannis Moßhammer 1378ca9844 Remove and reorganize stylesheets, add boostrap 3
refs #4550
2013-08-23 10:27:16 +02:00
Jannis Moßhammer 95ad8da2a3 Fix class not found exception when trying to send commands
This has already been fixed but got lost during a rebase,
so no ticket ref exists.
2013-08-21 16:48:12 +02:00
Eric Lippmann edb06ea8ea CS: Fix viloations for touched files in branch feature/backend-configuration-ui-3776
refs #3776
2013-08-21 14:22:31 +02:00
Eric Lippmann 585f69fe8f Monitoring/Configuration: Show ido, Ido as IDO
refs #3776
2013-08-21 14:22:30 +02:00
Jannis Moßhammer cd1fb2e4b5 Capitalization, smaleler codestyle fixes
refs #3776
2013-08-21 14:22:30 +02:00
Jannis Moßhammer 83d053965f Implement monitoring instance and backend configuration forms
refs #3776
2013-08-21 14:22:30 +02:00
Jannis Moßhammer a6ff6ecadd Fix Codestyle/PHPDoc, fix configPath being Overwritten
Also removed possibility to disable debugging as there's no use case for this

refs #4525
refs #4598
2013-08-21 14:22:30 +02:00
Jannis Moßhammer 972bc9853e Configuration interfaces for logging, authentication and general configuration
- Added HelpText decorator
- Added Time and DateFormatValidator
- Added tests

refs #3777
2013-08-21 14:22:30 +02:00
Jannis Moßhammer 17c1e5a449 Add tests, move BaseFormTest away from modules/monitoring
refs #3777
2013-08-21 14:18:53 +02:00
Jannis Moßhammer 26a5018d16 Add Forms and conditional hidden
refs #3777
2013-08-21 14:18:53 +02:00
Jannis Moßhammer d7358c65be Remove QUrl and QLink, add Href
refs #4516
2013-08-21 09:44:01 +02:00
Eric Lippmann 6765648380 Monitoring: Fix nonexistent Icinga\Backend usage in CommandController 2013-08-21 09:44:01 +02:00
Eric Lippmann d574a26db3 Monitoring: Fix nonexistent Icinga\Backend usage in CommandController 2013-08-20 16:19:34 +02:00
Marius Hein d1cc1fb61f Codestyle and doc strings for list controller
refs #4583
2013-08-20 15:45:44 +02:00
Marius Hein df864d2738 Remove unused summary components
refs #4583
2013-08-20 15:38:00 +02:00
Eric Lippmann ff1ed128ef Remove filter boxes from monitoring' list views since they're not working
refs #4583
2013-08-20 15:14:58 +02:00
Eric Lippmann ad84e9e9cf Remove unimplemented list views (concat-, host-, and servicegroups)
refs #4583
2013-08-20 15:14:57 +02:00
Eric Lippmann 207c47ae64 Nav: Remove tabs from ListController since their links are redundant to the main menu
refs #4583
2013-08-20 15:14:57 +02:00
Jannis Moßhammer bda3537c36 Comment out error-prone checktime test
The check time test for the host list easily fails when the db access
is slower than 1s, so it's commented out here

refs #4575
2013-08-19 20:16:40 +02:00
Marius Hein 3a8a3b8f2c Monitoring backend: Change database objects to DbAdapterFactory
refs #4575
2013-08-19 18:29:26 +02:00
Marius Hein eddbbd5f5b Monitoring backend: Move backends.ini to module configuration
refs #4575
2013-08-19 18:29:26 +02:00
Jannis Moßhammer f081531585 Phpdoc and small text fixes
refs #4524
2013-08-16 17:38:50 +02:00