aa5db51e77
`Repository`: Use correct name case for `DateTime::getTimestamp()` in `retrieveGeneralizedTime()` method
2023-08-23 10:53:13 +02:00
22c790ea48
`ActionControlle`: Avoid void return in `__call()` magic method
2023-08-23 10:53:13 +02:00
6b0244f247
`ActionController`: Declare property `$view`
2023-08-23 10:53:13 +02:00
2db4e35b78
`Button`: Import class `Zend_Config`
...
The parameters for the constructor can be of type `Zend_Config`. Hence the class has been imported.
2023-08-23 10:53:13 +02:00
f05d76e05e
`FormElement`: Fix the return type of `loadDefaultDecorators()`
2023-08-23 10:53:13 +02:00
4108b6b4cc
`Navigation`: Cast string to int to perform addition
...
In `library/Icinga/Web/Navigation/Navigation::merge()` the result of `preg_match`
must be cast to int before adding 1 to it.
2023-08-23 10:53:13 +02:00
fdddc21bc8
`View`: Define parameter `$var` for `escape()` as nullable
2023-08-23 10:53:13 +02:00
bf5aa41d63
`Widget`: Imported class `AbstractWidget`
...
The return type of static method `Widget::create()` is `AbstractWidget` instance.
Hence it is imported in `Widget::class`.
2023-08-23 10:53:13 +02:00
1d8ce55262
`AbstractWidget`: Import class `Zend_View_Abstract`
...
Since static property `AbstractWidget::view` is of type `Zend_View_Abstract` instance. The
class needs to be imported.
2023-08-23 10:53:13 +02:00
daddfe11b5
`Tab`: Fix type of property `$url`
...
`$url` can either be a string or `Icinga\Web\Url` instance.
2023-08-23 10:53:13 +02:00
3b707fb6ab
`Wizard`: Fix return type for method `getPage()`
...
The method `Wizard::getPage()` could also return `ModulePage` instance. Hence it is included as one of the
return type of this method.
2023-08-23 10:53:13 +02:00
4bfa2355b7
`DocSectionRenderer`: Replace fully qualified names of classes with class names
...
The classes in PHPDoc are imported and their fully qualified names are replaced with their class names.
2023-08-23 10:53:13 +02:00
acf3b7d340
`DocSearchIterator`: PHPDoc for `$section` is moved above the variable declaration in method `accept()`
2023-08-23 10:53:13 +02:00
4bece296e5
`MonitoringFlags`: Import class `MonitoredObject`
2023-08-23 10:53:13 +02:00
a780d9790b
Declare property `$view` for helpers in monitoring modules
...
The property `$view` with type `Icinga\Web\View` is declared for helpers in `modules/monitoring/application/views/helpers`
directory.
2023-08-23 10:53:13 +02:00
d22d2fb1e0
`HoststatussummaryQuery`: Fix name case for `HoststatusQuery`
2023-08-23 10:53:13 +02:00
b481a771d0
`ServicestatussummaryQuery`: Fix name case for `ServicestatusQuery`
2023-08-23 10:53:13 +02:00
caede2aaa9
`MonitoringBackend`: Import interface `QueryInterface`
...
The return type of `modules/monitoring/library/Monitoring/Backend/MonitoringBackend::query()` is `Icinga\Data\QueryInterface`.
Hence this interface is imported in `MonitoringBackend::class`.
2023-08-23 10:53:13 +02:00
a68e0595ff
`CommandTransport`: Fix return type for method `createTransport()`
...
`Icinga\Module\Monitoring\Command\Transport\CommandTransport::createTransport()` also returns `Icinga\Module\Monitoring\Command\Transport\ApiCommandTransport::class`.
Hence it is added to the method's return type in PHPDoc.
2023-08-23 10:53:13 +02:00
d7518388d8
`RemoteCommandFile`: Define parameter `$resource` as nullable for method `setResource()`
2023-08-23 10:53:13 +02:00
3d61fe6bf2
`MonitoringWizard`: Fix type for parameter `$page` of method `setupPage()`
...
The `$page` parameter for `Icinga\Module\Monitoring\MonitoringWizard::setupPage()` can also be
`Icinga\Module\Setup\Forms\RequirementsPage` or `Icinga\Module\Setup\Forms\SummaryPage`.
2023-08-23 10:53:13 +02:00
209bf62a56
`DbTool`: Import class `Zend_Db_Adapter_Pdo_Abstract`
...
Since `DbTool::zendconn` is of type `Zend_Db_Adapter_Pdo_Abstract`, it has to be imported.
2023-08-23 10:53:13 +02:00
1b1182d9b9
`Macro`: Import generic class `stdClass`
...
Generic empty class `stdClass` is imported as it is one of the return type for `Macro::resolveMacro()`
2023-08-23 10:53:13 +02:00
8b6f9fbfed
`ObjectList`: Fix return type for `getScheduledDowntimes()`
2023-08-23 10:53:13 +02:00
30c26f16fe
`ObjectList`: Include `\Icinga\Data\Filter\FilterChain` as return type in `getFilter()`
2023-08-23 10:53:13 +02:00
b813e0badb
`Perfdata`: Fix return type for method `convert()`
2023-08-23 10:53:13 +02:00
8fe428f987
`CustomVarTable`: Cast `$wrapper` to `ipl\Html\HtmlDocument` using inline `@var` in `renderGroup()`
2023-08-23 10:53:13 +02:00
baeba7c27a
`AdminAccountPage`: Cast `$query` to `LdapQuery` using inline `@var`
2023-08-23 10:53:13 +02:00
9e0c8ef76a
`RequirementsRenderer`: Cast `$currentSet` to `RequirementSet` in `beginChildren()` using inline @var
2023-08-23 10:53:13 +02:00
7677a0bc4e
`WebWizard`: Access `Form::getName()` with correct name case in `getNewPage()`
2023-08-23 10:53:13 +02:00
ea2166be6d
`WebWizard`: Import exception `InvalidArgumentException`
2023-08-23 10:53:13 +02:00
fc321ddc49
`WebWizard`: Use inline `@var` to cast setup pages to correct type
2023-08-23 10:53:13 +02:00
aa5da53c9d
`Webserver`: Fix name case of return type for `createInstance()` method
2023-08-23 10:53:13 +02:00
c0145890a3
`ArrayToTextTableHelper`: Update PHPDoc for constructor
2023-08-23 10:53:13 +02:00
06d61001b1
`GettextTranslationHelper`: Fix parameter list for `getSourceFileNames()` method
2023-08-23 10:53:13 +02:00
00f367c7d6
`MonitoredObjectController`: Access `MonitoredObject::fetchEventhistory()` with correct name case
2023-08-23 10:53:13 +02:00
72d155c57d
Remove not in use class `Plugin.php`
2023-08-23 10:53:13 +02:00
31bfdb33e1
Github Actions: Add PhpStan
...
Co-authored-by: Ravi Srinivasa <raviks789@gmail.com>
2023-08-23 10:53:13 +02:00
bd0fb8c154
Remove the use of unavailable property `$this->lessc->importDisabled`
...
The functionality to set import to disabled is removed in `lessc`. Hence the code where this
property is used has been removed from `LessCompiler`.
2023-08-23 10:53:13 +02:00
8e3c456327
Fix parameter name mismatch in `View::escape` method
...
The mismatch arises after migration from ZF1 to ZF-future.
2023-08-23 10:53:13 +02:00
695fe25891
Remove dead code from `Visitor.php`
...
The method `Visitor::visitColor` seems like a dead code and contains dynamic property
allocation. Hence, this method has been removed.
2023-08-23 10:53:13 +02:00
825f3a9b7f
Avoid use of dynamic properties deprecated in PHP 8.2
2023-08-23 10:53:13 +02:00
6de4bd6e7e
Explicitly add Module#configdir as (non-dynamic) property
...
W/o this the login page, if on PHP 8.2, says:
Deprecated: Creation of dynamic property Icinga\Application\Modules\Module::$configdir is deprecated in /usr/share/icingaweb2/library/Icinga/Application/Modules/Module.php on line 264
This breaks modules (if any) which use the property and not the getter.
2023-08-23 10:53:13 +02:00
f330fcba91
Add PHP 8.2 to the php workflow
2023-08-23 10:53:13 +02:00
847ba4f395
PdfExport: Fix false positive `! empty($this->content)`
2023-08-22 12:44:46 +02:00
8b99852fc2
Remove unused `FilterWidget::class` ( #5061 )
2023-08-21 15:35:17 +02:00
7da8431c7c
Fix documentation format (kiosk mode)
...
The text for the ini file was all shown in one line.
It's formatted properly now.
2023-08-21 11:26:14 +02:00
9c7d19ea95
JS: Don't always prefix extra updates containers with `#`
2023-08-11 16:14:17 +02:00
4a52a653e4
js: Always load redirects to their designated target
...
The server applies the redirection magic now, but only
for compatibility reasons.
resolves #4881
2023-08-11 16:08:00 +02:00
243192ba93
js: Enhance server side container closing ( #5065 )
...
* Let response header `X-Icinga-Container` either influence a request's
`$target` or `$redirectTarget`, but not both
* Issuing a `__CLOSE__` in a detail url still closes `#col2` and
refreshes `#col1`
* Issuing a `__CLOSE__` for a nested container still empties it
* Issuing a `__CLOSE__` in a modal, now refreshes the modal openers
container (now also `#col1`)
2023-08-11 16:07:38 +02:00
raviks789
Sukhwinder Dhillon
Alexander A. Klimov
Bernd Arnold
Yonas Habteab
Johannes Meyer