2493cb8d63
Fix incorrect uses of translation around sprintf
2017-11-21 15:47:46 +01:00
e4fd8d5124
Setup: Only allow to validate the API transport configuration
...
refs #3101
2017-11-21 13:48:29 +01:00
22c6bf75e7
Setup: Fix that the API transport validation does not work
...
refs #3101
2017-11-21 13:48:17 +01:00
d11519ac49
pogsql: Group by custom variables when querying them
...
Custom variables added via the URL parameters addColumns or sort must be added to the GROUP BY list when using PostgreSQL.
Credits to @nbuchwitz who came up with the initial fix for this.
refs #1873
2017-11-16 09:20:22 +01:00
166f27b947
CSS: Optimize monitoring status bar spacing
2017-11-13 15:02:06 +01:00
bb794d6993
Detect UP and DOWN in plugin output to colorize output
...
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-11-10 11:33:52 +01:00
fa9b2981d7
Fix PHP fatal error on monitoring/health/info when asking for JSON
...
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-11-10 11:16:33 +01:00
928185a144
Fix wrong unhandled services count in host views when restrictions are used
...
The query for fetching the unhandled services count utilises the hosts query as subquery.
Restrictions are applied to both the hosts query and the query for the unhandled services count.
This leads to wrong results since the restrictions are already in place for the unhandled services count because we're using the hosts query as subquery.
refs #2822
2017-11-10 10:17:32 +01:00
23066d2cc4
ServicegroupQuery: Use left joins instead of inner joins
...
refs #2796
2017-11-09 09:42:46 +01:00
4ef085bdcd
HostgroupQuery: Use left joins instead of inner joins
...
refs #2796
2017-11-09 09:42:46 +01:00
121fdaadb0
Allow to search for host and servicegroups by their case insensitive names too
...
refs #2971
2017-11-08 15:40:43 +01:00
f4ce2a5d82
Fix code style issues
2017-11-08 11:29:33 +01:00
73a6750489
Make phpcs and PhpStorm happy w/ intentional switch, case fall-throughs
...
Unfortunately, PhpStorm does not regonise PSR2 fall-through comments.
On the other hand, phpcs does not support the @noinspection phpdoc comment (/**).
The fix is a mix of PSR2 comments and @noinspection tags in code comments.
2017-11-08 10:25:28 +01:00
c3ef50978a
style: Fix minor styleguide issues for PHPCS
2017-11-08 10:06:45 +01:00
2caa07ce9b
Merge pull request #3027 from Icinga/bugfix/respect-limits-and-sort-order-for-format-requests-2967
...
Respect limits and sort orders for format requests
2017-11-06 09:51:19 +01:00
1748b3df9d
Fix help for icingacli monitoring list (--unhandled is --problems, etc.)
...
The help text still showed the wrong paramter, while it was not documented
as possible parameter either. In addition to that #562 unveils that a
custom --format parameter requires selected columns to do so.
This patch adds that into the documentation which is rendered as CLI command
help text then.
refs #562
2017-10-24 21:05:39 +02:00
37aeff7791
Respect limits and sort orders for format requests
...
fixes #2967
2017-10-23 15:49:12 +02:00
46a82c2739
Monitoring: Make downtime for all services checkbox configurable
...
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-10-23 11:17:25 +02:00
bd5de0949d
Remove array syntax from default comment filter
...
Added comment types 'comment' and 'ack' as separate fields and removed
the array syntax due to problems with the filter editor.
refs #2925
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-10-23 10:45:21 +02:00
c17c1b876c
Export JSON with .json extension
...
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-10-18 13:47:08 +02:00
91948a5a37
Merge pull request #2983 from Mikesch-mp/csv-export
...
Export CSV files with .csv extension
2017-10-18 13:21:59 +02:00
d76a18dd91
Export CSV files with .csv extension
...
refs #2808
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-10-18 13:21:19 +02:00
3b7147af16
Fix broken links in docs of monitoring and translation module
2017-10-09 15:52:10 +02:00
8de0b80f9e
Fix contact group member count
...
fixes #2837
2017-10-05 14:35:15 +02:00
773dae3750
Merge pull request #2978 from Icinga/fix/drop-livestatus
...
Remove unsupported livestatus functionality
2017-09-29 11:15:54 +02:00
4cadc90c92
Merge pull request #2972 from Icinga/feature/enhance-docs-add-missing-bits
...
Enhance the documentation, add missing bits and fix outdated information
2017-09-29 11:15:17 +02:00
36b5c949fd
Add documentation for addColumns in host/service list views
...
fixes #2579
2017-09-29 11:01:45 +02:00
34bd8e14c3
Enhance the documentation and fix outdated information (preferences, etc.)
...
This applies a new structure for the main doc/ and modules/*/doc tree with
01-About.md
02-Installation.md
...
This allows us to link from the main doc directory into module specific
documentation entries.
Furthermore table formatting, examples, and missing settings have been added
where applicable.
This patch also takes care about proper URL anchors and file names and directories.
fixes #2950
2017-09-29 11:01:37 +02:00
ab364e0fc7
Remove unsupported livestatus functionality
...
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-09-29 10:33:55 +02:00
3790fd0819
Bump version to 2.4.2
...
(cherry picked from commit 13e86b6320
2017-09-28 14:24:00 +02:00
624fab8194
Merge pull request #2960 from Icinga/bugfix/host-severity-order-2926
...
Adjust host severity
2017-09-25 17:11:36 +02:00
0b30fbd15d
Adjust host severity
...
refs #2926
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-09-25 17:03:33 +02:00
467fc79095
Style monitored objects' detailview extensions as expected
...
refs #2949
2017-09-20 14:49:14 +02:00
c2ee3bef06
DetailviewExtensionHook: provide the concrete implementation's module
...
refs #2949
2017-09-20 14:49:08 +02:00
2c312adf94
API Commands: Only send acknowledgement expire time if not null
...
Icinga 2 v2.7.0 is more strict with the `expiry` attribute if sent
(cannot be null, or in the past).
While acknowledgments with expire time worked well (and do so with this patch),
the command renderer did not check whether the value is actually not null
before setting it into the data form. The boolean value from the checkbox is
not available in the command renderer unfortunately.
@lippserd: Verified working with and without expire time inside the Vagrant boxes.
fixes #2911
2017-08-08 12:53:39 +02:00
2b3853d01c
Doc: Relax Icinga 2 API user permissions
...
Fixes #2884
2017-07-28 11:28:35 +02:00
adc2f90f74
Show DOWN hosts before UNREACHABLE when sorting by host_severity
...
refs #2034
2017-07-27 16:08:29 +02:00
7c88ee70d2
Remove sort rules from Programstatus
...
Sort is not necessary here.
2017-07-27 15:03:12 +02:00
1621755103
Don't call UNIX_TIMESTAMP when sorting by host_severity
2017-07-27 15:03:12 +02:00
9b7a155db2
Don't call UNIX_TIMESTAMP when sorting by service_severity
2017-07-27 15:03:12 +02:00
8a6240fe02
Reduce service_severity order by columns
...
Ordering by host and service display_name too here reduces performance and is not necessary.
2017-07-27 15:03:12 +02:00
c5f2fc5aa5
Reduce service_display_names order by columns
...
Ordering by host_display_name too here reduces performance as it forces MySQL to use a temp table.
2017-07-27 15:03:12 +02:00
ee429f54d0
Reduce host_severity order by columns
...
Ordering by host_display_name too here reduces performance and is not necessary.
2017-07-27 15:03:12 +02:00
e7776d08a9
Don't call UNIX_TIMESTAMP when sorting by host_last_state_change
...
Else possible indices can't be used.
2017-07-27 15:03:12 +02:00
3a1afb3511
Don't call UNIX_TIMESTAMP when sorting by service_last_state_change
...
Else possible indices can't be used.
2017-07-27 15:03:12 +02:00
9b529bcd15
Flip base tables in HoststatusQuery
...
This has no performance impact but all our queries should start w/ select from icinga_objects.
2017-07-27 15:03:12 +02:00
370d148072
Optimize imports in HoststatusQuery
2017-07-27 15:03:12 +02:00
e42d86a4e1
Remove unncessary column definitions in the Hostgroupsummary and Servicegroupsummary data views
2017-07-27 15:03:12 +02:00
0a3da99e7f
Reduce filter columns of the Hostgroup and Servicegroup data views
...
Its not necessary to expose those columns because these data views do not directly accept user input.
2017-07-27 15:03:12 +02:00
44da318109
Remove no-op order columns Hosts Severiy and Services Severity from the host group and service group views
2017-07-27 15:03:12 +02:00
b4df81e75a
Optimize queries used for fetching the service group summaries
2017-07-27 15:03:12 +02:00
06cb980308
Don't add GROUP BY for unjoined tables
2017-07-27 15:03:12 +02:00
30cc51a823
Optimize queries used for fetching the host group summaries
...
refs #1883
2017-07-27 11:43:13 +02:00
f5a9016dea
Optimize queries for creating the host and service problem badges in the menu
...
We now use two fast count queries w/ an appropriate filter instead of fetching a whole bunch of unnecessary host and service counters.
2017-07-27 11:38:00 +02:00
a9f3f99049
Don't hide errors in the BackendAvailabilityNavigationItemRenderer
...
If an exception occurs when fetching the dataview, we will now log the exception and display a badge in state unknown.
2017-07-27 11:35:40 +02:00
439d78a982
Don't hide errors in the MonitoringBadgeNavigationItemRenderer
...
If an exception occurs when fetching the dataview, we will now log the exception and display a badge in state unknown.
2017-07-27 11:31:10 +02:00
28790d254b
Remove caching form the MonitoringBadgeNavigationItemRenderer
...
Caching will be no longer necessary because we will replace the queries used to fetch the problem badges.
2017-07-27 11:29:57 +02:00
c0d359fbbd
Fix base class of MonitoringBadgeNavigationItemRenderer
...
The MonitoringBadgeNavigationItemRenderer extended the SummaryNavigationItemRenderer before which does not make sense because they have nothing in common.
2017-07-27 09:33:44 +02:00
6848ed6c1e
Merge branch 'bugfix/can-t-progress-in-wizard-due-to-error-2842'
...
fixes #2842
2017-07-05 14:40:10 +02:00
5460465e07
Fix null->setDecorators()
...
refs #2842
2017-07-05 14:34:17 +02:00
d208b48b72
Monitoring: Fix permission for the 'Process check result' action
...
fixes #2878
2017-07-04 17:24:57 +02:00
3d3b1cdf4f
RestRequestTest: Fully qualify expected exception
2017-06-13 11:07:16 +02:00
a7f5278aee
Timeline: fix link to acknowledgements
...
refs #2850
2017-05-26 12:28:34 +02:00
a4a0f9f5e6
Allow to filter notifications by notification_reason
...
refs #2698
2017-05-04 14:38:00 +02:00
b900a01d02
Add sort by severity to the servicegroup links in the servicegroups overview
2017-05-04 14:37:43 +02:00
c36b2661b1
Add sort by severity to the hostgroup links in the hostgroups overview
2017-05-04 14:03:57 +02:00
68842f00d8
Fix version
2017-05-03 15:12:07 +02:00
d6e54e8624
Fix pending services link in the tactical overview
2017-05-03 09:58:44 +02:00
890c95a2ce
Fix badge for handled critical services in the servicegroups overview
2017-05-03 09:43:30 +02:00
85eeff6b09
Fix badge for handled critical services in the hostgroups overview
...
fixes #2806
2017-05-03 09:41:06 +02:00
7a2d8eda8d
Fix exception when the response from the Icinga 2 API has an empty result set
...
fixes #2805
2017-04-04 09:17:52 +02:00
f7a8cf8a6e
Merge pull request #2721 from Icinga/feature/change-order-of-command-transports-2709
...
Feature/change order of command transports 2709
2017-03-28 11:10:17 +02:00
30788ceed0
Merge pull request #2733 from Icinga/feature/set-focus-to-comment-field-for-comments-13535
...
Set focus to comment field for acknowledgements, downtimes and comments
2017-03-28 10:52:50 +02:00
efac7f44c9
Merge pull request #2748 from Icinga/bugfix/validate-icinga2-api-user-2674
...
Bugfix/validate icinga2 api user 2674
2017-03-28 10:25:12 +02:00
302e559aab
Merge pull request #2750 from Icinga/bugfix/click-on-host-in-service-grid-invalid-filter-2523
...
Servicegrid: assemble filters with the Filter class
2017-03-28 10:22:11 +02:00
0fc45ea953
Merge pull request #2755 from Icinga/feature/keep-quick-actions-in-action-form-2675
...
Preserve quick actions in a command form view
2017-03-28 10:15:37 +02:00
49239dc7db
Display downtime type as text in the downtimes list
2017-03-28 10:12:07 +02:00
bbaf10aed2
Merge pull request #2759 from Icinga/feature/show-downtime-type-for-object-2693
...
Show every downtime's type in the detail view of a monitored object
2017-03-28 10:10:05 +02:00
e134b165f4
Merge pull request #2762 from tobiasvdk/bugfix/correct-hover-text-for-handled-services-2656
...
Correct hover text of the status bar
2017-03-28 10:08:03 +02:00
f749c19f37
Merge pull request #2771 from Icinga/feature/monitoring-detailviewextension-hook-2104
...
Feature/monitoring detailviewextension hook 2104
2017-03-28 09:46:28 +02:00
389bf8f4ea
Document DetailviewExtensionHook
...
refs #2104
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-03-28 09:44:59 +02:00
a2dbc457fc
Merge pull request #2774 from Icinga/bugfix/config-protected-vars-not-updated-2767
...
Bugfix/config protected vars not updated 2767
2017-03-28 09:38:37 +02:00
cd8d6e41dc
AcknowledgeProblemCommandForm: respect configuration when creating elements
...
refs #2776
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-03-28 09:21:42 +02:00
9a79b194dd
SecurityConfigForm: if protected_customvars is not set at all, display suggestion as placeholder
...
refs #2767
2017-02-23 12:52:47 +01:00
fb2abf40f8
Make the view available to DetailviewExtensionHooks
...
refs #2104
2017-02-21 12:23:21 +01:00
9f5158a159
Correct hover text of the status bar
...
Correct the count of handled critical services in the hover text in the
status bar.
fixes #2656
2017-02-17 21:55:35 +01:00
31aad4d3f5
Show every downtime's type in the detail view of a monitored object
...
refs #2693
2017-02-14 18:13:28 +01:00
fe72973e6e
Preserve quick actions in a command form view
...
refs #2675
2017-02-14 13:07:31 +01:00
6d593620d6
Test RestRequest
...
refs #2674
2017-02-13 14:56:35 +01:00
96e7411e25
TransportConfigForm: validate whether the Icinga 2 API can be connected to
...
refs #2674
2017-02-13 14:56:35 +01:00
d2341369a9
Merge pull request #2730 from Icinga/bugfix/invalid-icinga-2-api-response-2728
...
Handle invalid Icinga 2 API response types
2017-02-13 14:44:51 +01:00
c810f2bfd1
Servicegrid: assemble filters with the Filter class
...
refs #2523
2017-02-13 12:24:58 +01:00
9e26359c62
Set focus to comment field for acknowledgements, downtimes and comments
...
refs #13535
2017-02-10 11:24:28 +01:00
96ef0dccf8
Make JSON error handling logic reusable
...
refs #2728
2017-02-09 19:50:04 +01:00
6fbec7134c
Handle invalid Icinga 2 API response types
...
refs #2728
2017-02-09 13:38:43 +01:00
95020bfed4
Show check attempts only for soft state changes
...
refs #2718
2017-02-08 14:09:18 +01:00
b74971c08c
Update German translation
...
refs #2709
2017-02-08 11:31:56 +01:00
10ddc8c821
Make the order of command transports easily changable
...
refs #2709
2017-02-07 19:08:18 +01:00
35ba15a7a6
monitoring: Don't offer the Icinga 2 API as transport if cURL is missing
...
fixes #2661
2017-02-01 15:37:52 +01:00
e83e317cc6
TransportConfigForm: Make the Icinga 2 API the default transport
...
fixes #2660
2017-02-01 14:52:45 +01:00
Markus Frosch
Johannes Meyer
Eric Lippmann
Florian Strohmaier
cstegm
Klaus Jrgensen
lippserd
Michael Friedrich
tfylling
Nicolai Buchwitz
Mikesch-mp
Blerim Sheqa
Jennifer Mourek
Alexander A. Klimov
Eric Lippmann
Tobias von der Krone