tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
3,134 Commits 123 Branches 71 Tags 80 MiB
Commit Graph

3134 Commits

Author SHA1 Message Date
Marius Hein ee6145a173 Ldap/Query: Remove __toString() 
This is needed because of exception handling. Exceptions can now bubble
up for default handling. Method render() was renamed to create() because
the method create a query. Adjust the test for method create().

refs #5536
 2014-09-02 10:17:01 +02:00
Marius Hein baf768040f LdapQuery: Use Ldap/Exception for errors 
refs #5536
 2014-09-02 09:55:57 +02:00
Johannes Meyer deebb64869 Adjust Icinga\Form\Config\General* to use handleRequest() & Co. 
refs #5525
 2014-09-01 16:16:56 +02:00
Marius Hein 1c24273c9b Backend: Better implementation for createBackend 
Thanks eric!

fixes #7043
 2014-09-01 16:11:34 +02:00
Marius Hein 63cb357d48 TimelineController: Fix The use statement with non-compound ... 
fixes #7023
 2014-09-01 15:58:55 +02:00
Marius Hein 6b6826f737 Bug7043Test: Fix test to run without ini configuration 
fixes #7043
 2014-09-01 15:53:32 +02:00
Johannes Meyer 0e63e36ec0 Move Icinga\Form\Config\ConfirmRemovalForm to Icinga\Form 
This is a generic form not necessarily being used just for configuration
purposes.

refs #5525
 2014-09-01 15:11:09 +02:00
Johannes Meyer cd8015f41a Pass the current form instance to the callback as second argument 
refs #5525
 2014-09-01 14:58:16 +02:00
Marius Hein 160fc900d0 Backend: Set name if create default backend 
fixes #7043
 2014-09-01 14:46:06 +02:00
Eric Lippmann 0822aff293 library/form: Fix return value of `getName()' not being filterd the first time it's called 
`Form::getName()' auto-detects the form's name if it's not set and sets the form's name using `Zend_Form::setName()'.
`Zend_Form::setName()' then filters the form name stripping backslash '\' characters. The first call to `Form::getName()'
did not regard the filtering and thus returned the unfiltered name which led to `Form::wasSent()' returning `false'.

refs #5525
 2014-09-01 14:40:45 +02:00
Marius Hein 7bb5ff2c30 Merge branch 'bugfix/postgres-5896' 
fixes #5896
fixes #6351
fixes #6350
 2014-09-01 10:00:33 +02:00
Marius Hein f47bc46654 GroupSummary/Postgres: Fix group by in initial join query 
refs #5896
 2014-09-01 10:00:04 +02:00
Marius Hein 21f0b4c925 CommandQuery: Remove select * from joins (Postgres) 
refs #5896
 2014-09-01 10:00:04 +02:00
Marius Hein 30f391035c Postgres/DbQuery: Add orderfields to select 
refs #6896
 2014-09-01 10:00:04 +02:00
Marius Hein b4e9bad87a NotificationHistoryQuery: Add missing field to group statement 
refs #5896
 2014-09-01 10:00:04 +02:00
Marius Hein e46dd4bdfd DowntimeQuery: Postgres fixes 
Change is_fixed to boolean check and illegal postgres timerange of
'0000-00-00 00:00:00'.

refs #5896
 2014-09-01 10:00:04 +02:00
Marius Hein 751d2e6d11 ErrorController: Log exception and stacktrace 
refe #5896
 2014-09-01 10:00:04 +02:00
Marius Hein 62f502d276 Postgres/StatusQuery: Fix concatenation and group by 
refs #5896
 2014-09-01 10:00:04 +02:00
Eric Lippmann f3e74f0f24 library/form: Append class 'autosubmit' in case the element to autosubmit has the class attribute set 
Before, the class attribute would've been overwritten.

refs #5525
 2014-09-01 09:44:04 +02:00
Johannes Meyer fb5685bac3 Merge branch 'master' into bugfix/rebuild-form-builder-5525 
Conflicts:
	application/forms/Config/Authentication/BaseBackendForm.php
	application/forms/Config/Authentication/DbBackendForm.php
	application/forms/Config/Authentication/LdapBackendForm.php
	application/forms/Config/Authentication/ReorderForm.php
	application/forms/Config/LoggingForm.php
	application/forms/Config/ResourceForm.php
	application/forms/Preference/GeneralForm.php
	library/Icinga/Application/Config.php
	library/Icinga/Web/Form.php
	modules/monitoring/application/controllers/ConfigController.php
	modules/monitoring/application/forms/Config/Backend/CreateBackendForm.php
	modules/monitoring/application/forms/Config/Instance/CreateInstanceForm.php
	modules/monitoring/application/forms/Config/Instance/EditInstanceForm.php
	modules/monitoring/application/forms/Config/SecurityForm.php
 2014-08-29 16:05:56 +02:00
Johannes Meyer ae35650c7e Adjust authentication backend forms to suit.. some form implementation 
refs #5525
 2014-08-29 15:16:13 +02:00
Johannes Meyer 364c7c0858 Add base form class for configuration forms 
refs #5525
 2014-08-29 12:25:25 +02:00
Johannes Meyer e020dd3541 Icinga\App..\Config: Rename __construct to fromIni and add setConfigPath 
Prior to this change it was not possible to create an instance of Config
without passing a config file.
 2014-08-29 12:23:48 +02:00
Johannes Meyer 79b0ed64ec Make it possible to provide a closure to be called instead of onSuccess() 
This allows us to write generic forms like the ConfirmRemoval form but to
utilize handleRequest() while providing a closure in the array that is passed
to a form's constructor.

refs #5525
 2014-08-29 12:21:31 +02:00
Matthias Jentsch 055a107b90 Merge branch 'bugfix/piechart-labels-stick-out-7022' 
fixes #7022
 2014-08-29 09:14:36 +02:00
Johannes Meyer bf23688e73 Make autosubmit work in non-JS enviroments 
We require forms to set autosubmit=true on elements which are supposed
to be submitted automatically now. The base form then ensures that this
works in JS environments and non-JS environments as well by applying the
right changes to the HTML.

refs #5525
 2014-08-29 09:08:53 +02:00
Johannes Meyer 486104d59e Check explictly for FALSE when calling onSuccess() 
This allows us to just end onSuccess() without requiring it to return TRUE
to initiate redirection.

refs #5525
 2014-08-29 09:04:20 +02:00
Matthias Jentsch 3642b7b6fc Adjust CSS for inlinePies to be centered on the current line 2014-08-28 18:27:30 +02:00
Matthias Jentsch a26370bb12 Adjust PieCharts that are rendered without labels 
Center and resize PieCharts to use the full width and height of the available view port
 2014-08-28 18:25:19 +02:00
Matthias Jentsch e799d65d3f Only apply SVG responsiveness when not rendered in compact mode 
Don't let SVGs grow vertically in when displayed in the dashboard, to avoid wasted space
 2014-08-28 16:52:02 +02:00
Matthias Jentsch 648debff88 Draw charts for single ServiceGroups as PieChart 2014-08-28 16:50:29 +02:00
Matthias Jentsch 00a2d225a2 Ensure that PieCharts are centered and that labels dont leave the viewBox 
Add scaling and transformations to move the PieChart into a valid coordinate system and reduce the offset of the labels to make more efficient use of available space.
 2014-08-28 16:42:31 +02:00
Matthias Jentsch c5cface661 Improve readability of small pie charts 
Use a bigger font, to ensure that small pie charts still have readable labels.
 2014-08-28 16:40:34 +02:00
Matthias Jentsch 98809a1447 Do not use width and height as width and height percentages in the outer SVG element 
Height and width are solely used to define the SVGs ratio and should not cause side effects on the SVGs size in the site context.
 2014-08-28 16:37:21 +02:00
Matthias Jentsch a9eec0d672 Remove useless width and height properties from PieChart 2014-08-28 16:33:38 +02:00
Matthias Jentsch f77cd9cafa Fix coding guidelines 2014-08-28 16:21:16 +02:00
Matthias Jentsch 573a4ea12f Fix spelling mistakes 2014-08-28 16:14:59 +02:00
Marius Hein 0da16e4c68 Merge branch 'bugfix/icinga2-contacts-7020' 
fixes #7020
 2014-08-28 13:42:16 +02:00
Marius Hein 0a2b504db8 Gracatar: Pre sized with 60px because of display latency 
refs #7020
 2014-08-28 13:41:21 +02:00
Marius Hein c4c5bcdd48 ContactQuery: Change timeperiod joins to joinLeft() 
refs #7020
 2014-08-28 13:39:49 +02:00
Marius Hein dea7caa633 Merge branch 'bugfix/ConfigAwareFactory-5514' 
fixes #5514
 2014-08-28 12:15:31 +02:00
Marius Hein 4e83bb098a LdapBackendFormTest: Fix mock 
refs #5514
 2014-08-28 12:14:55 +02:00
Marius Hein e345aa257a Platform: Drop *Available function 
Create a function extensionLoaded and change usages.

refs #5514
 2014-08-28 12:14:55 +02:00
Marius Hein 436a4d2965 ResourceConfig: Chance createResouce to create 
Not useful everywhere. Changed on the best suitable places.

refs #5514
 2014-08-28 12:14:55 +02:00
Marius Hein 9d0037a53a ResourceFactory: Add function create(<name>) 
The ConfigAwareFactory is an interface forcing "backend-type" classes to call
ResourceFactory::createResource() passing a config they got in the constructor.

That's kind of overdesigned, if the ResourceFactory wants to be something like
a service locator it's responsabilities should include object instantiation.

refs #5514
 2014-08-28 12:14:54 +02:00
Marius Hein 35d11bd145 Class doc for Platform 
refs #5514
 2014-08-28 12:14:54 +02:00
Marius Hein 9b83074cc9 Class doc for ResourceFactory 
refs #5514
 2014-08-28 12:14:54 +02:00
Marius Hein 22e17e9901 ResourceFactory: Move available function to platform 
refs #5514
 2014-08-28 12:14:54 +02:00
Alexander Klimov c194c02435 Remove useless 'use \Exception' 2014-08-28 11:45:26 +02:00
Marius Hein fdef695896 Fix: The use statement with non-compound name 'Exception' has no effect 2014-08-28 11:34:08 +02:00