Commit Graph

3882 Commits

Author SHA1 Message Date
Michael Friedrich 2c312adf94 API Commands: Only send acknowledgement expire time if not null
Icinga 2 v2.7.0 is more strict with the `expiry` attribute if sent
(cannot be null, or in the past).

While acknowledgments with expire time worked well (and do so with this patch),
the command renderer did not check whether the value is actually not null
before setting it into the data form. The boolean value from the checkbox is
not available in the command renderer unfortunately.

@lippserd: Verified working with and without expire time inside the Vagrant boxes.

fixes #2911
2017-08-08 12:53:39 +02:00
Eric Lippmann 2b3853d01c Doc: Relax Icinga 2 API user permissions
Fixes #2884
2017-07-28 11:28:35 +02:00
Eric Lippmann adc2f90f74 Show DOWN hosts before UNREACHABLE when sorting by host_severity
refs #2034
2017-07-27 16:08:29 +02:00
Eric Lippmann 7c88ee70d2 Remove sort rules from Programstatus
Sort is not necessary here.
2017-07-27 15:03:12 +02:00
Eric Lippmann 1621755103 Don't call UNIX_TIMESTAMP when sorting by host_severity 2017-07-27 15:03:12 +02:00
Eric Lippmann 9b7a155db2 Don't call UNIX_TIMESTAMP when sorting by service_severity 2017-07-27 15:03:12 +02:00
Eric Lippmann 8a6240fe02 Reduce service_severity order by columns
Ordering by host and service display_name too here reduces performance and is not necessary.
2017-07-27 15:03:12 +02:00
Eric Lippmann c5f2fc5aa5 Reduce service_display_names order by columns
Ordering by host_display_name too here reduces performance as it forces MySQL to use a temp table.
2017-07-27 15:03:12 +02:00
Eric Lippmann ee429f54d0 Reduce host_severity order by columns
Ordering by host_display_name too here reduces performance and is not necessary.
2017-07-27 15:03:12 +02:00
Eric Lippmann e7776d08a9 Don't call UNIX_TIMESTAMP when sorting by host_last_state_change
Else possible indices can't be used.
2017-07-27 15:03:12 +02:00
Eric Lippmann 3a1afb3511 Don't call UNIX_TIMESTAMP when sorting by service_last_state_change
Else possible indices can't be used.
2017-07-27 15:03:12 +02:00
Eric Lippmann 9b529bcd15 Flip base tables in HoststatusQuery
This has no performance impact but all our queries should start w/ select from icinga_objects.
2017-07-27 15:03:12 +02:00
Eric Lippmann 370d148072 Optimize imports in HoststatusQuery 2017-07-27 15:03:12 +02:00
Eric Lippmann e42d86a4e1 Remove unncessary column definitions in the Hostgroupsummary and Servicegroupsummary data views 2017-07-27 15:03:12 +02:00
Eric Lippmann 0a3da99e7f Reduce filter columns of the Hostgroup and Servicegroup data views
Its not necessary to expose those columns because these data views do not directly accept user input.
2017-07-27 15:03:12 +02:00
Eric Lippmann 44da318109 Remove no-op order columns Hosts Severiy and Services Severity from the host group and service group views 2017-07-27 15:03:12 +02:00
Eric Lippmann b4df81e75a Optimize queries used for fetching the service group summaries 2017-07-27 15:03:12 +02:00
Eric Lippmann 06cb980308 Don't add GROUP BY for unjoined tables 2017-07-27 15:03:12 +02:00
Eric Lippmann 30cc51a823 Optimize queries used for fetching the host group summaries
refs #1883
2017-07-27 11:43:13 +02:00
Eric Lippmann f5a9016dea Optimize queries for creating the host and service problem badges in the menu
We now use two fast count queries w/ an appropriate filter instead of fetching a whole bunch of unnecessary host and service counters.
2017-07-27 11:38:00 +02:00
Eric Lippmann a9f3f99049 Don't hide errors in the BackendAvailabilityNavigationItemRenderer
If an exception occurs when fetching the dataview, we will now log the exception and display a badge in state unknown.
2017-07-27 11:35:40 +02:00
Eric Lippmann 439d78a982 Don't hide errors in the MonitoringBadgeNavigationItemRenderer
If an exception occurs when fetching the dataview, we will now log the exception and display a badge in state unknown.
2017-07-27 11:31:10 +02:00
Eric Lippmann 28790d254b Remove caching form the MonitoringBadgeNavigationItemRenderer
Caching will be no longer necessary because we will replace the queries used to fetch the problem badges.
2017-07-27 11:29:57 +02:00
Eric Lippmann c0d359fbbd Fix base class of MonitoringBadgeNavigationItemRenderer
The MonitoringBadgeNavigationItemRenderer extended the SummaryNavigationItemRenderer before which does not make sense because they have nothing in common.
2017-07-27 09:33:44 +02:00
Alexander A. Klimov 6848ed6c1e Merge branch 'bugfix/can-t-progress-in-wizard-due-to-error-2842'
fixes #2842
2017-07-05 14:40:10 +02:00
Alexander A. Klimov 5460465e07 Fix null->setDecorators()
refs #2842
2017-07-05 14:34:17 +02:00
Eric Lippmann d208b48b72 Monitoring: Fix permission for the 'Process check result' action
fixes #2878
2017-07-04 17:24:57 +02:00
Markus Frosch 3d3b1cdf4f RestRequestTest: Fully qualify expected exception 2017-06-13 11:07:16 +02:00
Tobias von der Krone a7f5278aee Timeline: fix link to acknowledgements
refs #2850
2017-05-26 12:28:34 +02:00
Eric Lippmann a4a0f9f5e6 Allow to filter notifications by notification_reason
refs #2698
2017-05-04 14:38:00 +02:00
Eric Lippmann b900a01d02 Add sort by severity to the servicegroup links in the servicegroups overview 2017-05-04 14:37:43 +02:00
Eric Lippmann c36b2661b1 Add sort by severity to the hostgroup links in the hostgroups overview 2017-05-04 14:03:57 +02:00
Eric Lippmann 68842f00d8 Fix version 2017-05-03 15:12:07 +02:00
Eric Lippmann d6e54e8624 Fix pending services link in the tactical overview 2017-05-03 09:58:44 +02:00
Eric Lippmann 890c95a2ce Fix badge for handled critical services in the servicegroups overview 2017-05-03 09:43:30 +02:00
Eric Lippmann 85eeff6b09 Fix badge for handled critical services in the hostgroups overview
fixes #2806
2017-05-03 09:41:06 +02:00
Eric Lippmann 7a2d8eda8d Fix exception when the response from the Icinga 2 API has an empty result set
fixes #2805
2017-04-04 09:17:52 +02:00
Eric Lippmann f7a8cf8a6e Merge pull request #2721 from Icinga/feature/change-order-of-command-transports-2709
Feature/change order of command transports 2709
2017-03-28 11:10:17 +02:00
Eric Lippmann 30788ceed0 Merge pull request #2733 from Icinga/feature/set-focus-to-comment-field-for-comments-13535
Set focus to comment field for acknowledgements, downtimes and comments
2017-03-28 10:52:50 +02:00
Eric Lippmann efac7f44c9 Merge pull request #2748 from Icinga/bugfix/validate-icinga2-api-user-2674
Bugfix/validate icinga2 api user 2674
2017-03-28 10:25:12 +02:00
Eric Lippmann 302e559aab Merge pull request #2750 from Icinga/bugfix/click-on-host-in-service-grid-invalid-filter-2523
Servicegrid: assemble filters with the Filter class
2017-03-28 10:22:11 +02:00
Eric Lippmann 0fc45ea953 Merge pull request #2755 from Icinga/feature/keep-quick-actions-in-action-form-2675
Preserve quick actions in a command form view
2017-03-28 10:15:37 +02:00
Eric Lippmann 49239dc7db Display downtime type as text in the downtimes list 2017-03-28 10:12:07 +02:00
Eric Lippmann bbaf10aed2 Merge pull request #2759 from Icinga/feature/show-downtime-type-for-object-2693
Show every downtime's type in the detail view of a monitored object
2017-03-28 10:10:05 +02:00
Eric Lippmann e134b165f4 Merge pull request #2762 from tobiasvdk/bugfix/correct-hover-text-for-handled-services-2656
Correct hover text of the status bar
2017-03-28 10:08:03 +02:00
Eric Lippmann f749c19f37 Merge pull request #2771 from Icinga/feature/monitoring-detailviewextension-hook-2104
Feature/monitoring detailviewextension hook 2104
2017-03-28 09:46:28 +02:00
Alexander A. Klimov 389bf8f4ea Document DetailviewExtensionHook
refs #2104

Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-03-28 09:44:59 +02:00
Eric Lippmann a2dbc457fc Merge pull request #2774 from Icinga/bugfix/config-protected-vars-not-updated-2767
Bugfix/config protected vars not updated 2767
2017-03-28 09:38:37 +02:00
Alexander A. Klimov cd8d6e41dc AcknowledgeProblemCommandForm: respect configuration when creating elements
refs #2776

Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-03-28 09:21:42 +02:00
Alexander A. Klimov 9a79b194dd SecurityConfigForm: if protected_customvars is not set at all, display suggestion as placeholder
refs #2767
2017-02-23 12:52:47 +01:00