Commit Graph

2913 Commits

Author SHA1 Message Date
Johannes Meyer 09dfcca0bc Merge branch 'master' into bugfix/styled-history-views-6637 2014-08-20 11:39:03 +02:00
Johannes Meyer 4ceecf1146 Let comment view look more standardized and add limit control
refs #6637
2014-08-20 11:34:24 +02:00
Johannes Meyer 4eaf94cdf1 Show only acknowledgement and user comments by default 2014-08-20 11:33:22 +02:00
Thomas Gelf 538c6cf90b js/events: ignore button/submit clicks
In case you clicked a (submit) button in an action row this also
also triggered that row's click handler. As the event is going to be
stopped there, this leads to "unsubmittable forms". Fixed.

fixes #6963
2014-08-20 09:26:16 +02:00
Thomas Gelf 686152abf3 js/events: fix a small bug introduced right now
Links on non-multiselect action tables stopped working.

refs #6705
2014-08-19 19:04:29 +02:00
Thomas Gelf 736113c80c AuthenticationController: show friendlier hints...
...while not disclosing sensitive information. More to come once we
have our setup wizard.

fixes #6534
2014-08-19 18:55:58 +02:00
Alexander Klimov 071937910b Monitoring/Object: filter protected customvars
Move the responsibility from the viewscript to Monitoring/Object

refs #6641
2014-08-19 18:46:37 +02:00
Alexander Fuhr ba748cbc4a Refactor multiSelect and highlight
refs #6705
2014-08-19 18:33:28 +02:00
Alexander Klimov ea0248ecf4 Remove '{{SAVE_ICON}}', tiny design fixes
refs #6641
2014-08-19 17:54:22 +02:00
Alexander Fuhr 6fe47bf5b0 Fix rows highlighting after refresh
fixes #6705
2014-08-19 17:32:17 +02:00
Johannes Meyer 3573908071 Let downtime view look more list-like and fix downtime end calculation
refs #6637
2014-08-19 17:03:35 +02:00
Eric Lippmann 995355ec30 lib/Limiter: fix translate w/ sprintf 2014-08-19 16:29:11 +02:00
Eric Lippmann 8c02f140c3 doc: fix translate calls w/ sprintf 2014-08-19 16:22:54 +02:00
Alexander Klimov c6d4ab4c44 Vagrant/Puppet: add file '/etc/icingaweb/modules/monitoring/config.ini'
refs #6641
2014-08-19 15:04:43 +02:00
Thomas Gelf f49a34625e Url\Params: check for QUERY_STRING before using it
fixes #6957
2014-08-19 14:53:56 +02:00
Alexander Klimov 3e079efe2a SecurityForm: replace `customvars' with `protected_customvars'
refs #6641
2014-08-19 14:51:30 +02:00
Alexander Fuhr 7035099468 Fix the host_unhandled_service_count error
fixes #6833
2014-08-19 14:43:24 +02:00
Alexander Klimov 65473ac8ee Monitoring config: use SecurityForm
refs #6641
2014-08-19 14:04:00 +02:00
Alexander Klimov 1ba3954b95 Monitoring config: implement SecurityForm
refs #6641
2014-08-19 14:02:26 +02:00
Alexander Klimov 6b468b7f9b Monitoring_ConfigController: make writeConfiguration's parameter `file' non-required
refs #6641
2014-08-19 13:51:10 +02:00
Eric Lippmann d29eb21b5f Merge branch 'feature/display-documentation-4820'
fixes #6730
resolves #4820
resolves #6303
resolves #6484
resolves #6629
resolves #6633
resolves #6726
2014-08-19 13:41:21 +02:00
Eric Lippmann 1c74fd7028 Merge branch 'master' into feature/display-documentation-4820
Conflicts:
	modules/doc/library/Doc/DocParser.php
2014-08-19 13:39:48 +02:00
Eric Lippmann f52b3f7b8c doc/config: add menu.ini
refs #4820
2014-08-19 13:38:34 +02:00
Eric Lippmann 55b3a5384a doc: set page title
refs #4820
2014-08-19 13:38:18 +02:00
Eric Lippmann d35e0816c9 doc: use `sprintf' in exceptions
refs #4820
2014-08-19 13:20:46 +02:00
Alexander Fuhr 2f54ff4797 Fix the unrelated tabs
resolves #6934
2014-08-19 13:18:52 +02:00
Thomas Gelf cd825a4e6b tests/ScrollingStyle: adjust, pagination shortened
Pagination has been "shortened" some time ago to waste less space,
tests now fit the current implementation.

fixes #6594
fixes #6595
2014-08-19 12:45:42 +02:00
Thomas Gelf 3f65f3447d Web\UrlTest: test should use %20 instead of +
We MUST use rawurlencode everywhere to avoid potential conflicts with
URLs created on JS side.

refs #6604
2014-08-19 12:39:53 +02:00
Thomas Gelf db3ef8fbd0 ActionController: remove redirectToLogin default
The redirectOnLogin function now doesn't have any predefined default.
This also leads to the behaviour that "Logout" will not redirect you
anywhere on a new login while "forcibly being logged out" (e.g. by
logging out in another browser tab) will bring you back to where you
came from.
2014-08-19 12:28:24 +02:00
Thomas Gelf 7334716d15 favicon: add link type
The favicon link tag was missing a type attribute.
2014-08-19 12:25:14 +02:00
Thomas Gelf f40ada6c81 js/ui: check whether a link tag has a type
The new favicon didn't have such, resulting in JS error when reloading
CSS at runtime.
2014-08-19 12:23:51 +02:00
Thomas Gelf 9ce99bf280 js/helpers: add $.hasAttr
Need this for another fix and there is no such jQuery function. As this
seems to also be inconsistant across browsers I thought this would
definitively be worth a custom jQuery plugin.
2014-08-19 12:22:36 +02:00
Thomas Gelf 0d3fb9e7a5 LoginForm: explicitely remove renderLayout
Should prevent against rare race conditions.

refs #6584
2014-08-19 11:35:51 +02:00
Eric Lippmann 127e4f444f doc: show prev chapter, index and next chapter links
refs #4820
2014-08-19 11:30:56 +02:00
Alexander Klimov 0464099764 Monitoring: implement "Security" config tab 2014-08-19 11:19:30 +02:00
Alexander Fuhr c69af6c5d2 Move "modules" to "System" menu
resolves #6934
2014-08-19 11:14:18 +02:00
Thomas Gelf a38d71f17c Cli\Command: provide Config()
This makes it feel more like action controllers

fixes #6954
2014-08-19 10:27:26 +02:00
Eric Lippmann 5c52e447f5 doc: upper case first character of a documentation's title
refs #4820
2014-08-19 10:26:38 +02:00
Thomas Gelf f67d273bbd AuthenticationController: handle redirect parameter
This is a form field instead of a get parameter right now.

fixes #6584
2014-08-19 10:14:46 +02:00
Thomas Gelf 17b64f9dd5 layout: add favicon
fixes #6956
2014-08-19 10:13:19 +02:00
Thomas Gelf b5f336583f layout/body: protect containers from renderLayout
IMO this should be stripped before, this is just an additional
security measure.

refs #6935
2014-08-19 10:10:23 +02:00
Thomas Gelf a333c3e57b DocParser: remove explicit call to getRelativeUrl
As this URLs will get rendered we want them to be automatically casted
resulting in correct URLs with &

refs #6699
2014-08-19 10:07:46 +02:00
Thomas Gelf 5a6b5172e6 Menu: ignore special params when comparing URLs
This fixes issues on login with dashboard != dashboard?renderLayout
and similar

refs #6699
2014-08-19 10:06:14 +02:00
Thomas Gelf 512e7d516b js/loader: Handle __SELF__ in redirection URLs
That's one more step to smoothly handle #! URLs, especially when you
are not yet authenticated.

refs #6935
2014-08-19 10:00:29 +02:00
Thomas Gelf 9d4a4f49c9 ActionController: JS should redirect to __SELF__...
...once you lost your session. That's the only way to do this in a
smooth way. When the server get's an unauthenticated request for a
single container, redirecting to auth/login?redir=<that-container>
was not what you expect.

Together with JS handling __SELF__ in redirection URLs this will
play fine.

refs #6935
2014-08-19 09:57:24 +02:00
Eric Lippmann cb17590b71 doc: rename `nofollow' to `noFollow'
refs #4820
2014-08-19 09:57:22 +02:00
Thomas Gelf b9cc964e24 Url\Params: remove() should reindex on change
There was a small bug, fixed.

refs #6699
2014-08-19 09:49:53 +02:00
Thomas Gelf 344909dfcd Web\UrlParams: add() and set() should encode...
...while there is now a addEncoded function, mostly for internal use.

refs #6699
2014-08-19 09:45:58 +02:00
Eric Lippmann 289aed8420 doc: Use `chapterId' instead of `chapterTitle' in URLs
Manually given chapter IDs are meant to not change while a chapter's title could change.

refs #4820
2014-08-19 09:45:53 +02:00
Thomas Gelf 217595dc15 Web/Url: more intuitive separator usage
One might not expect to get a URL with params separated by &amp; while
this is the correct way of writing them to HTML attributes. So default
behaviour is right now that all functions return URL params separated
by &, but if you cast a URL (or it's params) to a string, &amp; will be
used.

Additionally there are toString functions allowing you to choose the
separator "manually".

refs #6699
2014-08-19 09:42:16 +02:00