Commit Graph

1625 Commits

Author SHA1 Message Date
Markus Frosch 2493cb8d63 Fix incorrect uses of translation around sprintf 2017-11-21 15:47:46 +01:00
Alexander A. Klimov c7ffb41b02 Implement togglable flyover
refs #3024
2017-11-21 14:05:12 +01:00
Alexander A. Klimov b000c1ae4a Implement auto-detaching DOM elements
refs #3039
2017-11-21 13:17:55 +01:00
Alexander A. Klimov 71fe12393d Persist X-Icinga-WindowId across auto-refreshes 2017-11-21 11:30:36 +01:00
Alexander A. Klimov bdcb6389d8 Add user preference for default number of items per page
refs #2859

Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-11-15 16:56:43 +01:00
Eric Lippmann 73a6750489 Make phpcs and PhpStorm happy w/ intentional switch, case fall-throughs
Unfortunately, PhpStorm does not regonise PSR2 fall-through comments.
On the other hand, phpcs does not support the @noinspection phpdoc comment (/**).
The fix is a mix of PSR2 comments and @noinspection tags in code comments.
2017-11-08 10:25:28 +01:00
Markus Frosch c3ef50978a style: Fix minor styleguide issues for PHPCS 2017-11-08 10:06:45 +01:00
Eric Lippmann 1f5f610b04 Add newlines to AnnouncementIniRepository.php 2017-11-07 14:48:46 +01:00
Eric Lippmann 5ec14bdb9d Remove inheritdoc tags in AnnouncementIniRepository.php 2017-11-07 12:50:30 +01:00
Johannes Meyer 2e1bac81ff Form: Create the form as part of method `setDefaults'
We don't care anymore about the BC in Zend version 1.12.7.
Hence we'll happily override setDefaults now. Yay!

refs #2998
2017-10-23 15:10:50 +02:00
Johannes Meyer d348d95e5e Revert "Form: Don't prevent disabled elements from getting overwritten.."
This reverts commit eb343009bb.

refs #2998
2017-10-23 15:10:37 +02:00
Alexander A. Klimov c22efa4519 UrlValidator: translate error message 2017-10-20 14:27:33 +02:00
Alexander A. Klimov f70fc6e98d Fix not working SomeType[string] in code docs
refs #2980
2017-09-29 12:08:14 +02:00
lippserd 46014558e6 Merge pull request #2946 from Icinga/bugfix/enhance-code-autocompletion-in-ides-2945
Enhance code autocompletion in IDEs
2017-09-08 15:45:25 +02:00
lippserd ade0744701 Merge pull request #2923 from Icinga/bugfix/is-not-a-valid-number
Form/Element/Number: The field should be valid when empty
2017-09-08 15:32:48 +02:00
Alexander A. Klimov 356e194612 Enhance code autocompletion in IDEs
refs #2945
2017-09-07 11:22:46 +02:00
Johannes Meyer beb3326631 StyleSheet/JavaScript: Also include Cache-Control when answering with a 304
Without Cache-Control, the browser may invalidate its cached file and we're
serving the file again on the next request.

refs #2917
2017-08-22 09:33:28 +02:00
Johannes Meyer 6702ccb2a7 FileCache: Ignore compression suffix when checking cache made of multiple files
refs #2917
2017-08-22 09:31:56 +02:00
Johannes Meyer 7b7bfb5a5d FileCache: Use the correct variable when checking a file's modification time
refs #2917
2017-08-22 08:38:13 +02:00
Markus Frosch 1d06d4e3c4 Form/Element/Number: The field should be valid when empty 2017-08-17 13:20:51 +02:00
Johannes Meyer eb343009bb Form: Don't prevent disabled elements from getting overwritten..
..if someone just utilizes populate() programatically.

refs #2509
2017-07-13 13:53:48 +02:00
Johannes Meyer ed5ba14df2 Form: Register form notifications as custom error messages for API requests
I'd have liked to fix how we transmit validation messages in such cases,
but for compatibilty reasons this has to suffice..
2017-07-13 13:00:24 +02:00
Johannes Meyer 96c96df636 Form: Don't transmit duplicate error messages
Zend_Form::getMessages() already returns custom error messages,
if there are any
2017-07-13 12:59:23 +02:00
Johannes Meyer b93dc06f5b ActionController: Let the repsonse itself set its headers
The only header that is now set by the ActionController is X-Icinga-Title,
all others are delegated to Icinga\Web\Response.
2017-07-13 12:56:03 +02:00
Johannes Meyer 0d52bb421f ActionController: Don't re-enable the layout when just setting XHR layout
In case someone doesn't want the layout, we should not force it, especially
not for XHR requests.
2017-07-12 16:54:52 +02:00
Eric Lippmann c0d82fa2cc Rephrase autosumbit tooltips
fixes #1507
2017-07-04 13:59:02 +02:00
Eric Lippmann 53091384cd Remove unused attributes from the date time picker element 2017-07-04 10:32:30 +02:00
Eric Lippmann a5990d4de8 Add date and time form elements 2017-07-03 15:03:26 +02:00
Johannes Meyer f6166b3ab6 ActionController: Allow to control which inline view script to use
This also affects that rerendering the layout does only have any effect
in case of XHR requests and is not overwritten anymore in this case.
Since this property was previously private, this should not break anything.
2017-06-28 11:14:01 +02:00
Johannes Meyer 22223acf1d Controllers: Make all private properties protected
Controllers are neither library stuff nor any vital part that need to be
protected from too adventurous module developers.
2017-06-28 09:51:28 +02:00
Johannes Meyer 8ee6e763a6 ActionController: Ensure to utilize the response to redirect and exit 2017-06-19 09:11:12 +02:00
Johannes Meyer df04c0f837 ActionController: Introduce constant DEFAULT_TITLE
Controllers are now allowed to fully customize the page title.
2017-06-09 11:13:37 +02:00
Johannes Meyer 8a890a4a82 ActionController: Allow controllers to customize the login route 2017-05-19 08:39:11 +02:00
Noah Hilverling b0221c5e13 Form: Preserve default if element has attribute 'disabled'
fixes #2509
2017-02-14 10:18:56 +01:00
Alexander A. Klimov 96f0a8c24e FilterEditor: escape values correctly
refs #12330
2017-02-09 17:50:49 +01:00
Johannes Meyer 181e2ef05c Swag: Fix swag (aka a whole bunch of code style issues..) 2017-01-27 14:48:59 +01:00
Michael Friedrich 08a82daea3 Update to icinga.com
refs #2687
2017-01-18 12:04:43 +01:00
Johannes Meyer 0716f87852 Update german translation 2016-12-13 13:57:27 +01:00
Eric Lippmann a78ac6dfab Hide announcements when they have expired
refs #11198
2016-12-13 11:04:56 +01:00
Eric Lippmann 626afbd5ec Merge branch 'bugfix/always-use-the-jquery-find-method-w/-node-context-10704'
fixes #10704
2016-12-08 17:15:02 +01:00
Eric Lippmann 0e69ce4544 Remove obsolete class dropdown from the close-container-control 2016-12-08 16:55:33 +01:00
Eric Lippmann fed0fc9608 Merge branch 'feature/fold-and-unfold-filter-by-click-12634'
resolves #12634
2016-12-08 14:30:55 +01:00
Eric Lippmann 5661dfa63c Harden import of vendor JavaSript libs
fixes #12328
2016-12-08 10:40:22 +01:00
Eric Lippmann b3bc1b6f81 Let the SummaryNavigationItemRenderer show the worst state
fixes #11185
2016-12-08 10:40:22 +01:00
Alexander A. Klimov 8c2b6ae665 Conform to coding guidelines
refs #12634
2016-12-07 18:33:26 +01:00
Alexander A. Klimov 69c8ed471b FilterEditor: add possibility to fold and unfold filter by click
refs #12634

Signed-off-by: Alexander A. Klimov <alexander.klimov@icinga.com>
2016-12-07 18:26:45 +01:00
Alexander A. Klimov 4205eb4cc9 nl2br helper: convert also raw newlines 2016-12-05 13:33:11 +01:00
Eric Lippmann e549c44247 Don't show exception when no announcement has been created
refs #11198
2016-11-29 16:32:30 +01:00
Eric Lippmann 39c7451664 Implement announcements
refs #11198
2016-11-29 15:24:34 +01:00
Eric Lippmann a9461ada54 Only render a menu item when it's not empty
A menu item is not empty when it either has children or a defined URL.
2016-11-28 14:56:17 +01:00
Eric Lippmann 3d6e804ff3 Merge branch 'feature/include-check-if-chosen-locale-is-available-11820'
resolves #11820
2016-11-17 11:23:49 +01:00
Eric Lippmann 95cbb61987 Add parameter markAsError to Form::warning() and Form::error()
refs #11820
2016-11-17 11:21:58 +01:00
Johannes Meyer e75bfbc197 Response: Add ;charset=UTF-8 to the default content type
resolves #13117
2016-11-15 13:30:16 +01:00
Johannes Meyer 0ef81a2e0b Response: Use a constant for the default content type
There is already setHeader() to adjust this dynamically.

refs #12161
2016-11-09 11:38:04 +01:00
Eric Lippmann 2b060d9bd4 Challenge API requests only if the controller requires auth
fixes #12580
2016-11-07 10:40:38 +01:00
Johannes Meyer d207dcbd03 Url: Throw ProgrammingError when trying to use Url::from* on the CLI
refs #7051
2016-10-28 11:47:45 +02:00
Noah Hilverling e4324605bc Merge branch 'bugfix/username-and-password-not-being-passed-in-navigation-item-urls-12133'
fixes #12133
2016-10-20 09:30:54 +02:00
Noah Hilverling 1ff3149636 Url: Add basePath to urlString if url is external or has a username
refs #12133
2016-10-19 09:41:03 +02:00
Noah Hilverling 2fd1a957a8 Url: Add basePath to baseUrl in method getBaseUrl
refs #12133
2016-10-19 09:40:08 +02:00
Noah Hilverling 13827c79e4 Url: Improve documentation of method setHost
refs #12133
2016-10-19 09:35:40 +02:00
Alexander A. Klimov 00880710ed Navigation::fromArray(): pass $name only as string to addItem()
fixes #12923
2016-10-18 18:06:51 +02:00
Noah Hilverling 3b6b0b8d4b Url: Build full urlString instead of path if username is set
refs #12133
2016-10-18 16:19:24 +02:00
Noah Hilverling a952a400ca Url: Add username and password to method getBaseUrl
refs #12133
2016-10-18 16:16:13 +02:00
Noah Hilverling 9fcc39e0ba Url: Add use of method setBasePath in method setBaseUrl
refs #12133
2016-10-18 16:15:14 +02:00
Noah Hilverling 08719b0522 Url: Do not try to set attributes in method fromPath if not needed
refs #12133
2016-10-18 16:13:37 +02:00
Noah Hilverling b4aca4737b Url: Cut of "/" and spaces at the end of basePath in setBasePath
refs #12133
2016-10-18 16:08:34 +02:00
Noah Hilverling 1c55351460 Url: Remove "/" in front of path if the url has a user parameter
refs #12133
2016-10-18 16:07:13 +02:00
Noah Hilverling dda7311226 Url: Improve documentation
refs #12133
2016-10-18 16:03:31 +02:00
Noah Hilverling 4e64c02078 Url: Remove attribute baseUrl
refs #12133
2016-10-18 16:01:23 +02:00
Noah Hilverling 4dd9c05882 Url: Return basePath in method getBaseUrl if url is internal
refs #12133
2016-10-18 12:57:02 +02:00
Noah Hilverling f6f90822d6 Url: Set basePath correctly in methods fromRequest and fromPath
refs #12133
2016-10-18 12:57:02 +02:00
Noah Hilverling 888ac98007 Response: Improve documentation for method getHeader
refs #12161
2016-10-18 11:07:24 +02:00
Noah Hilverling e5c736aab4 Response: Use method getHeader to check if Content-Type is set already
refs #12161
2016-10-18 10:13:58 +02:00
Noah Hilverling f95c789353 Response: Add method getHeader
refs #12161
2016-10-18 09:58:33 +02:00
Noah Hilverling c927c32442 Response: Only set header Content-Type in method prepare if not already set
refs #12161
2016-10-17 16:34:07 +02:00
Noah Hilverling 703561f874 JsonResponse: Set content type at initialization and not at sendHeaders
refs #12161
2016-10-17 16:33:51 +02:00
Noah Hilverling c3276d4341 Response: Remove empty line after method getContentType
refs #12161
2016-10-17 16:03:33 +02:00
Noah Hilverling 2439460371 Url: Fix incorrect line indentation in method getAbsoluteUrl
refs #12133
2016-10-17 10:16:03 +02:00
Noah Hilverling 4df9696ed9 StyleSheet: Modify send method to use setContentType of Response class
refs #12161
2016-10-17 08:29:51 +02:00
Noah Hilverling af5c578adf Response: Set header Content-Type for every response by default
refs #12161
2016-10-14 16:16:13 +02:00
Noah Hilverling 7cf6b860b5 Response: Add contentType attribute
refs #12161
2016-10-14 16:12:47 +02:00
Noah Hilverling 9439dfa8f3 Url: Fix path handling for internal urls
refs #12133
2016-10-14 15:05:34 +02:00
Noah Hilverling ef359aa686 Url: Improve documentation
refs #12133
2016-10-14 15:04:03 +02:00
Noah Hilverling 3e2f3c8467 Url: Add basePath attribute
refs #12133
2016-10-14 15:01:03 +02:00
Jennifer Mourek 0cd2d98f71 StyleSheet: Don't try to load the icinga default theme
refs #12660
2016-10-14 13:24:17 +02:00
Jennifer Mourek 8294471253 Revert "LessCompiler: Remove error message when switching to Icinga theme"
This reverts commit 2e24833d7c.
2016-10-14 09:39:24 +02:00
Jennifer Mourek 2e24833d7c LessCompiler: Remove error message when switching to Icinga theme
fixes #12660
2016-10-14 08:06:05 +02:00
Noah Hilverling f557b89aea Url: Add support for username and password
fixes #12133
2016-10-13 11:01:39 +02:00
Noah Hilverling c868789472 Url: Add alternative attributes for baseUrl
refs #12133
2016-10-13 11:01:10 +02:00
Alexander A. Klimov 8bc7d47a62 Merge branch 'bugfix/preserve-http-response-code-in-rest-error-responses-12583'
fixes #12583
2016-10-11 10:46:20 +02:00
Alexander A. Klimov bf3cfda209 Response: rename setMetaDataFrom() to copyMetaDataFrom()
refs #12583
2016-10-11 10:45:15 +02:00
Eric Lippmann c83659eff7 Sometimes you just herp the derp so hard it herpderps 2016-09-29 16:19:41 +02:00
Alexander A. Klimov 4d16656100 Preserve status code and headers in JSON responses
refs #12583
2016-09-27 13:26:20 +02:00
Johannes Meyer 5b875f3749 JsonResponse: Allow to output the "data" key in case of an error
As stated by the JSend specification this key is optional for error responses.
2016-09-21 15:58:59 +02:00
Alexander A. Klimov c8b1693fdc Fix Controller::assertPermission() allowing everything for unauthenticated requests
fixes #12108
2016-09-12 08:18:36 +02:00
Eric Lippmann ef7be98e0c Simplify InternalUrlValidator::isValid()
refs #11920
2016-09-09 15:22:24 +02:00
Eric Lippmann 1f980f92f2 Optimize imports in InternalUrlValidator
refs #11920
2016-09-09 15:21:06 +02:00
Alexander A. Klimov fa113e023b dashboard/new-dashlet: don't allow external URLs
refs #11920
2016-08-31 15:11:55 +02:00
Eric Lippmann 42991b0756 Ensure correct URL for the refresh container button
Shifted params no longer appear in the URL which is retrieved from the request object.
We now use Url::fromRequest() instead.
2016-07-13 10:24:30 +02:00
Johannes Meyer 4774db16ef View: Add methods setHelperFunction and dropHelperFunction 2016-07-11 09:08:43 +02:00