Commit Graph

226 Commits

Author SHA1 Message Date
Eric Lippmann a47db3497e Rename BaseCommand to Command
refs #4580
2013-09-16 14:44:59 +02:00
Eric Lippmann bf012fbd7e Remove CommandType interface
Moved BaseCommand from the monitoring module to the application's library.

refs #4580
2013-09-16 14:39:14 +02:00
Johannes Meyer 4964d84e78 Doc fixes
refs #4580
2013-09-16 13:14:29 +02:00
Johannes Meyer 8e60e2dcd9 Fix group and children handling of ScheduleDowntimeCommand
refs #4580
2013-09-16 13:14:29 +02:00
Johannes Meyer 7045148f93 Adjust submitpassivecheckresult command handling
refs #4580
2013-09-16 13:14:29 +02:00
Johannes Meyer fef8370d5f Adjust reschedulecheck command handling
refs #4580
2013-09-16 13:14:28 +02:00
Johannes Meyer e9dc895b37 Adjust delay notification handling
refs #4580
2013-09-16 13:14:28 +02:00
Johannes Meyer 36424b508b Adjust custom notification handling
refs #4580
2013-09-16 13:14:28 +02:00
Johannes Meyer 52079b2e73 Adjust schedule downtime handling
refs #4580
2013-09-16 13:14:28 +02:00
Johannes Meyer ba7f455643 Adjust schedule downtime handling (WIP)
refs #4580
2013-09-16 13:14:28 +02:00
Eric Lippmann a5908c9553 CS: Replace multiple empty lines with one
find application/ library/Icinga/ test/ modules/ -name *.php | xargs sed -i '/^$/N;/^\n$/D'
2013-09-04 18:36:10 +02:00
Eric Lippmann b5e93afd86 CS: Add newline at end of file
find application/ library/ test/ modules/ -name *.php | xargs sed -i '$a\'
2013-09-04 18:28:35 +02:00
Eric Lippmann 35fd9fd391 CS: Remove whitespaces at end of line
find application/ library/ test/ modules/ -name *.php | xargs sed -i 's/\s\+$//'
2013-09-04 18:27:16 +02:00
Johannes Meyer b74e264f01 Refactor comment command handling
- Refactored Comment class
- Dropped IComment interface
- Added AddCommentCommand class
- Updated CommentForm

refs #4580
2013-09-04 18:08:00 +02:00
Johannes Meyer 9a476f16f4 Re-refactor dispatch process of commands and acknowledgement handling
refs #4580
2013-09-04 18:08:00 +02:00
Jannis Moßhammer d27e34cef8 Codestyle and Test fixes for SortBox
refs #4601
2013-09-04 15:22:00 +02:00
Jannis Moßhammer 57e66c247a Add sort widget, change js path from module to app, small style fixes
refs #4601
2013-09-04 15:22:00 +02:00
Eric Lippmann 1b858cbdb4 Monitoring: Fix remaining usages of namespace Monitoring without Icinga\Module prefix
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann 3e4d1aa2fb Monitoring/Tests: Replace BaseFormTest with BaseTestCase
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann 74b9731df5 Remove auto class requirement from BaseTestCase::createForm()
The tests for the respective forms must require the form class.

refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann c86874d4ba Rename namespace Monitoring to Icingæ\Module\Monitoring
refs #4586
2013-09-04 11:21:11 +02:00
Jannis Moßhammer a0e63a1320 Fix error message and move validation in own DateTimeValidator
refs #4581
refs #4632
2013-09-04 11:06:36 +02:00
Johannes Meyer 4d040fd761 Adjust command forms and tests
Made those command forms using the DateTimePicker
element compatible with its new validation.

refs #4581
2013-09-04 11:06:36 +02:00
Johannes Meyer 14b56151aa Move configuration and preference handling to Form base class
Moved setConfiguration, setUserPreferences and getUserPreferences
to our Form base class due to some redundancies.

refs #4581
2013-09-04 11:06:24 +02:00
Johannes Meyer 23f0962da1 Adjust command forms and tests
Made those command forms using the DateTimePicker
element compatible with its new validation.

refs #4581
2013-09-03 09:27:02 +02:00
Johannes Meyer 368bd3c9c7 Refactor datetime validation
The DateTimePicker form element needs to know from now on,
how user input can be formatted when validating.

refs #4581
2013-09-03 09:27:02 +02:00
Johannes Meyer 1a003f8c8b Move configuration and preference handling to Form base class
Moved setConfiguration, setUserPreferences and getUserPreferences
to our Form base class due to some redundancies.

refs #4581
2013-09-03 09:27:02 +02:00
Johannes Meyer d8eccd3858 Skip regression tests if no configuration available
refs #4600
refs #4666
2013-09-02 17:24:43 +02:00
Johannes Meyer 01d7ea39aa Fix error when initiating multiple logins with casperjs
refs #4600
2013-09-02 17:24:43 +02:00
Johannes Meyer 24ecbb56d7 Fix incorrect checkresult type selection
When submitting a passive checkresult for hosts only their correct
result types are added to the selection.

refs #4600
2013-09-02 17:24:42 +02:00
Jannis Moßhammer 18d021d104 Fix logger not testing if it's disabled
refs #4595
2013-09-02 12:16:05 +02:00
Jannis Moßhammer c77f4ff1d9 Frontend tests: Run each *.js file seperately
refs #4622
2013-09-02 10:59:05 +02:00
Jannis Moßhammer c7375d44fb Add regressiontest for this bug
refs #4622
2013-09-02 10:59:05 +02:00
Jannis Moßhammer 4d9ecd2b3b Fix FormTest breaking after onchange modification
refs #4622
2013-09-02 10:59:05 +02:00
Jannis Moßhammer a8b3716662 Fix checkswag not testing jshint correctly
The path was wrong, now it is correct.

refs #4617
2013-09-02 10:59:05 +02:00
Marius Hein 446da85a88 UserBackend: Fix interface in test
refs #4593
2013-08-30 15:32:06 +02:00
Marius Hein 7c8252a983 Rename class Credentials to Credential
refs #4641
2013-08-30 12:50:57 +02:00
Marius Hein 83d20a6175 AuthManager: Fix tests
refs #4641
2013-08-30 12:50:28 +02:00
Johannes Meyer bf5849a769 Fix GeneralForm tests
refs #4609
2013-08-29 15:08:31 +02:00
Johannes Meyer 49eb9ea30f Fix some remaining issues
- Changed "this.fail" to "this.test.fail" in frontend regression test 4606
- Restored default timezone "Europe/Berlin"
- Added "var/log/*.log" to .gitignore
- Updated default.pp so that the user apache is part of the vagrant group

refs #4606
refs #4605
refs #4640
2013-08-29 13:21:33 +02:00
Jannis Moßhammer 2c97ab26a4 Code style, Form tests and bugfixes
This commit summarizes the bugfixes made in this branch. As the frontend the fixes required a lot of stuff to be fixed afterwards and #4602 was used as a larger example regression test, this affects a few tickets:

- (Bug 4491) Frontend tests will hang randomly: CasperJS now operates on the installed version, so this shouldn't happen anymore
- (Bug 4602) Configuration Interface - Authentication: Backends moved when pushing enter: The authentication interface is reworked and does not persist a state over pages
- (Bug 4605) /tmp should not be the default log path: Now it is the application relative var/log path
- (Bug 4606) Configuration: Show message that changes were saved successfully: Implemented and tested with casperjs
- (Bug 4641) Installation/Testing fix configure/make: This has been reworked
- (Bug 4642) Allow Application placeholder in config: This was required for implementimg 4605
- (Bug 4643) Application doesn't work with older Zend Versions: A fallback __call has been implemented for this

refs #4491
refs #4602
refs #4605
refs #4606
refs #4641
refs #4642
refs #4643
2013-08-29 11:48:33 +02:00
Jannis Moßhammer 0f36cfce62 Fix frontend tests, give forms names
refs #4491
2013-08-29 11:48:33 +02:00
Jannis Moßhammer 0b515e39ac Implement {app} placeholder and Icinga\Config::resolvePath()
refs #4642
2013-08-29 11:48:32 +02:00
Jannis Moßhammer 782291ec84 Change basepath for test and .htaccess
refs #4491
2013-08-29 11:48:32 +02:00
Jannis Moßhammer 86f76a61bc Change 'die' to 'fail' in frontend tests
refs #4491
2013-08-29 11:48:32 +02:00
Jannis Moßhammer 51d9f8eaa7 Remove original authenticationFormTest
refs #4606
2013-08-29 11:48:32 +02:00
Jannis Moßhammer d0ac97f335 Configure fixes, regression test for 4606
The configure routine still has to be improved, right now unused
authentication backends are commented out

refs #4491
refs #4606
refs #4640
2013-08-29 11:48:32 +02:00
Jannis Moßhammer c5dca9062b Frontend and configure.ac fixes
refs #4491
2013-08-29 11:47:10 +02:00
Jannis Moßhammer 81b41326cc Update frontend tests, add loginpage test
the runner now supports --host, --port, --path, --user and --pass for
icingaweb access and doesn't spawn any servers by itself.

Also a login test has been added. Other tests are removed as they don't
apply anymore.

refs #4491
2013-08-29 11:47:10 +02:00
Matthias Jentsch 874b163009 Fix comment padding and some coding-style issues in the test classes
refs #4615
2013-08-27 18:28:21 +02:00