tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
697 Commits 121 Branches 71 Tags 80 MiB
Commit Graph

255 Commits

Author SHA1 Message Date
Johannes Meyer 23f0962da1 Adjust command forms and tests 
Made those command forms using the DateTimePicker
element compatible with its new validation.

refs #4581
 2013-09-03 09:27:02 +02:00
Johannes Meyer 368bd3c9c7 Refactor datetime validation 
The DateTimePicker form element needs to know from now on,
how user input can be formatted when validating.

refs #4581
 2013-09-03 09:27:02 +02:00
Johannes Meyer 1a003f8c8b Move configuration and preference handling to Form base class 
Moved setConfiguration, setUserPreferences and getUserPreferences
to our Form base class due to some redundancies.

refs #4581
 2013-09-03 09:27:02 +02:00
Eric Lippmann b09b3676de Rename determineAuthenticationState to requiresLogin 
refs #4572
 2013-09-02 18:42:05 +02:00
Jannis Moßhammer 9f923b4940 Fix pagination and remove ModuleController, rename handlesAuth 
This commit introduces the following changes:
- Count is now performed after joins are added to the selection query,
  therefore returning the correct number
- MonitoringControllerTest now needn't to mock ModuleActionController (which is now removed)
- handlesAuthentication is now requiresAuthentication
- Redirection to login is now directly handled in the ActionController constructor,
  so we don't need to overwrite the preDispatch method

refs #4589
refs #4591
refs #4572
 2013-09-02 18:42:05 +02:00
Jannis Moßhammer aac1d69ed2 Fix count query ignoring joins 
Count queries were created before the required columns were added,
so they often returned more values than a resultset really offers

refs #4589
 2013-09-02 18:42:05 +02:00
Marius Hein b99b9a7ca8 ModuleManager: Throw module dir exceptions later 
This is important for bootstrap to detect configuration
errors.

refs #4604
 2013-09-02 12:52:51 +02:00
Marius Hein b6eb19ce6a Module enable/disable: Better error messages 
refs #4604
 2013-09-02 12:52:51 +02:00
Marius Hein 439fade88d Simplify SystemPermissionException 
refs #4606
 2013-09-02 12:52:51 +02:00
Jannis Moßhammer 18d021d104 Fix logger not testing if it's disabled 
refs #4595
 2013-09-02 12:16:05 +02:00
Jannis Moßhammer c5fde2324e Generalize form handling in Icinga\Web Form & Tests 
configForm.js is now form.js and applied on all forms,
the autosubmit is now a special attribute for input fields,
so the PHP code doesn't create JS snippets anymore

refs #4622
 2013-09-02 10:59:05 +02:00
Jannis Moßhammer 978b3519f6 Add configform js component (will be renamed later) 
refs #4622
 2013-09-02 10:59:05 +02:00
Marius Hein 446da85a88 UserBackend: Fix interface in test 
refs #4593
 2013-08-30 15:32:06 +02:00
Marius Hein e2e744a424 Fix authentication chain 
refs #4593
 2013-08-30 14:46:52 +02:00
Marius Hein 845f181001 CS: Fix UserBackend interface 
refs #4641
 2013-08-30 12:50:57 +02:00
Marius Hein bed759d597 CS: Fix session classes 
refs #4641
 2013-08-30 12:50:57 +02:00
Marius Hein 7765877318 CS: Fix LdapUserBackend 
refs #4641
 2013-08-30 12:50:57 +02:00
Marius Hein c77a48ff1f CS: Fix DbUserBackend 
refs #4641
 2013-08-30 12:50:57 +02:00
Marius Hein 7c8252a983 Rename class Credentials to Credential 
refs #4641
 2013-08-30 12:50:57 +02:00
Marius Hein 83d20a6175 AuthManager: Fix tests 
refs #4641
 2013-08-30 12:50:28 +02:00
Marius Hein dfb7238b81 AuthManager: Implement backend chain 
refs #4641
refs #4590
refs #4593
 2013-08-30 12:50:28 +02:00
Johannes Meyer 28bd27d904 Fix user preference access when not authenticated 
refs #4609
 2013-08-29 15:08:31 +02:00
Johannes Meyer f4272f482d Apply user defined timezone during bootstrap 
refs #4609
refs #4552
 2013-08-29 15:08:31 +02:00
Johannes Meyer a82abbe2f6 Fix misplaced/redundant imports 
refs #4648
 2013-08-29 14:45:02 +02:00
Marius Hein 7be7335bdd Preferences: Fix error messages and convenience configuration 
refs #4648
 2013-08-29 14:45:02 +02:00
Jannis Moßhammer 2c97ab26a4 Code style, Form tests and bugfixes 
This commit summarizes the bugfixes made in this branch. As the frontend the fixes required a lot of stuff to be fixed afterwards and #4602 was used as a larger example regression test, this affects a few tickets:

- (Bug 4491) Frontend tests will hang randomly: CasperJS now operates on the installed version, so this shouldn't happen anymore
- (Bug 4602) Configuration Interface - Authentication: Backends moved when pushing enter: The authentication interface is reworked and does not persist a state over pages
- (Bug 4605) /tmp should not be the default log path: Now it is the application relative var/log path
- (Bug 4606) Configuration: Show message that changes were saved successfully: Implemented and tested with casperjs
- (Bug 4641) Installation/Testing fix configure/make: This has been reworked
- (Bug 4642) Allow Application placeholder in config: This was required for implementimg 4605
- (Bug 4643) Application doesn't work with older Zend Versions: A fallback __call has been implemented for this

refs #4491
refs #4602
refs #4605
refs #4606
refs #4641
refs #4642
refs #4643
 2013-08-29 11:48:33 +02:00
Jannis Moßhammer ec359c76d8 Chmod after file creation 
This allows the www-group to edit logs and preferences

refs #4491
 2013-08-29 11:48:33 +02:00
Jannis Moßhammer 3d3fa45838 Fix ActionController compatibility with older Zend Versions 
refs #4643
 2013-08-29 11:48:33 +02:00
Jannis Moßhammer 0b515e39ac Implement {app} placeholder and Icinga\Config::resolvePath() 
refs #4642
 2013-08-29 11:48:32 +02:00
Jannis Moßhammer d0ac97f335 Configure fixes, regression test for 4606 
The configure routine still has to be improved, right now unused
authentication backends are commented out

refs #4491
refs #4606
refs #4640
 2013-08-29 11:48:32 +02:00
Jannis Moßhammer 4e41ce5cdc Add logic validation for database authentication backends 
refs #4546
 2013-08-29 11:48:32 +02:00
Jannis Moßhammer 17e6402aa9 Split up authentication form, logic connectivity check 
refs #4606
refs #4622
refs #4602
refs #4546
 2013-08-29 11:48:29 +02:00
Jannis Moßhammer 4527aaf57a Smaller fixes in phpdoc style 
refs #4566
 2013-08-28 14:42:31 +02:00
Johannes Meyer 7fab739efd Fix styles in Form.php 
refs #4566
 2013-08-28 09:08:37 +02:00
Johannes Meyer 13e4efa221 Make use of the helptext decorator if suitable 
Refactored some uses of the form element Note so that
each one is properly attached to its input element.

refs #4566
 2013-08-28 08:57:46 +02:00
Jannis Moßhammer e3f9d1b6bd Replace "\n" with PHP_EOL 
refs #4615
 2013-08-27 18:49:30 +02:00
Matthias Jentsch 874b163009 Fix comment padding and some coding-style issues in the test classes 
refs #4615
 2013-08-27 18:28:21 +02:00
Matthias Jentsch 5b58d5488b Add support for section reordering and formatting options to the PreservingIniWriter 
The PreservingIniWriter needs to be aware of the the order of the sections and
update the section declarations in the configuration file when the order has
changed. Therefore add functions to correctly reorder sections.

refs #4615
 2013-08-27 18:28:21 +02:00
Marius Hein c5bea04909 BaseTestCase: User response, CS and typo 
refs #4608
 2013-08-27 10:37:35 +02:00
Marius Hein dc71885eac Fix icinga application forms using BaseTestCase now 
refs #4608
 2013-08-26 13:25:20 +02:00
Marius Hein 1130376ad6 BaseTest: Create class and tests 
refs #4608
 2013-08-26 11:15:27 +02:00
Marius Hein 0c69dbf482 CS: Fix for DbAdapter, Auth/Manager and Preferences/DbStore 
refs #4596
 2013-08-26 11:09:37 +02:00
Matthias Jentsch 49cf62a9dc Fix database related bugs 
Fix coding standards in database schemes. Use DbAdapterFactory in all unit
tests instead of creating own adapters. Fix DbUserBackend and DbStore to use
FETCH_OBJ, instead of FETCH_ASSOC, to handle it consistently in the whole
application. Remove unnecessary table columns from the "account" scheme.

refs #4577
refs #4578
refs #4596
refs #4599
refs #4627
 2013-08-26 11:09:37 +02:00
Marius Hein afc302d45c Bootstrap: Safe application start 
Log exceptions and inform user if something goes wrong.

refs #4625
refs #4592
 2013-08-23 17:28:13 +02:00
Marius Hein 2debc7826b Deactivate group backend initializing 
refs #4624
 2013-08-23 17:28:12 +02:00
Marius Hein c65f9d51ee Fix static preferences path overwriting configuration path 
refs #4598
 2013-08-23 17:28:12 +02:00
Jannis Moßhammer 895976550c Fix templates, capitalization and icons in php files 
refs #4550
refs #4584
 2013-08-23 10:28:48 +02:00
Jannis Moßhammer 015a914aab Fix template code style, use Bootstrap 3, remove icons 
- Icons have now the {{XY_ICON}} format
- custom classes are removed
- A few typos are fixed
- Capitalization

refs #4550
refs #4621
refs #4584
 2013-08-23 10:28:48 +02:00
Jannis Moßhammer dc2aad75d1 Modify application templates for proper bootstrap usage 
refs #4550
 2013-08-23 10:27:16 +02:00
Eric Lippmann d813ca62c5 Db: Set MySQL server SQL modes to behave closer to ANSI SQL 
Was already implemented but someone dropped it accidentally
 2013-08-21 14:40:37 +02:00