Commit Graph

199 Commits

Author SHA1 Message Date
Matthias Jentsch cbb9ef10a2 Remove single selections correctly when going back in the history 2015-07-28 15:21:14 +02:00
Matthias Jentsch f2d253f508 Assure that rows are refreshed correctly on reload
Assure that all links are initialized when the selection is applied after a request. Move action table code into the actiontable behavior.

refs #8623
2015-07-27 10:34:17 +02:00
Johannes Meyer 570dada0d8 js: Manually submit the form if it's being automatically submitted...
...in case we're submitting a multipart/form-data form using the iframe
fallback. The form wouldn't be submitted otherwise.

refs #8758
2015-07-21 14:15:12 +02:00
Johannes Meyer 37b87eb284 js: Add fallback in case XHR file uploads are not possible
refs #8758
2015-07-20 10:52:28 +02:00
Johannes Meyer 95bcb95cb5 events.js: Prevent default form submission as late as possible 2015-07-20 10:13:48 +02:00
Johannes Meyer 6d4d99aa62 js: Use window.FormData instead of just FormData
refs #8758
2015-07-15 15:49:34 +02:00
Johannes Meyer c1d9cde312 js: Properly submit multipart/form-data
This is not IE <10 compatible. Fix follows. ;-)

refs #8758
2015-07-15 15:25:40 +02:00
Matthias Jentsch aecfb2eb97 Merge branch 'bugfix/multiselection-not-visible-9054'
fixes #9054
fixes #9346
2015-06-30 14:08:19 +02:00
Matthias Jentsch 975a834bd4 Remove unused code and clean up 2015-06-30 12:28:41 +02:00
Matthias Jentsch 96677fb6c7 Fix selection when clicking on regular links
refs #9054
refs #9346
2015-06-29 18:51:32 +02:00
Matthias Jentsch aec59d9941 Use current filter to highlight active rows instead of storing active rows in JS
Clean up selection code and move it into separate behavior and parse filter query to fetch selectable rows.

refs #9054
refs #9346
2015-06-29 18:48:42 +02:00
Johannes Meyer ebe144c16a Form: Do not encode actions twice 2015-06-24 16:15:45 +02:00
Thomas Gelf cd70c27519 Merge remote-tracking branch 'origin/master' into feature/refine-ui-for-rc1-9361 2015-06-18 15:18:42 +02:00
Thomas Gelf 55dd3747f7 notifications: remove on click
This allows one to get rid of them faster in case access to the
underlying content is needed
2015-06-18 13:29:47 +02:00
Thomas Gelf 09c0ebcacd list/services: flip host/service for readability
Re-allow table.action to manually choose row action link if it should not
be the first one. This existed once but got lost.
2015-06-16 02:36:53 +02:00
Eric Lippmann 1bfbce98ac Disable all form controls on submit to prevent resubmission
fixes #7151
2015-05-28 13:17:00 +02:00
Matthias Jentsch 54207d3427 Revert "Abort pending AJAX requests before page unload"
This reverts commit 94bdb8b4b0. After the patch, Firefox shows an error message on each reload for an unknown reason.

refs #7759
2015-05-19 17:06:22 +02:00
Matthias Jentsch 94bdb8b4b0 Abort pending AJAX requests before page unload
Abort all pending requests before the page unload, to avoid confusing error messages during page reloads. Avoid rendering the site unusable in cases where the site is still being used after the beforeunload event.

fixes #7759
2015-05-19 16:35:44 +02:00
Matthias Jentsch 7c8ff44fd1 Fix comment and downtime list inline forms
refs #8903
refs #8902
2015-05-07 10:59:37 +02:00
Thomas Gelf ae7d679a6a Revert "Do not destroy all global on mailto link clicks"
This reverts commit 16b9c73436.

As I already mentioned, this re-introduces the problem that you'll
get ugly "lost connection to web server" notifications. Easiest way
to reproduce this: click your browsers reload button while a request
is pending - or just click reload a couple of times while showing the
dashboard.

refs #7759
2015-04-16 21:01:08 +02:00
Matthias Jentsch 1f0940c8e8 Remove all selections closing the detail area
fixes #8781
2015-04-13 17:55:41 +02:00
Matthias Jentsch f4c0b35eff Remove unused code 2015-04-13 17:55:41 +02:00
Matthias Jentsch 16b9c73436 Do not destroy all global on mailto link clicks
Only call the cleanup code on the unload event, beforeunload is only for asking for confirmation.

fixes #7759
2015-04-13 17:55:41 +02:00
Eric Lippmann 1bd2e7cb84 Submit forms to the container's target URL if the form's action is not set
refs #8605
2015-03-13 04:02:42 +01:00
Eric Lippmann 8b7250bfa6 JS: Focus the element referenced by the anchor on anchor navigation ...
... instead of looking for any heading.
2015-03-12 16:08:47 +01:00
Eric Lippmann 77b99552a4 Add JSDoc to Icinga.Events.prototype.handleAnchor() 2015-03-12 16:08:47 +01:00
Eric Lippmann 90971f2caf Revert "Merge branch 'feature/organize-headings-7976'"
This reverts commit ea2a17a76c, reversing
changes made to e72de8dfe1.

refs #7976
fixes #8647
2015-03-12 16:08:34 +01:00
Thomas Gelf 5270acd645 events.js: correctly detect form target container
This is for forms with no submit button.

fixes #8710
2015-03-12 11:30:21 +01:00
Johannes Meyer cddcde9494 Setup: Automatically check the respective admin account type selection
resolves #8603
2015-03-06 15:41:25 +01:00
Johannes Meyer 4351603243 Fix that editing an auth backend does not open the next column 2015-02-26 14:48:37 +01:00
Alexander Fuhr 16200417eb Add spinner active indicator for form submit buttons
refs #7968
2015-02-25 14:15:32 +01:00
Alexander Fuhr 4505718ecc Move spinner indicator functionality to linkClicked method
refs #7968
2015-02-25 12:10:08 +01:00
Alexander Fuhr aa5c52dfdd Implement content refresh control next to dropdown tab
refs #7968
2015-02-23 17:02:44 +01:00
Marius Hein 44019f4e67 Events: Quick fix for access the focusable element
refs #7976
2015-02-23 16:06:21 +01:00
Marius Hein d3c79dae32 Merge branch 'master' into feature/organize-headings-7976 2015-02-17 15:21:29 +01:00
Johannes Meyer 0c0478688e js: Fix that buttons with any DOM descendants are not ignored by linkClicked
fixes #8380
2015-02-16 15:07:31 +01:00
Marius Hein cd11cf3469 Fix close button: Test the anchor if it belongs to us 2015-02-13 11:47:16 +01:00
Marius Hein 7ca2e1d282 Fix close button: Test the anchor if it belongs to us 2015-02-13 11:45:20 +01:00
Marius Hein bcc03f8160 Focus: Set the focus to the next usable element
Fix copy and paste error and find h1 first.

refs #7976
2015-02-13 11:39:28 +01:00
Eric Lippmann 9bf8488f68 js: Remove out-commented function hrefIsHashtag from events.js 2015-02-13 09:59:34 +01:00
Marius Hein f586714f02 Skip Links: Select a more useful object
Skip links can select a container and find a usable element inside. Adapt
project jquery variable style.

refs #7976
2015-02-12 16:34:50 +01:00
Marius Hein 53818f50c6 Skip Links: Add anchor handlint to events
refs #7933
2015-02-12 13:13:52 +01:00
Johannes Meyer 423025b3fe javascript: Do not bind the button click event
Catching form submit events is sufficient as catching the button click
event is not an option due to circumventing the browser's native form
validation logic otherwise.

refs #8349
2015-02-05 13:21:03 +01:00
Matthias Jentsch b56eb7b669 Fix keyboard navigation
Store current focus position before reload and apply it after rendering.

fixes #8350
2015-02-04 18:01:06 +01:00
Eric Lippmann 6bae2e0a53 Note that our license is GPL v2 or any later version in our license header instead of pointing to the license's URL 2015-02-04 10:52:27 +01:00
Eric Lippmann 5b4fab0750 Add license header
This time without syntax errors hopefully :)
2015-02-03 16:27:59 +01:00
Eric Lippmann 5fa2e3cfdc Revert "Add license header"
This reverts commit 338d067aba.
2015-02-03 16:16:26 +01:00
Eric Lippmann 338d067aba Add license header
fixes #7788
2015-02-03 15:51:04 +01:00
Thomas Gelf f6fc592b91 events.js: reduce logging noise
Form submission by pressing return is not an error, and debug level
should suffice for the other button-related notices too.
2015-02-02 21:56:14 +01:00
Johannes Meyer a5fe9a1fe1 Revert "Introduce link target "_right" to keep a column with tabs rightmost"
This reverts commit 618ab4f4b9.
2015-02-02 16:34:29 +01:00
Johannes Meyer 618ab4f4b9 Introduce link target "_right" to keep a column with tabs rightmost
I'd have liked to get it to work that in case the tab control is not in the
rightmost column a "go back" in the history is being simulated causing
the preceding leftmost column(s) to be restored and the rightmost one
set to the one containing the tab control. But the history api does not
seem to support any read operations except for the current state..

refs #6436
2015-01-28 14:21:06 +01:00
Marius Hein b0382da5fe JS/submitForm: Choosing the right submit button in FF
refs #7751
2014-11-20 11:07:10 +01:00
Alexander Fuhr 46df428e28 Add selection count hint in grids with help for hosts and services
refs #7654
2014-11-13 12:50:39 +01:00
Johannes Meyer f7d168c80f Fix that FireFox < v33 is unable to find the button that got the focus 2014-11-07 14:22:03 +01:00
Johannes Meyer 62544111ff Fix that when pushing ENTER in a form with just <buttons> no button is sent 2014-10-09 13:42:15 +02:00
Matthias Jentsch ed91e119d2 Add close-button to all containers
refs #6216
2014-10-01 14:51:51 +02:00
Matthias Jentsch ef2f332869 Do not refresh a container when form input was changed or a form element is focused
Listen for changes in form elements and abort all reloads that contain a form with
at least one changed form element. Do not refresh containers that contain a focused form
element, except of elements with autofocus, to preserve form elements with a dropdown.
Only focus autofocus elements when there is currently no other selection.

refs #7146
refs #5537
fixes #7162
2014-09-19 15:48:44 +02:00
Matthias Jentsch ad53f7ad3d Use EventEmitter class as a way to delegate events from behaviors to the dom 2014-09-12 09:09:21 +02:00
Matthias Jentsch 7aadad913e Do not follow empty menu links 2014-09-10 17:02:39 +02:00
Matthias Jentsch cb9c9c78d8 Move navigation events into behavior 2014-09-10 17:02:39 +02:00
Matthias Jentsch f58da73e2d Move javascript behaviors into separate classes 2014-09-10 17:02:39 +02:00
Matthias Jentsch 5d2e849491 Apply behaviors correctly on startup 2014-09-10 17:02:39 +02:00
Matthias Jentsch d99d50b3c4 Add stub for javascript behaviors 2014-09-10 17:02:38 +02:00
Matthias Jentsch da7e599363 Only remove active elements in navigation on reload 2014-09-09 16:32:15 +02:00
Matthias Jentsch b7c207a9cb Do not drop preselection in the navigation on reload 2014-09-09 15:32:07 +02:00
Matthias Jentsch 157818c8e7 Fix navigation reload
Activate the correct menu item with JavaScript after relaod and don't
 render it on server-side on XHR requests.
2014-09-09 13:57:48 +02:00
Matthias Jentsch 56b779af4d Clean up mousemove handler and remove unused tooltip code 2014-09-08 16:46:47 +02:00
Matthias Jentsch 545db945da Auto refresh menu
Put the navigation into a container and reload it once every 15 seconds from a distinct menu action. Include the current
path into an URL param to still be able to mark the current menu item as active.

fixes #6955
2014-09-08 15:21:14 +02:00
Thomas Gelf 0b53f30b08 js/events: ignore mailto links
fixes #7079
2014-09-05 15:05:22 +02:00
Matthias Jentsch eeed030bb5 Do not use an invalid HTML attributes for rich titles 2014-09-04 13:32:30 +02:00
Matthias Jentsch e5be8d47ef Fix SVG bound calculation for tooltips in Firefox 2014-09-04 09:53:57 +02:00
Matthias Jentsch 868e8b25b6 Fix left over tooltips after reloads with layout shift 2014-09-04 09:32:15 +02:00
Matthias Jentsch 510e38335e Remove useless tooltip from host and service list
remove titles from time spans on all td.state, since the formatted time
is already displayed in the inner div
2014-09-03 17:43:43 +02:00
Matthias Jentsch b10b1ea034 Add jQuery tooltips 2014-09-03 15:53:56 +02:00
Thomas Gelf 538c6cf90b js/events: ignore button/submit clicks
In case you clicked a (submit) button in an action row this also
also triggered that row's click handler. As the event is going to be
stopped there, this leads to "unsubmittable forms". Fixed.

fixes #6963
2014-08-20 09:26:16 +02:00
Thomas Gelf 686152abf3 js/events: fix a small bug introduced right now
Links on non-multiselect action tables stopped working.

refs #6705
2014-08-19 19:04:29 +02:00
Alexander Fuhr ba748cbc4a Refactor multiSelect and highlight
refs #6705
2014-08-19 18:33:28 +02:00
Alexander Fuhr 6fe47bf5b0 Fix rows highlighting after refresh
fixes #6705
2014-08-19 17:32:17 +02:00
Johannes Meyer 7958a81975 Fix that a form's submit button is not being sent when the method is GET
fixes #6890
2014-08-12 12:49:03 +02:00
Johannes Meyer 3105c2059e Remove license headers from all files
refs #6309
2014-07-15 13:43:52 +02:00
Thomas Gelf 1385667edc js/responsiveness: respect singlecolumn layouts
Target _next now depends on current layout
2014-06-24 07:46:37 +02:00
Thomas Gelf ef0963af38 js/events: ignore javascript: in links 2014-06-24 06:35:52 +02:00
Thomas Gelf c0c7a815f8 Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018 2014-06-20 19:18:38 +02:00
Thomas Gelf 916c9c027e forms: fix isSubmitted
Implementation made wrong assumptions. A form is submitted when the
submit button has been pressed. It's value is then filled, it also
is when you're just pressing "RETURN". RETURN triggers the FIRST
submit button in a form. This way we are also able to find out which
form button has been pressed.

Current implementation is still poor, however isSubmitted works as
expected right now - and so does autosubmission.

fixes #5967
2014-06-20 14:32:22 +02:00
Thomas Gelf 76219b025b js/events: multiple multiselect fixes
* Removed obsolete checks (event is only triggered for multiselect tables)
* allows deselecting last row, closing "detail view"
* fix bug when unselecting one of two rows, it used to keep the wrong one
* play nice with other involved non-row-level links
2014-06-20 13:43:18 +02:00
Matthias Jentsch aae49ce0c0 Do not show tooltips for piechart areas that indicate empty or free areas
refs #6117
2014-06-18 17:38:25 +02:00
Matthias Jentsch 6555d347a7 Escape InlinePie html and adjust chart size
fixes #6117
2014-06-18 14:43:14 +02:00
Matthias Jentsch be0c5d4b23 Add more meaningful tooltip labels to InlinePies
Show current title, a well-formated value and a label for each area in a
tooltip and add the ability to customize tooltip labels of InlinePies

refs #6117
2014-06-18 14:43:14 +02:00
Marius Hein 06296f29d8 UI/Sparklines: Change sparkline code to serverside only
fixes #6124
2014-06-06 16:35:33 +02:00
Thomas Gelf 2d228ce83d JS for IE8: even more JS fixes
refs #6417
2014-06-05 18:11:19 +00:00
Thomas Gelf ca6b373be2 JS: fix multiselect burning resources
Especially on browsers with slow JS like IE8 iterating again and again
over all rows used to harm response rendering. Immagine a dasboard with
a total of a few hundred rows refreshing every 10 seconds while taking
3 secs to render one dashlet... it's far better right now.

refs #6417
2014-06-05 15:16:03 +00:00
Thomas Gelf 6d321d67cd JS/CSS: Get IE8 working
Just a bunch of JS and CSS improvements / fixes

refs #6417
2014-06-05 15:03:59 +00:00
Thomas Gelf ce220c5ea7 sidebar/menu: menu should be scrollable
This allows us to scroll menus not fitting into available screen height.
Plays nice with menu hovering, however once you scroll down your menu
you'll temporarily disable the hover-menu-feature.

fixes #6283
2014-05-26 08:18:47 +00:00
Thomas Gelf f32eab627a js/forms: treat buttons like input-buttons
This fixes a few autosubmission-detection woes.
2014-05-20 23:55:18 +00:00
Thomas Gelf 194914917a js/events: initialize only existing search field
Formlerly JS failed on layouts without menu, should be fixed now.
2014-05-20 21:55:32 +00:00
Thomas Gelf de0b97b4ca js/events: improve search field change detection
This used to be nasty since "search" is the field with the initial
focus. Right now we detect "real" changes, this might be implemented
in a more generic way for all autocompleting fields later on.
2014-05-20 14:07:19 +00:00
Thomas Gelf 67144407e6 js/events: do temporarily not respect tab focus
This has been added for keyboard navigation but caused some trouble.
Postponed for now.
2014-05-20 14:05:30 +00:00
Thomas Gelf 03e8ba88e4 Restore click behaviour for table links and rows
Multiselect handlers should influence only multiselect tables. Still
unhappy with current behaviour, but links should work fine right now.

refs #6162
2014-05-09 14:53:34 +00:00
Thomas Gelf 19220a5a44 Initial "click" handling for dropdown tabs
Still uncomplete, there are a number of edge cases that need to be
handled. Keyboard navigation is one of them, hover/click distinction
is another one.

refs #6167
2014-05-09 11:49:15 +00:00
Thomas Gelf 23679c0078 Completely ignore remote links
There are no issues with "returning true" so this should be the
preferred way. No need to fall back on "window.open" here.

fixes #6159
2014-05-09 11:41:18 +00:00