59dd80ed32
ActionController: benchmark should measure rendering
...
We have been cheating a little bit, now the measurement should be more
precise.
2014-06-25 20:37:17 +02:00
d49f30ff77
Improve InlinePie performance
...
Use str_replace instead of preg_replace
2014-06-25 15:24:53 +02:00
7b19bd1d99
Improve interface of InlinePie
...
Method setLabel can also accept a simple string and title is mandatory in constructor
2014-06-25 15:21:12 +02:00
8839166090
Add number format 'none' to InlinePie
2014-06-25 14:53:39 +02:00
35a5431512
Revert "Refractor InlinePie and Perfdata helper"
...
This reverts commit f003c38abd
2014-06-25 14:29:17 +02:00
f003c38abd
Refractor InlinePie and Perfdata helper
...
Refractor InlinePie methods for better usability, fix several coding guideline
issues and fix some typos
2014-06-25 12:41:17 +02:00
4591297e56
SortBox: use POST instead of GET
...
This avoids trouble with complex filter URLs
fixes #6556
2014-06-25 11:00:10 +02:00
1dcf44b9cd
FilterEditor: fix buggy dropdown boxes
...
There were some issues with option names. Also cleaned up HTML a
little bit and added autosubmission.
2014-06-25 10:37:06 +02:00
b40d0f6a1e
FilterWidget: POST instead of GET
...
Might have been a JS issue, but instead of messing with the URL just
POSTing is easier here - and works. Filters from the search box are
now added flawlessly to the filter tree.
2014-06-25 10:34:09 +02:00
2746b5ff9f
ConfigController: switch over to new config tabs
...
Module configuration now takes place in module detail view and does no
longer pollute our config tabs. Modules are now able to provide a bunch
of own config tabs, we don't really care what they use them for.
2014-06-24 21:31:59 +02:00
b38bcfc19b
Widget\FilterEditor: correct expression output
...
Filter expressions should be filled into form fields exactly as we
expect them at parse time.
fixes #6568
2014-06-24 21:00:01 +02:00
47b893e1ea
Widget\FilterEditor: handle custom vars
...
There was an issue with custom vars as they made only partially part
of the column dropdown. Sorted columns and tried to beautify column
names.
fixes #6569
2014-06-24 20:57:41 +02:00
3f9f4bb9e1
ModuleActionController: module object shortcut
...
This helps modules with the need to know more about themselves. No
more App -> Module Manager -> Module voodoo.
2014-06-24 20:54:39 +02:00
b7b99cfd67
Widget\AlertMessageBox: fix broken widget
...
This widget is pretty useless as the error view script can to it's
job. Interestingly nobody missed it, even the render() call was wrong.
I guess we will remove this soon, but for now it's fixed. Looks ugly,
but works.
2014-06-24 20:30:41 +02:00
ba9a633b73
Web\Form: relax form submission check
...
We have to live with some badly designed forms right now. Some have
submit buttons but don't know about, others don't have such but link
to foreign controllers fiddling with the form and adding different
button AFTER the form got submitted - it's a mess.
Relaxing the submission check to "just check whether btn_submit has
a value" fixes most of this. However I do not consider this being a
solution for the long run.
fixes #6423
fixes #5967
refs #6540
2014-06-23 13:31:34 +02:00
ea44de8698
ActionController/translate: detect domain only once
2014-06-22 20:09:23 +02:00
23ed744747
params/_render: replace it everywhere
...
Cleaning up controllers and JS, using headers only and respecting
history.
2014-06-22 20:07:44 +02:00
61600ae2d4
ModuleActionController: fix typo
2014-06-22 19:39:54 +02:00
997587d729
Chart\InlinePie: remove ugly default border
2014-06-22 16:38:12 +02:00
216f0f3f55
isIframe: clean up, load less html and js
...
We use isIframe only when we have no JS, therefore it makes no sense
to load JS files in an iFrame. Also removed sidebar.
2014-06-22 16:30:06 +02:00
3b84078b2f
Params/_render: get rid of it, start with iframe
2014-06-22 16:18:23 +02:00
bb23d0636c
ModuleActionController: use isXhr()
2014-06-22 16:04:55 +02:00
3774eb6889
ActionController: add isXhr() method
...
Makes things easier as we use this a lot
2014-06-22 15:36:41 +02:00
331d756a2a
ActionController: isolate ignoreXhrBody
...
This function is only a workaround for broken forms not redirecting
after submission. Will hopefully be removed soon.
2014-06-22 15:33:38 +02:00
b4f8ef74fa
ActionController: remove obsolete code
2014-06-22 15:20:55 +02:00
631603aba3
ActionController: create postDispatchXhr
...
Moved XHR-specific stuff to a dedicated post-dispatch function
2014-06-22 15:17:28 +02:00
cf995b366b
ActionController: cleanup postDispatch
...
Make XHR handling more readable, move module-related stuff to the
module controller
2014-06-22 15:11:08 +02:00
de19745eb2
ActionController: move moduleInit to Module controller
2014-06-22 13:54:02 +02:00
2cd25b7376
ActionController: if/else should be easy to read
2014-06-22 13:52:40 +02:00
b7fc0b67a8
Web/controllers: use own Request/Response objects
...
* introduces Icinga\Web\Response
* uses ModuleActionController where necessary
* no module translationDomain voodoo in base ActionController
2014-06-22 13:49:21 +02:00
ef5e1b54fd
Web\Window: fix it's usage, add helper function
...
Improved window handling, fixed controllers using it.
2014-06-22 13:21:21 +02:00
b350e3640d
Web\Window: move window handle to dedicated class
...
One more step in cleaning up our ActionController
2014-06-22 13:01:48 +02:00
d69a6d1640
ActionController: remove getRequestUrl
...
Thie removes complexity and makes redirection to login less error-
prone.
2014-06-22 12:23:34 +02:00
9608d8254d
ActionController: remove addModuleContainer
...
This method was obsolete
2014-06-22 12:09:07 +02:00
4980b700da
ActionController: __construct() as first function
2014-06-22 12:07:50 +02:00
a4955df1a9
controller->Auth(): one more lazy-loading helper
...
Not sure about the capital A, but doesn't look so bad - and similar
to Config().
2014-06-22 12:06:09 +02:00
373e1c5ecb
Web\Controller: re-introduce ModuleActionController
...
This will help getting rid of a couple of if/else constructs
2014-06-22 12:03:37 +02:00
469eb3dc98
Web\Url: remove forgotten "debug" line
2014-06-22 11:59:24 +02:00
b3cdeee35d
monitoring/timeline: should benefit from new filter
...
Different changes have been applied:
* Allow integer unix timestamps as parameters for timestamp columns
* Remove alias-rewriting from Url class
* Remove all traces of raw_timestamp
* Use new filters
2014-06-21 03:09:40 +02:00
216c2ca770
Autorefresh: should work also on initial page load
...
fixes #6296
2014-06-21 01:54:32 +02:00
c0c7a815f8
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
2014-06-20 19:18:38 +02:00
3e24a2cbe4
Paginator/SlidingWithBorder: use less space
...
Showing less items right now. It would be great if we could steer
this by parameter. IMO we should also think about dropping ZF
pagination and use a custom tiny widget.
2014-06-20 17:31:32 +02:00
afd6b11b7b
Web\Url: add set/mergeValues support
2014-06-20 15:50:55 +02:00
2cf79fe9a7
Widget\SortBox: hardcode some styles
...
This is a quickfix, should be moved to CSS once we know how our HTML
elements will definitively look like
2014-06-20 14:55:43 +02:00
916c9c027e
forms: fix isSubmitted
...
Implementation made wrong assumptions. A form is submitted when the
submit button has been pressed. It's value is then filled, it also
is when you're just pressing "RETURN". RETURN triggers the FIRST
submit button in a form. This way we are also able to find out which
form button has been pressed.
Current implementation is still poor, however isSubmitted works as
expected right now - and so does autosubmission.
fixes #5967
2014-06-20 14:32:22 +02:00
01631720cc
Dashboard\Component: don't pass on limit
...
Dashlets might be limited to just a few line, we shoultn't pass on
this parameters when showing the "large" variant
2014-06-20 14:29:45 +02:00
ac7354295a
Accessibiltiy: add alt tag for icons
...
Screen readers to not read title tags per default
2014-06-20 14:28:19 +02:00
27e7839d1b
Widget\Limiter: initial commit
...
This allows one to easily switch row count shown on a single page
2014-06-20 13:48:17 +02:00
07134cf931
JS/XHR: handle multiple notifications
...
As there seems to be problems with sending the same header multiple
times we put multiple notifications in one header.
2014-06-20 13:20:20 +02:00
617741c62f
helpers/widget: options are opional
2014-06-20 13:18:52 +02:00
Thomas Gelf
Matthias Jentsch