tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
8,447 Commits 120 Branches 71 Tags 80 MiB
Commit Graph

494 Commits

Author SHA1 Message Date
Matthias Jentsch 8dbd671b0d Conform to coding guidelines, update docstrings and cleanup unused code 
refs #8623
 2015-07-28 15:21:02 +02:00
Matthias Jentsch f2d253f508 Assure that rows are refreshed correctly on reload 
Assure that all links are initialized when the selection is applied after a request. Move action table code into the actiontable behavior.

refs #8623
 2015-07-27 10:34:17 +02:00
Johannes Meyer 0f2351ff1d js: Fix XHR loading of URLs in case window.FormData is not supported 
refs #8758
 2015-07-22 13:29:44 +02:00
Johannes Meyer 5e1ea958b4 js: Correctly process the redirectUrl-meta tag for successful frame uploads 
refs #8758
 2015-07-21 16:38:52 +02:00
Johannes Meyer 93fbb0231c loader.js: Split processRedirectHeader() to allow partly reuse 
refs #8758
 2015-07-21 16:37:21 +02:00
Johannes Meyer 9471c3c574 js: Make use of the _frameUpload parameter when submitting a form.. 
..to an iframe. This ensures that stuff like notifications are immediately
visible to the user after successful form submission.

refs #8758
 2015-07-21 15:43:47 +02:00
Johannes Meyer 570dada0d8 js: Manually submit the form if it's being automatically submitted... 
...in case we're submitting a multipart/form-data form using the iframe
fallback. The form wouldn't be submitted otherwise.

refs #8758
 2015-07-21 14:15:12 +02:00
Johannes Meyer 37b87eb284 js: Add fallback in case XHR file uploads are not possible 
refs #8758
 2015-07-20 10:52:28 +02:00
Johannes Meyer 95bcb95cb5 events.js: Prevent default form submission as late as possible 2015-07-20 10:13:48 +02:00
Johannes Meyer 6d4d99aa62 js: Use window.FormData instead of just FormData 
refs #8758
 2015-07-15 15:49:34 +02:00
Johannes Meyer c1d9cde312 js: Properly submit multipart/form-data 
This is not IE <10 compatible. Fix follows. ;-)

refs #8758
 2015-07-15 15:25:40 +02:00
Johannes Meyer 3098c21c17 loader.js: Push failed requests to history 
The commit ae68e8aec4 reverted
earlier seems to be supposed to do exactly what this one does now.
Prior, the commits ae68e8aec4 and
8bb0e4e0a0 were effectively
neutralizing each other. Quick tests of how Web 2 handles failing
requests while interacting with the browser's history were successful.
If this change breaks something else (again?), leave me a note and do
*not* fix it straight away..
 2015-07-06 16:56:44 +02:00
Johannes Meyer b4fe91bb2f Revert "Ajax onFailure: Write component URL to container" 
This reverts commit ae68e8aec4.

fixes #9042
fixes #9544
 2015-07-06 16:43:49 +02:00
Matthias Jentsch aecfb2eb97 Merge branch 'bugfix/multiselection-not-visible-9054' 
fixes #9054
fixes #9346
 2015-06-30 14:08:19 +02:00
Matthias Jentsch 6a7e3fe440 Document multi selection and use clearer names 
refs #9054
 2015-06-30 13:03:41 +02:00
Matthias Jentsch 975a834bd4 Remove unused code and clean up 2015-06-30 12:28:41 +02:00
Matthias Jentsch e0d588cda3 Fix look and feel of row selection 
Always refresh all tables on render and click events, to display or remove active rows without any delay.

refs #9054
refs #9346
 2015-06-30 11:53:38 +02:00
Matthias Jentsch 96677fb6c7 Fix selection when clicking on regular links 
refs #9054
refs #9346
 2015-06-29 18:51:32 +02:00
Matthias Jentsch aec59d9941 Use current filter to highlight active rows instead of storing active rows in JS 
Clean up selection code and move it into separate behavior and parse filter query to fetch selectable rows.

refs #9054
refs #9346
 2015-06-29 18:48:42 +02:00
Johannes Meyer ebe144c16a Form: Do not encode actions twice 2015-06-24 16:15:45 +02:00
Thomas Gelf cd70c27519 Merge remote-tracking branch 'origin/master' into feature/refine-ui-for-rc1-9361 2015-06-18 15:18:42 +02:00
Thomas Gelf 7ee192e774 fullscreen: no more fixes controls and padding 2015-06-18 13:41:12 +02:00
Thomas Gelf 2f62a4383a Layout: add showFullscreen parameter 
refs #6729
 2015-06-18 13:41:12 +02:00
Thomas Gelf 55dd3747f7 notifications: remove on click 
This allows one to get rid of them faster in case access to the
underlying content is needed
 2015-06-18 13:29:47 +02:00
Thomas Gelf 09c0ebcacd list/services: flip host/service for readability 
Re-allow table.action to manually choose row action link if it should not
be the first one. This existed once but got lost.
 2015-06-16 02:36:53 +02:00
Johannes Meyer cd0c418854 Merge branch 'master' into feature/user-and-group-management-8826 2015-06-02 10:44:13 +02:00
Eric Lippmann 1bfbce98ac Disable all form controls on submit to prevent resubmission 
fixes #7151
 2015-05-28 13:17:00 +02:00
Johannes Meyer ec556edc65 Merge branch 'master' into feature/user-and-group-management-8826 2015-05-26 09:28:35 +02:00
Johannes Meyer 88f5bb8368 js: Relax check whether to switch to single column layout upon redirect 
This fixes the problem when redirecting from a form using the same route
as in the leftmost column but with a different querystring, that one gets
the same route shown twice.
 2015-05-22 16:54:59 +02:00
Eric Lippmann 54577d04bd Merge branch 'master' into bugfix/time-formatting-6778 
Conflicts:
	modules/monitoring/application/views/scripts/list/comments.phtml
	modules/monitoring/application/views/scripts/list/hostgroups.phtml
	modules/monitoring/application/views/scripts/process/info.phtml
	modules/monitoring/application/views/scripts/show/components/downtime.phtml
	modules/monitoring/application/views/scripts/show/components/notifications.phtml
	modules/monitoring/public/css/module.less
 2015-05-21 14:57:01 +02:00
Eric Lippmann 1e9337846a ui: Fix refreshing partial time counters 
refs #6778
 2015-05-21 10:16:54 +02:00
Matthias Jentsch 54207d3427 Revert "Abort pending AJAX requests before page unload" 
This reverts commit 94bdb8b4b0. After the patch, Firefox shows an error message on each reload for an unknown reason.

refs #7759
 2015-05-19 17:06:22 +02:00
Matthias Jentsch 94bdb8b4b0 Abort pending AJAX requests before page unload 
Abort all pending requests before the page unload, to avoid confusing error messages during page reloads. Avoid rendering the site unusable in cases where the site is still being used after the beforeunload event.

fixes #7759
 2015-05-19 16:35:44 +02:00
Matthias Jentsch 7c8ff44fd1 Fix comment and downtime list inline forms 
refs #8903
refs #8902
 2015-05-07 10:59:37 +02:00
Johannes Meyer da7aa23820 Merge branch 'master' into bugfix/make-all-views-dashboard-compliant-7876 2015-04-20 15:20:23 +02:00
Johannes Meyer 5196f16bde Do not forcibly hide controls in the dashboard 
Our views respect view=compact now entirely so there is no need for such
a generic "solution" since it also prevents some views from being
completely displayed in the dashboard such as the host, service and
contact detail view.

refs #7876
 2015-04-20 13:06:45 +02:00
Matthias Jentsch ce6be0cc0f Only use JS tooltips when non-native tooltip behavior is required 
Only display JS tooltips when there are specific requirements for delay, there is a specific alignment or HTML markup can be rendered in the tooltip.

fixes #9025
 2015-04-20 11:21:10 +02:00
Johannes Meyer 54a370ca22 Merge branch 'master' into bugfix/make-all-views-dashboard-compliant-7876 2015-04-20 11:15:04 +02:00
Thomas Gelf ae7d679a6a Revert "Do not destroy all global on mailto link clicks" 
This reverts commit 16b9c73436.

As I already mentioned, this re-introduces the problem that you'll
get ugly "lost connection to web server" notifications. Easiest way
to reproduce this: click your browsers reload button while a request
is pending - or just click reload a couple of times while showing the
dashboard.

refs #7759
 2015-04-16 21:01:08 +02:00
Matthias Jentsch 6898a4e0d5 Display icon tooltips without delay 
Original functionality was broken when changing the icon library.
 2015-04-16 18:32:47 +02:00
Matthias Jentsch f07c0d83e8 Add option to change tooltip settings from data attributes 
refs #9025
 2015-04-16 18:32:47 +02:00
Matthias Jentsch aa409bda72 Fix formatting of js error log entries generated from responses 
Replace multiple whitespace characters with a single one and remove linebreaks.

refs #8711
 2015-04-16 12:15:59 +02:00
Eric Lippmann 796cbffbd7 Merge branch 'master' into bugfix/time-formatting-6778 
Conflicts:
	modules/monitoring/application/views/scripts/show/components/notifications.phtml
 2015-04-15 15:43:39 +02:00
Johannes Meyer be05d3a73a Fix dashboard header handling 
refs #7876
 2015-04-15 13:23:34 +02:00
Matthias Jentsch 1f0940c8e8 Remove all selections closing the detail area 
fixes #8781
 2015-04-13 17:55:41 +02:00
Matthias Jentsch f4c0b35eff Remove unused code 2015-04-13 17:55:41 +02:00
Matthias Jentsch 16b9c73436 Do not destroy all global on mailto link clicks 
Only call the cleanup code on the unload event, beforeunload is only for asking for confirmation.

fixes #7759
 2015-04-13 17:55:41 +02:00
Eric Lippmann 0baeb32751 Temporary disable timesince ui counter 
refs #6778
 2015-04-09 12:05:45 +02:00
Eric Lippmann 0de2dbd626 Temporary disable timeuntil ui counter 
refs #6778
 2015-04-08 15:23:00 +02:00
Johannes Meyer d6e5afa6d5 Fix that a menu section is not expanded in a popup when hovered 
fixes #8695
 2015-03-13 15:01:47 +01:00
Eric Lippmann 2e1ae185fb Retain detail URL if the layout is rerendered after a redirect 
refs #8605
 2015-03-13 04:04:58 +01:00
Eric Lippmann 1bd2e7cb84 Submit forms to the container's target URL if the form's action is not set 
refs #8605
 2015-03-13 04:02:42 +01:00
Eric Lippmann b5abff0313 Fix that the detail URL is no longer appended to the redirect URL on login 
JavaScript relied on #redirect but we now protect IDs which make them unusable
for JS and CSS.

refs #8728
 2015-03-13 03:48:46 +01:00
Eric Lippmann 29d5fd351b Merge branch 'bugfix/logout-external-8626' 
fixes #8626
 2015-03-12 16:47:49 +01:00
Eric Lippmann 8b7250bfa6 JS: Focus the element referenced by the anchor on anchor navigation ... 
... instead of looking for any heading.
 2015-03-12 16:08:47 +01:00
Eric Lippmann 77b99552a4 Add JSDoc to Icinga.Events.prototype.handleAnchor() 2015-03-12 16:08:47 +01:00
Eric Lippmann 90971f2caf Revert "Merge branch 'feature/organize-headings-7976'" 
This reverts commit ea2a17a76c, reversing
changes made to e72de8dfe1.

refs #7976
fixes #8647
 2015-03-12 16:08:34 +01:00
Thomas Gelf 5270acd645 events.js: correctly detect form target container 
This is for forms with no submit button.

fixes #8710
 2015-03-12 11:30:21 +01:00
Thomas Gelf 3af36015ff dashboard: do not fix and hide any controls 
It would be better if view scripts would care about this, but as we
failed so many times this might be the better option.

fixes #8697
 2015-03-12 10:04:19 +01:00
Eric Lippmann 7f94858b8d Add JSDoc to Icinga.Loader.prototype.processRedirectHeader() 
refs #8626
 2015-03-11 21:26:44 +01:00
Eric Lippmann 031f9ddc84 Don't always redirect to the current window's URL if the redirect URL is __SELF__ 
Please see code comments for an explanation.

refs #8626
 2015-03-11 21:24:56 +01:00
Johannes Meyer cddcde9494 Setup: Automatically check the respective admin account type selection 
resolves #8603
 2015-03-06 15:41:25 +01:00
Johannes Meyer 4351603243 Fix that editing an auth backend does not open the next column 2015-02-26 14:48:37 +01:00
Alexander Fuhr 16200417eb Add spinner active indicator for form submit buttons 
refs #7968
 2015-02-25 14:15:32 +01:00
Alexander Fuhr 4505718ecc Move spinner indicator functionality to linkClicked method 
refs #7968
 2015-02-25 12:10:08 +01:00
Alexander Fuhr 5297b15a61 Merge branch 'master' into feature/refresh-control-7968 2015-02-24 14:41:09 +01:00
Johannes Meyer 956efe5ef9 Merge branch 'master' into feature/link-labels-8458 
Conflicts:
	application/views/scripts/config/application.phtml
	application/views/scripts/config/module.phtml
	application/views/scripts/config/modules.phtml
	library/Icinga/Web/Widget/Dashboard/Dashlet.php
	modules/monitoring/application/controllers/TimelineController.php
 2015-02-24 08:42:36 +01:00
Alexander Fuhr aa5c52dfdd Implement content refresh control next to dropdown tab 
refs #7968
 2015-02-23 17:02:44 +01:00
Johannes Meyer 04d2c78983 Allow to move content not wrapped by <div> to another container 2015-02-23 16:28:12 +01:00
Marius Hein 44019f4e67 Events: Quick fix for access the focusable element 
refs #7976
 2015-02-23 16:06:21 +01:00
Marius Hein 2dda3be87b Merge remote-tracking branch 'origin/master' into feature/organize-headings-7976 2015-02-23 14:28:48 +01:00
Matthias Jentsch 2992bf3445 Always display tooltips in all charts 
Make information about data types available to colorblind, when hovering
over the displayed data set

fixes #8364
 2015-02-18 13:21:42 +01:00
Marius Hein d3c79dae32 Merge branch 'master' into feature/organize-headings-7976 2015-02-17 15:21:29 +01:00
Johannes Meyer 3dce0e434a Add more sophisticated fix for keeping the focus after an autorefresh 
fixes #8350
 2015-02-17 09:24:38 +01:00
Marius Hein ea57e7a786 History: Do not write abort requests to browser history 
Remove req.historyTriggered and introduce req.addToHistory.
 2015-02-16 15:56:50 +01:00
Marius Hein 6cc428d0e1 History: Combined cleanup regular expression 2015-02-16 15:38:16 +01:00
Johannes Meyer 0c0478688e js: Fix that buttons with any DOM descendants are not ignored by linkClicked 
fixes #8380
 2015-02-16 15:07:31 +01:00
Marius Hein 2aca4dc6d5 History: Do not push same url twice 2015-02-16 14:11:23 +01:00
Marius Hein ae68e8aec4 Ajax onFailure: Write component URL to container 
This is needed that history can push the correct detail url
 2015-02-16 14:11:11 +01:00
Marius Hein cd11cf3469 Fix close button: Test the anchor if it belongs to us 2015-02-13 11:47:16 +01:00
Marius Hein 7ca2e1d282 Fix close button: Test the anchor if it belongs to us 2015-02-13 11:45:20 +01:00
Marius Hein bcc03f8160 Focus: Set the focus to the next usable element 
Fix copy and paste error and find h1 first.

refs #7976
 2015-02-13 11:39:28 +01:00
Eric Lippmann 9bf8488f68 js: Remove out-commented function hrefIsHashtag from events.js 2015-02-13 09:59:34 +01:00
Marius Hein f586714f02 Skip Links: Select a more useful object 
Skip links can select a container and find a usable element inside. Adapt
project jquery variable style.

refs #7976
 2015-02-12 16:34:50 +01:00
Marius Hein 53818f50c6 Skip Links: Add anchor handlint to events 
refs #7933
 2015-02-12 13:13:52 +01:00
Thomas Gelf d10beb7604 js: no console.log. please! 2015-02-09 15:26:55 +01:00
Johannes Meyer 423025b3fe javascript: Do not bind the button click event 
Catching form submit events is sufficient as catching the button click
event is not an option due to circumventing the browser's native form
validation logic otherwise.

refs #8349
 2015-02-05 13:21:03 +01:00
Matthias Jentsch b56eb7b669 Fix keyboard navigation 
Store current focus position before reload and apply it after rendering.

fixes #8350
 2015-02-04 18:01:06 +01:00
Eric Lippmann 6bae2e0a53 Note that our license is GPL v2 or any later version in our license header instead of pointing to the license's URL 2015-02-04 10:52:27 +01:00
Matthias Jentsch 2f254851e3 Fix pieChart layout and add indicator for truncated piecharts 2015-02-03 17:34:56 +01:00
Matthias Jentsch e8466ec7be Fix inlinePie borders and SVG sizes 
Add white border to inline piecharts in the list, to make them more visible on mouse hovering. Set a default image size for the loaded svg charts.
 2015-02-03 16:46:12 +01:00
Eric Lippmann 5b4fab0750 Add license header 
This time without syntax errors hopefully :)
 2015-02-03 16:27:59 +01:00
Eric Lippmann 5fa2e3cfdc Revert "Add license header" 
This reverts commit 338d067aba.
 2015-02-03 16:16:26 +01:00
Eric Lippmann 338d067aba Add license header 
fixes #7788
 2015-02-03 15:51:04 +01:00
Thomas Gelf f6fc592b91 events.js: reduce logging noise 
Form submission by pressing return is not an error, and debug level
should suffice for the other button-related notices too.
 2015-02-02 21:56:14 +01:00
Johannes Meyer 8bb0e4e0a0 Failure requests: Fix auto refresh and history II 
Allow to change url's in history and stop auto auto refresh if
the container URL is not up to date.

Use variable after ajax call and the check is more robust.
 2015-02-02 16:52:36 +01:00
Marius Hein bc69a3b20f Revert "Failure requests: Fix auto refresh and history" 
This reverts commit 8c758a9f12.
 2015-02-02 16:40:05 +01:00
Johannes Meyer a5fe9a1fe1 Revert "Introduce link target "_right" to keep a column with tabs rightmost" 
This reverts commit 618ab4f4b9.
 2015-02-02 16:34:29 +01:00
Marius Hein 67a426580d loader: Remove gray out on complete handler 
A failure did not remove the impact class which colorize
the background gray.
 2015-02-02 15:20:12 +01:00
Marius Hein 6555a2ec0a Menu: Move request handling to complete 
If a failure occur the menu is still working.
 2015-02-02 15:03:36 +01:00