Eric Lippmann
5b5ad0acb9
monitoring/security: Add missing permission checks of command actions
2015-02-03 17:36:53 +01:00
Matthias Jentsch
2f254851e3
Fix pieChart layout and add indicator for truncated piecharts
2015-02-03 17:34:56 +01:00
Eric Lippmann
49e96b7200
Revert "monitoring/security: Guard delete comment action"
...
This reverts commit 4ef5f0c813
.
2015-02-03 16:51:00 +01:00
Matthias Jentsch
e8466ec7be
Fix inlinePie borders and SVG sizes
...
Add white border to inline piecharts in the list, to make them more visible on mouse hovering. Set a default image size for the loaded svg charts.
2015-02-03 16:46:12 +01:00
Johannes Meyer
b712d9453b
It's not the "permissions.ini" but the "roles.ini" that holds the role settings
2015-02-03 16:38:32 +01:00
Eric Lippmann
5b4fab0750
Add license header
...
This time without syntax errors hopefully :)
2015-02-03 16:27:59 +01:00
Eric Lippmann
5fa2e3cfdc
Revert "Add license header"
...
This reverts commit 338d067aba
.
2015-02-03 16:16:26 +01:00
Johannes Meyer
04edf0d075
Fix that the search is case-sensitive in case of a PostgreSQL backend
...
fixes #8083
2015-02-03 16:15:59 +01:00
Eric Lippmann
4ef5f0c813
monitoring/security: Guard delete comment action
2015-02-03 16:11:56 +01:00
Eric Lippmann
d701f9a354
monitoring/security: Guard delete downtime action
2015-02-03 16:11:29 +01:00
Eric Lippmann
338d067aba
Add license header
...
fixes #7788
2015-02-03 15:51:04 +01:00
Eric Lippmann
946a903a39
Merge branch 'bugfix/Improve-tooltip-descriptions-8110'
...
fixes #8110
2015-02-03 12:38:59 +01:00
Eric Lippmann
dd0638c5d0
monitoring: Improve tooltips for services command links
...
refs #8110
2015-02-03 12:35:06 +01:00
Eric Lippmann
31728fd024
monitoring: Improve tooltips for hosts command links
...
refs #8110
2015-02-03 12:34:22 +01:00
Thomas Gelf
a705e03aff
HostController: fix merge BS
2015-02-02 18:21:01 +01:00
Thomas Gelf
b54a12c2d5
HostActionsHook: document the new hook
2015-02-02 18:17:30 +01:00
Thomas Gelf
ac7ffc757f
Merge branch 'feature/hostactions-hook-8208' of git.icinga.org:icingaweb2 into feature/hostactions-hook-8208
...
Manually merged diverged tab activation
Conflicts:
modules/monitoring/application/controllers/HostController.php
2015-02-02 17:48:40 +01:00
Thomas Gelf
b4c47c51e7
components/actions: show links if available
...
Now we show links regardless of whether we have host actions, there
might be hook-provided links only. Renamed "Foreign URLs" to "Actions"
and made it translatable.
2015-02-02 17:46:40 +01:00
Thomas Gelf
3038de5ad0
components/actions: show host action urls if given
2015-02-02 17:46:40 +01:00
Thomas Gelf
6c8808875a
host/show: show action urls above perfdata
2015-02-02 17:46:40 +01:00
Thomas Gelf
67e935557e
HostController: use host actions hook
...
refs #8208
2015-02-02 17:46:39 +01:00
Thomas Gelf
45bf071db6
HostActionsHook: initial very simple implementation
...
refs #8208
2015-02-02 17:44:29 +01:00
Eric Lippmann
61fde8b359
monitoring: Prefix tooltips in the service groups overview with "List ..."
...
refs #8110
2015-02-02 17:29:30 +01:00
Eric Lippmann
a8de3c093a
monitoring/host: Add tooltip for the unhandled services link to the link
...
refs #8110
2015-02-02 17:27:59 +01:00
Eric Lippmann
2722463372
Prefix tooltips in the host groups overview with "List ..."
...
refs #8110
2015-02-02 17:06:32 +01:00
Johannes Meyer
c4c6d36b00
setup: Clarify that the db user's credentials may be insufficient as well
2015-02-02 16:55:31 +01:00
Eric Lippmann
4fc8850e25
Use transplatePlural for hosts in downtime and hosts having comments tooltips
...
refs #8110
2015-02-02 16:48:13 +01:00
Eric Lippmann
942d55c0d4
Merge branch 'master' into bugfix/Improve-tooltip-descriptions-8110
2015-02-02 16:37:03 +01:00
Johannes Meyer
a5fe9a1fe1
Revert "Introduce link target "_right" to keep a column with tabs rightmost"
...
This reverts commit 618ab4f4b9
.
2015-02-02 16:34:29 +01:00
Johannes Meyer
9df2430cbe
Remove redundant help message when scheduling host/service checks
2015-02-02 16:31:57 +01:00
Johannes Meyer
5382f73c53
Drop all old object- and command-view scripts
2015-02-02 16:31:25 +01:00
Johannes Meyer
8b377cd651
Use the new command-view scripts
2015-02-02 16:30:52 +01:00
Johannes Meyer
2e99e476fe
Use the new object-view scripts
2015-02-02 16:28:35 +01:00
Johannes Meyer
afa3431aed
Introduce new object- and command-view scripts
...
Represents how we plan to handle view scripts that are re-usable. Should
supersede all <action>/component/* view scripts in the upcoming future.
2015-02-02 16:26:55 +01:00
Eric Lippmann
bfb2f710a1
monitoring: Fix exception in the alert summary report when using the "One month" interval
...
fixes #8220
2015-02-02 14:28:47 +01:00
Eric Lippmann
f9047e85c5
monitoring: Fix wrong unhandled service problems count in the hosts overview
...
The query was missing the is_active = 1 condition. I'll open an issue for the other
affected queries.
fixes #8013
2015-02-02 11:12:27 +01:00
Eric Lippmann
cf944a7daf
monitoring: Show close button when removing a backend
2015-02-02 11:07:01 +01:00
Eric Lippmann
a62acb4a82
monitoring: Show close button when updating a backend
2015-02-02 11:06:40 +01:00
Eric Lippmann
42fe7079ee
monitoring: Show close button when creating an instance
2015-02-02 11:06:20 +01:00
Eric Lippmann
cbc1a0313a
monitoring: Show close button when creating a backend
2015-02-02 11:05:50 +01:00
Eric Lippmann
d7cbfebbd0
monitoring: Show close button when removing an instance
2015-02-02 11:05:32 +01:00
Eric Lippmann
734c7b3546
monitoring: Show close button when updating an instance
2015-02-02 11:04:41 +01:00
Eric Lippmann
f2d639108f
monitoring: Move "Service Grid" beneath "Problems"
...
The service grid is filtered by problems by default. Thus it makes sense
to move it beneath the problems section.
2015-02-02 00:08:25 +01:00
Eric Lippmann
ad4ebf8fa5
monitoring: Fix that selecting a hostgroup displays its services instead of its hosts
...
fixes #8273
2015-02-01 23:30:48 +01:00
Johannes Meyer
bf470125c3
Merge branch 'master' into feature/create-missing-directories-when-creating-inis-8219
...
Conflicts:
modules/monitoring/library/Monitoring/MonitoringWizard.php
2015-01-30 16:21:42 +01:00
Johannes Meyer
f5a651664c
Create the enabledModules directory when necessary only as well
...
refs #8219
2015-01-30 16:16:12 +01:00
Johannes Meyer
a95fd561cd
Revert "setup: Convert octal directory mode to decimal notation"
...
This reverts commit e93e8f6330
.
2015-01-30 15:47:21 +01:00
Johannes Meyer
d2dd66c9fd
Revert "setup: Fix octdec for directory modes"
...
This reverts commit c0444a81b2
.
2015-01-30 15:47:11 +01:00
Johannes Meyer
6416fc421c
Do not create directories which are created automatically if necessary
...
refs #8219
2015-01-30 15:43:39 +01:00
Johannes Meyer
e8619686ae
Add the sockets module as optional requirement of the monitoring module
2015-01-30 13:01:51 +01:00
Eric Lippmann
127ce7abfe
monitoring/security: Fix that toggling instance features is always disabled
...
In HTML5 the presence of a boolean attribute on an element represents the true value,
and the absence of the attribute represents the false value.
In Zend we have to set null for the absence of the attribute and the empty string for the
presence of the attribute.
2015-01-30 10:47:02 +01:00
Eric Lippmann
1681f746c1
monitoring/security: Disable toggling object features if user lacks the permission monitoring/command/feature/object
2015-01-30 10:46:24 +01:00
Eric Lippmann
bdc637ff67
monitoring/security: Guard toggling object features
...
Toggling object features will only be possible if the user has the permission monitoring/command/feature/object.
2015-01-30 10:31:49 +01:00
Alexander Klimov
868295110a
Merge branch 'master' into bugfix/Improve-tooltip-descriptions-8110
...
Conflicts:
modules/monitoring/application/views/scripts/hosts/show.phtml
2015-01-30 10:26:47 +01:00
Eric Lippmann
35b33647cf
monitoring/security: Guard the link for disabling notifications on an instance-wide basis
...
The link in the monitoring health view will only be shown if the user has the permission monitoring/command/feature/instance.
2015-01-30 10:26:43 +01:00
Eric Lippmann
3716be4a48
monitoring/security: Disable toggling instance features if user lacks the permission monitoring/command/feature/instance
2015-01-30 10:01:03 +01:00
Eric Lippmann
26613a0106
monitoring/security: Rename permission monitoring/command/feature/program to monitoring/command/feature/instance
2015-01-30 09:58:30 +01:00
Eric Lippmann
7dbb8c6841
monitoring/security: Require monitoring/command/feature/instance permission for toggling instance features
2015-01-30 09:58:10 +01:00
Eric Lippmann
d19e36d937
monitoring/security: Require monitoring/command/feature/instance permission for disabling notifications
2015-01-30 09:57:31 +01:00
Johannes Meyer
63305fdf9a
Add Icinga\Application\Config::saveIni()
...
Simplifies saving INI files. Icinga\File\Ini\IniWriter does already require an
instance of Icinga\Application\Config so it's obvious to give "Config" the
task to initialize the writer.. We do also have a central place to handle
creating missing ancestor directories now.
refs #8219
2015-01-30 09:32:08 +01:00
Johannes Meyer
3a983e8859
Merge branch 'master' into feature/improve-autologin-setup-8274
2015-01-28 18:01:15 +01:00
Johannes Meyer
78f5bf4f3d
Phrase external auth warnings more neutral
...
refs #8274
2015-01-28 16:22:20 +01:00
Johannes Meyer
618ab4f4b9
Introduce link target "_right" to keep a column with tabs rightmost
...
I'd have liked to get it to work that in case the tab control is not in the
rightmost column a "go back" in the history is being simulated causing
the preceding leftmost column(s) to be restored and the rightmost one
set to the one containing the tab control. But the history api does not
seem to support any read operations except for the current state..
refs #6436
2015-01-28 14:21:06 +01:00
Johannes Meyer
c19ff289bf
Open command forms in the same column where their link is located
...
refs #8279
2015-01-28 13:02:37 +01:00
Johannes Meyer
6fde4eec30
Show all tabs except "Add to Dashboard" when issuing a command
...
refs #8279
2015-01-28 12:50:29 +01:00
Eric Lippmann
49b82af704
monitoring/security: Apply services/filter restriction in the service detail view
2015-01-27 14:57:54 +01:00
Eric Lippmann
49d4d74dbb
monitoring/security: Apply hosts/filter restriction in the host detail view
2015-01-27 14:57:22 +01:00
Eric Lippmann
7bf6bd39e9
monitoring: Implement Filterable in MonitoredObject
2015-01-27 14:54:21 +01:00
Eric Lippmann
e086905384
monitoring: Deprecate DataView::addFilter() and DataView::setFilter()
...
The from now on deprecated interface Filterable has proven that it sucks in the DataView.
Because of requiring us to implement trillion stupid methods, only DataView::applyFilter()
does not forget to handle column validation. Thus only DataView::applyFilter() must be used in order
to apply filters.
For setFilter() a wrapping Filter::matchAny() for the IdoQuery (or the DbQuery or the SimpleQuery I didn't have a look)
is required for the filter to work properly.
The deprecation is just for the records. I guess we do not use the other methods.
2015-01-27 14:52:13 +01:00
Eric Lippmann
b2f93abb12
monitoring/security: Require a Filterable instead of a DataView in applyRestriction()
2015-01-27 14:24:56 +01:00
Eric Lippmann
3cbafe16f6
monitoring/security: Move applyRestriction() to the module's base controller
2015-01-27 14:22:37 +01:00
Johannes Meyer
23c36898da
Rename css class "info" to "info-box" and add it as generic box
...
refs #8274
2015-01-27 14:05:41 +01:00
Eric Lippmann
f37cd0cb95
monitoring/security: Apply hosts restriction in the hosts overview
2015-01-27 13:51:15 +01:00
Eric Lippmann
c8084dde92
monitoring/security: Apply services restriction in the services overview
2015-01-27 13:49:51 +01:00
Eric Lippmann
f8aa9eb05c
monitoring/security: Replace 'monitoring/filter' restrictions with filter for the hosts and the services view
2015-01-27 13:48:33 +01:00
Eric Lippmann
405e18a46f
monitoring: Fix PHPDoc for MonitoringBackend::from()
2015-01-27 13:37:28 +01:00
Eric Lippmann
08795e7cf4
monitoring/security: Expect restriction name in ListController::applyRestriction()
...
Before, the restriction was hard coded to 'monitoring/filter'.
This restriction will be removed because we can not use the very same filter for all views.
2015-01-27 13:33:52 +01:00
Johannes Meyer
afd4a9a134
There will be '.. users create' instead of '.. setup config webserver --with..'
...
refs #8274
2015-01-27 10:54:33 +01:00
Johannes Meyer
50fc85d7ff
Rename authentication type "autologin" to "external"
...
refs #8274
2015-01-27 09:49:36 +01:00
Johannes Meyer
0fa133abfb
setup: Display a note in case autologin is chosen while not being logged in
...
In case the user chooses to use autologin as authentication while not being
externally authenticated a note is displayed indicating that it is necessary
to set up the webserver's authentication to be able to login once the wizard
is complete.
refs #8274
2015-01-26 16:58:40 +01:00
Johannes Meyer
45408e45af
Relax database permission checks in the setup wizard
...
The wizard considered all permissions being exclusively associated to their
most important context, which is, in the most common case, incorrect.
Permissions assigned on database level do not need to be assigned on
table level as well.
refs #8267
2015-01-26 15:51:47 +01:00
Alexander Klimov
fccc2ffbcf
Hosts list: use $this->translatePlural()
2015-01-26 14:17:48 +01:00
Johannes Meyer
7006bbf8b2
Suggest "icingaweb2" as group instead of the webserver's user
...
..and note that it is necessary to create this group.
2015-01-26 14:13:10 +01:00
Alexander Klimov
f0784caaad
Hosts view: show object amounts in titles
2015-01-26 14:09:39 +01:00
Eric Lippmann
555ab77c3d
Fix "Undefined property: stdClass::$service_display_name" in the alert summary
...
fixes #8284
2015-01-26 13:42:05 +01:00
Johannes Meyer
0b73dbdd6d
Fix exception "Undefined index: type" in the WebWizard's page logic
...
refs #8275
2015-01-26 10:32:33 +01:00
Johannes Meyer
fb97e74453
Use the correct element identifier for the preference storage type selection
...
Used to be `type' but has changed to `store'
to get a more clear INI structure.
fixes #8275
2015-01-26 07:39:31 +01:00
Johannes Meyer
359336243c
Save "none" instead of "null" when choosing to not to store preferences
...
refs #8234
2015-01-23 16:25:24 +01:00
Johannes Meyer
2a543bb5ae
Rename the preference setting `type' to `store'
...
refs #8234
2015-01-23 16:25:23 +01:00
Eric Lippmann
5fe5e22395
doc: Support any link having a fragment except http(s) links for linking between headings
2015-01-23 16:00:15 +01:00
Eric Lippmann
53a4f10253
monitoring: Sort host groups and service groups by their alias
...
refs #7843
2015-01-23 15:47:18 +01:00
Eric Lippmann
910065436b
monitoring: Support hostgroup_alias and servicegroup_alias filter
2015-01-23 15:47:18 +01:00
Eric Lippmann
a1fbb3d937
monitoring: Fix host and service groups overviews when using PostgreSQL
...
fixes #8268
2015-01-23 15:47:18 +01:00
Johannes Meyer
a07bff490f
Fix that the monitoring module's config directory is not being created
...
Forgot to re-add this when reverting a temporary change while adjusting
the module installation as part of #8191 .
2015-01-23 15:31:45 +01:00
Eric Lippmann
7500dd9c68
Revert "GroupSummary/Postgres: Fix group by in initial join query"
...
This reverts commit f47bc46654
.
Conflicts:
modules/monitoring/library/Monitoring/Backend/Ido/Query/GroupsummaryQuery.php
No need to reintroduce group columns.
2015-01-23 15:27:52 +01:00
Johannes Meyer
14a4aaeb77
Revert "Fix that when chosing to not to store preferences an invalid config is created"
...
This reverts commit 6284da451e
.
2015-01-23 15:23:43 +01:00
Johannes Meyer
6284da451e
Fix that when chosing to not to store preferences an invalid config is created
...
fixes #8234
2015-01-23 14:42:09 +01:00
Eric Lippmann
c78d4aa0bd
monitoring/security: Provide permissions for the feature commands
2015-01-23 13:29:47 +01:00
Eric Lippmann
86ac09d7b1
monitoring: Use the service group alias for displaying service group names in the servicegroups overview
...
refs #8266
2015-01-23 11:24:39 +01:00
Eric Lippmann
7e05de1255
monitoring: Select the service group alias in the servicegroups ovweview
...
refs #8266
2015-01-23 11:23:59 +01:00