tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
2,614 Commits 120 Branches 71 Tags 80 MiB
Commit Graph

403 Commits

Author SHA1 Message Date
Thomas Gelf 7caccd7691 Web\Url: remove stripUrlFragment() 
This function had an interesting history and seems to be a result of
missunderstanding of each others commits. Removed, as the fragment is
already there.

refs #6699
 2014-08-19 09:36:15 +02:00
Johannes Meyer f2ed813c9a Fix that Icinga\Web\Url::fromPath drops fragments 
fixes #6284
 2014-08-14 14:23:31 +02:00
Johannes Meyer 666591beb7 Encode url before passing it to Icinga\Form\Dashboard\AddUrlForm 
fixes #6611
 2014-08-13 16:41:40 +02:00
Thomas Gelf 8f729bfb65 ActionController: set a default window title 
In case a controller action didn't set a view title this fix restores
the default title on XHR requests.

fixes #6797
 2014-07-31 17:04:26 +02:00
Eric Lippmann a68ccecb28 Revert "Do not use htmlspecialchars in widgets" 
This reverts commit 2ff43abcf5.

`Widget::escape()' does not exist. But `Widget::view()::espcae()' does.
 2014-07-23 12:28:04 +02:00
Alexander Klimov 2ff43abcf5 Do not use htmlspecialchars in widgets 
refs #6759
 2014-07-23 12:12:05 +02:00
Matthias Jentsch 091ddbe552 Partiall revert bfc54b7e 
Refactor Url->getParams() to return an instance of UrlParam instead of an array.

fixes #6760
 2014-07-21 09:22:19 +02:00
Matthias Jentsch bfc54b7e32 Fix array conversion of the Dashboard and its Components 
Do not omit the parameters when converting the dashboard components to
an array. Add an array conversion to the UrlParams class.

refs #6691
 2014-07-16 17:31:01 +02:00
Johannes Meyer 5c507d5d91 Fix notice that the session has been already started after retrieving its id 2014-07-16 15:39:40 +02:00
Johannes Meyer e6dee9fe89 Protect login against CSRF 
refs #5626
 2014-07-16 09:55:23 +02:00
Johannes Meyer 19f05256a0 Only call session_start() when reading from session 
fixes #6383
 2014-07-16 09:55:22 +02:00
Johannes Meyer 3105c2059e Remove license headers from all files 
refs #6309
 2014-07-15 13:43:52 +02:00
Johannes Meyer e567ad67c5 Display statehistory summary vertically 
fixes #6636
 2014-07-14 15:26:35 +02:00
Thomas Gelf 49c679fe0f FilterEditor: hide "add" links 
They where there to show how this should look like. Removed for now as
they are not implemented yet.

refs #6668
 2014-07-08 17:21:36 +02:00
Johannes Meyer bb2c85f90b Remove forgotten ActionController::requiresConfig() call 
Should have been reverted by last commit but was not.
 2014-07-07 16:12:26 +02:00
Johannes Meyer 82d2f5ac9b Revert "Merge branch 'feature/install-wizard-6136'" 
This reverts commit 88d4262e7c, reversing
changes made to 6fae333048.

Conflicts:

	application/controllers/InstallController.php
	library/Icinga/Web/Controller/ActionController.php
 2014-07-07 15:09:03 +02:00
Thomas Gelf 0d4166b1bd ModuleActionController: fix reference, var removed 2014-07-04 12:39:23 +02:00
Thomas Gelf 3cfdf4c977 Web\Response: add redirection function 
The response now provides redirectAndExit(). One more step to clean up
our action controller. Please not that this is still unused right now.
 2014-07-04 12:35:33 +02:00
Thomas Gelf 3772b9c16f ActionController: set layout module name early 
Didn't work correctly before
 2014-07-04 12:33:49 +02:00
Johannes Meyer 143a1e44fe Add a HTML renderer for Icinga\Web\Menu 
The menu was being rendered through recursive partials before. The
overhead this fact implicates is not as efficient as standard recursion
so there is now a special renderer for Icinga\Web\Menu utilizing
the RecursiveIteratorIterator

refs #6153
 2014-07-03 15:46:46 +02:00
Johannes Meyer be18af7e7e Merge Icinga\Web\MenuItem into Icinga\Web\Menu 
We do not need an additional class for the menu's root item just to
encapsulate our config handling, so these two classes were now merged
into a single one. Icinga\Web\Menu now also extends from
RecursiveIterator to be able to render the menu more efficient to html.

refs #6153
 2014-07-03 15:14:47 +02:00
Johannes Meyer 7eb0f3c472 Remove @codingStandardsIgnoreStart/-Stop annotations 
refs #6091
 2014-06-30 13:59:58 +02:00
Johannes Meyer f2e5d8afa5 Remove @codeCoverageIgnoreStart/-Stop annotations 
refs #6091
 2014-06-30 13:58:37 +02:00
Thomas Gelf 62928c48b0 helpers/timeSince: fix c&p error 2014-06-27 23:37:39 +02:00
Thomas Gelf 7112ed23f4 Chart\InlinePie: locale-ignorant cast for floats 
This has already been fixed with 92f454c3 and got broken again with be0c5d4b.
Time for a regression test I guess.

refs #6348
 2014-06-25 22:13:19 +02:00
Thomas Gelf 10d1520711 Widget\Limiter: show "all" 
In case we pass limit=0 we show this, still unsure whether we should
provide a link for "showing all" - might really hurt with millions of
history rows.
 2014-06-25 20:39:10 +02:00
Thomas Gelf 59dd80ed32 ActionController: benchmark should measure rendering 
We have been cheating a little bit, now the measurement should be more
precise.
 2014-06-25 20:37:17 +02:00
Matthias Jentsch d49f30ff77 Improve InlinePie performance 
Use str_replace instead of preg_replace
 2014-06-25 15:24:53 +02:00
Matthias Jentsch 7b19bd1d99 Improve interface of InlinePie 
Method setLabel can also accept a simple string and title is mandatory in constructor
 2014-06-25 15:21:12 +02:00
Matthias Jentsch 8839166090 Add number format 'none' to InlinePie 2014-06-25 14:53:39 +02:00
Matthias Jentsch 35a5431512 Revert "Refractor InlinePie and Perfdata helper" 
This reverts commit f003c38abd.
 2014-06-25 14:29:17 +02:00
Matthias Jentsch f003c38abd Refractor InlinePie and Perfdata helper 
Refractor InlinePie methods for better usability, fix several coding guideline
issues and fix some typos
 2014-06-25 12:41:17 +02:00
Thomas Gelf 4591297e56 SortBox: use POST instead of GET 
This avoids trouble with complex filter URLs

fixes #6556
 2014-06-25 11:00:10 +02:00
Thomas Gelf 1dcf44b9cd FilterEditor: fix buggy dropdown boxes 
There were some issues with option names. Also cleaned up HTML a
little bit and added autosubmission.
 2014-06-25 10:37:06 +02:00
Thomas Gelf b40d0f6a1e FilterWidget: POST instead of GET 
Might have been a JS issue, but instead of messing with the URL just
POSTing is easier here - and works. Filters from the search box are
now added flawlessly to the filter tree.
 2014-06-25 10:34:09 +02:00
Thomas Gelf 2746b5ff9f ConfigController: switch over to new config tabs 
Module configuration now takes place in module detail view and does no
longer pollute our config tabs. Modules are now able to provide a bunch
of own config tabs, we don't really care what they use them for.
 2014-06-24 21:31:59 +02:00
Thomas Gelf b38bcfc19b Widget\FilterEditor: correct expression output 
Filter expressions should be filled into form fields exactly as we
expect them at parse time.

fixes #6568
 2014-06-24 21:00:01 +02:00
Thomas Gelf 47b893e1ea Widget\FilterEditor: handle custom vars 
There was an issue with custom vars as they made only partially part
of the column dropdown. Sorted columns and tried to beautify column
names.

fixes #6569
 2014-06-24 20:57:41 +02:00
Thomas Gelf 3f9f4bb9e1 ModuleActionController: module object shortcut 
This helps modules with the need to know more about themselves. No
more App -> Module Manager -> Module voodoo.
 2014-06-24 20:54:39 +02:00
Thomas Gelf b7b99cfd67 Widget\AlertMessageBox: fix broken widget 
This widget is pretty useless as the error view script can to it's
job. Interestingly nobody missed it, even the render() call was wrong.

I guess we will remove this soon, but for now it's fixed. Looks ugly,
but works.
 2014-06-24 20:30:41 +02:00
Thomas Gelf ba9a633b73 Web\Form: relax form submission check 
We have to live with some badly designed forms right now. Some have
submit buttons but don't know about, others don't have such but link
to foreign controllers fiddling with the form and adding different
button AFTER the form got submitted - it's a mess.

Relaxing the submission check to "just check whether btn_submit has
a value" fixes most of this. However I do not consider this being a
solution for the long run.

fixes #6423
fixes #5967
refs #6540
 2014-06-23 13:31:34 +02:00
Thomas Gelf ea44de8698 ActionController/translate: detect domain only once 2014-06-22 20:09:23 +02:00
Thomas Gelf 23ed744747 params/_render: replace it everywhere 
Cleaning up controllers and JS, using headers only and respecting
history.
 2014-06-22 20:07:44 +02:00
Thomas Gelf 61600ae2d4 ModuleActionController: fix typo 2014-06-22 19:39:54 +02:00
Thomas Gelf 997587d729 Chart\InlinePie: remove ugly default border 2014-06-22 16:38:12 +02:00
Thomas Gelf 216f0f3f55 isIframe: clean up, load less html and js 
We use isIframe only when we have no JS, therefore it makes no sense
to load JS files in an iFrame. Also removed sidebar.
 2014-06-22 16:30:06 +02:00
Thomas Gelf 3b84078b2f Params/_render: get rid of it, start with iframe 2014-06-22 16:18:23 +02:00
Thomas Gelf bb23d0636c ModuleActionController: use isXhr() 2014-06-22 16:04:55 +02:00
Thomas Gelf 3774eb6889 ActionController: add isXhr() method 
Makes things easier as we use this a lot
 2014-06-22 15:36:41 +02:00
Thomas Gelf 331d756a2a ActionController: isolate ignoreXhrBody 
This function is only a workaround for broken forms not redirecting
after submission. Will hopefully be removed soon.
 2014-06-22 15:33:38 +02:00