Johannes Meyer
2cf09ebc48
Revert "LdapResourceForm: Validate the host field and do not require a port"
...
This reverts commit a34d6026b3
.
refs #7990
2015-03-11 08:00:20 +01:00
Johannes Meyer
a34d6026b3
LdapResourceForm: Validate the host field and do not require a port
...
fixes #7990
2015-03-10 15:03:48 +01:00
Johannes Meyer
d0383a241e
Use date and mktime instead of cal_days_in_month to count a month's days
...
fixes #8637
2015-03-10 12:30:22 +01:00
Louis Sautier
083c1a9e6b
Fix some spelling errors in comments and messages
...
fixes #8633
Signed-off-by: Gunnar Beutner <gunnar@beutner.name>
2015-03-08 15:32:22 +01:00
Johannes Meyer
6cfa958bb8
Allow setting `requirement' on form elements
...
It's supposed to be used as description what
kind of value an element will accept.
refs #7947
2015-03-06 08:53:34 +01:00
Johannes Meyer
b9811f8590
Form: Do not set the requiredSuffix as option but use its virtual setter
...
This removes the invalid attribute on each <label> tag once the
FormDescriptions decorator removes the suffix.
refs #7947
2015-03-05 15:13:38 +01:00
Johannes Meyer
b8eedc21bb
Form: Explicitly set subform decorators
...
refs #7947
2015-03-05 15:12:02 +01:00
Johannes Meyer
764f125778
Make the FormDescriptions decorator able to handle sub forms
...
refs #7947
2015-03-05 15:08:30 +01:00
Johannes Meyer
ff263946c8
Form: Fix translation domain detection while running unit tests
2015-03-04 09:38:00 +01:00
Johannes Meyer
e2887df03e
Form: It's a field, not a control
2015-03-03 15:01:09 +01:00
Johannes Meyer
8510835fba
Fix accessibility of the Autosubmit decorator when applied to a form
...
refs #7935
2015-03-03 14:35:46 +01:00
Johannes Meyer
c2339d156b
Improve aria-hidden handling in the icon and img view helper
2015-03-03 14:35:41 +01:00
Johannes Meyer
747e51553e
Allow the Autosubmit decorator being used on forms as well
...
refs #7935
2015-03-03 13:33:26 +01:00
Johannes Meyer
642fa44fce
Move a form's title into the markup of its form
2015-03-03 09:53:25 +01:00
Johannes Meyer
b1d0c12df3
Form: Introduce setTitle() as alias for Zend_Form::setDescription()
2015-03-02 18:40:46 +01:00
Johannes Meyer
ad288c08ca
Form: Add the Description decorator by default for native title support
2015-03-02 18:40:46 +01:00
Johannes Meyer
cbd061aa41
Fix that the FormDescriptions decorator does not ignore Notes and Buttons
2015-03-02 18:40:46 +01:00
Johannes Meyer
1eacaa4c48
Improve the display of the text cue on required form elements
...
Shows just a message at the top of the form if all elements are required
and a explaining message what the cue is standing for otherwise.
refs #7934
2015-03-02 13:48:35 +01:00
Johannes Meyer
1a334f8d64
Add decorator FormDescriptions
...
This decorator displays a list of messages at the top of a form.
refs #7947
2015-03-02 13:45:24 +01:00
Johannes Meyer
7bb78330a9
Replace cancel icon with the trash icon...
...
...where the link's purpose is to remove something
2015-02-27 14:47:46 +01:00
Johannes Meyer
74dfa6e72a
Fix invalid icon names passed to the icon view helper
2015-02-27 14:45:47 +01:00
Johannes Meyer
96c132908d
Provide a warning on autosubmit form elements and a title for the apply btn
...
resolves #7935
2015-02-27 13:09:13 +01:00
Johannes Meyer
4f0bddd7da
Do not add aria-label to icons and images with titles if aria-hidden is set
2015-02-27 12:12:24 +01:00
Johannes Meyer
82017da85f
Help: Do not protect form element ids twice
2015-02-27 09:20:15 +01:00
Johannes Meyer
c00e336ea8
Make the cue that is being appended to required form elements configurable
...
refs #7934
2015-02-27 09:08:05 +01:00
Johannes Meyer
48c3199a2d
Form: Fix id protection
...
Altering element ids upon rendering makes it impossible to reference
them elsewhere. Zend_Form::getId() should be preferred over getName()
as it falls automatically back to getName() in case there is no id attribute
set. Setter are required to return their instance. Overwriting methods
without calling the parent (getId) without any valid (or at least
documented) reason is very bad practice.
refs #8460
2015-02-27 09:01:46 +01:00
Johannes Meyer
6d81a194ab
Make form element descriptions accessible
...
Re-added the Help decorator to make sure an element's description
is being added in an accessible way.
2015-02-27 08:10:25 +01:00
Johannes Meyer
0111fdf78e
Add an asterisk suffix to a form element's label if its required
...
The screen reader part "(required)" is not being considered with this
commit as most screen readers do not need this due to the ARIA and
HTML5 property.
resolves #7934
2015-02-26 16:05:13 +01:00
Matthias Jentsch
89451f3086
Ensure that form ids are unique
...
Add an unique prefix to each Form- or FormElement id, unless id protection is disabled explicitly, to prevent id collisions between different containers.
fixes #8460
2015-02-25 18:00:28 +01:00
Alexander Fuhr
cc403806f7
Fix refresh accessibility lable if it is empty
...
refs #7968
2015-02-25 15:28:09 +01:00
Alexander Fuhr
08ace05ac7
Remove animations.css from StyleSheet loading lessFiles
...
refs #7968
2015-02-25 13:56:32 +01:00
Alexander Fuhr
7f883a4770
Add own animation.less to provide own parameterized animate function
...
refs #7968
2015-02-25 13:51:26 +01:00
Alexander Fuhr
3a2b69a63c
Remove refreshTab property from Tabs
...
refs #7968
2015-02-25 13:24:11 +01:00
Alexander Fuhr
e219bb1664
Add doc for the label
...
refs #7968
2015-02-25 13:13:22 +01:00
Alexander Fuhr
481c58ec03
Add accessibility to renderRefreshTab
...
refs #7968
2015-02-25 12:14:26 +01:00
Alexander Fuhr
5297b15a61
Merge branch 'master' into feature/refresh-control-7968
2015-02-24 14:41:09 +01:00
Johannes Meyer
d68c636359
Wizard: Disable the browser's form validation when navigating back
...
formnovalidate... The fukin awesomeness of HTML5 is sometimes
even impressing a god-damned h4x0r like me.
fixes #8507
2015-02-24 13:16:31 +01:00
Johannes Meyer
8e8bab0795
Do only escape a qlink's label manually if necessary
2015-02-24 11:35:25 +01:00
Johannes Meyer
956efe5ef9
Merge branch 'master' into feature/link-labels-8458
...
Conflicts:
application/views/scripts/config/application.phtml
application/views/scripts/config/module.phtml
application/views/scripts/config/modules.phtml
library/Icinga/Web/Widget/Dashboard/Dashlet.php
modules/monitoring/application/controllers/TimelineController.php
2015-02-24 08:42:36 +01:00
Johannes Meyer
b626a96e16
Add aria-label to each box of the event grid
...
refs #8458
2015-02-23 17:14:40 +01:00
Johannes Meyer
fb7640db0a
Add proper titles to the Limiter control
...
refs #8458
2015-02-23 17:06:01 +01:00
Johannes Meyer
b2f817925b
Add proper titles to the FilterEditor
...
refs #8458
2015-02-23 17:05:39 +01:00
Johannes Meyer
66305bd79a
Add proper titles to dashboards and dashlets
...
refs #8458
2015-02-23 17:05:02 +01:00
Johannes Meyer
a5514392db
Adjust dashboard, output-format and module tabs
2015-02-23 17:03:11 +01:00
Alexander Fuhr
aa5c52dfdd
Implement content refresh control next to dropdown tab
...
refs #7968
2015-02-23 17:02:44 +01:00
Johannes Meyer
9fb3dcabea
Introduce Icinga\Web\Widget\Tab::$label as alternative for $title
2015-02-23 16:48:02 +01:00
Johannes Meyer
f6ea02fec5
qlink: Allow passing null as default for $properties
2015-02-23 16:29:07 +01:00
Marius Hein
4cdc1313cf
Dashlet: Add titles to iframe title attribute
...
resolves #8459
2015-02-23 16:20:08 +01:00
Marius Hein
2dda3be87b
Merge remote-tracking branch 'origin/master' into feature/organize-headings-7976
2015-02-23 14:28:48 +01:00
Marius Hein
03160ef81a
Header: Add header to event history
...
Add header to the following widgets:
- FilterEditor
- SortBox
refs #7976
2015-02-23 14:23:56 +01:00
Matthias Jentsch
2992bf3445
Always display tooltips in all charts
...
Make information about data types available to colorblind, when hovering
over the displayed data set
fixes #8364
2015-02-18 13:21:42 +01:00
Marius Hein
d3c79dae32
Merge branch 'master' into feature/organize-headings-7976
2015-02-17 15:21:29 +01:00
Johannes Meyer
9c5d44caf0
Fix that webkit submits datetime values not according to RFC 3339
...
That's actually more of a workaround instead of a fix as the bug itself
is part of webkit, not Icinga Web 2.
fixes #8457
2015-02-17 12:50:11 +01:00
Alexander Klimov
43691f6612
Drop BasketAction as it's not used anywhere
2015-02-16 14:37:54 +01:00
Alexander Fuhr
7be134a774
Merge master fixed conflicts
2015-02-16 11:24:15 +01:00
Johannes Meyer
5321c2f9e5
Mute icons properly using the new automatic mechanisms of our view helpers
...
refs #8360
2015-02-16 10:52:42 +01:00
Johannes Meyer
243bc6ec0c
Make the view helpers qlink, img and icon handle aria-tags automatically
...
refs #8358
refs #8360
2015-02-16 10:26:03 +01:00
Alexander Fuhr
2112676594
Implement hidden accessible control for auto refresh on the page
...
refs #7945
2015-02-13 14:34:29 +01:00
Marius Hein
ce3a564de7
Header: Add header to tabs extension
...
refs #7976
2015-02-13 11:26:09 +01:00
Alexander Fuhr
b9c9f564ec
Add editable auto_refresh parameter to the user preferences
...
refs #7945
2015-02-12 15:12:10 +01:00
Johannes Meyer
9232c5cf22
Add aria-hidden="true" to all icons that exist only for design reasons
...
refs #8360
2015-02-12 13:49:31 +01:00
Marius Hein
09349288e1
Merge branch 'master' into feature/skip-content-7933
2015-02-12 13:14:56 +01:00
Marius Hein
b6daf2237d
Menu: Add html5 nav element to menu
...
refs #7933
2015-02-12 13:14:01 +01:00
Johannes Meyer
9e933d835d
Add Icinga\Web\Form\ErrorLabeller
...
refs #8415
2015-02-12 09:11:03 +01:00
Johannes Meyer
aa473fb8cf
Standardize path validators according to Zend's validators
...
refs #8415
2015-02-12 09:11:02 +01:00
Johannes Meyer
a2f3e7d4f7
Display an error in case a user inputs an invalid formatted datetime string
...
resolves #7975
2015-02-12 09:11:02 +01:00
Johannes Meyer
a630db93e8
Show proper examples in case a user doesn't enter a permitted/correct val
...
resolves #7973
2015-02-12 09:11:02 +01:00
Johannes Meyer
eb3063e36d
Form: Add prefix path for custom form validators
...
refs #8415
2015-02-12 09:11:02 +01:00
Eric Lippmann
97261cd8bd
lib: Do not setLayout('pdf') twice
2015-02-11 15:15:18 +01:00
Eric Lippmann
ec8a89b96e
lib: Add recursive iterator over a DOMNode
2015-02-11 13:20:01 +01:00
Johannes Meyer
c5b6d7ee41
Ensure that all required form elements are marked as such in HTML markup
...
refs #8349
2015-02-05 13:15:18 +01:00
Eric Lippmann
6bae2e0a53
Note that our license is GPL v2 or any later version in our license header instead of pointing to the license's URL
2015-02-04 10:52:27 +01:00
Eric Lippmann
49e96b7200
Revert "monitoring/security: Guard delete comment action"
...
This reverts commit 4ef5f0c813
.
2015-02-03 16:51:00 +01:00
Matthias Jentsch
e8466ec7be
Fix inlinePie borders and SVG sizes
...
Add white border to inline piecharts in the list, to make them more visible on mouse hovering. Set a default image size for the loaded svg charts.
2015-02-03 16:46:12 +01:00
Eric Lippmann
5b4fab0750
Add license header
...
This time without syntax errors hopefully :)
2015-02-03 16:27:59 +01:00
Eric Lippmann
5fa2e3cfdc
Revert "Add license header"
...
This reverts commit 338d067aba
.
2015-02-03 16:16:26 +01:00
Eric Lippmann
4ef5f0c813
monitoring/security: Guard delete comment action
2015-02-03 16:11:56 +01:00
Eric Lippmann
338d067aba
Add license header
...
fixes #7788
2015-02-03 15:51:04 +01:00
Eric Lippmann
08fd000496
Remove any topbar related stuff
...
It's not used anywhere.
2015-02-03 12:42:02 +01:00
Markus Frosch
cb08b25e17
Remove executable flags from some PHP libraries
...
Note: dompdf.php is actually a CLI script, but has no shebang and is not used
in Icingaweb2.
Fixes #8345
2015-02-03 10:50:50 +01:00
Thomas Gelf
f8c5bf6819
Web\Hook: support hook base classes in modules
...
refs #8207
2015-02-02 17:44:29 +01:00
Thomas Gelf
3596e7ce62
FilterEditor: use preserved params
...
fixes #7904
2015-02-02 17:07:54 +01:00
Eric Lippmann
9d6906bd64
Save user dashboards to Icinga Web 2's configuration directory
...
fixes #8056
2015-02-02 15:06:29 +01:00
Eric Lippmann
5a1ebf9c89
lib: Implement Tab::getUrl()
2015-02-02 14:16:26 +01:00
Johannes Meyer
bf470125c3
Merge branch 'master' into feature/create-missing-directories-when-creating-inis-8219
...
Conflicts:
modules/monitoring/library/Monitoring/MonitoringWizard.php
2015-01-30 16:21:42 +01:00
Eric Lippmann
df29dd0e7c
Implement Form::hasPermission() and Form::getPermission()
2015-01-30 09:35:01 +01:00
Eric Lippmann
2faf5f0ca1
Throw SecurityException in ActionController::assertPermission()
2015-01-30 09:34:19 +01:00
Johannes Meyer
63305fdf9a
Add Icinga\Application\Config::saveIni()
...
Simplifies saving INI files. Icinga\File\Ini\IniWriter does already require an
instance of Icinga\Application\Config so it's obvious to give "Config" the
task to initialize the writer.. We do also have a central place to handle
creating missing ancestor directories now.
refs #8219
2015-01-30 09:32:08 +01:00
Marius Hein
dd483d98df
LessCompiler: Remove useless argument
...
refs #6417
2015-01-29 14:04:47 +01:00
Marius Hein
c1df1f822e
ifont: Reorganize files and drop use less attributes
...
fixes #6417
2015-01-29 11:25:37 +01:00
Marius Hein
4abb30e55b
Merge branch 'master' into bugfix/ie8-fixes-6417
2015-01-28 17:08:56 +01:00
Marius Hein
9d05190517
ifont: Fix empty font glyphs for IE8
...
The embedded font is included inline in the stylesheets. IE falls back and
tries to load one of the other font sources which was not exported by the web
server. This fix moves the fontello directory to public and add add a
prefix path to the embedded stylesheet.
refs #6417
2015-01-28 17:06:55 +01:00
Johannes Meyer
6fde4eec30
Show all tabs except "Add to Dashboard" when issuing a command
...
refs #8279
2015-01-28 12:50:29 +01:00
Eric Lippmann
cd8822ceff
lib: Add View::hasPermission()
2015-01-23 09:36:45 +01:00
Eric Lippmann
6da3cb8403
lib: Reorder auth related functions in the ActionController
2015-01-23 09:36:05 +01:00
Eric Lippmann
ef0a7c0e77
Revert "Security: Temporary grant all permissions"
...
This reverts commit 9b7e75a616
.
Patching function hasPermission is not enough. A fix will follow.
2015-01-22 17:11:53 +01:00
Eric Lippmann
0f13c0428c
Controller: Introduce method assertHttpMethod()
...
We have actions where only certain HTTP methods, e.g. POST are allowed but they are not restricted yet.
Controller::assertHttpMethod() takes a number of allowed HTTP methods and responds with HTTP 405 in case
the current request's method is not one of the given methods.
2015-01-22 15:47:16 +01:00
Eric Lippmann
9b7e75a616
Security: Temporary grant all permissions
...
We'll introduce permissions and restrictions in the next hours. Because our web setup
does not configure permissions yet, all permissions are granted for all users from now on.
2015-01-22 15:20:38 +01:00
Johannes Meyer
94d727dbb8
Fix error in Icinga\Web\Form in case the label decorator is missing
...
Zend_Form::getDecorator() returns false instead of null in case the
decorator is not found.
2015-01-22 09:21:50 +01:00
Johannes Meyer
10eacf9682
Allow jumping to already visited pages
...
This was already possible using just the base implementation of Wizard
but since WebWizard has optional pages it did not work with pages that
had such an optional page as previous page.
refs #8191
2015-01-21 15:39:06 +01:00