a42668edb8
Fix tests
...
refs #4663
2013-10-09 09:20:17 +02:00
b89d61add3
Monitoring: Refactor data views (WIP)
...
refs #4663
2013-10-09 09:20:16 +02:00
ec2ffcabdf
Add redirection to AuthenticationController
...
refs #4670
2013-10-04 15:43:02 +02:00
c6838f67a1
Icinga/Chart: Fixes typo, doc, interfaces, inspection warnings
...
refs #4614
2013-09-25 16:32:28 +02:00
7690b0ec7f
Add basic tests and meta attributes for graphs
...
refs #4614
2013-09-25 14:24:26 +02:00
b78d1a236a
Finish graphing library and add documentation
...
refs #4614
2013-09-25 14:24:26 +02:00
45bf37b085
Add library/Icinga/Chart skeleton
...
refs #4614
2013-09-25 14:24:26 +02:00
e7696bec89
CS: Fixes for controllers: Static, Action, List and Show
...
refs #4611
2013-09-24 12:52:00 +02:00
b4000d34fb
CS: Fixed styles, add codingStandardsIgnore for helper
...
refs #4611
2013-09-23 13:56:59 +02:00
6d26240d6d
Add Main detail state to url, renderhelper, container tests
...
- The ActionController is now able to render a seperate detail view
- All list scripts select the currently active row from the detail view with
the 'active' class
- Autosubmit is now again attached to the onchange attribute (to prevent issues
when js can't load correctly)
- Logout is now recognized and causes a page refresh (will be made more generic)
- Add history mock for testing url changes
- Update all grids to implement the app/mainDetailGrid component
refs #4611
2013-09-23 13:56:57 +02:00
24f64e6d30
Fix conflicts from rebase, using inet_aton with pgsql, PHP strict standards violations, CS compliance
...
refs #4255
2013-09-17 15:12:18 +02:00
c9ce7c53b0
Paginator may be ready for QueryInterface
2013-09-17 10:46:32 +02:00
c75a83d1d2
PDF fixes
2013-09-17 10:46:32 +02:00
2ff5455018
First attempt to write a backend-independent Pivot-Table implementation
2013-09-17 10:41:02 +02:00
dc34905315
Moved Data\Array to DataArray
2013-09-17 10:36:04 +02:00
1eb0fcdff8
AbstractQuery implements QueryInterface, added addColumn, fixed sort
2013-09-17 10:36:04 +02:00
86945152b4
QueryInterface, initial commit
2013-09-17 10:36:04 +02:00
1d1214b8b9
Implemented conservative count, implemented count 'cache'
2013-09-17 10:36:04 +02:00
0f48d0e2d6
Added fetchColumn, it was missing
2013-09-16 17:02:30 +02:00
103ed266c5
Typo
2013-09-16 17:02:30 +02:00
3908974698
We need to set Db fetchMode as it has previously been done
2013-09-16 17:02:30 +02:00
d181e8018b
Prefs fail if configDir is not writable
2013-09-16 16:51:54 +02:00
4237e3e53e
modules/README triggers pointless warning
2013-09-16 16:38:51 +02:00
72df979791
Zend_Db::FETCH_MODE is not available before ZF 1.11 (ZF-6620)
...
* TODO: Check whether passing 'fetchMode' really works?!
2013-09-16 16:38:50 +02:00
f76f5b1c1d
Command: Fix docstring for excludeHost
...
refs #4580
2013-09-16 14:59:45 +02:00
8baa2dec54
Command: Rename getParameters to getArguments
...
refs #4580
2013-09-16 14:46:18 +02:00
a47db3497e
Rename BaseCommand to Command
...
refs #4580
2013-09-16 14:44:59 +02:00
bf012fbd7e
Remove CommandType interface
...
Moved BaseCommand from the monitoring module to the application's library.
refs #4580
2013-09-16 14:39:14 +02:00
7045148f93
Adjust submitpassivecheckresult command handling
...
refs #4580
2013-09-16 13:14:29 +02:00
fef8370d5f
Adjust reschedulecheck command handling
...
refs #4580
2013-09-16 13:14:28 +02:00
e9dc895b37
Adjust delay notification handling
...
refs #4580
2013-09-16 13:14:28 +02:00
36424b508b
Adjust custom notification handling
...
refs #4580
2013-09-16 13:14:28 +02:00
ba7f455643
Adjust schedule downtime handling (WIP)
...
refs #4580
2013-09-16 13:14:28 +02:00
8022bf57af
Some doc fixes and other improvements
...
refs #4580
2013-09-16 13:14:28 +02:00
cabe2ccbee
Widget/Tabs: Show caret
2013-09-05 14:15:29 +02:00
a5908c9553
CS: Replace multiple empty lines with one
...
find application/ library/Icinga/ test/ modules/ -name *.php | xargs sed -i '/^$/N;/^\n$/D'
2013-09-04 18:36:10 +02:00
b5e93afd86
CS: Add newline at end of file
...
find application/ library/ test/ modules/ -name *.php | xargs sed -i '$a\'
2013-09-04 18:28:35 +02:00
35fd9fd391
CS: Remove whitespaces at end of line
...
find application/ library/ test/ modules/ -name *.php | xargs sed -i 's/\s\+$//'
2013-09-04 18:27:16 +02:00
95e9117325
Fix SortBox not keeping Sort By input after submission
2013-09-04 18:21:10 +02:00
7f4e1936f7
Fix trigger downtime default value issing, docstring fixes
...
refs #4580
2013-09-04 18:08:00 +02:00
b74e264f01
Refactor comment command handling
...
- Refactored Comment class
- Dropped IComment interface
- Added AddCommentCommand class
- Updated CommentForm
refs #4580
2013-09-04 18:08:00 +02:00
9a476f16f4
Re-refactor dispatch process of commands and acknowledgement handling
...
refs #4580
2013-09-04 18:08:00 +02:00
79eb6588c5
Restructure dispatch process of commands
...
refs #4580
2013-09-04 18:07:59 +02:00
05d08fb0b8
Fix Bootstrap typed wrong
...
refs #4601
2013-09-04 17:12:44 +02:00
b1df9fa67d
Readd import in BaseTestCase that got lost during rebase
...
refs #4601
2013-09-04 15:22:01 +02:00
d27e34cef8
Codestyle and Test fixes for SortBox
...
refs #4601
2013-09-04 15:22:00 +02:00
57e66c247a
Add sort widget, change js path from module to app, small style fixes
...
refs #4601
2013-09-04 15:22:00 +02:00
6afeaac6b2
Make 'ini' in descriptions uppercase, add comment to index.php about date_default_timezone_set
...
refs #4529
2013-09-04 14:56:55 +02:00
c9673bfea3
Catch database errors, set fallback tz
...
The fallback timezone is set in case an error occurs
before setupTimezone() is entered. In this case the user
is presented with an warning about missing timezone settings
if the php.ini doesn't contain timezone information
refs #4529
2013-09-04 14:27:37 +02:00
95bc8a2f4f
Add NullStore as preference fallback
...
refs #4529
2013-09-04 14:27:37 +02:00
1b858cbdb4
Monitoring: Fix remaining usages of namespace Monitoring without Icinga\Module prefix
...
refs #4586
2013-09-04 11:21:12 +02:00
6f383abdd1
Tests: Let the BaseTestCase require db and form libraries once it's being required
...
Further add function t() and mt() to the global namespace when requiring BaseTestCase
refs #4586
2013-09-04 11:21:12 +02:00
74b9731df5
Remove auto class requirement from BaseTestCase::createForm()
...
The tests for the respective forms must require the form class.
refs #4586
2013-09-04 11:21:12 +02:00
092c5780ea
CS: Fix violations for overdue files
...
refs #4586
2013-09-04 11:21:12 +02:00
03f081ce33
Module/Autoloader: Register Icinga\Module\<module> namespace
...
refs #4586
2013-09-04 11:21:11 +02:00
a0e63a1320
Fix error message and move validation in own DateTimeValidator
...
refs #4581
refs #4632
2013-09-04 11:06:36 +02:00
23f0962da1
Adjust command forms and tests
...
Made those command forms using the DateTimePicker
element compatible with its new validation.
refs #4581
2013-09-03 09:27:02 +02:00
368bd3c9c7
Refactor datetime validation
...
The DateTimePicker form element needs to know from now on,
how user input can be formatted when validating.
refs #4581
2013-09-03 09:27:02 +02:00
1a003f8c8b
Move configuration and preference handling to Form base class
...
Moved setConfiguration, setUserPreferences and getUserPreferences
to our Form base class due to some redundancies.
refs #4581
2013-09-03 09:27:02 +02:00
b09b3676de
Rename determineAuthenticationState to requiresLogin
...
refs #4572
2013-09-02 18:42:05 +02:00
9f923b4940
Fix pagination and remove ModuleController, rename handlesAuth
...
This commit introduces the following changes:
- Count is now performed after joins are added to the selection query,
therefore returning the correct number
- MonitoringControllerTest now needn't to mock ModuleActionController (which is now removed)
- handlesAuthentication is now requiresAuthentication
- Redirection to login is now directly handled in the ActionController constructor,
so we don't need to overwrite the preDispatch method
refs #4589
refs #4591
refs #4572
2013-09-02 18:42:05 +02:00
aac1d69ed2
Fix count query ignoring joins
...
Count queries were created before the required columns were added,
so they often returned more values than a resultset really offers
refs #4589
2013-09-02 18:42:05 +02:00
b99b9a7ca8
ModuleManager: Throw module dir exceptions later
...
This is important for bootstrap to detect configuration
errors.
refs #4604
2013-09-02 12:52:51 +02:00
b6eb19ce6a
Module enable/disable: Better error messages
...
refs #4604
2013-09-02 12:52:51 +02:00
439fade88d
Simplify SystemPermissionException
...
refs #4606
2013-09-02 12:52:51 +02:00
18d021d104
Fix logger not testing if it's disabled
...
refs #4595
2013-09-02 12:16:05 +02:00
c5fde2324e
Generalize form handling in Icinga\Web Form & Tests
...
configForm.js is now form.js and applied on all forms,
the autosubmit is now a special attribute for input fields,
so the PHP code doesn't create JS snippets anymore
refs #4622
2013-09-02 10:59:05 +02:00
978b3519f6
Add configform js component (will be renamed later)
...
refs #4622
2013-09-02 10:59:05 +02:00
446da85a88
UserBackend: Fix interface in test
...
refs #4593
2013-08-30 15:32:06 +02:00
e2e744a424
Fix authentication chain
...
refs #4593
2013-08-30 14:46:52 +02:00
845f181001
CS: Fix UserBackend interface
...
refs #4641
2013-08-30 12:50:57 +02:00
bed759d597
CS: Fix session classes
...
refs #4641
2013-08-30 12:50:57 +02:00
7765877318
CS: Fix LdapUserBackend
...
refs #4641
2013-08-30 12:50:57 +02:00
c77a48ff1f
CS: Fix DbUserBackend
...
refs #4641
2013-08-30 12:50:57 +02:00
7c8252a983
Rename class Credentials to Credential
...
refs #4641
2013-08-30 12:50:57 +02:00
83d20a6175
AuthManager: Fix tests
...
refs #4641
2013-08-30 12:50:28 +02:00
dfb7238b81
AuthManager: Implement backend chain
...
refs #4641
refs #4590
refs #4593
2013-08-30 12:50:28 +02:00
28bd27d904
Fix user preference access when not authenticated
...
refs #4609
2013-08-29 15:08:31 +02:00
f4272f482d
Apply user defined timezone during bootstrap
...
refs #4609
refs #4552
2013-08-29 15:08:31 +02:00
a82abbe2f6
Fix misplaced/redundant imports
...
refs #4648
2013-08-29 14:45:02 +02:00
7be7335bdd
Preferences: Fix error messages and convenience configuration
...
refs #4648
2013-08-29 14:45:02 +02:00
2c97ab26a4
Code style, Form tests and bugfixes
...
This commit summarizes the bugfixes made in this branch. As the frontend the fixes required a lot of stuff to be fixed afterwards and #4602 was used as a larger example regression test, this affects a few tickets:
- (Bug 4491) Frontend tests will hang randomly: CasperJS now operates on the installed version, so this shouldn't happen anymore
- (Bug 4602) Configuration Interface - Authentication: Backends moved when pushing enter: The authentication interface is reworked and does not persist a state over pages
- (Bug 4605) /tmp should not be the default log path: Now it is the application relative var/log path
- (Bug 4606) Configuration: Show message that changes were saved successfully: Implemented and tested with casperjs
- (Bug 4641) Installation/Testing fix configure/make: This has been reworked
- (Bug 4642) Allow Application placeholder in config: This was required for implementimg 4605
- (Bug 4643) Application doesn't work with older Zend Versions: A fallback __call has been implemented for this
refs #4491
refs #4602
refs #4605
refs #4606
refs #4641
refs #4642
refs #4643
2013-08-29 11:48:33 +02:00
ec359c76d8
Chmod after file creation
...
This allows the www-group to edit logs and preferences
refs #4491
2013-08-29 11:48:33 +02:00
3d3fa45838
Fix ActionController compatibility with older Zend Versions
...
refs #4643
2013-08-29 11:48:33 +02:00
0b515e39ac
Implement {app} placeholder and Icinga\Config::resolvePath()
...
refs #4642
2013-08-29 11:48:32 +02:00
d0ac97f335
Configure fixes, regression test for 4606
...
The configure routine still has to be improved, right now unused
authentication backends are commented out
refs #4491
refs #4606
refs #4640
2013-08-29 11:48:32 +02:00
4e41ce5cdc
Add logic validation for database authentication backends
...
refs #4546
2013-08-29 11:48:32 +02:00
17e6402aa9
Split up authentication form, logic connectivity check
...
refs #4606
refs #4622
refs #4602
refs #4546
2013-08-29 11:48:29 +02:00
4527aaf57a
Smaller fixes in phpdoc style
...
refs #4566
2013-08-28 14:42:31 +02:00
7fab739efd
Fix styles in Form.php
...
refs #4566
2013-08-28 09:08:37 +02:00
13e4efa221
Make use of the helptext decorator if suitable
...
Refactored some uses of the form element Note so that
each one is properly attached to its input element.
refs #4566
2013-08-28 08:57:46 +02:00
e3f9d1b6bd
Replace "\n" with PHP_EOL
...
refs #4615
2013-08-27 18:49:30 +02:00
874b163009
Fix comment padding and some coding-style issues in the test classes
...
refs #4615
2013-08-27 18:28:21 +02:00
5b58d5488b
Add support for section reordering and formatting options to the PreservingIniWriter
...
The PreservingIniWriter needs to be aware of the the order of the sections and
update the section declarations in the configuration file when the order has
changed. Therefore add functions to correctly reorder sections.
refs #4615
2013-08-27 18:28:21 +02:00
c5bea04909
BaseTestCase: User response, CS and typo
...
refs #4608
2013-08-27 10:37:35 +02:00
dc71885eac
Fix icinga application forms using BaseTestCase now
...
refs #4608
2013-08-26 13:25:20 +02:00
1130376ad6
BaseTest: Create class and tests
...
refs #4608
2013-08-26 11:15:27 +02:00
0c69dbf482
CS: Fix for DbAdapter, Auth/Manager and Preferences/DbStore
...
refs #4596
2013-08-26 11:09:37 +02:00
49cf62a9dc
Fix database related bugs
...
Fix coding standards in database schemes. Use DbAdapterFactory in all unit
tests instead of creating own adapters. Fix DbUserBackend and DbStore to use
FETCH_OBJ, instead of FETCH_ASSOC, to handle it consistently in the whole
application. Remove unnecessary table columns from the "account" scheme.
refs #4577
refs #4578
refs #4596
refs #4599
refs #4627
2013-08-26 11:09:37 +02:00
afc302d45c
Bootstrap: Safe application start
...
Log exceptions and inform user if something goes wrong.
refs #4625
refs #4592
2013-08-23 17:28:13 +02:00
2debc7826b
Deactivate group backend initializing
...
refs #4624
2013-08-23 17:28:12 +02:00
c65f9d51ee
Fix static preferences path overwriting configuration path
...
refs #4598
2013-08-23 17:28:12 +02:00
895976550c
Fix templates, capitalization and icons in php files
...
refs #4550
refs #4584
2013-08-23 10:28:48 +02:00
015a914aab
Fix template code style, use Bootstrap 3, remove icons
...
- Icons have now the {{XY_ICON}} format
- custom classes are removed
- A few typos are fixed
- Capitalization
refs #4550
refs #4621
refs #4584
2013-08-23 10:28:48 +02:00
dc2aad75d1
Modify application templates for proper bootstrap usage
...
refs #4550
2013-08-23 10:27:16 +02:00
d813ca62c5
Db: Set MySQL server SQL modes to behave closer to ANSI SQL
...
Was already implemented but someone dropped it accidentally
2013-08-21 14:40:37 +02:00
cd2ae0450a
Config: Hint that moduleFolder directive is currently not in use
...
refs #3776
2013-08-21 14:22:31 +02:00
8ac914b29a
Fix ActionController missing use Icinga\Web\Url
...
refs #3776
2013-08-21 14:22:31 +02:00
edb06ea8ea
CS: Fix viloations for touched files in branch feature/backend-configuration-ui-3776
...
refs #3776
2013-08-21 14:22:31 +02:00
83d053965f
Implement monitoring instance and backend configuration forms
...
refs #3776
2013-08-21 14:22:30 +02:00
4c5d26fe9a
Fix Codestyle/PHPDoc, fix configPath being Overwritten
...
Also removed possibility to disable debugging as there's no use case for this
refs #4525
refs #4598
2013-08-21 14:22:30 +02:00
a6ff6ecadd
Fix Codestyle/PHPDoc, fix configPath being Overwritten
...
Also removed possibility to disable debugging as there's no use case for this
refs #4525
refs #4598
2013-08-21 14:22:30 +02:00
972bc9853e
Configuration interfaces for logging, authentication and general configuration
...
- Added HelpText decorator
- Added Time and DateFormatValidator
- Added tests
refs #3777
2013-08-21 14:22:30 +02:00
4810a0d47e
Code style and test fixes
...
refs #3777
2013-08-21 14:22:29 +02:00
c705f5d475
Implement Authentication form
...
- Allow creation of authentication providers
- Allow modification of authentication providers
- Allow reordering of authentication providers
refs #3777
2013-08-21 14:18:54 +02:00
9ddc03d571
Implement General configuration form
...
Missing:
- Logical validation (check for writable paths)
- DB Resource selection (see #4503 )
refs #3777
2013-08-21 14:18:53 +02:00
26a5018d16
Add Forms and conditional hidden
...
refs #3777
2013-08-21 14:18:53 +02:00
dbae055e8e
Fix redirector to use relative url
...
refs #4516
2013-08-21 09:44:01 +02:00
4cdab8d904
Fix phpcs errors for Icinga\Web\Hook
2013-08-20 19:33:15 +02:00
0581d9a130
Fix phpcs errors for Icinga\Web\View
2013-08-20 19:26:44 +02:00
df6ccce6f2
Fix phpcs errors
2013-08-20 17:34:47 +02:00
3a8a3b8f2c
Monitoring backend: Change database objects to DbAdapterFactory
...
refs #4575
2013-08-19 18:29:26 +02:00
1b94eed945
Remove \Icinga\Backend class
...
refs #4575
2013-08-19 18:29:26 +02:00
3d3fbb123d
Monitoring/Commands: Add help messages to the custom notification form
...
refs #4524
2013-08-16 17:38:50 +02:00
7dc2f78b63
CS: Fix docstrings in Icinga/Web/Widget/* and Icinga/Web/Controller/ActionController.php
...
refs #4512
2013-08-16 15:08:28 +02:00
0b479e3796
Code style fixes, fix documentation, fix tab parameters not being overwritten
...
refs #4512
2013-08-16 15:08:28 +02:00
b28c7f2f4c
Refactor test, tabs and controller
...
- Remove unused methods,
- Code style
- Documentation for widgets
- Tabextensions instead of hardcoded tab actions
- Add tests for tabs
- Add missing phpdoc for touched files
- Fix tests
refs #4512
refs #4541
refs #4540
2013-08-16 15:08:28 +02:00
e6c57f029d
Fix code styling to comply with coding standard
...
refs #4503
2013-08-15 14:58:08 +02:00
7f30b587be
Change the StoreFactory to work with the DbAdapterFactory and fix code styling
...
Change the StoreFactory configuration to reference to a resource instead of
defining the whole database. Additionally fix docstrings, fix imports and fix
function calls to comply to coding style standards.
refs #4503
2013-08-15 14:16:34 +02:00
f1040aad60
Add additional functionality and documentation for easier use through developers
...
Add functions to get information about currently available resources and add
documentation about class usage for developers.
2013-08-14 16:22:58 +02:00
68deb735c0
Add the DbAdapterFactory to instanciate database adapters using resource names
...
Create the DbAdapterFactory to instanciate db adapters, add resources.ini to configure resources, change
the authentication Manager to fall back to backends with lower priority in case
of errors, update the current UserBackends to the changed environment. Also
adjust the documentation and existing unit tests.
resolves #4503
2013-08-14 16:22:58 +02:00
6d98b923ca
CS: Fix docstrings in Icinga/Application/Modules/Module.php and Manager.php
...
refs #4530
2013-08-14 16:08:15 +02:00
d604b01349
Fix missing Icinga\Application\Logger import in module manager
...
refs #4530
2013-08-14 16:08:15 +02:00
392e568bf8
Code style fixes: License header, phpdoc tags, psr-2 compliance
...
refs #4530
2013-08-14 16:08:15 +02:00
8c91410680
CS: Fix phpdoc tags indent in Icinga/Application/Modules/Module.php
...
refs #4530
2013-08-14 16:08:15 +02:00
be29b8ff8f
Make ConfigController and PreferenceController extensible by convention
...
- Rename ConfigurationController to ConfigController
- ConfigController and PreferenceController are now subclasses of
BaseConfigController and BasePreferenceController
- Module and Application Config/Preference Tabs are detected via
the ControllerTabCollector
- Moved Controller classes to Icinga/Web/Controller (this is why
so many files are modified)
refs #4530
2013-08-14 16:08:15 +02:00
7c1b11baa4
Fix a bug that causes a warning to be displayed when a section
...
declaration at line 0 is present
2013-08-14 15:05:10 +02:00
eecbc233b9
Fix behavior of PreservingIniWriter that caused comments at the line end to be deleted
...
Implement a function to fetch comments at line end and use it to preserve
comments. Change the regular expressions used to parse lines to be more aware
of whitespaces between terms. Add automatic value and comment indentation
to produce cleaner output.
2013-08-14 15:05:10 +02:00
4585bf2555
CC: Add missing docstrings to DateTimeFactory and DateTimePicker
...
refs #4440
2013-08-12 17:27:23 +02:00
bd140f2828
CC: Fix phpcs errors of files changed in feature/datetime-element-4440
...
refs #4440
2013-08-12 16:43:10 +02:00
2c217d1d06
Framework/DateTime: No longer use the Unix timestamp format since this ignores the time zone
...
refs #4440
2013-08-12 16:43:10 +02:00
9f22905837
Framework/DateTimePicker: Set element's value to Unix timestamp after the input is considered valid
...
refs #4440
2013-08-12 16:43:09 +02:00
5cb9c67443
Framework: Fix Form's docstrings
...
refs #4440
2013-08-12 16:43:09 +02:00
e95c604084
Framework: Fix typo in DateTimeFactory::setConfig
...
refs #4440
2013-08-12 16:43:09 +02:00
b4b51b9d46
Framework: Implement time zone aware DateTimeFactory
...
refs #4440
2013-08-12 16:43:09 +02:00
ba00fd39df
Framework: Get DateTimePicker's value as timestamp and add input validation
...
refs #4440
2013-08-12 16:43:09 +02:00
3122a75e73
Framework/User: getTimeZone now returns a DateTimeZone object instead of a string
...
refs #4440
2013-08-12 16:43:09 +02:00
da7f619804
Framework: Implement DateFormat view helper
...
Support date, time and datetime formatting based on format strings
set either by the user or via config.ini. The view helper
FormDateTime uses the new helper already
refs #4440
refs #4424
2013-08-12 16:43:09 +02:00
1f10cb3124
Framework: Rename DateTime form element to DateTimePicker
...
refs #4440
2013-08-12 16:43:08 +02:00
94ea09b552
Remove Date and Time form elements
...
Drops the Date and Time form element as they are redundant.
refs #4440
2013-08-12 16:43:08 +02:00
c0e3712e1b
Framework/Elements: Implement DateTime form element
...
refs #4440
2013-08-12 16:42:51 +02:00
8af901e9ed
Framework/User: Implement getTimezone to retrieve the user's Timezone
...
refs #4440
2013-08-12 16:42:50 +02:00
9170523afa
Application/Bootstrap: Throw Exception if timezone isn't valid
...
refs #4440
2013-08-12 16:42:50 +02:00
93ae6d6811
Framework: mv Icinga\Config\Config to Icinga\Application\Config
...
refs #4543
2013-08-12 15:02:25 +02:00
07717e9119
Fix codestyle
...
- return self insteead of return $this
- missing licence header in Dimension.php
refs #4192
2013-08-09 10:32:57 +02:00
886da7d0cb
Fix codestyle, change wrong 'dashboard' parameter to pane causing pane switching to fail
...
- Fixed concatenation
- Added license header where missing
- Fixed the index controller fetching the wrong parameter ('dashboard' instead of 'pane')
refs #4192
2013-08-08 17:42:34 +02:00
6e68826da6
Fix PSR compliance of code
...
refs #4192
2013-08-07 18:10:39 +02:00
488310df37
Fix style and docstrings, exception when removing the last tab
...
refs #4192
2013-08-07 17:45:09 +02:00
2b25757e20
Add documentation, add errorhandling and sizing
...
The optional width/height parameter can be set in the ini to change the dashboard components
size, documentation has been added and in the error case a message with the configuration is shown
refs #4192
2013-08-07 17:44:30 +02:00
f8bb478f0e
Update dashboard implementation
...
fix javascript naming (icinga-url to icingaurl), fix add form, add remove
button, code style changes
refs #4192
2013-08-07 17:43:37 +02:00
b3e0d5e8ce
Remove AbstractWidget and make Widget an interface
...
As Widget's already denote an abstract concept, the name
'AbstractWidget' is redundant. Also this class didn't do anything except
fetching a view via a singleton (which is now injected into the render method)
and bypassing the PHP class properties by creating a 'properties' array which is
filled with magic getters and setters (which now are simply php class properties)
Further changes:
- toString is removed, as this incorporated a lot of
application logic which would cause unrecoverable
errors when throwing exceptions
- renderToHtml is now just render and the view dependency must be
passed, as a widget shouldn't be responsible for getting
view instance (this means that <?= $this->tabs ?> is now
<?= $this->tabs->render($this); ?> in the templates
- Controllers don't have $this->widget anymore as Widgets are
directly instanciated with their class, allowing better code completion
and avoiding hidden dependencies, also Widget::create is now removed
in favor of direct instanciation.
refs #4192
2013-08-07 17:41:43 +02:00
57257d1af3
Fix coding standard violations
...
resolves #4352
2013-08-07 16:19:15 +02:00
76d7753860
Split up functions in PreservingIniWriter for better readabillity and add better comment handling
...
Split up the function diffPropertyUpdates into two single functions. Change the
IniEditor to "glue" comments to section declarations.
resolves #4352
2013-08-07 15:58:51 +02:00
c1338898a6
Fix errors in function comments and move IniEditor into single class file
...
refs #4352
2013-08-07 15:58:51 +02:00
56e47fd084
Add an ini writer for configuration files
...
Add an ini writer that respects the file structure and the comments that may be
already present in the config file. Move Application/Config.php into
Config/Config.php.
refs #4352
2013-08-07 15:58:42 +02:00
edebbf93ab
Add an IniWriter that preserves the comments in already existing files
...
Add a function to create diffs between two object, add a
FileEditor to edit files line-by-line and add the class PropertyDiff to
describe a single property change.
refs #4352
2013-08-07 15:56:42 +02:00
290c8c5225
CC: Add newline to end of file where missing
...
Following command was used:
$ find application/ library/Icinga/ modules/ -name *.php | xargs sed -i -e :a -e '/./,$!d;/^\n*$/{$d;N;};/\n$/ba;$a\'
2013-08-07 10:27:50 +02:00
ff62a82895
Fix dynamic form validation behaviour, fix documentaion, fix correct isValid() call
...
- When a dynamic form is modified, no validation is performed, but
the form is being populated with $this->populate.
- changed parent::isValid to $this->isValid, otherwise no custom validation
logic could be implemented
- Updated documentation
- Fix CSRF protection by removing the time
refs #4439
2013-08-06 15:08:54 +02:00
66592ecabf
Enable dynamic form elements
...
Expire time of the AcknowledgeForm and hours as well as
minutes of the ScheduleDowntimeForm are now dynamic.
refs #4439
2013-08-06 15:06:20 +02:00
f5162189dd
Implement dynamic form elements
...
Rename "isPostAndValid" to "isSubmittedAndValid" and refactor it.
Add possibility for specific form elements to auto-submit their form.
refs #4439
2013-08-06 15:03:25 +02:00
584198f00c
Fix hostlist test
...
refs #4516
2013-08-06 14:06:25 +02:00
15999eb880
Change _forward to redirect() to keep url history updates
...
refs #4382
2013-08-06 13:39:10 +02:00
4befc9be94
Merge branch 'feature/preferences-backend-4069'
...
resolves #4069
2013-08-06 12:04:16 +02:00
5533b632ed
Fix code style and make form name non mandatory
...
refs #4439
2013-08-06 11:11:29 +02:00
f26af0eb12
Update command form tests
...
Update command form tests so that they reflect the new dynamic
functionality and the correct purpose of "isSubmittedAndValid".
refs #4439
2013-08-06 11:11:28 +02:00
8efbe6f613
Move submit and cancel handling
...
Move submit and cancel handling from ConfirmationForm to Form.
refs #4439
2013-08-06 11:11:28 +02:00
fa7379adc7
Enable dynamic form elements
...
Expire time of the AcknowledgeForm and hours as well as
minutes of the ScheduleDowntimeForm are now dynamic.
refs #4439
2013-08-06 11:09:42 +02:00
98e7ab02db
Implement dynamic form elements
...
Rename "isPostAndValid" to "isSubmittedAndValid" and refactor it.
Add possibility for specific form elements to auto-submit their form.
refs #4439
2013-08-06 11:09:42 +02:00
c9c5e6ef3c
Send commands: Review fixes
...
refs #4441
2013-08-06 09:32:27 +02:00
a58c933a29
Code style and comment fixes
...
refs #4441
2013-08-06 09:32:27 +02:00
7675ea0514
Call commandhandler from commandcontroller actions
...
The CommandController now implements the calls to the specific
command methods and sends commands to the icinga process
refs #4441
2013-08-06 09:31:13 +02:00
1894054929
Implement first commands, fix obsessing state
...
refs #4441
2013-08-06 09:30:25 +02:00
4f1e6ec720
Code style and comment fixes
...
refs #4441
2013-08-06 09:27:37 +02:00
b44de95caa
Call commandhandler from commandcontroller actions
...
The CommandController now implements the calls to the specific
command methods and sends commands to the icinga process
refs #4441
2013-08-06 09:27:37 +02:00
2091f63c3b
Implement first commands, fix obsessing state
...
refs #4441
2013-08-06 09:27:37 +02:00
d6bbed3a54
Extract the transport functions from the CommandPipe
...
- The CommandPipe class now delegates submission of commands to
the Transport classes (LocalPipe or SecureShell)
- Added SSH options for non-interactive mode
- Refactored tests
refs #4441
2013-08-06 09:27:37 +02:00
512676ec1a
User preferences: Review fixes
...
refs #4069
2013-08-05 16:56:03 +02:00
8f1a3b228b
User preferences: remove test code
...
refs #4096
2013-08-05 16:56:03 +02:00
cc9b18376d
User preferences: Add doc, fix initial session write
...
refs #4069
2013-08-05 16:56:03 +02:00
6112189b0c
User preferences: Add database store
...
refs #4069
2013-08-05 16:56:03 +02:00
f3ed73175b
User preferences: Session store and glue to build instance
...
refs #4069
2013-08-05 16:56:02 +02:00
6d1f349616
User preferences: Implement interfaces and ini store
...
refs #4069
2013-08-05 16:56:02 +02:00
06fc3e395e
NO_ZERO_IN_DATE is available since MySQL 5.0.2
...
refs #4255
2013-08-02 15:10:09 +02:00
5c3eb1d796
Style fixes and addParam test
...
refs #4381
2013-08-02 13:14:56 +02:00
50ca1aec1a
Refactor URL class and test
...
The constructor of the class is now private, instantiation happens
with Url::fromRequest and Url::fromPath. Also updated all occurences
of Url and fixed the Qlink helper to not overwrite the baseUrl with null
values
refs #4381
2013-08-02 13:14:55 +02:00
5ade338632
Fix wrong getter after renaming
...
refs #4066
2013-07-30 14:06:46 +02:00
a1a8d4c157
Code compliance change and rename refs to User
...
refs #4066
2013-07-30 14:06:46 +02:00
8510d57cf8
Prepare user settings api
...
Rework application bootstrap, move user object to its new location, implement web
request class to handle the user object.
refs #4066
2013-07-30 14:06:46 +02:00
457f9b8f50
Db: Set MySQL server SQL modes to behave closer to ANSI SQL
...
refs #4413
2013-07-29 18:37:59 +02:00
f2c6a66de7
Code cleanup, fixed and extended MySQL SQL_MODE
2013-07-29 13:24:25 +00:00
e51737f42a
Fix the installation manual, comments and give the unit-test functions a more
...
verbose name
refs #3769
2013-07-29 11:42:31 +02:00
94e9ffc7b3
Fix comments
...
refs #3769
2013-07-26 15:57:37 +02:00
845654b77f
Fix strict error on ldap auth-fail, ldap is default auth now
...
refs #3769
refs #4463
2013-07-26 15:29:13 +02:00
306a51271b
Change 'user' table to 'account', error handling and docs
...
Fix installation instructions for postgresql, the user table is now
'account', as user is a keyword in some rdbms, now catching exceptions
and returning auth failed while logging errors
refs #3769
2013-07-26 15:01:52 +02:00
ce95511890
Change default database to "icingaweb" and add installation instructions
...
Set the default database and user to "icingaweb" in the authentication.ini. Add
instructions about how to set up the databases to authentication.ini.
refs #3769
2013-07-26 13:10:00 +02:00
fd4cbf1c5b
Add default login to the authentication database
...
refs #3772
2013-07-26 13:10:00 +02:00
2807982f72
Remove crypto-module and use libraries instead
...
Remove the crypto-module to reduce amount of dependencies and use hash_hmac
with SHA256 instead.
refs #3769
2013-07-26 13:09:59 +02:00
3ff0c0f02a
Adds DbUserBackend to handle the authentication against a sql db.
...
Users should be able to authenticate against an internal DB without setting up
additional authentication domains.
refs #3769
2013-07-26 13:09:59 +02:00
6900507ebc
Merge branch 'feature/command-masks-4355' of ssh://git.icinga.org/icinga2-web
2013-07-24 12:49:43 +02:00
2b3bef457d
Command masks: Small PSR fix, drop unused core, fix lazy render
...
refs #4355
2013-07-24 12:43:26 +02:00
ddfbf915ed
Implement isPostAndValid, fix CSRF in forms, update tests
...
Form provides isPostAndValid for validation, using the
request for fetching POST data.
The tests are now updated to use the CSRF protection and
are cleaner now
refs #4355
2013-07-24 10:56:41 +02:00
849eee2cf2
Command masks: Review changes [WIP]
...
refs #4355
2013-07-23 17:09:06 +02:00
e8204f4755
Merge branch 'feature/service-detail-view-4181' of ssh://git.icinga.org/icinga2-web
...
Conflicts:
library/Icinga/Application/Logger.php
library/Icinga/Application/Web.php
library/Icinga/Authentication/Backend/LdapUserBackend.php
library/Icinga/Authentication/Credentials.php
library/Icinga/Authentication/Manager.php
library/Icinga/Authentication/PhpSession.php
library/Icinga/Authentication/Session.php
library/Icinga/Authentication/User.php
library/Icinga/Authentication/UserBackend.php
library/Icinga/Backend/AbstractBackend.php
library/Icinga/Backend/DataView/ObjectRemappingView.php
library/Icinga/Backend/Query.php
library/Icinga/Backend/Statusdat/DataView/StatusdatHostView.php
library/Icinga/Backend/Statusdat/HostgroupsummaryQuery.php
library/Icinga/Backend/Statusdat/HostlistQuery.php
library/Icinga/Backend/Statusdat/ServicegroupsummaryQuery.php
library/Icinga/Backend/Statusdat/ServicelistQuery.php
library/Icinga/Exception/ConfigurationError.php
library/Icinga/Exception/MissingParameterException.php
library/Icinga/Exception/NotImplementedError.php
library/Icinga/Exception/ProgrammingError.php
library/Icinga/Exception/SystemPermissionException.php
library/Icinga/Protocol/AbstractQuery.php
library/Icinga/Protocol/Commandpipe/Acknowledgement.php
library/Icinga/Protocol/Commandpipe/CommandPipe.php
library/Icinga/Protocol/Commandpipe/Comment.php
library/Icinga/Protocol/Commandpipe/Downtime.php
library/Icinga/Protocol/Commandpipe/Exception/InvalidCommandException.php
library/Icinga/Protocol/Commandpipe/IComment.php
library/Icinga/Protocol/Commandpipe/PropertyModifier.php
library/Icinga/Protocol/Ldap/Connection.php
library/Icinga/Protocol/Ldap/Exception.php
library/Icinga/Protocol/Ldap/LdapUtils.php
library/Icinga/Protocol/Ldap/Node.php
library/Icinga/Protocol/Ldap/Query.php
library/Icinga/Protocol/Ldap/Root.php
library/Icinga/Protocol/Statusdat/Exception/ParsingException.php
library/Icinga/Protocol/Statusdat/IReader.php
library/Icinga/Protocol/Statusdat/ObjectContainer.php
library/Icinga/Protocol/Statusdat/Parser.php
library/Icinga/Protocol/Statusdat/Query.php
library/Icinga/Protocol/Statusdat/Query/Expression.php
library/Icinga/Protocol/Statusdat/Query/Group.php
library/Icinga/Protocol/Statusdat/Query/IQueryPart.php
library/Icinga/Protocol/Statusdat/Reader.php
library/Icinga/Protocol/Statusdat/RuntimeStateContainer.php
library/Icinga/Protocol/Statusdat/View/AccessorStrategy.php
library/Icinga/Web/ActionController.php
library/Icinga/Web/Form.php
library/Icinga/Web/Hook/Configuration/ConfigurationTab.php
library/Icinga/Web/Hook/Configuration/ConfigurationTabBuilder.php
library/Icinga/Web/Hook/Configuration/ConfigurationTabInterface.php
library/Icinga/Web/Hook/Grapher.php
library/Icinga/Web/Hook/Toptray.php
library/Icinga/Web/ModuleActionController.php
library/Icinga/Web/Notification.php
library/Icinga/Web/Paginator/Adapter/QueryAdapter.php
library/Icinga/Web/Paginator/ScrollingStyle/SlidingWithBorder.php
library/Icinga/Web/Widget.php
modules/monitoring/application/views/helpers/MonitoringCommands.php
modules/monitoring/application/views/helpers/MonitoringFlags.php
modules/monitoring/application/views/helpers/MonitoringProperties.php
modules/monitoring/application/views/scripts/show/components/comments.phtml
modules/monitoring/application/views/scripts/show/components/downtime.phtml
modules/monitoring/application/views/scripts/show/components/flags.phtml
modules/monitoring/application/views/scripts/show/components/properties.phtml
modules/monitoring/application/views/scripts/show/header.phtml
modules/monitoring/application/views/scripts/show/host.phtml
modules/monitoring/application/views/scripts/show/service.phtml
modules/monitoring/library/Monitoring/Backend/AbstractBackend.php
modules/monitoring/library/Monitoring/Backend/Ido/Query/DowntimeQuery.php
modules/monitoring/library/Monitoring/Backend/Ido/Query/StatusQuery.php
modules/monitoring/library/Monitoring/Backend/Statusdat.php
modules/monitoring/library/Monitoring/Backend/Statusdat/Criteria/Order.php
modules/monitoring/library/Monitoring/Backend/Statusdat/DataView/StatusdatServiceView.php
modules/monitoring/library/Monitoring/Backend/Statusdat/Query/GroupsummaryQuery.php
modules/monitoring/library/Monitoring/Backend/Statusdat/Query/Query.php
modules/monitoring/library/Monitoring/Command/Meta.php
modules/monitoring/library/Monitoring/View/DowntimeView.php
modules/monitoring/test/php/application/views/helpers/MonitoringCommandsTest.php
modules/monitoring/test/php/application/views/helpers/MonitoringPropertiesTest.php
modules/monitoring/test/php/library/Command/MetaTest.php
2013-07-23 16:33:07 +02:00
89e7fa6b2d
Command masks: Add validator and change validation flow
...
refs #4355
2013-07-23 14:47:40 +02:00
e9c9c9de87
Command masks: Fix lazy initialization of forms
...
refs #4355
2013-07-23 14:47:40 +02:00
03f4a8eceb
Command masks: Implement missing forms [WIP]
...
Fixes phpcs issues, missing features, fix controller using
new config interface.
refs #4355
2013-07-23 14:47:40 +02:00
0de38c25eb
Command masks: Refactor and implement masks
...
refs #4355
2013-07-23 14:47:40 +02:00
d5b8a850ea
Forms: New form system
...
Move new form parts arround and add new LoginForm.
refs #4355
2013-07-23 14:46:26 +02:00
dc878de275
Forms: Move class to the right place
...
Drop some methods we do not need anymore (all model related).
refs #4355
2013-07-23 14:46:25 +02:00
2469e3652c
Forms: Drop old form class
2013-07-23 14:46:25 +02:00
576124a827
Forms: Move Icinga\Form to Icinga\Web\Form
2013-07-23 14:46:25 +02:00
b351cf61a7
Refactor Form-builder [WIP]
...
Refactor Form-builder so that it is an abstract extension class of
Zend_Form.
refs #4355
2013-07-23 14:46:25 +02:00
56b8b398c2
Add Number functionality to Icinga\Form\SendCommand
2013-07-23 14:46:25 +02:00
087e4dfe90
Add choice functionality to Icinga\Form\SendCommand
2013-07-23 14:46:25 +02:00
23e15e3f54
Add textbox functionality to Icinga\Form\SendCommand
2013-07-23 14:46:25 +02:00
4b8643dc56
Add a date and time form-element.
...
Added a date and time form-element which are implemented based on the
new "date" and "time" input-types introduced with html5. If those are not
available two bootstrap javascript-modules will be enabled.
refs #4355
2013-07-23 14:46:24 +02:00
15ab7f188a
Implement schedule host/service check action
...
Refactored existing schedule action and fixed selectCommandTargets.
refs #4355
2013-07-23 14:46:24 +02:00
aa241865b4
Replace custom formNote element with the one from Zend
...
Replaced custom form element "Note" as
Zend already provides such an element.
2013-07-23 14:46:24 +02:00
abda65f4bd
Refactor command controller and implement restart action.
...
Refactored existing command controller so that it reflects the
correct coding style, rewritten the icinga restart command and
added a very simple form for it.
refs #4355
2013-07-23 14:46:24 +02:00
8d3ff94696
Remove php strict errors
...
refs #4448
2013-07-23 12:18:27 +02:00
a0839ea0da
Add service detail view
...
refs #4181
2013-07-22 16:03:36 +02:00
dac9b7be4b
Fix mixedPagination property typo, Statusloader libraries missing and getter for Abstractquery
...
refs #4178
2013-07-19 17:48:24 +02:00
5e4adcfea2
Add Service overview and fixes for Statusdat
...
The service overview required a few fixes for issues that
occured because the StatusDat Query class now inherits from
Data/AbstractQuery.
refs #4178
2013-07-19 17:45:51 +02:00
5827cb37cb
Fix statusdat tests and implementation
...
After moving StatusDat to monitoring/Backends and changing the
inheritance to Library/Icinga/Data, a few changes must be reflected in the tests:
- Move tests to monitoring module
- Change $this->backend references in StatusDat Queries to $this->ds
- Added LibraryLoader to ease requiring of libaries (to be discussed)
refs #4417
refs #4179
2013-07-19 11:36:05 +02:00
cea7cdbcaf
Move Statusdat to backend, remove old backend from library
...
Except for statusdat, the library/Icinga/Backend classes were unused
refs #4417
refs #4179
2013-07-18 17:20:12 +02:00
c1860e7d5d
Merge branch 'master' of ssh://git.icinga.org/icinga2-web into feature/host-overview--4179
...
Conflicts:
modules/monitoring/application/controllers/ListController.php
modules/monitoring/application/controllers/ShowController.php
modules/monitoring/library/Monitoring/Backend/AbstractBackend.php
2013-07-15 13:52:26 +02:00
e83526be08
Make form folder optional
...
When the form folder didn't exist, an exception was thrown that
froze the frontend without any error message. Now it is tested
whether the form folder in a module is available and only registered
in the auotoloader if so.
refs #4407
2013-07-15 13:37:43 +02:00
705127a95e
Make sql-queries more standard compliant
...
The connection now uses ONLY_FULL_GROUP_BY when connecting and
also forces ANSI SQL, this is reflected in the query codebase.
Also the comment count fields are added in this commit.
refs #4179
2013-07-15 13:21:48 +02:00
5489c2fa2e
Update license header
...
refs #4407
2013-07-15 12:26:10 +02:00
6742696e09
Autoloader: Rename module namespace
2013-07-15 12:16:14 +02:00
e049d8f3c4
Autoload: Fix test before rename namespaces
...
Drop builder test, it is not needed anymore. Skip all notification
tests. Test includes bootstrapping and throw errors with ldap auth.
refs #4407
2013-07-15 11:20:12 +02:00
e27c73fe15
Autoloader: Move builder to new location [WIP]
...
refs #4407
2013-07-15 11:07:22 +02:00
316893ad2c
Add new autoloader implementation
...
New namespace implementation created to load application code
like forms with this autoloader. Consumpting services can register
their own, multiple namespaces. Overlapping namespaces matched
by closest name.
refs #4407
2013-07-12 16:11:03 +02:00
2fffb892d3
Enable registerMenuEntries for modules since this works now
...
refs #4354
2013-07-12 15:44:55 +02:00
51755209b6
Adapt usage of config class
...
refs #4354
2013-07-12 15:43:23 +02:00
8c6f2a07ae
Remove magic retrieval of configuration files
...
This change leads to expected exceptions when bootstrapping the
application since the \Icinga\Application\Config class was
refactored but its usage not.
refs #4354
refs #4353
2013-07-12 15:41:35 +02:00
297b621bf6
Add view helper url
2013-07-12 14:45:25 +02:00
ca09dc084d
Add Icinga\Web\ViewStream.php
2013-07-12 14:35:14 +02:00
d871b3c287
Update the monitoring module
2013-07-12 14:33:17 +02:00
be3193a0d7
Update LDAP and Livestatus protocol
2013-07-12 13:41:48 +02:00
Eric Lippmann
Matthias Jentsch
Marius Hein
Jannis Moßhammer
Thomas Gelf
root
Johannes Meyer
Thomas Gelf