Commit Graph

1613 Commits

Author SHA1 Message Date
Johannes Meyer a5fe9a1fe1 Revert "Introduce link target "_right" to keep a column with tabs rightmost"
This reverts commit 618ab4f4b9.
2015-02-02 16:34:29 +01:00
Johannes Meyer 9df2430cbe Remove redundant help message when scheduling host/service checks 2015-02-02 16:31:57 +01:00
Johannes Meyer 5382f73c53 Drop all old object- and command-view scripts 2015-02-02 16:31:25 +01:00
Johannes Meyer 8b377cd651 Use the new command-view scripts 2015-02-02 16:30:52 +01:00
Johannes Meyer 2e99e476fe Use the new object-view scripts 2015-02-02 16:28:35 +01:00
Johannes Meyer afa3431aed Introduce new object- and command-view scripts
Represents how we plan to handle view scripts that are re-usable. Should
supersede all <action>/component/* view scripts in the upcoming future.
2015-02-02 16:26:55 +01:00
Eric Lippmann bfb2f710a1 monitoring: Fix exception in the alert summary report when using the "One month" interval
fixes #8220
2015-02-02 14:28:47 +01:00
Eric Lippmann f9047e85c5 monitoring: Fix wrong unhandled service problems count in the hosts overview
The query was missing the is_active = 1 condition. I'll open an issue for the other
affected queries.

fixes #8013
2015-02-02 11:12:27 +01:00
Eric Lippmann cf944a7daf monitoring: Show close button when removing a backend 2015-02-02 11:07:01 +01:00
Eric Lippmann a62acb4a82 monitoring: Show close button when updating a backend 2015-02-02 11:06:40 +01:00
Eric Lippmann 42fe7079ee monitoring: Show close button when creating an instance 2015-02-02 11:06:20 +01:00
Eric Lippmann cbc1a0313a monitoring: Show close button when creating a backend 2015-02-02 11:05:50 +01:00
Eric Lippmann d7cbfebbd0 monitoring: Show close button when removing an instance 2015-02-02 11:05:32 +01:00
Eric Lippmann 734c7b3546 monitoring: Show close button when updating an instance 2015-02-02 11:04:41 +01:00
Eric Lippmann f2d639108f monitoring: Move "Service Grid" beneath "Problems"
The service grid is filtered by problems by default. Thus it makes sense
to move it beneath the problems section.
2015-02-02 00:08:25 +01:00
Eric Lippmann ad4ebf8fa5 monitoring: Fix that selecting a hostgroup displays its services instead of its hosts
fixes #8273
2015-02-01 23:30:48 +01:00
Johannes Meyer bf470125c3 Merge branch 'master' into feature/create-missing-directories-when-creating-inis-8219
Conflicts:
	modules/monitoring/library/Monitoring/MonitoringWizard.php
2015-01-30 16:21:42 +01:00
Johannes Meyer 6416fc421c Do not create directories which are created automatically if necessary
refs #8219
2015-01-30 15:43:39 +01:00
Johannes Meyer e8619686ae Add the sockets module as optional requirement of the monitoring module 2015-01-30 13:01:51 +01:00
Eric Lippmann 127ce7abfe monitoring/security: Fix that toggling instance features is always disabled
In HTML5 the presence of a boolean attribute on an element represents the true value,
and the absence of the attribute represents the false value.

In Zend we have to set null for the absence of the attribute and the empty string for the
presence of the attribute.
2015-01-30 10:47:02 +01:00
Eric Lippmann 1681f746c1 monitoring/security: Disable toggling object features if user lacks the permission monitoring/command/feature/object 2015-01-30 10:46:24 +01:00
Eric Lippmann bdc637ff67 monitoring/security: Guard toggling object features
Toggling object features will only be possible if the user has the permission monitoring/command/feature/object.
2015-01-30 10:31:49 +01:00
Eric Lippmann 35b33647cf monitoring/security: Guard the link for disabling notifications on an instance-wide basis
The link in the monitoring health view will only be shown if the user has the permission monitoring/command/feature/instance.
2015-01-30 10:26:43 +01:00
Eric Lippmann 3716be4a48 monitoring/security: Disable toggling instance features if user lacks the permission monitoring/command/feature/instance 2015-01-30 10:01:03 +01:00
Eric Lippmann 26613a0106 monitoring/security: Rename permission monitoring/command/feature/program to monitoring/command/feature/instance 2015-01-30 09:58:30 +01:00
Eric Lippmann 7dbb8c6841 monitoring/security: Require monitoring/command/feature/instance permission for toggling instance features 2015-01-30 09:58:10 +01:00
Eric Lippmann d19e36d937 monitoring/security: Require monitoring/command/feature/instance permission for disabling notifications 2015-01-30 09:57:31 +01:00
Johannes Meyer 63305fdf9a Add Icinga\Application\Config::saveIni()
Simplifies saving INI files. Icinga\File\Ini\IniWriter does already require an
instance of Icinga\Application\Config so it's obvious to give "Config" the
task to initialize the writer.. We do also have a central place to handle
creating missing ancestor directories now.

refs #8219
2015-01-30 09:32:08 +01:00
Johannes Meyer 618ab4f4b9 Introduce link target "_right" to keep a column with tabs rightmost
I'd have liked to get it to work that in case the tab control is not in the
rightmost column a "go back" in the history is being simulated causing
the preceding leftmost column(s) to be restored and the rightmost one
set to the one containing the tab control. But the history api does not
seem to support any read operations except for the current state..

refs #6436
2015-01-28 14:21:06 +01:00
Johannes Meyer c19ff289bf Open command forms in the same column where their link is located
refs #8279
2015-01-28 13:02:37 +01:00
Johannes Meyer 6fde4eec30 Show all tabs except "Add to Dashboard" when issuing a command
refs #8279
2015-01-28 12:50:29 +01:00
Eric Lippmann 49b82af704 monitoring/security: Apply services/filter restriction in the service detail view 2015-01-27 14:57:54 +01:00
Eric Lippmann 49d4d74dbb monitoring/security: Apply hosts/filter restriction in the host detail view 2015-01-27 14:57:22 +01:00
Eric Lippmann 7bf6bd39e9 monitoring: Implement Filterable in MonitoredObject 2015-01-27 14:54:21 +01:00
Eric Lippmann e086905384 monitoring: Deprecate DataView::addFilter() and DataView::setFilter()
The from now on deprecated interface Filterable has proven that it sucks in the DataView.
Because of requiring us to implement trillion stupid methods, only DataView::applyFilter()
does not forget to handle column validation. Thus only DataView::applyFilter() must be used in order
to apply filters.
For setFilter() a wrapping Filter::matchAny() for the IdoQuery (or the DbQuery or the SimpleQuery I didn't have a look)
is required for the filter to work properly.
The deprecation is just for the records. I guess we do not use the other methods.
2015-01-27 14:52:13 +01:00
Eric Lippmann b2f93abb12 monitoring/security: Require a Filterable instead of a DataView in applyRestriction() 2015-01-27 14:24:56 +01:00
Eric Lippmann 3cbafe16f6 monitoring/security: Move applyRestriction() to the module's base controller 2015-01-27 14:22:37 +01:00
Eric Lippmann f37cd0cb95 monitoring/security: Apply hosts restriction in the hosts overview 2015-01-27 13:51:15 +01:00
Eric Lippmann c8084dde92 monitoring/security: Apply services restriction in the services overview 2015-01-27 13:49:51 +01:00
Eric Lippmann f8aa9eb05c monitoring/security: Replace 'monitoring/filter' restrictions with filter for the hosts and the services view 2015-01-27 13:48:33 +01:00
Eric Lippmann 405e18a46f monitoring: Fix PHPDoc for MonitoringBackend::from() 2015-01-27 13:37:28 +01:00
Eric Lippmann 08795e7cf4 monitoring/security: Expect restriction name in ListController::applyRestriction()
Before, the restriction was hard coded to 'monitoring/filter'.
This restriction will be removed because we can not use the very same filter for all views.
2015-01-27 13:33:52 +01:00
Eric Lippmann 555ab77c3d Fix "Undefined property: stdClass::$service_display_name" in the alert summary
fixes #8284
2015-01-26 13:42:05 +01:00
Eric Lippmann 53a4f10253 monitoring: Sort host groups and service groups by their alias
refs #7843
2015-01-23 15:47:18 +01:00
Eric Lippmann 910065436b monitoring: Support hostgroup_alias and servicegroup_alias filter 2015-01-23 15:47:18 +01:00
Eric Lippmann a1fbb3d937 monitoring: Fix host and service groups overviews when using PostgreSQL
fixes #8268
2015-01-23 15:47:18 +01:00
Johannes Meyer a07bff490f Fix that the monitoring module's config directory is not being created
Forgot to re-add this when reverting a temporary change while adjusting
the module installation as part of #8191.
2015-01-23 15:31:45 +01:00
Eric Lippmann 7500dd9c68 Revert "GroupSummary/Postgres: Fix group by in initial join query"
This reverts commit f47bc46654.

Conflicts:
	modules/monitoring/library/Monitoring/Backend/Ido/Query/GroupsummaryQuery.php

No need to reintroduce group columns.
2015-01-23 15:27:52 +01:00
Eric Lippmann c78d4aa0bd monitoring/security: Provide permissions for the feature commands 2015-01-23 13:29:47 +01:00
Eric Lippmann 86ac09d7b1 monitoring: Use the service group alias for displaying service group names in the servicegroups overview
refs #8266
2015-01-23 11:24:39 +01:00