tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
753 Commits 116 Branches 71 Tags 80 MiB
Commit Graph

56 Commits

Author SHA1 Message Date
Eric Lippmann c47778f10e Capitalize monitoring properties, e.g. Current Attempt 2013-09-05 14:49:37 +02:00
Eric Lippmann a5908c9553 CS: Replace multiple empty lines with one 
find application/ library/Icinga/ test/ modules/ -name *.php | xargs sed -i '/^$/N;/^\n$/D'
 2013-09-04 18:36:10 +02:00
Johannes Meyer b74e264f01 Refactor comment command handling 
- Refactored Comment class
- Dropped IComment interface
- Added AddCommentCommand class
- Updated CommentForm

refs #4580
 2013-09-04 18:08:00 +02:00
Johannes Meyer 95d7a8a553 Fix triggered_by field in ScheduleDowntimeForm is not a select box 
refs #4496
 2013-09-04 18:07:59 +02:00
Jannis Moßhammer d27e34cef8 Codestyle and Test fixes for SortBox 
refs #4601
 2013-09-04 15:22:00 +02:00
Eric Lippmann 3e4d1aa2fb Monitoring/Tests: Replace BaseFormTest with BaseTestCase 
refs #4586
 2013-09-04 11:21:12 +02:00
Eric Lippmann e3044b8b62 Tests/Monitoring: Remove ScheduleDowntimeFormTest since it's being refactored in another branch 
refs #4586
 2013-09-04 11:21:12 +02:00
Eric Lippmann a89631fd92 Tests/Monitoring: Remove useless test ConfirmationFormTest 
refs #4586
 2013-09-04 11:21:12 +02:00
Eric Lippmann 74b9731df5 Remove auto class requirement from BaseTestCase::createForm() 
The tests for the respective forms must require the form class.

refs #4586
 2013-09-04 11:21:12 +02:00
Eric Lippmann 8a062ff3e5 Fix tests after renaming the namespace 
refs #4586
 2013-09-04 11:21:12 +02:00
Eric Lippmann c86874d4ba Rename namespace Monitoring to Icingæ\Module\Monitoring 
refs #4586
 2013-09-04 11:21:11 +02:00
Johannes Meyer 23f0962da1 Adjust command forms and tests 
Made those command forms using the DateTimePicker
element compatible with its new validation.

refs #4581
 2013-09-03 09:27:02 +02:00
Jannis Moßhammer 9f923b4940 Fix pagination and remove ModuleController, rename handlesAuth 
This commit introduces the following changes:
- Count is now performed after joins are added to the selection query,
  therefore returning the correct number
- MonitoringControllerTest now needn't to mock ModuleActionController (which is now removed)
- handlesAuthentication is now requiresAuthentication
- Redirection to login is now directly handled in the ActionController constructor,
  so we don't need to overwrite the preDispatch method

refs #4589
refs #4591
refs #4572
 2013-09-02 18:42:05 +02:00
Johannes Meyer 13e4efa221 Make use of the helptext decorator if suitable 
Refactored some uses of the form element Note so that
each one is properly attached to its input element.

refs #4566
 2013-08-28 08:57:46 +02:00
Jannis Moßhammer 895976550c Fix templates, capitalization and icons in php files 
refs #4550
refs #4584
 2013-08-23 10:28:48 +02:00
Jannis Moßhammer 972bc9853e Configuration interfaces for logging, authentication and general configuration 
- Added HelpText decorator
- Added Time and DateFormatValidator
- Added tests

refs #3777
 2013-08-21 14:22:30 +02:00
Jannis Moßhammer 17c1e5a449 Add tests, move BaseFormTest away from modules/monitoring 
refs #3777
 2013-08-21 14:18:53 +02:00
Jannis Moßhammer bda3537c36 Comment out error-prone checktime test 
The check time test for the host list easily fails when the db access
is slower than 1s, so it's commented out here

refs #4575
 2013-08-19 20:16:40 +02:00
Marius Hein 3a8a3b8f2c Monitoring backend: Change database objects to DbAdapterFactory 
refs #4575
 2013-08-19 18:29:26 +02:00
Eric Lippmann a45409c5f3 Monitoring/Commands/Forms/Tests: Follow our Coding Standards 
refs #4524
 2013-08-16 17:38:50 +02:00
Eric Lippmann 5e85dd1c06 Monitoring/Commands: Fix reschedule next check form tests 
refs #4524
 2013-08-16 17:38:50 +02:00
Eric Lippmann 26f7b740c5 Monitoring/Commands: Fix delay notification form tests 
refs #4524
 2013-08-16 17:38:50 +02:00
Eric Lippmann 329d63839b Monitoring/Commands: Fix tests 
refs #4524
 2013-08-16 17:38:50 +02:00
Jannis Moßhammer b28c7f2f4c Refactor test, tabs and controller 
- Remove unused methods,
- Code style
- Documentation for widgets
- Tabextensions instead of hardcoded tab actions
- Add tests for tabs
- Add missing phpdoc for touched files
- Fix tests

refs #4512
refs #4541
refs #4540
 2013-08-16 15:08:28 +02:00
Jannis Moßhammer be29b8ff8f Make ConfigController and PreferenceController extensible by convention 
- Rename ConfigurationController to ConfigController
- ConfigController and PreferenceController are now subclasses of
  BaseConfigController and BasePreferenceController
- Module and Application Config/Preference Tabs are detected via
  the ControllerTabCollector
- Moved Controller classes to Icinga/Web/Controller (this is why
  so many files are modified)

refs #4530
 2013-08-14 16:08:15 +02:00
Eric Lippmann 7dea7fcad0 Monitoring/Forms: Replace PHP DateTime usage with DateTimeFactory 
refs #4440
 2013-08-12 16:43:10 +02:00
Eric Lippmann 7c732ef682 Monitoring/Tests: Fix DateTimePicker element usage 
refs #4440
 2013-08-12 16:43:08 +02:00
Jannis Moßhammer f8bb478f0e Update dashboard implementation 
fix javascript naming (icinga-url to icingaurl), fix add form, add remove
button, code style changes

refs #4192
 2013-08-07 17:43:37 +02:00
Eric Lippmann 290c8c5225 CC: Add newline to end of file where missing 
Following command was used:
    $ find application/ library/Icinga/ modules/ -name *.php | xargs sed -i -e :a -e '/./,$!d;/^\n*$/{$d;N;};/\n$/ba;$a\'
 2013-08-07 10:27:50 +02:00
Jannis Moßhammer ff62a82895 Fix dynamic form validation behaviour, fix documentaion, fix correct isValid() call 
- When a dynamic form is modified, no validation is performed, but
  the form is being populated with $this->populate.
- changed parent::isValid to $this->isValid, otherwise no custom validation
  logic could be implemented
- Updated documentation
- Fix CSRF protection by removing the time

refs #4439
 2013-08-06 15:08:54 +02:00
Marius Hein 584198f00c Fix hostlist test 
refs #4516
 2013-08-06 14:06:25 +02:00
Johannes Meyer d78a5338df Rename ConfirmationForm and ConfirmationWithIdentifierForm 
Rename ConfirmationForm to CommandForm and
ConfirmationWithIdentifierForm to CommandWithIdentifierForm.

refs #4439
 2013-08-06 11:14:56 +02:00
Johannes Meyer 5533b632ed Fix code style and make form name non mandatory 
refs #4439
 2013-08-06 11:11:29 +02:00
Johannes Meyer f26af0eb12 Update command form tests 
Update command form tests so that they reflect the new dynamic
functionality and the correct purpose of "isSubmittedAndValid".

refs #4439
 2013-08-06 11:11:28 +02:00
Johannes Meyer 8efbe6f613 Move submit and cancel handling 
Move submit and cancel handling from ConfirmationForm to Form.

refs #4439
 2013-08-06 11:11:28 +02:00
Johannes Meyer 98e7ab02db Implement dynamic form elements 
Rename "isPostAndValid" to "isSubmittedAndValid" and refactor it.
Add possibility for specific form elements to auto-submit their form.

refs #4439
 2013-08-06 11:09:42 +02:00
Jannis Moßhammer 2091f63c3b Implement first commands, fix obsessing state 
refs #4441
 2013-08-06 09:27:37 +02:00
Jannis Moßhammer 6900507ebc Merge branch 'feature/command-masks-4355' of ssh://git.icinga.org/icinga2-web 2013-07-24 12:49:43 +02:00
Jannis Moßhammer ddfbf915ed Implement isPostAndValid, fix CSRF in forms, update tests 
Form provides isPostAndValid for validation, using the
request for fetching POST data.
The tests are now updated to use the CSRF protection and
are cleaner now

refs #4355
 2013-07-24 10:56:41 +02:00
Marius Hein 849eee2cf2 Command masks: Review changes [WIP] 
refs #4355
 2013-07-23 17:09:06 +02:00
Jannis Mosshammer e8204f4755 Merge branch 'feature/service-detail-view-4181' of ssh://git.icinga.org/icinga2-web 
Conflicts:
	library/Icinga/Application/Logger.php
	library/Icinga/Application/Web.php
	library/Icinga/Authentication/Backend/LdapUserBackend.php
	library/Icinga/Authentication/Credentials.php
	library/Icinga/Authentication/Manager.php
	library/Icinga/Authentication/PhpSession.php
	library/Icinga/Authentication/Session.php
	library/Icinga/Authentication/User.php
	library/Icinga/Authentication/UserBackend.php
	library/Icinga/Backend/AbstractBackend.php
	library/Icinga/Backend/DataView/ObjectRemappingView.php
	library/Icinga/Backend/Query.php
	library/Icinga/Backend/Statusdat/DataView/StatusdatHostView.php
	library/Icinga/Backend/Statusdat/HostgroupsummaryQuery.php
	library/Icinga/Backend/Statusdat/HostlistQuery.php
	library/Icinga/Backend/Statusdat/ServicegroupsummaryQuery.php
	library/Icinga/Backend/Statusdat/ServicelistQuery.php
	library/Icinga/Exception/ConfigurationError.php
	library/Icinga/Exception/MissingParameterException.php
	library/Icinga/Exception/NotImplementedError.php
	library/Icinga/Exception/ProgrammingError.php
	library/Icinga/Exception/SystemPermissionException.php
	library/Icinga/Protocol/AbstractQuery.php
	library/Icinga/Protocol/Commandpipe/Acknowledgement.php
	library/Icinga/Protocol/Commandpipe/CommandPipe.php
	library/Icinga/Protocol/Commandpipe/Comment.php
	library/Icinga/Protocol/Commandpipe/Downtime.php
	library/Icinga/Protocol/Commandpipe/Exception/InvalidCommandException.php
	library/Icinga/Protocol/Commandpipe/IComment.php
	library/Icinga/Protocol/Commandpipe/PropertyModifier.php
	library/Icinga/Protocol/Ldap/Connection.php
	library/Icinga/Protocol/Ldap/Exception.php
	library/Icinga/Protocol/Ldap/LdapUtils.php
	library/Icinga/Protocol/Ldap/Node.php
	library/Icinga/Protocol/Ldap/Query.php
	library/Icinga/Protocol/Ldap/Root.php
	library/Icinga/Protocol/Statusdat/Exception/ParsingException.php
	library/Icinga/Protocol/Statusdat/IReader.php
	library/Icinga/Protocol/Statusdat/ObjectContainer.php
	library/Icinga/Protocol/Statusdat/Parser.php
	library/Icinga/Protocol/Statusdat/Query.php
	library/Icinga/Protocol/Statusdat/Query/Expression.php
	library/Icinga/Protocol/Statusdat/Query/Group.php
	library/Icinga/Protocol/Statusdat/Query/IQueryPart.php
	library/Icinga/Protocol/Statusdat/Reader.php
	library/Icinga/Protocol/Statusdat/RuntimeStateContainer.php
	library/Icinga/Protocol/Statusdat/View/AccessorStrategy.php
	library/Icinga/Web/ActionController.php
	library/Icinga/Web/Form.php
	library/Icinga/Web/Hook/Configuration/ConfigurationTab.php
	library/Icinga/Web/Hook/Configuration/ConfigurationTabBuilder.php
	library/Icinga/Web/Hook/Configuration/ConfigurationTabInterface.php
	library/Icinga/Web/Hook/Grapher.php
	library/Icinga/Web/Hook/Toptray.php
	library/Icinga/Web/ModuleActionController.php
	library/Icinga/Web/Notification.php
	library/Icinga/Web/Paginator/Adapter/QueryAdapter.php
	library/Icinga/Web/Paginator/ScrollingStyle/SlidingWithBorder.php
	library/Icinga/Web/Widget.php
	modules/monitoring/application/views/helpers/MonitoringCommands.php
	modules/monitoring/application/views/helpers/MonitoringFlags.php
	modules/monitoring/application/views/helpers/MonitoringProperties.php
	modules/monitoring/application/views/scripts/show/components/comments.phtml
	modules/monitoring/application/views/scripts/show/components/downtime.phtml
	modules/monitoring/application/views/scripts/show/components/flags.phtml
	modules/monitoring/application/views/scripts/show/components/properties.phtml
	modules/monitoring/application/views/scripts/show/header.phtml
	modules/monitoring/application/views/scripts/show/host.phtml
	modules/monitoring/application/views/scripts/show/service.phtml
	modules/monitoring/library/Monitoring/Backend/AbstractBackend.php
	modules/monitoring/library/Monitoring/Backend/Ido/Query/DowntimeQuery.php
	modules/monitoring/library/Monitoring/Backend/Ido/Query/StatusQuery.php
	modules/monitoring/library/Monitoring/Backend/Statusdat.php
	modules/monitoring/library/Monitoring/Backend/Statusdat/Criteria/Order.php
	modules/monitoring/library/Monitoring/Backend/Statusdat/DataView/StatusdatServiceView.php
	modules/monitoring/library/Monitoring/Backend/Statusdat/Query/GroupsummaryQuery.php
	modules/monitoring/library/Monitoring/Backend/Statusdat/Query/Query.php
	modules/monitoring/library/Monitoring/Command/Meta.php
	modules/monitoring/library/Monitoring/View/DowntimeView.php
	modules/monitoring/test/php/application/views/helpers/MonitoringCommandsTest.php
	modules/monitoring/test/php/application/views/helpers/MonitoringPropertiesTest.php
	modules/monitoring/test/php/library/Command/MetaTest.php
 2013-07-23 16:33:07 +02:00
Marius Hein 6e3e3c358b Command masks: Add test 
refs #4355
 2013-07-23 14:47:40 +02:00
Marius Hein 8d3ff94696 Remove php strict errors 
refs #4448
 2013-07-23 12:18:27 +02:00
Jannis Moßhammer a0839ea0da Add service detail view 
refs #4181
 2013-07-22 16:03:36 +02:00
Jannis Moßhammer 07f7e7ef23 Fix interface changes of statusdat in tests 
The StatusDat tests didn't run as they were outdated, now a
newer version is added

refs #4178
refs #4179
 2013-07-22 13:47:09 +02:00
Jannis Moßhammer 5e4adcfea2 Add Service overview and fixes for Statusdat 
The service overview required a few fixes for issues that
occured because the StatusDat Query class now inherits from
Data/AbstractQuery.

refs #4178
 2013-07-19 17:45:51 +02:00
Jannis Moßhammer 340554a58c Rename wrong filename 
refs #4417
 2013-07-19 12:00:42 +02:00
Jannis Moßhammer 5827cb37cb Fix statusdat tests and implementation 
After moving StatusDat to monitoring/Backends and changing the
inheritance to Library/Icinga/Data, a few changes must be reflected in the tests:
- Move tests to monitoring module
- Change $this->backend references in StatusDat Queries to $this->ds
- Added LibraryLoader to ease requiring of libaries (to be discussed)

refs #4417
refs #4179
 2013-07-19 11:36:05 +02:00
Jannis Moßhammer 281d27255b Add documentation for testlib 2013-07-18 17:15:32 +02:00
Jannis Moßhammer 8cc3139f17 Testfixture insertion fixes 
refs #4417
 2013-07-18 14:53:47 +02:00