1193 Commits

Author SHA1 Message Date
Johannes Meyer
368bd3c9c7 Refactor datetime validation
The DateTimePicker form element needs to know from now on,
how user input can be formatted when validating.

refs #4581
2013-09-03 09:27:02 +02:00
Johannes Meyer
1a003f8c8b Move configuration and preference handling to Form base class
Moved setConfiguration, setUserPreferences and getUserPreferences
to our Form base class due to some redundancies.

refs #4581
2013-09-03 09:27:02 +02:00
Eric Lippmann
30e36f1e09 Merge branch 'bugfix/pagination-fixes-4589'
fixes #4589
fixes #4591
fixes #4572
2013-09-02 18:43:16 +02:00
Eric Lippmann
b09b3676de Rename determineAuthenticationState to requiresLogin
refs #4572
2013-09-02 18:42:05 +02:00
Jannis Moßhammer
9f923b4940 Fix pagination and remove ModuleController, rename handlesAuth
This commit introduces the following changes:
- Count is now performed after joins are added to the selection query,
  therefore returning the correct number
- MonitoringControllerTest now needn't to mock ModuleActionController (which is now removed)
- handlesAuthentication is now requiresAuthentication
- Redirection to login is now directly handled in the ActionController constructor,
  so we don't need to overwrite the preDispatch method

refs #4589
refs #4591
refs #4572
2013-09-02 18:42:05 +02:00
Jannis Moßhammer
aac1d69ed2 Fix count query ignoring joins
Count queries were created before the required columns were added,
so they often returned more values than a resultset really offers

refs #4589
2013-09-02 18:42:05 +02:00
Jannis Moßhammer
cce217c7c2 Merge branch 'bugfix/correct-check-result-type-distinction-4600'
fixes #4600
2013-09-02 17:24:53 +02:00
Johannes Meyer
d8eccd3858 Skip regression tests if no configuration available
refs #4600
refs #4666
2013-09-02 17:24:43 +02:00
Johannes Meyer
01d7ea39aa Fix error when initiating multiple logins with casperjs
refs #4600
2013-09-02 17:24:43 +02:00
Johannes Meyer
24ecbb56d7 Fix incorrect checkresult type selection
When submitting a passive checkresult for hosts only their correct
result types are added to the selection.

refs #4600
2013-09-02 17:24:42 +02:00
Jannis Moßhammer
b63e19063e Merge branch 'bugfix/enable-module-exception-4604'
fixes #4604
2013-09-02 13:15:22 +02:00
Marius Hein
b99b9a7ca8 ModuleManager: Throw module dir exceptions later
This is important for bootstrap to detect configuration
errors.

refs #4604
2013-09-02 12:52:51 +02:00
Marius Hein
b6eb19ce6a Module enable/disable: Better error messages
refs #4604
2013-09-02 12:52:51 +02:00
Marius Hein
439fade88d Simplify SystemPermissionException
refs #4606
2013-09-02 12:52:51 +02:00
Johannes Meyer
a01559f6e5 Merge branch 'bugfix/log-disable-broken-4595'
fixes #4595
2013-09-02 12:16:55 +02:00
Jannis Moßhammer
18d021d104 Fix logger not testing if it's disabled
refs #4595
2013-09-02 12:16:05 +02:00
Marius Hein
fff746bdb3 Merge branch 'bugfix/discard-changes-notify-4622'
fixes #4622
fixes #4617
2013-09-02 11:19:01 +02:00
Marius Hein
6c59d2cf40 Fix icinga js license header
refs #4622
2013-09-02 10:59:05 +02:00
Jannis Moßhammer
6db96bfb8f CS Fixes: form.js License, comments and deprecated bind()
refs #4622
2013-09-02 10:59:05 +02:00
Jannis Moßhammer
c77f4ff1d9 Frontend tests: Run each *.js file seperately
refs #4622
2013-09-02 10:59:05 +02:00
Jannis Moßhammer
c7375d44fb Add regressiontest for this bug
refs #4622
2013-09-02 10:59:05 +02:00
Jannis Moßhammer
4d9ecd2b3b Fix FormTest breaking after onchange modification
refs #4622
2013-09-02 10:59:05 +02:00
Jannis Moßhammer
a8b3716662 Fix checkswag not testing jshint correctly
The path was wrong, now it is correct.

refs #4617
2013-09-02 10:59:05 +02:00
Jannis Moßhammer
c5fde2324e Generalize form handling in Icinga\Web Form & Tests
configForm.js is now form.js and applied on all forms,
the autosubmit is now a special attribute for input fields,
so the PHP code doesn't create JS snippets anymore

refs #4622
2013-09-02 10:59:05 +02:00
Jannis Moßhammer
978b3519f6 Add configform js component (will be renamed later)
refs #4622
2013-09-02 10:59:05 +02:00
Jannis Moßhammer
649dcd434c Merge branch 'bugfix/fix-auth-manager-4641'
fixes #4641
fixes #4590
fixes #4593
2013-08-30 16:31:31 +02:00
Jannis Moßhammer
feab57e790 Fix old constructor syntax being called in DbBackendForm
refs #4641
2013-08-30 16:28:13 +02:00
Marius Hein
446da85a88 UserBackend: Fix interface in test
refs #4593
2013-08-30 15:32:06 +02:00
Marius Hein
e2e744a424 Fix authentication chain
refs #4593
2013-08-30 14:46:52 +02:00
Marius Hein
845f181001 CS: Fix UserBackend interface
refs #4641
2013-08-30 12:50:57 +02:00
Marius Hein
bed759d597 CS: Fix session classes
refs #4641
2013-08-30 12:50:57 +02:00
Marius Hein
7765877318 CS: Fix LdapUserBackend
refs #4641
2013-08-30 12:50:57 +02:00
Marius Hein
c77a48ff1f CS: Fix DbUserBackend
refs #4641
2013-08-30 12:50:57 +02:00
Marius Hein
7c8252a983 Rename class Credentials to Credential
refs #4641
2013-08-30 12:50:57 +02:00
Marius Hein
83d20a6175 AuthManager: Fix tests
refs #4641
2013-08-30 12:50:28 +02:00
Marius Hein
dfb7238b81 AuthManager: Implement backend chain
refs #4641
refs #4590
refs #4593
2013-08-30 12:50:28 +02:00
Marius Hein
12b3f5f732 Merge branch 'feature/date-and-time-preview-4609'
resolves #4609
fixes #4552
2013-08-29 15:13:59 +02:00
Johannes Meyer
cb8bf4cba7 GeneralForm: Code fixes
Made that the user's last configuration is
previewed in case the input is invalid.

refs #4609
2013-08-29 15:08:31 +02:00
Johannes Meyer
29068269dc Config/GeneralForm: Doc fixes
refs #4609
2013-08-29 15:08:31 +02:00
Johannes Meyer
28bd27d904 Fix user preference access when not authenticated
refs #4609
2013-08-29 15:08:31 +02:00
Johannes Meyer
bf5849a769 Fix GeneralForm tests
refs #4609
2013-08-29 15:08:31 +02:00
Johannes Meyer
f4272f482d Apply user defined timezone during bootstrap
refs #4609
refs #4552
2013-08-29 15:08:31 +02:00
Johannes Meyer
74241258f5 Preview example date/time results in configuration views
refs #4609
2013-08-29 15:08:30 +02:00
Johannes Meyer
32abb20a60 Merge branch 'bugfix/preferences-error-messages-4648'
fixes #4648
2013-08-29 14:53:55 +02:00
Johannes Meyer
a82abbe2f6 Fix misplaced/redundant imports
refs #4648
2013-08-29 14:45:02 +02:00
Marius Hein
7be7335bdd Preferences: Fix error messages and convenience configuration
refs #4648
2013-08-29 14:45:02 +02:00
Johannes Meyer
772d27bb89 Merge branch 'bugfix/frontend-tests-4491'
fixes #4602
fixes #4605
fixes #4606
fixes #4642
fixes #4643
fixes #4546
fixes #4640
fixes #4491
fixes #4657
2013-08-29 13:40:18 +02:00
Johannes Meyer
49eb9ea30f Fix some remaining issues
- Changed "this.fail" to "this.test.fail" in frontend regression test 4606
- Restored default timezone "Europe/Berlin"
- Added "var/log/*.log" to .gitignore
- Updated default.pp so that the user apache is part of the vagrant group

refs #4606
refs #4605
refs #4640
2013-08-29 13:21:33 +02:00
Jannis Moßhammer
b7e4682e1a Fix wrong chmod option order
refs #4640
2013-08-29 11:48:33 +02:00
Jannis Moßhammer
cc4b74250f Fix configure/make substitutions and wrong doc hint
- Documentation stated that apache installation is performed
  wie make install-apache2-config, this is install-apache-config.
- Removed superfluos substitution parameters
- Fixed folder permissions and var/log creation on installation

refs #4640
2013-08-29 11:48:33 +02:00