Eric Lippmann
35fd9fd391
CS: Remove whitespaces at end of line
...
find application/ library/ test/ modules/ -name *.php | xargs sed -i 's/\s\+$//'
2013-09-04 18:27:16 +02:00
Johannes Meyer
b74e264f01
Refactor comment command handling
...
- Refactored Comment class
- Dropped IComment interface
- Added AddCommentCommand class
- Updated CommentForm
refs #4580
2013-09-04 18:08:00 +02:00
Johannes Meyer
9a476f16f4
Re-refactor dispatch process of commands and acknowledgement handling
...
refs #4580
2013-09-04 18:08:00 +02:00
Eric Lippmann
1b858cbdb4
Monitoring: Fix remaining usages of namespace Monitoring without Icinga\Module prefix
...
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
3e4d1aa2fb
Monitoring/Tests: Replace BaseFormTest with BaseTestCase
...
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
74b9731df5
Remove auto class requirement from BaseTestCase::createForm()
...
The tests for the respective forms must require the form class.
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
c86874d4ba
Rename namespace Monitoring to Icingæ\Module\Monitoring
...
refs #4586
2013-09-04 11:21:11 +02:00
Jannis Moßhammer
a0e63a1320
Fix error message and move validation in own DateTimeValidator
...
refs #4581
refs #4632
2013-09-04 11:06:36 +02:00
Johannes Meyer
23f0962da1
Adjust command forms and tests
...
Made those command forms using the DateTimePicker
element compatible with its new validation.
refs #4581
2013-09-03 09:27:02 +02:00
Johannes Meyer
368bd3c9c7
Refactor datetime validation
...
The DateTimePicker form element needs to know from now on,
how user input can be formatted when validating.
refs #4581
2013-09-03 09:27:02 +02:00
Jannis Moßhammer
4d9ecd2b3b
Fix FormTest breaking after onchange modification
...
refs #4622
2013-09-02 10:59:05 +02:00
Marius Hein
446da85a88
UserBackend: Fix interface in test
...
refs #4593
2013-08-30 15:32:06 +02:00
Marius Hein
7c8252a983
Rename class Credentials to Credential
...
refs #4641
2013-08-30 12:50:57 +02:00
Marius Hein
83d20a6175
AuthManager: Fix tests
...
refs #4641
2013-08-30 12:50:28 +02:00
Jannis Moßhammer
0b515e39ac
Implement {app} placeholder and Icinga\Config::resolvePath()
...
refs #4642
2013-08-29 11:48:32 +02:00
Jannis Moßhammer
51d9f8eaa7
Remove original authenticationFormTest
...
refs #4606
2013-08-29 11:48:32 +02:00
Matthias Jentsch
874b163009
Fix comment padding and some coding-style issues in the test classes
...
refs #4615
2013-08-27 18:28:21 +02:00
Matthias Jentsch
5b58d5488b
Add support for section reordering and formatting options to the PreservingIniWriter
...
The PreservingIniWriter needs to be aware of the the order of the sections and
update the section declarations in the configuration file when the order has
changed. Therefore add functions to correctly reorder sections.
refs #4615
2013-08-27 18:28:21 +02:00
Marius Hein
c5bea04909
BaseTestCase: User response, CS and typo
...
refs #4608
2013-08-27 10:37:35 +02:00
Marius Hein
1dfc578c00
Fix provider for Authentication/DbUserBackendTest
...
refs #4608
2013-08-26 12:36:49 +02:00
Marius Hein
69aa6e3d22
Test: Fix provider for Preferences/DbStoreTest
...
refs #4608
2013-08-26 11:41:35 +02:00
Marius Hein
1130376ad6
BaseTest: Create class and tests
...
refs #4608
2013-08-26 11:15:27 +02:00
Matthias Jentsch
49cf62a9dc
Fix database related bugs
...
Fix coding standards in database schemes. Use DbAdapterFactory in all unit
tests instead of creating own adapters. Fix DbUserBackend and DbStore to use
FETCH_OBJ, instead of FETCH_ASSOC, to handle it consistently in the whole
application. Remove unnecessary table columns from the "account" scheme.
refs #4577
refs #4578
refs #4596
refs #4599
refs #4627
2013-08-26 11:09:37 +02:00
Marius Hein
9d4ca7739b
Bootstrap: Safe application start
...
Log exceptions and inform user if something goes wrong.
refs #4625
refs #4592
2013-08-23 17:28:13 +02:00
Marius Hein
afc302d45c
Bootstrap: Safe application start
...
Log exceptions and inform user if something goes wrong.
refs #4625
refs #4592
2013-08-23 17:28:13 +02:00
Eric Lippmann
d813ca62c5
Db: Set MySQL server SQL modes to behave closer to ANSI SQL
...
Was already implemented but someone dropped it accidentally
2013-08-21 14:40:37 +02:00
Jannis Moßhammer
a6ff6ecadd
Fix Codestyle/PHPDoc, fix configPath being Overwritten
...
Also removed possibility to disable debugging as there's no use case for this
refs #4525
refs #4598
2013-08-21 14:22:30 +02:00
Jannis Moßhammer
972bc9853e
Configuration interfaces for logging, authentication and general configuration
...
- Added HelpText decorator
- Added Time and DateFormatValidator
- Added tests
refs #3777
2013-08-21 14:22:30 +02:00
Jannis Moßhammer
17c1e5a449
Add tests, move BaseFormTest away from modules/monitoring
...
refs #3777
2013-08-21 14:18:53 +02:00
Marius Hein
d348477455
Fix user test case: DateTimeZone comparison
2013-08-20 11:27:25 +02:00
Marius Hein
3a8a3b8f2c
Monitoring backend: Change database objects to DbAdapterFactory
...
refs #4575
2013-08-19 18:29:26 +02:00
Eric Lippmann
329d63839b
Monitoring/Commands: Fix tests
...
refs #4524
2013-08-16 17:38:50 +02:00
Jannis Moßhammer
0b479e3796
Code style fixes, fix documentation, fix tab parameters not being overwritten
...
refs #4512
2013-08-16 15:08:28 +02:00
Jannis Moßhammer
49d56f1eab
Fix capitalization error in test require
...
refs #4512
2013-08-16 15:08:28 +02:00
Jannis Moßhammer
b28c7f2f4c
Refactor test, tabs and controller
...
- Remove unused methods,
- Code style
- Documentation for widgets
- Tabextensions instead of hardcoded tab actions
- Add tests for tabs
- Add missing phpdoc for touched files
- Fix tests
refs #4512
refs #4541
refs #4540
2013-08-16 15:08:28 +02:00
Matthias Jentsch
7f30b587be
Change the StoreFactory to work with the DbAdapterFactory and fix code styling
...
Change the StoreFactory configuration to reference to a resource instead of
defining the whole database. Additionally fix docstrings, fix imports and fix
function calls to comply to coding style standards.
refs #4503
2013-08-15 14:16:34 +02:00
Matthias Jentsch
f1040aad60
Add additional functionality and documentation for easier use through developers
...
Add functions to get information about currently available resources and add
documentation about class usage for developers.
2013-08-14 16:22:58 +02:00
Matthias Jentsch
3ce44b72e1
Change accepted exception type of unit test
...
Change the generic type Exception to a more specific one, to achieve
a more accurate test case.
resolves #4503
2013-08-14 16:22:58 +02:00
Matthias Jentsch
68deb735c0
Add the DbAdapterFactory to instanciate database adapters using resource names
...
Create the DbAdapterFactory to instanciate db adapters, add resources.ini to configure resources, change
the authentication Manager to fall back to backends with lower priority in case
of errors, update the current UserBackends to the changed environment. Also
adjust the documentation and existing unit tests.
resolves #4503
2013-08-14 16:22:58 +02:00
Jannis Moßhammer
be29b8ff8f
Make ConfigController and PreferenceController extensible by convention
...
- Rename ConfigurationController to ConfigController
- ConfigController and PreferenceController are now subclasses of
BaseConfigController and BasePreferenceController
- Module and Application Config/Preference Tabs are detected via
the ControllerTabCollector
- Moved Controller classes to Icinga/Web/Controller (this is why
so many files are modified)
refs #4530
2013-08-14 16:08:15 +02:00
Matthias Jentsch
eecbc233b9
Fix behavior of PreservingIniWriter that caused comments at the line end to be deleted
...
Implement a function to fetch comments at line end and use it to preserve
comments. Change the regular expressions used to parse lines to be more aware
of whitespaces between terms. Add automatic value and comment indentation
to produce cleaner output.
2013-08-14 15:05:10 +02:00
Eric Lippmann
bd140f2828
CC: Fix phpcs errors of files changed in feature/datetime-element-4440
...
refs #4440
2013-08-12 16:43:10 +02:00
Eric Lippmann
2c217d1d06
Framework/DateTime: No longer use the Unix timestamp format since this ignores the time zone
...
refs #4440
2013-08-12 16:43:10 +02:00
Eric Lippmann
9f22905837
Framework/DateTimePicker: Set element's value to Unix timestamp after the input is considered valid
...
refs #4440
2013-08-12 16:43:09 +02:00
Eric Lippmann
3d104474d9
Tests: Fix UserTest as getTimeZone now returns a DateTimeZone object
...
refs #4440
2013-08-12 16:43:09 +02:00
Eric Lippmann
ba00fd39df
Framework: Get DateTimePicker's value as timestamp and add input validation
...
refs #4440
2013-08-12 16:43:09 +02:00
Eric Lippmann
da7f619804
Framework: Implement DateFormat view helper
...
Support date, time and datetime formatting based on format strings
set either by the user or via config.ini. The view helper
FormDateTime uses the new helper already
refs #4440
refs #4424
2013-08-12 16:43:09 +02:00
Eric Lippmann
8af901e9ed
Framework/User: Implement getTimezone to retrieve the user's Timezone
...
refs #4440
2013-08-12 16:42:50 +02:00
Eric Lippmann
93ae6d6811
Framework: mv Icinga\Config\Config to Icinga\Application\Config
...
refs #4543
2013-08-12 15:02:25 +02:00
Jannis Moßhammer
ec17efe328
Add test for Dimension
...
refs #4192
2013-08-07 17:44:40 +02:00