Commit Graph

519 Commits

Author SHA1 Message Date
Johannes Meyer a0b2c0b454 Fix another documentation block 2014-08-22 12:18:26 +02:00
Johannes Meyer 75a0c17933 Ensure that all forms have a name
refs #5525
2014-08-22 12:15:02 +02:00
Johannes Meyer 2b879b344f Do not populate using createElements() and fix documentation blocks
refs #5525
2014-08-22 12:04:14 +02:00
Alexander Fuhr 20cead67a6 Merge branch 'master' into bugfix/modules-menu-provider-6639 2014-08-22 11:44:10 +02:00
Alexander Fuhr f757f69bd1 Change Menu load from config ini files to self provided configuration
refs #6639
2014-08-22 11:10:17 +02:00
Johannes Meyer bc05d2ee64 Merge LoggingForm into GeneralForm
fixes #6933
2014-08-22 11:05:20 +02:00
Thomas Gelf af97db31d7 StaticController: fix gravatar sample img header 2014-08-21 19:10:53 +02:00
Johannes Meyer bb7972aa39 Merge branch 'master' into bugfix/rebuild-form-builder-5525
Conflicts:
	application/controllers/AuthenticationController.php
	application/controllers/ConfigController.php
	application/forms/Authentication/LoginForm.php
	application/forms/Preference/GeneralForm.php
	modules/monitoring/application/controllers/ChartController.php
2014-08-20 13:13:50 +02:00
Thomas Gelf 736113c80c AuthenticationController: show friendlier hints...
...while not disclosing sensitive information. More to come once we
have our setup wizard.

fixes #6534
2014-08-19 18:55:58 +02:00
Alexander Fuhr 2f54ff4797 Fix the unrelated tabs
resolves #6934
2014-08-19 13:18:52 +02:00
Thomas Gelf 7334716d15 favicon: add link type
The favicon link tag was missing a type attribute.
2014-08-19 12:25:14 +02:00
Thomas Gelf 0d3fb9e7a5 LoginForm: explicitely remove renderLayout
Should prevent against rare race conditions.

refs #6584
2014-08-19 11:35:51 +02:00
Alexander Fuhr c69af6c5d2 Move "modules" to "System" menu
resolves #6934
2014-08-19 11:14:18 +02:00
Thomas Gelf f67d273bbd AuthenticationController: handle redirect parameter
This is a form field instead of a get parameter right now.

fixes #6584
2014-08-19 10:14:46 +02:00
Thomas Gelf 17b64f9dd5 layout: add favicon
fixes #6956
2014-08-19 10:13:19 +02:00
Thomas Gelf b5f336583f layout/body: protect containers from renderLayout
IMO this should be stripped before, this is just an additional
security measure.

refs #6935
2014-08-19 10:10:23 +02:00
Thomas Gelf 5a6b5172e6 Menu: ignore special params when comparing URLs
This fixes issues on login with dashboard != dashboard?renderLayout
and similar

refs #6699
2014-08-19 10:06:14 +02:00
Thomas Gelf 1cffbc9034 LoginForm: add "redirect" POST field
Instead of blindly trusting the redirect parameter in the URL this
creates a hidden form field and explicitely set's the form action
to the current URL without the redirect parameter.

refs #6584
2014-08-19 09:30:54 +02:00
Johannes Meyer 4ddc0e718b Report the default language also as being available for setting up the locale
fixes #6905
2014-08-14 10:48:52 +02:00
Johannes Meyer fe63ce664f Make use if 'ignore´ instead of explicitly unsetting array keys
refs #5525
2014-08-12 13:57:28 +02:00
Johannes Meyer e6bcda260d Redirect after a new resource has been created successfully
refs #5525
2014-08-12 10:42:28 +02:00
Johannes Meyer eea43e9a60 Adjust Icinga\Form\Dashboard\AddUrlForm to suit the new form interface
refs #5525
2014-08-12 09:49:27 +02:00
Johannes Meyer a627571b87 Drop obsolete button elements
refs #5525
2014-08-11 10:46:45 +02:00
Johannes Meyer f0a99274e6 Access backend information by using getValue() instead of getConfig()
refs #5525
2014-08-11 10:46:08 +02:00
Johannes Meyer 5203f82b80 Fix message translation 2014-08-11 10:44:21 +02:00
Johannes Meyer a37e65be52 Fix coding style 2014-08-11 10:43:54 +02:00
Johannes Meyer d260c3fb94 Do not overwrite __construct() in forms, there's init() for that purpose
refs #5525
2014-08-11 10:39:13 +02:00
Johannes Meyer c36e30af1e Remove DbBackendForm::getConfig as it's not used anywhere
refs #5525
2014-08-11 09:13:41 +02:00
Marius Hein e2c761a7aa AutoLogin/Logout: Remove own session namespace
Store data in the user and implement interface to left
backends store remote information.

fixes #6461
2014-07-30 12:35:55 +02:00
Alexander Klimov e07f2a2b0d Show an error message if a ConfigurationError is thrown 2014-07-29 12:25:48 +02:00
Alexander Klimov 4e1e845675 DbBackendForm: replace create with createElements and getResources with __construct
refs #5525
2014-07-29 12:22:43 +02:00
Alexander Klimov 5e6ef57590 LdapBackendForm: replace create with createElements and getResources with __construct
refs #5525
2014-07-29 12:21:58 +02:00
Marius Hein d05e3bfcca Autologin: Fix javascript logout code
Window onload event handler comes to late. Change
part of the code to use jQuery.

refs #6461
2014-07-29 11:12:15 +02:00
Marius Hein 8b9d446d2e Autologin: Remove deprecated autologin methods
Remove methods from manager because autologin
is now handled with special backends (AutoLoginBackend).

The session is used to store the status about a remote
user authentication to send a 401 header to the client
upon logout.

refs #6461
2014-07-29 10:48:57 +02:00
Alexander Klimov ed10e49bb6 Add AutologinBackendForm
fixes #6434
2014-07-25 14:51:42 +02:00
Alexander Klimov 644b3a1628 Make it possible to remove an authentication backend
refs #6434
2014-07-25 14:49:05 +02:00
Alexander Klimov c06db7495b Merge remote-tracking branch 'origin/bugfix/rebuild-form-builder-5525' into bugfix/autologin-backend-form-6434 2014-07-25 10:57:08 +02:00
Alexander Klimov 50de21e437 Make it possible to edit an authentication backend
refs #6434
2014-07-25 10:29:33 +02:00
Alexander Klimov af898cc2b3 Prefer switch rather than if - elseif 2014-07-24 17:35:26 +02:00
Johannes Meyer 26a78dc387 Remove properties from ConfirmRemovalForm and update it
Which object should be removed needs not to be a part of a form but is
accessible from the url's query string which should be in the action of the
form.

refs #5525
2014-07-24 16:20:01 +02:00
Johannes Meyer c3731fa79e Adjust removeresource-action to suit the new resource form interface
refs #5525
2014-07-24 16:17:30 +02:00
Alexander Klimov 1902b4f10f Make it possible to create an authentication backend of type autologin
refs #6434
2014-07-24 15:50:01 +02:00
Johannes Meyer 0964316df4 Adjust editresource-action to suit the new resource form interface
refs #5525
2014-07-24 12:37:33 +02:00
Johannes Meyer 9c434fe8bf Make isValid more compact and fix coding style
refs #5525
2014-07-24 09:05:10 +02:00
Johannes Meyer edf49d091e Rewrite addForceCreationCheckbox and move it downwards
We should not instantiate form elements directly without any specific
reason.

refs #5525
2014-07-24 08:57:49 +02:00
Johannes Meyer d8b468cf12 Add addSubmitButton to BaseBackendForm
refs #5525
2014-07-24 08:49:47 +02:00
Johannes Meyer 235c4a8c52 Remove getConfig and add get/setBackendConfig instead
As for every configuration form, backend forms need special population
mechanisms as well.

refs #5525
2014-07-24 08:47:58 +02:00
Johannes Meyer 4fe46a2c6e Remove unnecessary properties and their getters/setters
This kind of data is mainly prepared in the controller's action now or
directly fetched in a concrete form implementation.

refs #5525
2014-07-24 08:45:38 +02:00
Johannes Meyer fd912daa3d Adjust createresource-action to suit the updated resource form interface
refs #5525
2014-07-23 16:39:54 +02:00
Johannes Meyer 936f65eb27 Adjust resource form to suit the new form builder implementation
refs #5525
2014-07-23 16:39:15 +02:00
Johannes Meyer c8d61f78e7 Fix the config/resource-action's html markup 2014-07-23 12:55:43 +02:00
Johannes Meyer 9cdd891866 Drop ReorderForm and handle its logic in the controller and view instead
refs #5525
2014-07-23 12:35:39 +02:00
Johannes Meyer a73e2ee654 Adjust general config form to suit the new form builder implementation
refs #5525
2014-07-21 14:33:52 +02:00
Johannes Meyer a9f0b95e51 Adjust preferences form to suit the new form builder implementation
refs #5525
2014-07-21 10:20:04 +02:00
Johannes Meyer 6ed3d5fdbd Remove Icinga\Form\Install\LoggingPage 2014-07-18 10:40:37 +02:00
Johannes Meyer 7157b11f97 Adjust LoggingForm to suit the "final" form builder implementation
refs #5525
2014-07-18 10:29:23 +02:00
Johannes Meyer 5da14d3fc5 Adjust LoginForm to suit the "final" form builder implementation
refs #5525
2014-07-18 10:23:04 +02:00
Johannes Meyer 1de2d0c14f Merge branch 'master' into bugfix/rebuild-form-builder-5525
Conflicts:
	application/forms/Authentication/LoginForm.php
	library/Icinga/Test/BaseTestCase.php
	library/Icinga/Web/Form.php
	library/Icinga/Web/Form/Decorator/BootstrapForm.php
2014-07-17 13:15:42 +02:00
Johannes Meyer 4d199180b3 We do not want to access $_POST directly if it is possible to avoid it 2014-07-17 09:28:10 +02:00
Johannes Meyer e6dee9fe89 Protect login against CSRF
refs #5626
2014-07-16 09:55:23 +02:00
Johannes Meyer 3105c2059e Remove license headers from all files
refs #6309
2014-07-15 13:43:52 +02:00
Johannes Meyer d22363d365 Fix error messages not being displayed in the preferences configuration 2014-07-10 13:43:49 +02:00
Johannes Meyer 6690410c42 Adjust Icinga\Form\Config\LoggingForm to suit the new form builder
refs #5525
2014-07-10 11:16:31 +02:00
Johannes Meyer 630b36e706 Adjust Icinga\Form\Authentication\LoginForm to suit the new form builder
refs #5525
2014-07-10 11:15:46 +02:00
Johannes Meyer e21b4243ca Fix error message when no authentication method available
The error handling for configuration files has slightly changed (non
existent files are treated as empty) so the authentication chain handling
needed to be adjusted as well.

fixes #6268
2014-07-09 12:53:25 +02:00
Johannes Meyer 82d2f5ac9b Revert "Merge branch 'feature/install-wizard-6136'"
This reverts commit 88d4262e7c, reversing
changes made to 6fae333048.

Conflicts:

	application/controllers/InstallController.php
	library/Icinga/Web/Controller/ActionController.php
2014-07-07 15:09:03 +02:00
Johannes Meyer 1950c09478 Remove encoding suffix from locale identifiers
We do not need those as the encoding of a gettext-catalog is already
mentioned in its header.

refs #6602
2014-07-07 09:09:22 +02:00
Matthias Jentsch 57f3023ec4 Fix coding style 2014-07-03 16:20:45 +02:00
Johannes Meyer 143a1e44fe Add a HTML renderer for Icinga\Web\Menu
The menu was being rendered through recursive partials before. The
overhead this fact implicates is not as efficient as standard recursion
so there is now a special renderer for Icinga\Web\Menu utilizing
the RecursiveIteratorIterator

refs #6153
2014-07-03 15:46:46 +02:00
Matthias Jentsch fd21ba4e4d Fix violation of coding guidelines 2014-06-30 18:20:19 +02:00
Johannes Meyer 7eb0f3c472 Remove @codingStandardsIgnoreStart/-Stop annotations
refs #6091
2014-06-30 13:59:58 +02:00
Johannes Meyer f2e5d8afa5 Remove @codeCoverageIgnoreStart/-Stop annotations
refs #6091
2014-06-30 13:58:37 +02:00
Thomas Gelf 3020273b36 ConfigController: re-add devtools action
I accidentally removed it. Don't care about this right now, this is
just a playground.
2014-06-25 20:31:44 +02:00
Johannes Meyer 461b050718 Add locale negotiation to Icinga\Util\Translator
Translator::getPreferredLocaleCode($header) can now be used with the
HTTP "Accept-Language" header to return the best matching locale using
the user's preferations reported by the browser and our available locale
stack. Additionally Translator::getLocale and Translator::getLanguage were
replaced by Translator::splitLocaleCode to provide a more flexible
implemenation in order to identify specific parts of a particular locale or
the current one.

refs #6074
2014-06-25 12:15:41 +02:00
Alexander Klimov 5974305647 Config: Remove path to preferences INI files setting 2014-06-25 11:59:09 +02:00
Alexander Klimov fdf74c5e18 Revert "Make preferences INI path NOT be configurable"
This reverts commit 219869607d.
2014-06-25 11:59:08 +02:00
Thomas Gelf 2b23b259fa ConfigController: notification text fixes
NB: We still have to translate them
2014-06-25 10:50:31 +02:00
Thomas Gelf 408c15b8fb error/error: show newlines in exception 2014-06-25 10:01:59 +02:00
Thomas Gelf 4199e642ef GeneralForm: reorganize use definitions 2014-06-24 21:53:44 +02:00
Thomas Gelf eccfb9b6bc GeneralForms: remove date/timeFormat settings
They are still in use throughout the code, but the sooner we get rid
of them the better it is.

refs #6077
2014-06-24 21:50:11 +02:00
Thomas Gelf 2746b5ff9f ConfigController: switch over to new config tabs
Module configuration now takes place in module detail view and does no
longer pollute our config tabs. Modules are now able to provide a bunch
of own config tabs, we don't really care what they use them for.
2014-06-24 21:31:59 +02:00
Thomas Gelf f7d2bdbc78 ConfigController: notifications before redirection
That's how they reach the browser in a nice way
2014-06-24 21:11:48 +02:00
Thomas Gelf 3576263559 config/devtools: playground for developer tools
This is nothing but a prototype right now but could become pretty
useful. We want to allow our users to control most of our developer
tools without deep knowledge about Icinga Web internals.

This first prototype allows allows one to toggle the JS UI debug
window.
2014-06-24 20:50:02 +02:00
Thomas Gelf b7b99cfd67 Widget\AlertMessageBox: fix broken widget
This widget is pretty useless as the error view script can to it's
job. Interestingly nobody missed it, even the render() call was wrong.

I guess we will remove this soon, but for now it's fixed. Looks ugly,
but works.
2014-06-24 20:30:41 +02:00
Alexander Klimov 219869607d Make preferences INI path NOT be configurable
fixes #6567
2014-06-24 18:29:28 +02:00
Thomas Gelf 1efd1d183e GeneralForm: replace ignorant button
It makes no sense to add submit buttons without telling the form
that there is such, especially in combination with autosubmitting
elements.

refs #5967
2014-06-23 15:46:15 +02:00
Thomas Gelf a1acd52ad9 SearchController: disable autorefresh
Makes no sense as search dashlets refresh themselves.

refs #6536
2014-06-23 10:50:55 +02:00
Thomas Gelf 3fc1205175 AuthenticationController: use Auth() helper function 2014-06-22 20:08:55 +02:00
Thomas Gelf 23ed744747 params/_render: replace it everywhere
Cleaning up controllers and JS, using headers only and respecting
history.
2014-06-22 20:07:44 +02:00
Thomas Gelf 216f0f3f55 isIframe: clean up, load less html and js
We use isIframe only when we have no JS, therefore it makes no sense
to load JS files in an iFrame. Also removed sidebar.
2014-06-22 16:30:06 +02:00
Thomas Gelf 3b84078b2f Params/_render: get rid of it, start with iframe 2014-06-22 16:18:23 +02:00
Thomas Gelf 78193137f0 config/modules: show metadata, improve usability
Well... I didn't want to commit this before creating single-button
forms for enabling/disabling modules. However part of this accidentally
made it through, so let's finish it.

Still some work to do, but it already looks far better like this.

refs #4095
2014-06-21 02:27:27 +02:00
Thomas Gelf 216c2ca770 Autorefresh: should work also on initial page load
fixes #6296
2014-06-21 01:54:32 +02:00
Thomas Gelf 8d6e6421ea config/general: remove obsolete environment setting 2014-06-20 23:21:31 +02:00
Thomas Gelf 0e57887e9a Config/General: remove obsolete moduleFolder
refs #6158
2014-06-20 22:46:44 +02:00
Thomas Gelf 45fa8ca225 CSS/forms: style them
* login form style should only affect login form
* accessibility: add labels on login page
2014-06-20 16:39:01 +02:00
Thomas Gelf c8e2cd109e Accessibility: add roles and missing alt tag 2014-06-20 15:02:19 +02:00
Thomas Gelf 9411dec5d0 StaticController: improve cache headers
Apache does automagic stuff if we don't care (e.g. pragma). Playing
around with ETags, not happy yet.
2014-06-20 14:53:38 +02:00
Thomas Gelf 472ad08090 Accessibility: improve pagination 2014-06-20 14:27:17 +02:00
Thomas Gelf a622f34be6 authentication/login: add missing alt tag 2014-06-20 13:15:13 +02:00