Johannes Meyer
675d070b86
Set the view property `compact' exactly once
...
refs #7876
2015-04-15 15:33:00 +02:00
Johannes Meyer
ed2de3c4d0
Fix SortBox widget
...
refs #7876
2015-04-15 14:20:36 +02:00
Johannes Meyer
d882ea11b4
Avoid to set an empty redirect url parameter when accessing icinga web 2
2015-04-15 11:00:47 +02:00
Johannes Meyer
36fed03764
Do not log that the logging configuration is invalid on every request
...
Instead, log those messages *everytime* a subsequent message is being
logged.
refs #8957
2015-04-13 17:11:42 +02:00
Johannes Meyer
67ad575cf5
Set the configured logging level even if the configured logging type is invalid
...
refs #8957
2015-04-13 17:09:49 +02:00
Johannes Meyer
638c00d685
Merge branch 'master' into feature/non-collated-ido-queries-8613
2015-04-13 15:55:32 +02:00
Alexander A. Klimov
a817d9070e
Move setupSortControl() from Monitoring_ListController to Icinga\Web\Controller
2015-04-10 11:36:25 +02:00
Johannes Meyer
55e9407371
Use `service' instead of `service_description' when searching for services
...
refs #8613
2015-04-08 14:57:30 +02:00
Johannes Meyer
e94c99e20e
Use `host' instead of `host_name' when searching for hosts
...
refs #8613
2015-04-08 14:57:08 +02:00
Eric Lippmann
45d1230b28
Merge branch 'master' into bugfix/significant-whitespaces-8777
2015-04-08 10:19:53 +02:00
Eric Lippmann
a185107927
Trim off leading whitespaces from filter values when searching
...
Because whitespaces may be used when searching for entities using the query string format "column = value" we have to trim off leading whitespaces from filter values.
This loses the possibility for search for entities with leading whitespaces of course.
refs #8777
2015-04-08 10:14:42 +02:00
Eric Lippmann
6e6aabedf2
Don't trim filter expressions
...
Leading and trailing whitespaces may be significant for comparison.
refs #8777
2015-04-08 09:31:11 +02:00
Matthias Jentsch
46da404452
Add docstrings to ObjectList and coding style
2015-04-07 16:34:20 +02:00
Johannes Meyer
9596b4fdf7
Form: Make it possible to preserve default values during (auto)submission
2015-04-07 15:07:36 +02:00
Alexander Klimov
967a2e82dc
Use (only) "@return $this" in fluent interfaces' documentation
2015-04-07 14:24:11 +02:00
Eric Lippmann
6b63f3d8a2
Merge branch 'feature/require-mandatory-params-8886'
...
resolves #8886
2015-04-07 13:06:43 +02:00
Eric Lippmann
dfd8c91827
Add PHPDoc to ActionController::$params
2015-04-07 12:25:46 +02:00
Eric Lippmann
002e793a53
lib: Add Params::req()
...
Params::req() should be used for requiring a mandatory CLI parameter.
refs #8886
2015-04-07 12:20:37 +02:00
Eric Lippmann
93b1a35de0
lib: Add UrlParams::req()
...
UrlParams::req() should be used for requiring a mandatory URL parameter.
refs #8886
2015-04-07 12:17:59 +02:00
Eric Lippmann
0fc5801e5e
lib: Add MissingParameterException::getParameter and ::setParameter ...
...
... for getting/setting the name of the missing parameter which caused the exception.
refs #8886
2015-04-07 12:15:15 +02:00
Alexander Klimov
e32eeb991e
Implement Icinga\Web\Widget\SortBox::create()
2015-04-07 11:37:06 +02:00
Alexander Klimov
57ed849cee
Icinga\Web\Widget\SortBox::applyRequest(): return $this
2015-04-07 11:26:16 +02:00
Eric Lippmann
4d795494fc
Fix MissingParameterException's PHPDoc
...
refs #8886
2015-04-07 10:48:37 +02:00
Johannes Meyer
b0b95ab387
Fix that Icinga\Application\Logger::writesTo* is not functional
2015-04-07 10:31:57 +02:00
Matthias Jentsch
5619ac960c
Add inline pies to host and service back to multi-select views
...
Add old inline pie code and visualize handled/unhandled state.
refs #8565
2015-04-02 16:25:20 +02:00
Eric Lippmann
9ce9e0270c
Fix that LDAP encryption settings have no effect
...
I renamed the directive for the encryption setting from 'connection' to 'encryption' before releasing Beta3 but
I forgot to change the Connection class accordingly.
fixes #8953
2015-04-02 10:41:25 +02:00
Matthias Jentsch
9fbd7822d0
Fix coding guideline violations
2015-03-31 17:41:57 +02:00
Matthias Jentsch
b0b0ae157c
Turn prepareStateName into more generic string utility function
...
refs #8565
2015-03-31 16:45:21 +02:00
Matthias Jentsch
5383999ef7
Add warning to links that open in a new window
...
Add warning on mouseover / focus as recommended by as recommended by WCAG20 G201
refs #7937
2015-03-19 10:49:28 +01:00
Eric Lippmann
949438d753
lib: Add SimpleQuery::splitOrder() ...
...
... for supporting specifying the sort direction next to the column, e.g.
'service_display_name ASC'
refs #8716
2015-03-13 17:09:32 +01:00
Thomas Gelf
63f87da53d
Session: reworked to avoid duplicate notifications
...
* clear session on initialization, store once on shutdown
* less static method calls
* fixes erraneous cli checks
2015-03-13 14:10:27 +01:00
Johannes Meyer
0bc1416b10
Use the correct name for malformed LDAP attributes automatically
...
...or more purposefully: Guard lazy users from themselves. I hope I don't
have to explain why _this_ is not part of Icinga\Protocol\Ldap\Query...
resolves #8608
2015-03-13 11:17:43 +01:00
Thomas Gelf
316d926811
Ldap/Query: re-add __toString
...
We stopped using __toString as it is unable to handle exceptions - and
this makes sense. However, that's IMO not a good reason to completely
drop __toString. Especially when debugging, benchmarking and similar you
often need a quick way to "dump" an object.
In that case you are often not in a mood to figure out whether that
specific class prefers create(), dump(), render() or whatever. We should
not base our view scripts on __toString - at least unless we do not catch
Exceptions in __toString methods, eventually "forwarding" them as triggered
error where needed.
2015-03-13 08:58:25 +01:00
Eric Lippmann
e36c430bb3
Merge branch 'feature/protected-menu-8720'
...
resolves #8720
2015-03-13 04:26:19 +01:00
Eric Lippmann
200982e4f5
Set form action automatically only if Form::setAction() has not been called
...
refs #8605
2015-03-13 03:59:43 +01:00
Eric Lippmann
d8d0d88c95
Rename Capability::hasStartTLS to Capability::hasStartTls()
2015-03-13 00:29:00 +01:00
Eric Lippmann
db08ccad4b
Fix encryption setting written to a LDAP reource's INI configuration
...
Use starttls for STARTTLS and ldaps for LDAPS.
2015-03-12 23:56:25 +01:00
Eric Lippmann
86f3ce9133
Rename Ldap\Connetion::SSL to ::LDAPS
...
The SSL constant was used to denote LDAP over TLS/SSL. In fact both STARTTLS and LDAPS use encrypted TLS/SSL communication
w/ STARTTLS upgrading a plain text connection and LDAPS using a separate port. Thus speaking of SSL only for LDAPS and TLS only for STARTTLS
is not correct.
2015-03-12 23:56:08 +01:00
Eric Lippmann
1b9ddaacac
Add PHPDoc to Ldap\Connection's encryption consts
2015-03-12 23:35:38 +01:00
Eric Lippmann
17393a7b41
Remove unnecessary PHPDoc tags from Ldap\Connection
2015-03-12 23:30:04 +01:00
Eric Lippmann
03f78a06fb
Optimize imports in the SearchDashboard
...
refs #8668
2015-03-12 18:48:59 +01:00
Eric Lippmann
dc6b472ec9
Don't create search dashlets if the search string is empty
...
refs #8668
2015-03-12 18:47:34 +01:00
Eric Lippmann
515fe3249f
Fix PHPDoc of SearchDashboard::search()
...
refs #8668
2015-03-12 18:44:23 +01:00
Eric Lippmann
77cd48e6fe
We do not use the @package tag
2015-03-12 18:11:33 +01:00
Eric Lippmann
6c5a6215ef
Render search results based on their priority
...
refs #8668
2015-03-12 18:11:06 +01:00
Eric Lippmann
c1d5231619
Add priority param to Module::provideSearchUrl()
...
refs #8668
2015-03-12 17:55:29 +01:00
Eric Lippmann
29d5fd351b
Merge branch 'bugfix/logout-external-8626'
...
fixes #8626
2015-03-12 16:47:49 +01:00
Eric Lippmann
8563d5ed3f
PHPDoc: Use @var instead of @type
...
Becasue of too many kittens PSR-5 backed off of deprecating @var.
So that's the way we go too.
2015-03-12 16:08:47 +01:00
Eric Lippmann
90971f2caf
Revert "Merge branch 'feature/organize-headings-7976'"
...
This reverts commit ea2a17a76c
, reversing
changes made to e72de8dfe1
.
refs #7976
fixes #8647
2015-03-12 16:08:34 +01:00
Eric Lippmann
093dfd627e
Security: Hide config menu items if the user lacks the required permission
...
refs #8720
2015-03-12 15:45:33 +01:00
Eric Lippmann
da16bfcef3
Security: Use PermittedMenuItemFilter in the MenuRenderer
...
refs #8720
2015-03-12 15:45:30 +01:00
Eric Lippmann
e6a60e214c
lib: Add PermittedMenuItemFilter ...
...
... for iterating over menu items the user is allowed to display
refs #8720
2015-03-12 15:45:27 +01:00
Eric Lippmann
7f010102f6
Add wildcard support to the permission passed to User::can()
...
refs #8720
2015-03-12 15:45:25 +01:00
Eric Lippmann
0c30356d52
Add Menu::getPermission() and Menu::setPermission()
...
Those two functions are required for filtering menu items based on a user's grants.
refs #8720
2015-03-12 15:44:43 +01:00
Johannes Meyer
8295d6d9b0
Do not require the `connection' directive when creating a LDAP resource
2015-03-12 15:36:52 +01:00
Johannes Meyer
359a5f54c3
Merge branch 'master' into feature/ldap-ssl-and-tls-support-7771
2015-03-12 15:18:53 +01:00
Johannes Meyer
5de5a65df0
Do not suppress errors when a LDAP capability query fails
2015-03-12 15:18:00 +01:00
Johannes Meyer
1b440a4f1b
Make SSL/TLS configurable for LDAP resources
...
refs #7771
2015-03-12 15:17:19 +01:00
Eric Lippmann
749957c3b4
Fix too greedy __SELF__ login redirect on XHR
...
I introduced this bug some commits earlier. We only must redirect to __SELF__ on XHR
if a redirect URL was set.
refs #8626
2015-03-12 00:57:03 +01:00
Eric Lippmann
2f752ed1ac
Respond with HTTP status code 403 when an XHR requires authentication
...
refs #8626
2015-03-11 22:32:04 +01:00
Eric Lippmann
0806ab3ec9
Remove strict equality for $auth->isAuthenticated()
2015-03-11 22:26:03 +01:00
Eric Lippmann
64ad54ebd6
Optimize imports in Web.php
2015-03-11 22:08:28 +01:00
Eric Lippmann
a835cad31f
Remove a nonsense TODO from Web.php
...
TODOs for replacing Zend classes are unnecessary.
2015-03-11 22:06:23 +01:00
Eric Lippmann
c54648244e
Remove newlines from Web.php
2015-03-11 22:05:23 +01:00
Eric Lippmann
c47164601a
Don't alias Zend_Controller_Action_HelperBroker in Web.php
2015-03-11 22:03:49 +01:00
Eric Lippmann
dfa7e20b74
Don't use Icinga\Authentication\Manager twice
2015-03-11 22:01:41 +01:00
Eric Lippmann
9e81370551
Removed unused use ... in Web.php
2015-03-11 22:00:09 +01:00
Eric Lippmann
32ca28bc46
Use @return $this for documenting fluent interfaces
2015-03-11 21:58:41 +01:00
Eric Lippmann
ac2522af20
Merge branch 'master' into bugfix/logout-external-8626
2015-03-11 21:55:52 +01:00
Eric Lippmann
7fe4b3d7ab
Fix PHPDoc of Web::detectLocale()
2015-03-11 21:55:04 +01:00
Eric Lippmann
29d4ad69b9
Remove // @codeCoverageIgnoreEnd
...
This is obsolete.
2015-03-11 21:50:41 +01:00
Eric Lippmann
bc1336b6f9
Fix stupid code in ActionController::redirectToLogin()
...
refs #8626
2015-03-11 21:49:20 +01:00
Eric Lippmann
4ebfbf83ab
Leave note about __SELF__ in our action controller
...
refs #8626
2015-03-11 21:40:14 +01:00
Eric Lippmann
d102a61e22
Fix Undefined index: HTTP_ACCEPT_LANGUAGE
...
fixes #8370
2015-03-11 20:50:05 +01:00
Johannes Meyer
ba0154ab79
Tab: Use the title as caption if there is no label set yet
2015-03-11 10:21:06 +01:00
Johannes Meyer
39a74c4f3d
LDAP-Auth backend config: Add support for custom LDAP filter rules
...
refs #8365
2015-03-11 09:52:14 +01:00
Johannes Meyer
0758be4af1
Add support for dynamic ldap filter expressions
...
"Dynamic" is a more of a overstatement when describing this commit but
the current implementation is just the start. Once our ldap protocol stuff
supports our filter implementation this will be vastly improved.
refs #8365
2015-03-11 09:50:41 +01:00
Johannes Meyer
2cf09ebc48
Revert "LdapResourceForm: Validate the host field and do not require a port"
...
This reverts commit a34d6026b3
.
refs #7990
2015-03-11 08:00:20 +01:00
Johannes Meyer
a34d6026b3
LdapResourceForm: Validate the host field and do not require a port
...
fixes #7990
2015-03-10 15:03:48 +01:00
Johannes Meyer
d0383a241e
Use date and mktime instead of cal_days_in_month to count a month's days
...
fixes #8637
2015-03-10 12:30:22 +01:00
Johannes Meyer
4badbc660b
Merge branch 'master' into feature/conditional-requirements-8508
2015-03-09 08:51:03 +01:00
Louis Sautier
083c1a9e6b
Fix some spelling errors in comments and messages
...
fixes #8633
Signed-off-by: Gunnar Beutner <gunnar@beutner.name>
2015-03-08 15:32:22 +01:00
Eric Lippmann
d414d7e395
Fix that preferences can't be stored in a database
...
The mtime column is a column to update, not a column for the where condition.
fixes #8629
2015-03-08 10:19:17 +01:00
Johannes Meyer
f45f00b022
Run a module's configuration script only in case it has been registered
...
fixes #8601
2015-03-06 13:25:04 +01:00
Johannes Meyer
f3fa743022
Fix login when using a PostgreSQL database as authentication backend
...
fixes #8524
2015-03-06 11:03:45 +01:00
Matthias Jentsch
cb0ca6d6ac
Remove unused piechart code
2015-03-06 09:41:38 +01:00
Johannes Meyer
6cfa958bb8
Allow setting `requirement' on form elements
...
It's supposed to be used as description what
kind of value an element will accept.
refs #7947
2015-03-06 08:53:34 +01:00
Johannes Meyer
b9811f8590
Form: Do not set the requiredSuffix as option but use its virtual setter
...
This removes the invalid attribute on each <label> tag once the
FormDescriptions decorator removes the suffix.
refs #7947
2015-03-05 15:13:38 +01:00
Johannes Meyer
b8eedc21bb
Form: Explicitly set subform decorators
...
refs #7947
2015-03-05 15:12:02 +01:00
Johannes Meyer
764f125778
Make the FormDescriptions decorator able to handle sub forms
...
refs #7947
2015-03-05 15:08:30 +01:00
Johannes Meyer
ff263946c8
Form: Fix translation domain detection while running unit tests
2015-03-04 09:38:00 +01:00
Johannes Meyer
6e61980dd2
Fix operator precedence when detecting the default locale
...
fixes #8370
2015-03-04 08:28:30 +01:00
Johannes Meyer
e2887df03e
Form: It's a field, not a control
2015-03-03 15:01:09 +01:00
Johannes Meyer
8510835fba
Fix accessibility of the Autosubmit decorator when applied to a form
...
refs #7935
2015-03-03 14:35:46 +01:00
Johannes Meyer
c2339d156b
Improve aria-hidden handling in the icon and img view helper
2015-03-03 14:35:41 +01:00
Johannes Meyer
747e51553e
Allow the Autosubmit decorator being used on forms as well
...
refs #7935
2015-03-03 13:33:26 +01:00
Johannes Meyer
642fa44fce
Move a form's title into the markup of its form
2015-03-03 09:53:25 +01:00
Johannes Meyer
b1d0c12df3
Form: Introduce setTitle() as alias for Zend_Form::setDescription()
2015-03-02 18:40:46 +01:00
Johannes Meyer
ad288c08ca
Form: Add the Description decorator by default for native title support
2015-03-02 18:40:46 +01:00
Johannes Meyer
cbd061aa41
Fix that the FormDescriptions decorator does not ignore Notes and Buttons
2015-03-02 18:40:46 +01:00