Commit Graph

128 Commits

Author SHA1 Message Date
Matthias Jentsch 4e2595c09b Fix history breaking on autorefresh 2015-08-28 16:06:07 +02:00
Matthias Jentsch ef8ee3302b Improve JS error handling
Refresh URL after loading erroring containers, when the user refreshes he expects to reload the page he just loaded and not the previous one.
2015-08-26 15:23:58 +02:00
Matthias Jentsch 96e3845f46 Improve handling of navigation on link closes
Do not drop active menu when closing the left column, unless there is a different active menu that matches the current state.

fixes #9761
2015-08-25 16:55:10 +02:00
Johannes Meyer e3d99cb00d loader.js: Add support for ajax progress timer
refs #8369
refs #8848
2015-08-20 14:38:03 +02:00
Matthias Jentsch 34bf6bb11e Stop refresh on any error unless its an auto-refresh
Links with the same URL may still be user-triggered actions, which should cause the auto-refresh to be stalled. The old implementation assumed that user-triggered requests always have a different URL.

fixes #8975
2015-08-18 16:47:45 +02:00
Matthias Jentsch 0c2afe3c3b Clean up and conform to coding guidelines 2015-08-18 16:47:45 +02:00
Matthias Jentsch 7c7881659d Always replace requests in loader by non-GET requests
Fix issue that caused form submits to be aborted when there's already a pending autosubmit for the same url.

fixes #9024
2015-08-18 11:42:43 +02:00
Matthias Jentsch 6ba86619bc Assure that the history is updated when calling 'rendered'
fixes #9819
2015-08-11 17:41:24 +02:00
Johannes Meyer 153f3ba2f9 js: Drop function events.handleAnchor() and ui.scrollContainerToAnchor()
There is ui.focusElement() now which handles ids as well.

refs #8615
2015-08-06 11:51:57 +02:00
Matthias Jentsch ecdc03a2d7 Fix selection lost after pushing refresh
Remove old row action code that interfered with action table behavior.

refs #8623
2015-07-29 11:41:53 +02:00
Johannes Meyer 0f2351ff1d js: Fix XHR loading of URLs in case window.FormData is not supported
refs #8758
2015-07-22 13:29:44 +02:00
Johannes Meyer 5e1ea958b4 js: Correctly process the redirectUrl-meta tag for successful frame uploads
refs #8758
2015-07-21 16:38:52 +02:00
Johannes Meyer 93fbb0231c loader.js: Split processRedirectHeader() to allow partly reuse
refs #8758
2015-07-21 16:37:21 +02:00
Johannes Meyer 9471c3c574 js: Make use of the _frameUpload parameter when submitting a form..
..to an iframe. This ensures that stuff like notifications are immediately
visible to the user after successful form submission.

refs #8758
2015-07-21 15:43:47 +02:00
Johannes Meyer 37b87eb284 js: Add fallback in case XHR file uploads are not possible
refs #8758
2015-07-20 10:52:28 +02:00
Johannes Meyer 6d4d99aa62 js: Use window.FormData instead of just FormData
refs #8758
2015-07-15 15:49:34 +02:00
Johannes Meyer c1d9cde312 js: Properly submit multipart/form-data
This is not IE <10 compatible. Fix follows. ;-)

refs #8758
2015-07-15 15:25:40 +02:00
Johannes Meyer 3098c21c17 loader.js: Push failed requests to history
The commit ae68e8aec4 reverted
earlier seems to be supposed to do exactly what this one does now.
Prior, the commits ae68e8aec4 and
8bb0e4e0a0 were effectively
neutralizing each other. Quick tests of how Web 2 handles failing
requests while interacting with the browser's history were successful.
If this change breaks something else (again?), leave me a note and do
*not* fix it straight away..
2015-07-06 16:56:44 +02:00
Johannes Meyer b4fe91bb2f Revert "Ajax onFailure: Write component URL to container"
This reverts commit ae68e8aec4.

fixes #9042
fixes #9544
2015-07-06 16:43:49 +02:00
Matthias Jentsch 975a834bd4 Remove unused code and clean up 2015-06-30 12:28:41 +02:00
Johannes Meyer 88f5bb8368 js: Relax check whether to switch to single column layout upon redirect
This fixes the problem when redirecting from a form using the same route
as in the leftmost column but with a different querystring, that one gets
the same route shown twice.
2015-05-22 16:54:59 +02:00
Johannes Meyer 54a370ca22 Merge branch 'master' into bugfix/make-all-views-dashboard-compliant-7876 2015-04-20 11:15:04 +02:00
Matthias Jentsch aa409bda72 Fix formatting of js error log entries generated from responses
Replace multiple whitespace characters with a single one and remove linebreaks.

refs #8711
2015-04-16 12:15:59 +02:00
Johannes Meyer be05d3a73a Fix dashboard header handling
refs #7876
2015-04-15 13:23:34 +02:00
Eric Lippmann 2e1ae185fb Retain detail URL if the layout is rerendered after a redirect
refs #8605
2015-03-13 04:04:58 +01:00
Eric Lippmann 7f94858b8d Add JSDoc to Icinga.Loader.prototype.processRedirectHeader()
refs #8626
2015-03-11 21:26:44 +01:00
Eric Lippmann 031f9ddc84 Don't always redirect to the current window's URL if the redirect URL is __SELF__
Please see code comments for an explanation.

refs #8626
2015-03-11 21:24:56 +01:00
Johannes Meyer 3dce0e434a Add more sophisticated fix for keeping the focus after an autorefresh
fixes #8350
2015-02-17 09:24:38 +01:00
Marius Hein ea57e7a786 History: Do not write abort requests to browser history
Remove req.historyTriggered and introduce req.addToHistory.
2015-02-16 15:56:50 +01:00
Marius Hein ae68e8aec4 Ajax onFailure: Write component URL to container
This is needed that history can push the correct detail url
2015-02-16 14:11:11 +01:00
Thomas Gelf d10beb7604 js: no console.log. please! 2015-02-09 15:26:55 +01:00
Matthias Jentsch b56eb7b669 Fix keyboard navigation
Store current focus position before reload and apply it after rendering.

fixes #8350
2015-02-04 18:01:06 +01:00
Eric Lippmann 6bae2e0a53 Note that our license is GPL v2 or any later version in our license header instead of pointing to the license's URL 2015-02-04 10:52:27 +01:00
Eric Lippmann 5b4fab0750 Add license header
This time without syntax errors hopefully :)
2015-02-03 16:27:59 +01:00
Eric Lippmann 5fa2e3cfdc Revert "Add license header"
This reverts commit 338d067aba.
2015-02-03 16:16:26 +01:00
Eric Lippmann 338d067aba Add license header
fixes #7788
2015-02-03 15:51:04 +01:00
Johannes Meyer 8bb0e4e0a0 Failure requests: Fix auto refresh and history II
Allow to change url's in history and stop auto auto refresh if
the container URL is not up to date.

Use variable after ajax call and the check is more robust.
2015-02-02 16:52:36 +01:00
Marius Hein bc69a3b20f Revert "Failure requests: Fix auto refresh and history"
This reverts commit 8c758a9f12.
2015-02-02 16:40:05 +01:00
Marius Hein 67a426580d loader: Remove gray out on complete handler
A failure did not remove the impact class which colorize
the background gray.
2015-02-02 15:20:12 +01:00
Marius Hein 6555a2ec0a Menu: Move request handling to complete
If a failure occur the menu is still working.
2015-02-02 15:03:36 +01:00
Marius Hein 8c758a9f12 Failure requests: Fix auto refresh and history
Allow to change url's in history and stop auto auto refresh if
the container URL is not up to date.
2015-02-02 13:32:40 +01:00
Marius Hein 190c1e8f04 Revert "Revert "Dashboard: Always replace title""
This reverts commit d1f13819e4.

Please do not ask. This was no syntax error.
2015-02-02 12:04:28 +01:00
Marius Hein d1f13819e4 Revert "Dashboard: Always replace title"
This reverts commit c0c0e7d9e5.

Syntax error
2015-02-02 12:01:40 +01:00
Marius Hein c0c0e7d9e5 Dashboard: Always replace title
This is needed if an error occurs and the exception title was rendered
into the container.
2015-02-02 12:00:08 +01:00
Marius Hein 7b8332ccd8 Notifications do not disappear after autorefresh
This is not affected anymore because the errors goes directly
into the container. But this commit fixes the codes if someone
use the notifications in the loader. Also remove unused
variable this.exception.

fixes #6278
2015-01-30 15:25:12 +01:00
Marius Hein 6ec2ee753d Render error messages in the container itself
fixes #6280
2015-01-30 14:50:25 +01:00
Thomas Gelf 95f9bebdc5 js/loader: support multi-container redirection
Redirections to #!-separated URLs (multiple containers) should also
work when not re-rendering the whole layout.
2014-11-01 01:23:55 +01:00
Thomas Gelf 6298d303c4 js/loader: trigger 'beforerender' container event 2014-11-01 01:12:59 +01:00
Thomas Gelf f25f4f06d8 js/loader: disable click handler block on refresh
This used to be ways too slow when many elements where involved. Left
the old code there as a reminder. In case we really need it we should
use something faster like an overlay or so.
2014-11-01 01:11:12 +01:00
Matthias Jentsch 6124f984ee Adjust scroll position on container after triggering the 'rendered' event
Prevent behaviors from altering the current scroll-position on page reload when refreshing or changing the focus.

fixes #7269
2014-10-14 15:50:15 +02:00