Commit Graph

1040 Commits

Author SHA1 Message Date
Alexander Fuhr 5f3aafd3bd Merge branch 'bugfix/menu-item-renderer-deduplication-7658'
fixes #7658
2015-04-20 17:15:21 +02:00
Alexander Fuhr 9ebf4742de Use the MenuItemRenderer render() implemnetations
refs #7658
2015-04-20 17:07:34 +02:00
Alexander Fuhr 4eb5f75c62 Use default MenuItemRenderer as renderer if no custom renderer is set
refs #7658
2015-04-20 17:04:46 +02:00
Alexander Fuhr f543321ac4 Replace MenuItemRenderer interface with a base class MenuItemRenderer
refs #7658
2015-04-20 17:02:42 +02:00
Johannes Meyer da7aa23820 Merge branch 'master' into bugfix/make-all-views-dashboard-compliant-7876 2015-04-20 15:20:23 +02:00
Alexander Fuhr 7bc07c4368 Force absolute nampesace for module menu item renderer
refs #7642
2015-04-20 13:21:37 +02:00
Alexander Fuhr a9819907ed Add namespaced item renderer class loader
refs #7642
2015-04-20 13:08:49 +02:00
Alexander Fuhr 593ea7add5 Move monitoring module renderers from global module to monitoring module
refs #7642
2015-04-20 13:02:12 +02:00
Johannes Meyer 54a370ca22 Merge branch 'master' into bugfix/make-all-views-dashboard-compliant-7876 2015-04-20 11:15:04 +02:00
Johannes Meyer 2bd31ee395 Icinga\Web\Controller: Add helper functions to create control widgets
refs #7876
2015-04-17 16:08:41 +02:00
Johannes Meyer b52b507134 FilterEditor: Fix css 2015-04-17 10:05:48 +02:00
Matthias Jentsch 6898a4e0d5 Display icon tooltips without delay
Original functionality was broken when changing the icon library.
2015-04-16 18:32:47 +02:00
Matthias Jentsch 168577ff33 Use icon instead of the letter 'X' in close tab 2015-04-16 18:32:47 +02:00
Eric Lippmann ff45faf123 lib: Remove prefixedTimeUntil()
refs #6778
2015-04-15 15:47:58 +02:00
Eric Lippmann 44c8d37288 lib: Remove prefixedTimeSince()
refs #6778
2015-04-15 15:47:10 +02:00
Eric Lippmann 796cbffbd7 Merge branch 'master' into bugfix/time-formatting-6778
Conflicts:
	modules/monitoring/application/views/scripts/show/components/notifications.phtml
2015-04-15 15:43:39 +02:00
Johannes Meyer 675d070b86 Set the view property `compact' exactly once
refs #7876
2015-04-15 15:33:00 +02:00
Johannes Meyer ed2de3c4d0 Fix SortBox widget
refs #7876
2015-04-15 14:20:36 +02:00
Johannes Meyer d882ea11b4 Avoid to set an empty redirect url parameter when accessing icinga web 2 2015-04-15 11:00:47 +02:00
Johannes Meyer 638c00d685 Merge branch 'master' into feature/non-collated-ido-queries-8613 2015-04-13 15:55:32 +02:00
Eric Lippmann 5a46821d91 Rename timeago, timesince and timeuntil CSS classes to time-ago, time-since and time-until
refs #6778
2015-04-10 14:19:08 +02:00
Alexander A. Klimov a817d9070e Move setupSortControl() from Monitoring_ListController to Icinga\Web\Controller 2015-04-10 11:36:25 +02:00
Eric Lippmann 3ec6caa15b lib: Add timeAgo to views
refs #6778
2015-04-10 09:56:39 +02:00
Johannes Meyer 55e9407371 Use `service' instead of `service_description' when searching for services
refs #8613
2015-04-08 14:57:30 +02:00
Johannes Meyer e94c99e20e Use `host' instead of `host_name' when searching for hosts
refs #8613
2015-04-08 14:57:08 +02:00
Eric Lippmann 45d1230b28 Merge branch 'master' into bugfix/significant-whitespaces-8777 2015-04-08 10:19:53 +02:00
Eric Lippmann a185107927 Trim off leading whitespaces from filter values when searching
Because whitespaces may be used when searching for entities using the query string format "column = value" we have to trim off leading whitespaces from filter values.
This loses the possibility for search for entities with leading whitespaces of course.

refs #8777
2015-04-08 10:14:42 +02:00
Johannes Meyer 9596b4fdf7 Form: Make it possible to preserve default values during (auto)submission 2015-04-07 15:07:36 +02:00
Alexander Klimov 967a2e82dc Use (only) "@return $this" in fluent interfaces' documentation 2015-04-07 14:24:11 +02:00
Eric Lippmann 6b63f3d8a2 Merge branch 'feature/require-mandatory-params-8886'
resolves #8886
2015-04-07 13:06:43 +02:00
Eric Lippmann dfd8c91827 Add PHPDoc to ActionController::$params 2015-04-07 12:25:46 +02:00
Eric Lippmann 93b1a35de0 lib: Add UrlParams::req()
UrlParams::req() should be used for requiring a mandatory URL parameter.

refs #8886
2015-04-07 12:17:59 +02:00
Alexander Klimov e32eeb991e Implement Icinga\Web\Widget\SortBox::create() 2015-04-07 11:37:06 +02:00
Alexander Klimov 57ed849cee Icinga\Web\Widget\SortBox::applyRequest(): return $this 2015-04-07 11:26:16 +02:00
Matthias Jentsch 5619ac960c Add inline pies to host and service back to multi-select views
Add old inline pie code and visualize handled/unhandled state.

refs #8565
2015-04-02 16:25:20 +02:00
Matthias Jentsch 9fbd7822d0 Fix coding guideline violations 2015-03-31 17:41:57 +02:00
Matthias Jentsch 5383999ef7 Add warning to links that open in a new window
Add warning on mouseover / focus as recommended by as recommended by WCAG20 G201

refs #7937
2015-03-19 10:49:28 +01:00
Thomas Gelf 63f87da53d Session: reworked to avoid duplicate notifications
* clear session on initialization, store once on shutdown
* less static method calls
* fixes erraneous cli checks
2015-03-13 14:10:27 +01:00
Eric Lippmann e36c430bb3 Merge branch 'feature/protected-menu-8720'
resolves #8720
2015-03-13 04:26:19 +01:00
Eric Lippmann 200982e4f5 Set form action automatically only if Form::setAction() has not been called
refs #8605
2015-03-13 03:59:43 +01:00
Eric Lippmann 03f78a06fb Optimize imports in the SearchDashboard
refs #8668
2015-03-12 18:48:59 +01:00
Eric Lippmann dc6b472ec9 Don't create search dashlets if the search string is empty
refs #8668
2015-03-12 18:47:34 +01:00
Eric Lippmann 515fe3249f Fix PHPDoc of SearchDashboard::search()
refs #8668
2015-03-12 18:44:23 +01:00
Eric Lippmann 77cd48e6fe We do not use the @package tag 2015-03-12 18:11:33 +01:00
Eric Lippmann 6c5a6215ef Render search results based on their priority
refs #8668
2015-03-12 18:11:06 +01:00
Eric Lippmann 29d5fd351b Merge branch 'bugfix/logout-external-8626'
fixes #8626
2015-03-12 16:47:49 +01:00
Eric Lippmann 8563d5ed3f PHPDoc: Use @var instead of @type
Becasue of too many kittens PSR-5 backed off of deprecating @var.
So that's the way we go too.
2015-03-12 16:08:47 +01:00
Eric Lippmann 90971f2caf Revert "Merge branch 'feature/organize-headings-7976'"
This reverts commit ea2a17a76c, reversing
changes made to e72de8dfe1.

refs #7976
fixes #8647
2015-03-12 16:08:34 +01:00
Eric Lippmann 093dfd627e Security: Hide config menu items if the user lacks the required permission
refs #8720
2015-03-12 15:45:33 +01:00
Eric Lippmann da16bfcef3 Security: Use PermittedMenuItemFilter in the MenuRenderer
refs #8720
2015-03-12 15:45:30 +01:00
Eric Lippmann e6a60e214c lib: Add PermittedMenuItemFilter ...
... for iterating over menu items the user is allowed to display

refs #8720
2015-03-12 15:45:27 +01:00
Eric Lippmann 0c30356d52 Add Menu::getPermission() and Menu::setPermission()
Those two functions are required for filtering menu items based on a user's grants.

refs #8720
2015-03-12 15:44:43 +01:00
Eric Lippmann 749957c3b4 Fix too greedy __SELF__ login redirect on XHR
I introduced this bug some commits earlier. We only must redirect to __SELF__ on XHR
if a redirect URL was set.

refs #8626
2015-03-12 00:57:03 +01:00
Eric Lippmann 2f752ed1ac Respond with HTTP status code 403 when an XHR requires authentication
refs #8626
2015-03-11 22:32:04 +01:00
Eric Lippmann bc1336b6f9 Fix stupid code in ActionController::redirectToLogin()
refs #8626
2015-03-11 21:49:20 +01:00
Eric Lippmann 4ebfbf83ab Leave note about __SELF__ in our action controller
refs #8626
2015-03-11 21:40:14 +01:00
Johannes Meyer ba0154ab79 Tab: Use the title as caption if there is no label set yet 2015-03-11 10:21:06 +01:00
Johannes Meyer 2cf09ebc48 Revert "LdapResourceForm: Validate the host field and do not require a port"
This reverts commit a34d6026b3.

refs #7990
2015-03-11 08:00:20 +01:00
Johannes Meyer a34d6026b3 LdapResourceForm: Validate the host field and do not require a port
fixes #7990
2015-03-10 15:03:48 +01:00
Johannes Meyer d0383a241e Use date and mktime instead of cal_days_in_month to count a month's days
fixes #8637
2015-03-10 12:30:22 +01:00
Louis Sautier 083c1a9e6b Fix some spelling errors in comments and messages
fixes #8633

Signed-off-by: Gunnar Beutner <gunnar@beutner.name>
2015-03-08 15:32:22 +01:00
Johannes Meyer 6cfa958bb8 Allow setting `requirement' on form elements
It's supposed to be used as description what
kind of value an element will accept.

refs #7947
2015-03-06 08:53:34 +01:00
Johannes Meyer b9811f8590 Form: Do not set the requiredSuffix as option but use its virtual setter
This removes the invalid attribute on each <label> tag once the
FormDescriptions decorator removes the suffix.

refs #7947
2015-03-05 15:13:38 +01:00
Johannes Meyer b8eedc21bb Form: Explicitly set subform decorators
refs #7947
2015-03-05 15:12:02 +01:00
Johannes Meyer 764f125778 Make the FormDescriptions decorator able to handle sub forms
refs #7947
2015-03-05 15:08:30 +01:00
Johannes Meyer ff263946c8 Form: Fix translation domain detection while running unit tests 2015-03-04 09:38:00 +01:00
Johannes Meyer e2887df03e Form: It's a field, not a control 2015-03-03 15:01:09 +01:00
Johannes Meyer 8510835fba Fix accessibility of the Autosubmit decorator when applied to a form
refs #7935
2015-03-03 14:35:46 +01:00
Johannes Meyer c2339d156b Improve aria-hidden handling in the icon and img view helper 2015-03-03 14:35:41 +01:00
Johannes Meyer 747e51553e Allow the Autosubmit decorator being used on forms as well
refs #7935
2015-03-03 13:33:26 +01:00
Johannes Meyer 642fa44fce Move a form's title into the markup of its form 2015-03-03 09:53:25 +01:00
Johannes Meyer b1d0c12df3 Form: Introduce setTitle() as alias for Zend_Form::setDescription() 2015-03-02 18:40:46 +01:00
Johannes Meyer ad288c08ca Form: Add the Description decorator by default for native title support 2015-03-02 18:40:46 +01:00
Johannes Meyer cbd061aa41 Fix that the FormDescriptions decorator does not ignore Notes and Buttons 2015-03-02 18:40:46 +01:00
Johannes Meyer 1eacaa4c48 Improve the display of the text cue on required form elements
Shows just a message at the top of the form if all elements are required
and a explaining message what the cue is standing for otherwise.

refs #7934
2015-03-02 13:48:35 +01:00
Johannes Meyer 1a334f8d64 Add decorator FormDescriptions
This decorator displays a list of messages at the top of a form.

refs #7947
2015-03-02 13:45:24 +01:00
Johannes Meyer 7bb78330a9 Replace cancel icon with the trash icon...
...where the link's purpose is to remove something
2015-02-27 14:47:46 +01:00
Johannes Meyer 74dfa6e72a Fix invalid icon names passed to the icon view helper 2015-02-27 14:45:47 +01:00
Johannes Meyer 96c132908d Provide a warning on autosubmit form elements and a title for the apply btn
resolves #7935
2015-02-27 13:09:13 +01:00
Johannes Meyer 4f0bddd7da Do not add aria-label to icons and images with titles if aria-hidden is set 2015-02-27 12:12:24 +01:00
Johannes Meyer 82017da85f Help: Do not protect form element ids twice 2015-02-27 09:20:15 +01:00
Johannes Meyer c00e336ea8 Make the cue that is being appended to required form elements configurable
refs #7934
2015-02-27 09:08:05 +01:00
Johannes Meyer 48c3199a2d Form: Fix id protection
Altering element ids upon rendering makes it impossible to reference
them elsewhere. Zend_Form::getId() should be preferred over getName()
as it falls automatically back to getName() in case there is no id attribute
set. Setter are required to return their instance. Overwriting methods
without calling the parent (getId) without any valid (or at least
documented) reason is very bad practice.

refs #8460
2015-02-27 09:01:46 +01:00
Johannes Meyer 6d81a194ab Make form element descriptions accessible
Re-added the Help decorator to make sure an element's description
is being added in an accessible way.
2015-02-27 08:10:25 +01:00
Johannes Meyer 0111fdf78e Add an asterisk suffix to a form element's label if its required
The screen reader part "(required)" is not being considered with this
commit as most screen readers do not need this due to the ARIA and
HTML5 property.

resolves #7934
2015-02-26 16:05:13 +01:00
Matthias Jentsch 89451f3086 Ensure that form ids are unique
Add an unique prefix to each Form- or FormElement id, unless id protection is disabled explicitly, to prevent id collisions between different containers.

fixes #8460
2015-02-25 18:00:28 +01:00
Alexander Fuhr cc403806f7 Fix refresh accessibility lable if it is empty
refs #7968
2015-02-25 15:28:09 +01:00
Alexander Fuhr 08ace05ac7 Remove animations.css from StyleSheet loading lessFiles
refs #7968
2015-02-25 13:56:32 +01:00
Alexander Fuhr 7f883a4770 Add own animation.less to provide own parameterized animate function
refs #7968
2015-02-25 13:51:26 +01:00
Alexander Fuhr 3a2b69a63c Remove refreshTab property from Tabs
refs #7968
2015-02-25 13:24:11 +01:00
Alexander Fuhr e219bb1664 Add doc for the label
refs #7968
2015-02-25 13:13:22 +01:00
Alexander Fuhr 481c58ec03 Add accessibility to renderRefreshTab
refs #7968
2015-02-25 12:14:26 +01:00
Alexander Fuhr 5297b15a61 Merge branch 'master' into feature/refresh-control-7968 2015-02-24 14:41:09 +01:00
Johannes Meyer d68c636359 Wizard: Disable the browser's form validation when navigating back
formnovalidate... The fukin awesomeness of HTML5 is sometimes
even impressing a god-damned h4x0r like me.

fixes #8507
2015-02-24 13:16:31 +01:00
Johannes Meyer 8e8bab0795 Do only escape a qlink's label manually if necessary 2015-02-24 11:35:25 +01:00
Johannes Meyer 956efe5ef9 Merge branch 'master' into feature/link-labels-8458
Conflicts:
	application/views/scripts/config/application.phtml
	application/views/scripts/config/module.phtml
	application/views/scripts/config/modules.phtml
	library/Icinga/Web/Widget/Dashboard/Dashlet.php
	modules/monitoring/application/controllers/TimelineController.php
2015-02-24 08:42:36 +01:00
Johannes Meyer b626a96e16 Add aria-label to each box of the event grid
refs #8458
2015-02-23 17:14:40 +01:00
Johannes Meyer fb7640db0a Add proper titles to the Limiter control
refs #8458
2015-02-23 17:06:01 +01:00
Johannes Meyer b2f817925b Add proper titles to the FilterEditor
refs #8458
2015-02-23 17:05:39 +01:00
Johannes Meyer 66305bd79a Add proper titles to dashboards and dashlets
refs #8458
2015-02-23 17:05:02 +01:00
Johannes Meyer a5514392db Adjust dashboard, output-format and module tabs 2015-02-23 17:03:11 +01:00
Alexander Fuhr aa5c52dfdd Implement content refresh control next to dropdown tab
refs #7968
2015-02-23 17:02:44 +01:00
Johannes Meyer 9fb3dcabea Introduce Icinga\Web\Widget\Tab::$label as alternative for $title 2015-02-23 16:48:02 +01:00
Johannes Meyer f6ea02fec5 qlink: Allow passing null as default for $properties 2015-02-23 16:29:07 +01:00
Marius Hein 4cdc1313cf Dashlet: Add titles to iframe title attribute
resolves #8459
2015-02-23 16:20:08 +01:00
Marius Hein 2dda3be87b Merge remote-tracking branch 'origin/master' into feature/organize-headings-7976 2015-02-23 14:28:48 +01:00
Marius Hein 03160ef81a Header: Add header to event history
Add header to the following widgets:

- FilterEditor
- SortBox

refs #7976
2015-02-23 14:23:56 +01:00
Matthias Jentsch 2992bf3445 Always display tooltips in all charts
Make information about data types available to colorblind, when hovering
over the displayed data set

fixes #8364
2015-02-18 13:21:42 +01:00
Marius Hein d3c79dae32 Merge branch 'master' into feature/organize-headings-7976 2015-02-17 15:21:29 +01:00
Johannes Meyer 9c5d44caf0 Fix that webkit submits datetime values not according to RFC 3339
That's actually more of a workaround instead of a fix as the bug itself
is part of webkit, not Icinga Web 2.

fixes #8457
2015-02-17 12:50:11 +01:00
Alexander Klimov 43691f6612 Drop BasketAction as it's not used anywhere 2015-02-16 14:37:54 +01:00
Alexander Fuhr 7be134a774 Merge master fixed conflicts 2015-02-16 11:24:15 +01:00
Johannes Meyer 5321c2f9e5 Mute icons properly using the new automatic mechanisms of our view helpers
refs #8360
2015-02-16 10:52:42 +01:00
Johannes Meyer 243bc6ec0c Make the view helpers qlink, img and icon handle aria-tags automatically
refs #8358
refs #8360
2015-02-16 10:26:03 +01:00
Alexander Fuhr 2112676594 Implement hidden accessible control for auto refresh on the page
refs #7945
2015-02-13 14:34:29 +01:00
Marius Hein ce3a564de7 Header: Add header to tabs extension
refs #7976
2015-02-13 11:26:09 +01:00
Alexander Fuhr b9c9f564ec Add editable auto_refresh parameter to the user preferences
refs #7945
2015-02-12 15:12:10 +01:00
Johannes Meyer 9232c5cf22 Add aria-hidden="true" to all icons that exist only for design reasons
refs #8360
2015-02-12 13:49:31 +01:00
Marius Hein 09349288e1 Merge branch 'master' into feature/skip-content-7933 2015-02-12 13:14:56 +01:00
Marius Hein b6daf2237d Menu: Add html5 nav element to menu
refs #7933
2015-02-12 13:14:01 +01:00
Johannes Meyer 9e933d835d Add Icinga\Web\Form\ErrorLabeller
refs #8415
2015-02-12 09:11:03 +01:00
Johannes Meyer aa473fb8cf Standardize path validators according to Zend's validators
refs #8415
2015-02-12 09:11:02 +01:00
Johannes Meyer a2f3e7d4f7 Display an error in case a user inputs an invalid formatted datetime string
resolves #7975
2015-02-12 09:11:02 +01:00
Johannes Meyer a630db93e8 Show proper examples in case a user doesn't enter a permitted/correct val
resolves #7973
2015-02-12 09:11:02 +01:00
Johannes Meyer eb3063e36d Form: Add prefix path for custom form validators
refs #8415
2015-02-12 09:11:02 +01:00
Eric Lippmann 97261cd8bd lib: Do not setLayout('pdf') twice 2015-02-11 15:15:18 +01:00
Eric Lippmann ec8a89b96e lib: Add recursive iterator over a DOMNode 2015-02-11 13:20:01 +01:00
Johannes Meyer c5b6d7ee41 Ensure that all required form elements are marked as such in HTML markup
refs #8349
2015-02-05 13:15:18 +01:00
Eric Lippmann 6bae2e0a53 Note that our license is GPL v2 or any later version in our license header instead of pointing to the license's URL 2015-02-04 10:52:27 +01:00
Eric Lippmann 49e96b7200 Revert "monitoring/security: Guard delete comment action"
This reverts commit 4ef5f0c813.
2015-02-03 16:51:00 +01:00
Matthias Jentsch e8466ec7be Fix inlinePie borders and SVG sizes
Add white border to inline piecharts in the list, to make them more visible on mouse hovering. Set a default image size for the loaded svg charts.
2015-02-03 16:46:12 +01:00
Eric Lippmann 5b4fab0750 Add license header
This time without syntax errors hopefully :)
2015-02-03 16:27:59 +01:00
Eric Lippmann 5fa2e3cfdc Revert "Add license header"
This reverts commit 338d067aba.
2015-02-03 16:16:26 +01:00
Eric Lippmann 4ef5f0c813 monitoring/security: Guard delete comment action 2015-02-03 16:11:56 +01:00
Eric Lippmann 338d067aba Add license header
fixes #7788
2015-02-03 15:51:04 +01:00
Eric Lippmann 08fd000496 Remove any topbar related stuff
It's not used anywhere.
2015-02-03 12:42:02 +01:00
Markus Frosch cb08b25e17 Remove executable flags from some PHP libraries
Note: dompdf.php is actually a CLI script, but has no shebang and is not used
in Icingaweb2.

Fixes #8345
2015-02-03 10:50:50 +01:00
Thomas Gelf f8c5bf6819 Web\Hook: support hook base classes in modules
refs #8207
2015-02-02 17:44:29 +01:00
Thomas Gelf 3596e7ce62 FilterEditor: use preserved params
fixes #7904
2015-02-02 17:07:54 +01:00
Eric Lippmann 9d6906bd64 Save user dashboards to Icinga Web 2's configuration directory
fixes #8056
2015-02-02 15:06:29 +01:00
Eric Lippmann 5a1ebf9c89 lib: Implement Tab::getUrl() 2015-02-02 14:16:26 +01:00
Johannes Meyer bf470125c3 Merge branch 'master' into feature/create-missing-directories-when-creating-inis-8219
Conflicts:
	modules/monitoring/library/Monitoring/MonitoringWizard.php
2015-01-30 16:21:42 +01:00
Eric Lippmann df29dd0e7c Implement Form::hasPermission() and Form::getPermission() 2015-01-30 09:35:01 +01:00
Eric Lippmann 2faf5f0ca1 Throw SecurityException in ActionController::assertPermission() 2015-01-30 09:34:19 +01:00
Johannes Meyer 63305fdf9a Add Icinga\Application\Config::saveIni()
Simplifies saving INI files. Icinga\File\Ini\IniWriter does already require an
instance of Icinga\Application\Config so it's obvious to give "Config" the
task to initialize the writer.. We do also have a central place to handle
creating missing ancestor directories now.

refs #8219
2015-01-30 09:32:08 +01:00
Marius Hein dd483d98df LessCompiler: Remove useless argument
refs #6417
2015-01-29 14:04:47 +01:00
Marius Hein c1df1f822e ifont: Reorganize files and drop use less attributes
fixes #6417
2015-01-29 11:25:37 +01:00
Marius Hein 4abb30e55b Merge branch 'master' into bugfix/ie8-fixes-6417 2015-01-28 17:08:56 +01:00
Marius Hein 9d05190517 ifont: Fix empty font glyphs for IE8
The embedded font is included inline in the stylesheets. IE falls back and
tries to load one of the other font sources which was not exported by the web
server. This fix moves the fontello directory to public and add add a
prefix path to the embedded stylesheet.

refs #6417
2015-01-28 17:06:55 +01:00
Johannes Meyer 6fde4eec30 Show all tabs except "Add to Dashboard" when issuing a command
refs #8279
2015-01-28 12:50:29 +01:00