Thomas Gelf
e3e6826d9d
Icinga\Filter: remove
2014-06-17 13:26:57 +00:00
Thomas Gelf
d2ccc68214
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
...
Conflicts:
modules/monitoring/application/controllers/ListController.php
2014-06-17 09:47:14 +00:00
Johannes Meyer
32a7decc3e
Remove python test-runners
...
refs #6092
2014-06-12 16:29:07 +02:00
Johannes Meyer
d28d20696c
Move binary testing stuff and phpunit.xml to its own module
...
refs #6092
2014-06-12 16:29:07 +02:00
Johannes Meyer
159d765f14
Fix that calling ActionController::translate() throws an exception
...
Translating strings must not throw an exception
even if the given domain is not valid.
fixes #6432
2014-06-11 13:39:22 +02:00
Thomas Gelf
db3accc704
Data\Db: rename Query and Connection to Db...
...
Class names in namespaces should not be chosen as once we didn't have
such. The fact that we already did "use Db\Connection as DbConnection"
is the best hint that naming was wrong.
So this patch renames Db\Connection to Db\DbConnection and does the
same with DbQuery. DbQuery has been adjusted to fit our new SimpleQuery
and to handle the new Filter implementation.
2014-06-06 06:43:13 +00:00
Thomas Gelf
f438cb30e1
Data\Filter: initial commit basic implementation
...
Basic operators are there, still missing: subclassed "where" to distinct
comparison operators like greater/less than on a class level.
refs #6418
2014-06-06 06:04:24 +00:00
Thomas Gelf
6b0a212094
tests/Data: implement basic data filtering tests
...
First test examples, more to come
2014-06-06 05:42:02 +00:00
Thomas Gelf
bfe6a1593a
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
2014-06-06 05:32:54 +00:00
Thomas Gelf
55880cb5a3
packaging/config: rename ICINGA_APPDIR
...
Renamed ICINGA_APPDIR to ICINGAWEB_APPDIR for consistency. This way
it fits ICINGAWEB_CONFIGDIR.
refs #6400
2014-06-04 21:11:27 +00:00
Thomas Gelf
820b6b7a8d
Data\BaseQuery: rename to Data\SimpleQuery
...
BaseQuery should no longer be abstract but be usable as is as soon as
we stripped ResultSet-specific tasks. As "Base" suggests something that
must be extended, the name no longer fits. So this is SimpleQuery right
now.
2014-05-07 11:55:35 +00:00
Johannes Meyer
4cf3044a53
Rename Icinga\Logger\Writer\StreamWriter to FileWriter
...
refs #6038
2014-04-30 11:59:22 +02:00
Johannes Meyer
a5faa8bf25
Fix ResourceForm
...
refs #6038
2014-04-30 10:16:20 +02:00
Johannes Meyer
98ca15d1fb
Mark less important or non-testable code as skipped for code coverage
...
refs #6011
2014-04-28 14:06:41 +02:00
Johannes Meyer
1df56cbfb9
Fix errors in tests
...
refs #6011
2014-04-28 14:06:40 +02:00
Johannes Meyer
07da92ee42
Rewrite test for Icinga\Web\Url and fix some bugs
...
refs #6011
2014-04-28 14:06:40 +02:00
Johannes Meyer
c5c375e72d
Add test for Icinga\Web\MenuItem
...
refs #6011
2014-04-28 14:06:40 +02:00
Johannes Meyer
290fe9eeb5
Rewrite test for Icinga\Web\Hook
...
refs #6011
2014-04-28 14:06:40 +02:00
Johannes Meyer
2b15d35dec
Rewrite test for Icinga\Web\Form
...
refs #6011
2014-04-28 14:06:40 +02:00
Johannes Meyer
f20d459000
Rename test/php/library/Icinga/Application/Config to ConfigTest
...
refs 6011
2014-04-28 14:06:40 +02:00
Johannes Meyer
87863d3212
Add test for Icinga\File\Csv
...
refs #6011
2014-04-28 14:06:40 +02:00
Johannes Meyer
e8ed7c7166
Rewrite test for Icinga\Config\PreservingIniWriter
...
refs #6011
2014-04-28 14:06:40 +02:00
Johannes Meyer
54a5e996bb
Add test for Icinga/Logger/Writer/StreamWriter
...
refs #6011
2014-04-28 14:06:39 +02:00
Johannes Meyer
45d7864198
Refactor test for Icinga\Test\BaseTestCase
...
refs #6011
2014-04-28 14:06:39 +02:00
Johannes Meyer
c93159d287
Add test for Icinga\User\Preferences\Store\IniStore
...
refs #6011
2014-04-28 14:06:39 +02:00
Johannes Meyer
9efe71441a
Add test for Icinga\User\Preferences\Store\DbStore
...
refs #6011
2014-04-28 14:06:39 +02:00
Johannes Meyer
d44aaeb8d7
Add test for Icinga\User\Preferences
...
refs #6011
2014-04-28 14:06:39 +02:00
Johannes Meyer
be410a685b
Add test for Icinga\User
...
refs #6011
2014-04-28 14:06:39 +02:00
Johannes Meyer
e10193f570
Add test for Icinga\Util\DateTimeFactory
...
refs #6011
2014-04-28 14:06:39 +02:00
Johannes Meyer
891d36dbd7
Make DateTimeFactory expecting a string instead of a DateTimeZone
2014-04-28 14:06:39 +02:00
Johannes Meyer
3e83854e04
Add test for Icinga\Util\String
...
refs #6011
2014-04-28 14:06:39 +02:00
Johannes Meyer
e27e538bd9
Add test for Icinga\Util\Translator
...
refs #6011
2014-04-28 14:06:39 +02:00
Johannes Meyer
1145fc118e
Move session tests to correct sub-folder
...
refs #6011
2014-04-28 14:06:39 +02:00
Johannes Meyer
2415604035
Add test for Zend_View_Helper_DateFormat
...
refs #6011
2014-04-28 14:06:39 +02:00
Johannes Meyer
f7051ca992
Remove form tests that cover only graphical tests
...
refs #6011
2014-04-28 14:06:38 +02:00
Johannes Meyer
21b949758f
Refactor ResourceForm tests
...
refs #6011
2014-04-28 14:06:38 +02:00
Johannes Meyer
aaa6a56146
Refactor authentication config form tests and fix auth backend validation
...
refs #6011
fixes #5712
2014-04-28 14:06:38 +02:00
Johannes Meyer
301e29b5e8
Remove statusdat protocol tests
...
refs #4639
2014-04-14 15:35:27 +02:00
Johannes Meyer
1555f55857
Remove broken, invalid and useless ModuleManager tests
...
refs #4639
2014-04-14 14:32:04 +02:00
Johannes Meyer
f69707e6de
Remove Notification tests
...
refs #4639
2014-04-14 13:17:04 +02:00
Johannes Meyer
4667a53121
Remove tab tests
...
refs #4639
2014-04-14 12:50:16 +02:00
Johannes Meyer
1ed1c0bc3c
Remove user auth and backend tests
...
refs #4639
2014-04-14 11:44:02 +02:00
Johannes Meyer
9d9624b331
Remove testcase for the IndexController
...
refs #4639
2014-04-14 10:58:24 +02:00
Johannes Meyer
1df4d9022b
Convert existing mocks to Mockery-mocks (Part 2)
...
refs #4639
2014-04-14 10:57:48 +02:00
Johannes Meyer
4c8428423e
Convert existing mocks to Mockery-mocks (Part 1)
...
refs #4639
2014-04-11 17:03:45 +02:00
Johannes Meyer
927772578d
We do not want to use "@backupStaticAttributes enabled"
...
refs #4639
2014-04-11 15:31:29 +02:00
Johannes Meyer
f3c87782cb
Remove uneccesary date_default_timezone_set calls
...
refs #4639
2014-04-11 10:32:47 +02:00
Johannes Meyer
6897db63a7
Extend session namespace tests
...
refs #4639
2014-04-11 09:36:09 +02:00
Johannes Meyer
3d62b8fda2
Add bootstrapping code for Mockery
...
refs #4639
2014-04-11 09:35:19 +02:00
Johannes Meyer
1db9247d0d
Fix module tests
...
refs #4639
2014-04-10 14:52:08 +02:00
Johannes Meyer
fe9cff843d
Fix GeneralForm tests
...
refs #4639
2014-04-10 14:08:11 +02:00
Johannes Meyer
1e69169bab
Fix database tests
...
refs #4639
2014-04-10 11:33:24 +02:00
Johannes Meyer
d78aec2d48
Fix statusdat component test
...
refs #4639
2014-04-10 10:42:50 +02:00
Johannes Meyer
ccae70bc80
Make all tests inherit from BaseTestCase and fix license headers and style
...
refs #4639
2014-04-10 10:32:50 +02:00
Johannes Meyer
6056327c6d
Fix that it's not possible to set non-existing values in a session with setAll()
...
refs #4639
2014-04-09 16:18:51 +02:00
Johannes Meyer
bd986e8c81
Skip widget tests as view objects cannot be passed "around" anymore
...
refs #4639
2014-04-09 15:29:05 +02:00
Johannes Meyer
4c65acac13
Fix web url test
...
refs #4639
2014-04-09 15:03:09 +02:00
Johannes Meyer
e1793c9ea1
Make the statusdat reader test using its own cache location
...
refs #4639
2014-04-09 14:56:25 +02:00
Johannes Meyer
3a29cc34c9
Mark faulty tests as skipped
...
refs #4639
2014-04-09 14:18:56 +02:00
Johannes Meyer
91675bac50
Remove require instructions from all tests and fix namespaces
...
refs #4639
2014-04-09 14:18:14 +02:00
Johannes Meyer
0dc4a4f541
Refactor php unittest bootstrapping
...
refs #4639
2014-04-09 10:42:06 +02:00
Marius Hein
7708b9901f
Drop BaseTestCase static class loader
...
refs #4639
2014-04-09 09:27:01 +02:00
Marius Hein
746cc4b5d9
Drop obsolete test cases
...
refs #4639
2014-04-09 09:26:11 +02:00
Marius Hein
34822d9a02
Clean up tests [WIP]
...
refs #4639
2014-04-09 09:23:59 +02:00
Marius Hein
0ca0eef311
Test: Using autoloader for tests
...
refs #4639
2014-04-09 09:23:58 +02:00
Johannes Meyer
f802b36ca9
Move session class files
2014-03-25 11:13:10 +01:00
Eric Lippmann
07d04628cf
Merge branch 'feature/installation-and-configuration-cleanup-5638'
...
Conflicts:
config/config.ini.in
library/Icinga/Application/ApplicationBootstrap.php
library/Icinga/Application/Cli.php
library/Icinga/Application/EmbeddedWeb.php
library/Icinga/Application/Logger.php
library/Icinga/Application/Modules/Manager.php
library/Icinga/Application/Web.php
library/Icinga/Authentication/Backend/DbUserBackend.php
library/Icinga/Authentication/Manager.php
library/Icinga/User/Preferences/IniStore.php
test/php/library/Icinga/Application/LoggerTest.php
2014-03-03 19:03:39 +01:00
Johannes Meyer
1e7c863e3c
Add stream writer
...
refs #5683
2014-02-26 13:47:16 +01:00
Johannes Meyer
031c91ce4a
Fix tests that make use of the log wrapper
...
refs #5683
2014-02-26 11:21:23 +01:00
Johannes Meyer
485bbcd25d
Fix AuthenticationManager test
2014-02-21 14:14:45 +01:00
Eric Lippmann
af342d6b3a
Tests: Fix Fatal error: Class 'Icinga\Exception\NotReadableError' not found
2014-02-20 14:02:29 +01:00
Eric Lippmann
8edf421c45
Replace debug log with respecting log priorities
...
refs #5638
fixes #5522
2014-02-18 14:46:15 +01:00
Markus Frosch
971a87c608
Fixed executable flags on normal files.
...
Refs #5040
2014-02-18 09:42:13 +01:00
Eric Lippmann
08d7edebfc
Decouple (automatic) preferences storage from user preferences (WIP)
...
DbStore, persisting preferences and tests not yet reworked.
2014-02-14 17:28:11 +01:00
Eric Lippmann
41ffa1d7c2
Fix PHP Fatal error: Class 'Icinga\Authentication\Membership' not found in ManagerTest.php
2014-02-14 12:11:49 +01:00
Marius Hein
b78eb52732
Fix LoggerTest
...
fixes #5561
2014-02-11 17:12:17 +01:00
Marius Hein
9b45898ed9
Fix: Missing class in GeneralFormTest
2014-02-11 17:12:17 +01:00
Johannes Meyer
6cc4f1b53a
Fix authentication backend tests
2014-01-29 15:57:51 +01:00
Johannes Meyer
2bf9b96aab
Extend functionality of session namespaces and add tests
...
refs #5510
2014-01-24 14:44:19 +01:00
Johannes Meyer
cf778d4609
Implement session namespaces
...
refs #5510
2014-01-24 14:44:19 +01:00
Johannes Meyer
ac0b041523
Remove session handling from the authentication manager
...
refs #5510
2014-01-24 14:44:19 +01:00
Matthias Jentsch
85dbd86e5b
Change all UserBackends to a lazy connection-behavior
...
refs #5506
2014-01-22 13:04:11 +01:00
Marius Hein
5d31633eb5
Fix salt and password used in wrong position
...
fixes #5227
2013-11-27 11:32:07 +01:00
Matthias Jentsch
2a0add3ec3
Fix messages in ConfigController
...
Store messages in the current user session to be able to fetch messages from
other controllers, so that the use can be redirected back to the index, instead
of staying in the original action
refs #5100
2013-11-20 19:10:38 +01:00
Matthias Jentsch
941ce6d68e
Fix bug that caused ajax-request to override values written to the session
...
Authentication/Session.php and its Subclasses do not have a open/closed -state
anymore. Read will refresh the session, write will always write the changes,
and opening/closing will be handled internally.
refs #5101
2013-11-20 12:01:40 +01:00
Matthias Jentsch
984ed0b006
Fix LdapBackendForm unit test
...
refs #4786
2013-11-13 18:33:34 +01:00
Matthias Jentsch
bd38e998d7
Provide a cleaner interface for the Authentication Backends
...
refs #4786
2013-11-06 14:49:16 +01:00
Matthias Jentsch
59d4baff0b
Fix remaining references to DbUserBackend and refresh the documentation.
...
refs #4786
2013-11-06 13:31:07 +01:00
Matthias Jentsch
ad08691362
Extend resources.ini to contain all resources, including ldap
...
Remove the old calls to DbAdapterFactory and use ResourceFactory instead. Remove
the DbAdapterFactory and fix all unit tests that have been broken due to the changes.
Change the functionality of the ResourceFactory to also handle LdapConnections
resolves #4587
2013-11-06 10:20:15 +01:00
Eric Lippmann
ca1d50ae53
Rename Icinga 2 Web to Icinga Web 2
2013-10-23 15:11:06 +02:00
Marius Hein
b071160cdc
Fix tests for ldap and login mask
...
refs #4941
2013-10-22 17:50:21 +02:00
Jannis Moßhammer
b553b4b61e
Fix tests reflecting removed 'OR' queries and array operator
2013-10-21 17:15:39 +02:00
Jannis Moßhammer
f3bbf09bae
Status.dat query fixes and documentation after rebase
...
refs #3801
2013-10-20 15:16:44 +02:00
Jannis Moßhammer
f350011028
Add Status.dat backend
...
refs #3801
2013-10-20 15:16:44 +02:00
Marius Hein
23de93e400
Fix TabTest used with icon class
...
fixes #4915
2013-10-18 11:32:53 +02:00
Jannis Moßhammer
7a7c10e8df
Fix EventHistory Query and tests
...
refs #4868
2013-10-17 20:53:11 +02:00
Jannis Moßhammer
4a95ba3468
Change url handling to detail on hashtag, add service filter
...
The url is now
http://%mainUrl%#%anchor%!detail=%detailUrl%
which allows us to better support IE and prevents
the detail url from appearing on the server side.
refs #4868
2013-10-17 19:55:00 +02:00
Jannis Moßhammer
c034a5eff8
Fix tests and a few member access issues
...
refs #3801
2013-10-17 19:55:00 +02:00
Jannis Moßhammer
44be5e85da
Refactoring and Query and IDO code,
...
the Monitoring/View code was completly dropped in favor of
the DataView implementations, as new Backends otherwise
would require to implement two seperate query logics
refs #3801
2013-10-17 19:54:58 +02:00
Jannis Moßhammer
d33cec78de
Semantic search implementation
...
- Only implemented for hosts as an example
- URL behaviour still has to be normalized
refs #4469
2013-10-17 19:52:52 +02:00
Jannis Moßhammer
24da98be83
Implement base filter library and tests
...
refs #4469
2013-10-17 19:52:25 +02:00
Eric Lippmann
a42668edb8
Fix tests
...
refs #4663
2013-10-09 09:20:17 +02:00
Jannis Moßhammer
7690b0ec7f
Add basic tests and meta attributes for graphs
...
refs #4614
2013-09-25 14:24:26 +02:00
Eric Lippmann
24f64e6d30
Fix conflicts from rebase, using inet_aton with pgsql, PHP strict standards violations, CS compliance
...
refs #4255
2013-09-17 15:12:18 +02:00
Thomas Gelf
bb99358a21
Renamed MonitoringView to AbstractView
2013-09-17 10:41:02 +02:00
Eric Lippmann
a47db3497e
Rename BaseCommand to Command
...
refs #4580
2013-09-16 14:44:59 +02:00
Eric Lippmann
bf012fbd7e
Remove CommandType interface
...
Moved BaseCommand from the monitoring module to the application's library.
refs #4580
2013-09-16 14:39:14 +02:00
Johannes Meyer
4964d84e78
Doc fixes
...
refs #4580
2013-09-16 13:14:29 +02:00
Johannes Meyer
8e60e2dcd9
Fix group and children handling of ScheduleDowntimeCommand
...
refs #4580
2013-09-16 13:14:29 +02:00
Johannes Meyer
7045148f93
Adjust submitpassivecheckresult command handling
...
refs #4580
2013-09-16 13:14:29 +02:00
Johannes Meyer
fef8370d5f
Adjust reschedulecheck command handling
...
refs #4580
2013-09-16 13:14:28 +02:00
Johannes Meyer
e9dc895b37
Adjust delay notification handling
...
refs #4580
2013-09-16 13:14:28 +02:00
Johannes Meyer
36424b508b
Adjust custom notification handling
...
refs #4580
2013-09-16 13:14:28 +02:00
Johannes Meyer
52079b2e73
Adjust schedule downtime handling
...
refs #4580
2013-09-16 13:14:28 +02:00
Johannes Meyer
ba7f455643
Adjust schedule downtime handling (WIP)
...
refs #4580
2013-09-16 13:14:28 +02:00
Eric Lippmann
a5908c9553
CS: Replace multiple empty lines with one
...
find application/ library/Icinga/ test/ modules/ -name *.php | xargs sed -i '/^$/N;/^\n$/D'
2013-09-04 18:36:10 +02:00
Eric Lippmann
b5e93afd86
CS: Add newline at end of file
...
find application/ library/ test/ modules/ -name *.php | xargs sed -i '$a\'
2013-09-04 18:28:35 +02:00
Eric Lippmann
35fd9fd391
CS: Remove whitespaces at end of line
...
find application/ library/ test/ modules/ -name *.php | xargs sed -i 's/\s\+$//'
2013-09-04 18:27:16 +02:00
Johannes Meyer
b74e264f01
Refactor comment command handling
...
- Refactored Comment class
- Dropped IComment interface
- Added AddCommentCommand class
- Updated CommentForm
refs #4580
2013-09-04 18:08:00 +02:00
Johannes Meyer
9a476f16f4
Re-refactor dispatch process of commands and acknowledgement handling
...
refs #4580
2013-09-04 18:08:00 +02:00
Jannis Moßhammer
d27e34cef8
Codestyle and Test fixes for SortBox
...
refs #4601
2013-09-04 15:22:00 +02:00
Eric Lippmann
1b858cbdb4
Monitoring: Fix remaining usages of namespace Monitoring without Icinga\Module prefix
...
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
3e4d1aa2fb
Monitoring/Tests: Replace BaseFormTest with BaseTestCase
...
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
74b9731df5
Remove auto class requirement from BaseTestCase::createForm()
...
The tests for the respective forms must require the form class.
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
c86874d4ba
Rename namespace Monitoring to Icingæ\Module\Monitoring
...
refs #4586
2013-09-04 11:21:11 +02:00
Jannis Moßhammer
a0e63a1320
Fix error message and move validation in own DateTimeValidator
...
refs #4581
refs #4632
2013-09-04 11:06:36 +02:00
Johannes Meyer
4d040fd761
Adjust command forms and tests
...
Made those command forms using the DateTimePicker
element compatible with its new validation.
refs #4581
2013-09-04 11:06:36 +02:00
Johannes Meyer
14b56151aa
Move configuration and preference handling to Form base class
...
Moved setConfiguration, setUserPreferences and getUserPreferences
to our Form base class due to some redundancies.
refs #4581
2013-09-04 11:06:24 +02:00
Johannes Meyer
23f0962da1
Adjust command forms and tests
...
Made those command forms using the DateTimePicker
element compatible with its new validation.
refs #4581
2013-09-03 09:27:02 +02:00
Johannes Meyer
368bd3c9c7
Refactor datetime validation
...
The DateTimePicker form element needs to know from now on,
how user input can be formatted when validating.
refs #4581
2013-09-03 09:27:02 +02:00
Johannes Meyer
1a003f8c8b
Move configuration and preference handling to Form base class
...
Moved setConfiguration, setUserPreferences and getUserPreferences
to our Form base class due to some redundancies.
refs #4581
2013-09-03 09:27:02 +02:00
Jannis Moßhammer
18d021d104
Fix logger not testing if it's disabled
...
refs #4595
2013-09-02 12:16:05 +02:00
Jannis Moßhammer
4d9ecd2b3b
Fix FormTest breaking after onchange modification
...
refs #4622
2013-09-02 10:59:05 +02:00
Marius Hein
446da85a88
UserBackend: Fix interface in test
...
refs #4593
2013-08-30 15:32:06 +02:00
Marius Hein
7c8252a983
Rename class Credentials to Credential
...
refs #4641
2013-08-30 12:50:57 +02:00
Marius Hein
83d20a6175
AuthManager: Fix tests
...
refs #4641
2013-08-30 12:50:28 +02:00
Johannes Meyer
bf5849a769
Fix GeneralForm tests
...
refs #4609
2013-08-29 15:08:31 +02:00
Jannis Moßhammer
2c97ab26a4
Code style, Form tests and bugfixes
...
This commit summarizes the bugfixes made in this branch. As the frontend the fixes required a lot of stuff to be fixed afterwards and #4602 was used as a larger example regression test, this affects a few tickets:
- (Bug 4491) Frontend tests will hang randomly: CasperJS now operates on the installed version, so this shouldn't happen anymore
- (Bug 4602) Configuration Interface - Authentication: Backends moved when pushing enter: The authentication interface is reworked and does not persist a state over pages
- (Bug 4605) /tmp should not be the default log path: Now it is the application relative var/log path
- (Bug 4606) Configuration: Show message that changes were saved successfully: Implemented and tested with casperjs
- (Bug 4641) Installation/Testing fix configure/make: This has been reworked
- (Bug 4642) Allow Application placeholder in config: This was required for implementimg 4605
- (Bug 4643) Application doesn't work with older Zend Versions: A fallback __call has been implemented for this
refs #4491
refs #4602
refs #4605
refs #4606
refs #4641
refs #4642
refs #4643
2013-08-29 11:48:33 +02:00
Jannis Moßhammer
0b515e39ac
Implement {app} placeholder and Icinga\Config::resolvePath()
...
refs #4642
2013-08-29 11:48:32 +02:00
Jannis Moßhammer
51d9f8eaa7
Remove original authenticationFormTest
...
refs #4606
2013-08-29 11:48:32 +02:00
Matthias Jentsch
874b163009
Fix comment padding and some coding-style issues in the test classes
...
refs #4615
2013-08-27 18:28:21 +02:00
Matthias Jentsch
5b58d5488b
Add support for section reordering and formatting options to the PreservingIniWriter
...
The PreservingIniWriter needs to be aware of the the order of the sections and
update the section declarations in the configuration file when the order has
changed. Therefore add functions to correctly reorder sections.
refs #4615
2013-08-27 18:28:21 +02:00
Marius Hein
c5bea04909
BaseTestCase: User response, CS and typo
...
refs #4608
2013-08-27 10:37:35 +02:00
Marius Hein
dc71885eac
Fix icinga application forms using BaseTestCase now
...
refs #4608
2013-08-26 13:25:20 +02:00
Marius Hein
1dfc578c00
Fix provider for Authentication/DbUserBackendTest
...
refs #4608
2013-08-26 12:36:49 +02:00
Marius Hein
69aa6e3d22
Test: Fix provider for Preferences/DbStoreTest
...
refs #4608
2013-08-26 11:41:35 +02:00
Marius Hein
1130376ad6
BaseTest: Create class and tests
...
refs #4608
2013-08-26 11:15:27 +02:00
Matthias Jentsch
49cf62a9dc
Fix database related bugs
...
Fix coding standards in database schemes. Use DbAdapterFactory in all unit
tests instead of creating own adapters. Fix DbUserBackend and DbStore to use
FETCH_OBJ, instead of FETCH_ASSOC, to handle it consistently in the whole
application. Remove unnecessary table columns from the "account" scheme.
refs #4577
refs #4578
refs #4596
refs #4599
refs #4627
2013-08-26 11:09:37 +02:00
Marius Hein
9d4ca7739b
Bootstrap: Safe application start
...
Log exceptions and inform user if something goes wrong.
refs #4625
refs #4592
2013-08-23 17:28:13 +02:00
Marius Hein
afc302d45c
Bootstrap: Safe application start
...
Log exceptions and inform user if something goes wrong.
refs #4625
refs #4592
2013-08-23 17:28:13 +02:00
Eric Lippmann
d813ca62c5
Db: Set MySQL server SQL modes to behave closer to ANSI SQL
...
Was already implemented but someone dropped it accidentally
2013-08-21 14:40:37 +02:00
Jannis Moßhammer
9cd4c2f856
Fix codestyle, add basic tests
...
refs #4525
2013-08-21 14:22:30 +02:00
Jannis Moßhammer
a6ff6ecadd
Fix Codestyle/PHPDoc, fix configPath being Overwritten
...
Also removed possibility to disable debugging as there's no use case for this
refs #4525
refs #4598
2013-08-21 14:22:30 +02:00
Marius Hein
71603ccd70
Fix factory resource mock structure
...
refs #3777
2013-08-21 14:22:30 +02:00
Jannis Moßhammer
972bc9853e
Configuration interfaces for logging, authentication and general configuration
...
- Added HelpText decorator
- Added Time and DateFormatValidator
- Added tests
refs #3777
2013-08-21 14:22:30 +02:00
Jannis Moßhammer
4810a0d47e
Code style and test fixes
...
refs #3777
2013-08-21 14:22:29 +02:00
Jannis Moßhammer
17c1e5a449
Add tests, move BaseFormTest away from modules/monitoring
...
refs #3777
2013-08-21 14:18:53 +02:00
Marius Hein
d348477455
Fix user test case: DateTimeZone comparison
2013-08-20 11:27:25 +02:00
Marius Hein
3a8a3b8f2c
Monitoring backend: Change database objects to DbAdapterFactory
...
refs #4575
2013-08-19 18:29:26 +02:00
Eric Lippmann
329d63839b
Monitoring/Commands: Fix tests
...
refs #4524
2013-08-16 17:38:50 +02:00
Jannis Moßhammer
0b479e3796
Code style fixes, fix documentation, fix tab parameters not being overwritten
...
refs #4512
2013-08-16 15:08:28 +02:00
Jannis Moßhammer
49d56f1eab
Fix capitalization error in test require
...
refs #4512
2013-08-16 15:08:28 +02:00
Jannis Moßhammer
b28c7f2f4c
Refactor test, tabs and controller
...
- Remove unused methods,
- Code style
- Documentation for widgets
- Tabextensions instead of hardcoded tab actions
- Add tests for tabs
- Add missing phpdoc for touched files
- Fix tests
refs #4512
refs #4541
refs #4540
2013-08-16 15:08:28 +02:00
Matthias Jentsch
7f30b587be
Change the StoreFactory to work with the DbAdapterFactory and fix code styling
...
Change the StoreFactory configuration to reference to a resource instead of
defining the whole database. Additionally fix docstrings, fix imports and fix
function calls to comply to coding style standards.
refs #4503
2013-08-15 14:16:34 +02:00
Matthias Jentsch
f1040aad60
Add additional functionality and documentation for easier use through developers
...
Add functions to get information about currently available resources and add
documentation about class usage for developers.
2013-08-14 16:22:58 +02:00
Matthias Jentsch
3ce44b72e1
Change accepted exception type of unit test
...
Change the generic type Exception to a more specific one, to achieve
a more accurate test case.
resolves #4503
2013-08-14 16:22:58 +02:00
Matthias Jentsch
68deb735c0
Add the DbAdapterFactory to instanciate database adapters using resource names
...
Create the DbAdapterFactory to instanciate db adapters, add resources.ini to configure resources, change
the authentication Manager to fall back to backends with lower priority in case
of errors, update the current UserBackends to the changed environment. Also
adjust the documentation and existing unit tests.
resolves #4503
2013-08-14 16:22:58 +02:00
Jannis Moßhammer
be29b8ff8f
Make ConfigController and PreferenceController extensible by convention
...
- Rename ConfigurationController to ConfigController
- ConfigController and PreferenceController are now subclasses of
BaseConfigController and BasePreferenceController
- Module and Application Config/Preference Tabs are detected via
the ControllerTabCollector
- Moved Controller classes to Icinga/Web/Controller (this is why
so many files are modified)
refs #4530
2013-08-14 16:08:15 +02:00
Matthias Jentsch
eecbc233b9
Fix behavior of PreservingIniWriter that caused comments at the line end to be deleted
...
Implement a function to fetch comments at line end and use it to preserve
comments. Change the regular expressions used to parse lines to be more aware
of whitespaces between terms. Add automatic value and comment indentation
to produce cleaner output.
2013-08-14 15:05:10 +02:00
Eric Lippmann
bd140f2828
CC: Fix phpcs errors of files changed in feature/datetime-element-4440
...
refs #4440
2013-08-12 16:43:10 +02:00
Eric Lippmann
2c217d1d06
Framework/DateTime: No longer use the Unix timestamp format since this ignores the time zone
...
refs #4440
2013-08-12 16:43:10 +02:00
Eric Lippmann
9f22905837
Framework/DateTimePicker: Set element's value to Unix timestamp after the input is considered valid
...
refs #4440
2013-08-12 16:43:09 +02:00
Eric Lippmann
3d104474d9
Tests: Fix UserTest as getTimeZone now returns a DateTimeZone object
...
refs #4440
2013-08-12 16:43:09 +02:00
Eric Lippmann
ba00fd39df
Framework: Get DateTimePicker's value as timestamp and add input validation
...
refs #4440
2013-08-12 16:43:09 +02:00
Eric Lippmann
da7f619804
Framework: Implement DateFormat view helper
...
Support date, time and datetime formatting based on format strings
set either by the user or via config.ini. The view helper
FormDateTime uses the new helper already
refs #4440
refs #4424
2013-08-12 16:43:09 +02:00
Eric Lippmann
8af901e9ed
Framework/User: Implement getTimezone to retrieve the user's Timezone
...
refs #4440
2013-08-12 16:42:50 +02:00
Eric Lippmann
93ae6d6811
Framework: mv Icinga\Config\Config to Icinga\Application\Config
...
refs #4543
2013-08-12 15:02:25 +02:00
Jannis Moßhammer
ec17efe328
Add test for Dimension
...
refs #4192
2013-08-07 17:44:40 +02:00
Jannis Moßhammer
b3e0d5e8ce
Remove AbstractWidget and make Widget an interface
...
As Widget's already denote an abstract concept, the name
'AbstractWidget' is redundant. Also this class didn't do anything except
fetching a view via a singleton (which is now injected into the render method)
and bypassing the PHP class properties by creating a 'properties' array which is
filled with magic getters and setters (which now are simply php class properties)
Further changes:
- toString is removed, as this incorporated a lot of
application logic which would cause unrecoverable
errors when throwing exceptions
- renderToHtml is now just render and the view dependency must be
passed, as a widget shouldn't be responsible for getting
view instance (this means that <?= $this->tabs ?> is now
<?= $this->tabs->render($this); ?> in the templates
- Controllers don't have $this->widget anymore as Widgets are
directly instanciated with their class, allowing better code completion
and avoiding hidden dependencies, also Widget::create is now removed
in favor of direct instanciation.
refs #4192
2013-08-07 17:41:43 +02:00
Matthias Jentsch
c1338898a6
Fix errors in function comments and move IniEditor into single class file
...
refs #4352
2013-08-07 15:58:51 +02:00
Matthias Jentsch
56e47fd084
Add an ini writer for configuration files
...
Add an ini writer that respects the file structure and the comments that may be
already present in the config file. Move Application/Config.php into
Config/Config.php.
refs #4352
2013-08-07 15:58:42 +02:00
Johannes Meyer
4befc9be94
Merge branch 'feature/preferences-backend-4069'
...
resolves #4069
2013-08-06 12:04:16 +02:00
Johannes Meyer
3ad4a4281d
Add missing form tests and update documentation
...
refs #4439
2013-08-06 11:11:29 +02:00
Johannes Meyer
98e7ab02db
Implement dynamic form elements
...
Rename "isPostAndValid" to "isSubmittedAndValid" and refactor it.
Add possibility for specific form elements to auto-submit their form.
refs #4439
2013-08-06 11:09:42 +02:00
Jannis Moßhammer
4f1e6ec720
Code style and comment fixes
...
refs #4441
2013-08-06 09:27:37 +02:00
Jannis Moßhammer
b44de95caa
Call commandhandler from commandcontroller actions
...
The CommandController now implements the calls to the specific
command methods and sends commands to the icinga process
refs #4441
2013-08-06 09:27:37 +02:00
Jannis Moßhammer
d6bbed3a54
Extract the transport functions from the CommandPipe
...
- The CommandPipe class now delegates submission of commands to
the Transport classes (LocalPipe or SecureShell)
- Added SSH options for non-interactive mode
- Refactored tests
refs #4441
2013-08-06 09:27:37 +02:00
Marius Hein
6112189b0c
User preferences: Add database store
...
refs #4069
2013-08-05 16:56:03 +02:00
Marius Hein
6d1f349616
User preferences: Implement interfaces and ini store
...
refs #4069
2013-08-05 16:56:02 +02:00
Jannis Moßhammer
5a82c37ed1
Fix session test save path not being writable for vagrant user
...
The tests now try to write to /tmp and are skipped if this folder
is not writable. Also the test has been refactored a bit (comments,
assertion messages)
regs #4461
2013-08-02 15:35:05 +02:00
Jannis Moßhammer
5c3eb1d796
Style fixes and addParam test
...
refs #4381
2013-08-02 13:14:56 +02:00
Jannis Moßhammer
50ca1aec1a
Refactor URL class and test
...
The constructor of the class is now private, instantiation happens
with Url::fromRequest and Url::fromPath. Also updated all occurences
of Url and fixed the Qlink helper to not overwrite the baseUrl with null
values
refs #4381
2013-08-02 13:14:55 +02:00
Marius Hein
a1a8d4c157
Code compliance change and rename refs to User
...
refs #4066
2013-07-30 14:06:46 +02:00
Marius Hein
8510d57cf8
Prepare user settings api
...
Rework application bootstrap, move user object to its new location, implement web
request class to handle the user object.
refs #4066
2013-07-30 14:06:46 +02:00
Matthias Jentsch
d5d0da6b1b
Add missing property comments in DbUserBackendTest
...
refs #3769
2013-07-29 12:47:15 +02:00
Matthias Jentsch
e51737f42a
Fix the installation manual, comments and give the unit-test functions a more
...
verbose name
refs #3769
2013-07-29 11:42:31 +02:00
Matthias Jentsch
94e9ffc7b3
Fix comments
...
refs #3769
2013-07-26 15:57:37 +02:00
Jannis Moßhammer
306a51271b
Change 'user' table to 'account', error handling and docs
...
Fix installation instructions for postgresql, the user table is now
'account', as user is a keyword in some rdbms, now catching exceptions
and returning auth failed while logging errors
refs #3769
2013-07-26 15:01:52 +02:00
Matthias Jentsch
fd4cbf1c5b
Add default login to the authentication database
...
refs #3772
2013-07-26 13:10:00 +02:00
Matthias Jentsch
b013966464
Fix unit tests and add documentation
...
Add functionality to check if a certain database type like psql or mysql is
available and skip the tests accordingly.
Add documentation for backend authentication.
refs #3769
2013-07-26 13:09:59 +02:00