Commit Graph

3112 Commits

Author SHA1 Message Date
Eric Lippmann 9a758f3ed9 doc: Use Controller::httpNotFound() in SearchController
refs #9644
2015-07-28 13:47:25 +02:00
Eric Lippmann 9846dfb2e2 doc: Use Controller:httpNotFound() in ModuleController
refs #9644
2015-07-28 13:47:06 +02:00
Eric Lippmann 7cfc78558d Merge branch 'master' into feature/secure-modules-9644
Conflicts:
	library/Icinga/Exception/IcingaException.php
2015-07-28 13:42:02 +02:00
Eric Lippmann 0d2f73668d Merge branch 'bugfix/non-compound-9449'
fixes #9449
2015-07-28 13:37:39 +02:00
Eric Lippmann a8765bc4ea monitoring: Remove unnecessary use in StatehistoryForm
refs #9449
2015-07-28 13:36:51 +02:00
Eric Lippmann 7df1b3aa0f monitoring: Fix use statements in EventOverviewForm
refs #9449
2015-07-28 13:35:52 +02:00
Eric Lippmann 0a01eb66b1 monitoring: Remove unnecessary use w/ backslash in DeleteDowntimesCommandForm
refs #9449
2015-07-28 13:34:39 +02:00
Eric Lippmann 919c7c52cf monitoring: Fix PHPDoc in DeleteDowntimeCommand 2015-07-28 13:33:56 +02:00
Eric Lippmann dd7d078704 monitoring: Fix PHPDoc in DeleteCommentCommand 2015-07-28 13:33:56 +02:00
Eric Lippmann 5d01dca291 monitoring: Fix PHPDoc in DeleteDowntimesCommandForm 2015-07-28 13:33:56 +02:00
Eric Lippmann 72c3337be8 monitoring: Use @inheritdoc in DeleteDowntimeCommandForm 2015-07-28 13:33:56 +02:00
Eric Lippmann 455d2cee69 monitoring: Use @inheritdoc in DeleteCommentCommandForm 2015-07-28 13:33:56 +02:00
Eric Lippmann 9bd31f70e2 monitoring: Remove unnecessary use w/ backlash in DeleteDowntimeCommandForm
refs #9449
2015-07-28 12:44:27 +02:00
Eric Lippmann f6ec028627 monitoring: Fix PHPDoc in DeleteCommentsCommandForm 2015-07-28 12:32:19 +02:00
Eric Lippmann 36a5ec3e17 monitoring: Fix PHPDoc in CommandForm 2015-07-28 12:32:19 +02:00
Eric Lippmann 901e6754eb monitoring: Define CommandTransportInterface::send() 2015-07-28 12:32:19 +02:00
Eric Lippmann b2fb0a836f monitoring: Move CommandTransportException to the monitoring's exception namespace 2015-07-28 12:32:19 +02:00
Eric Lippmann 4536eacd66 monitoring: Rename TransportException to CommandTransportException 2015-07-28 12:32:19 +02:00
Eric Lippmann ec07da6c5e monitoring: Remove unnecessary use w/ backlash in DeleteCommentsCommandForm
refs #9449
2015-07-28 11:56:48 +02:00
Eric Lippmann d850cffa42 doc: Remove unnecessary use in SearchController
refs #9449
2015-07-28 11:55:27 +02:00
Eric Lippmann b3f463a7a5 doc: Remove unnecessary use in ModuleController
refs #9449
2015-07-28 11:54:55 +02:00
Eric Lippmann e70fb76d31 doc: Remove unnecessary use in IcingawebController
refs #9449
2015-07-28 11:54:00 +02:00
Johannes Meyer d56b31fe5e DataView\Eventhistory: Fix sort rules
refs #6644
2015-07-28 11:42:55 +02:00
Johannes Meyer 247c0f3952 DataView\Customvar: Fix sort rules
refs #6644
2015-07-28 11:42:40 +02:00
Johannes Meyer 1f6bc8ea47 DataView: Implement interface SortRules
refs #6644
2015-07-28 11:41:25 +02:00
Eric Lippmann 07fb82357b doc: Make documentation for all installed modules avaiable
Before, only documentation of enabled modules was available.

refs #9644
2015-07-27 15:19:32 +02:00
Johannes Meyer 998610bafa ProgramstatusQuery: Provide a(nother) fallback for older IDO installations
fixes #9168
2015-07-24 15:46:12 +02:00
Johannes Meyer 2c4b6eb915 ResourceConfigForm: Replace isValid- with inspectResource()
refs #7588
2015-07-24 14:24:11 +02:00
Johannes Meyer b3e6b2755c UserBackendConfigForm: Replace isValid- with inspectUserBackend()
refs #7588
2015-07-24 11:45:49 +02:00
Johannes Meyer 56759e7f21 Merge branch 'master' into feature/ldap-auth-backend-discovery-9602 2015-07-24 10:52:14 +02:00
Eric Lippmann 12856da971 Merge branch 'bugfix/filter-custom-variables-9692'
fixes #9692
2015-07-24 09:27:05 +02:00
Johannes Meyer 0448323697 InstanceConfigForm: Translate exceptions shown to the user 2015-07-23 16:18:44 +02:00
Johannes Meyer 666c401a40 BackendConfigForm: Translate exceptions shown to the user 2015-07-23 16:18:35 +02:00
Johannes Meyer 4e3da3a6eb UserBackendConfigForm: Adjust how to process requests...
...and use sub-forms, finally.

refs #9602
2015-07-23 16:18:09 +02:00
Johannes Meyer 1d3a0f63eb BackendConfigForm: Fix that skipping the schema validation is not possible
fixes #9719
2015-07-23 12:25:30 +02:00
Eric Lippmann a75b1a35c6 monitoring: Don't fail when selecting custom variables while having a group by clause
refs #9692
2015-07-22 13:47:52 +02:00
Eric Lippmann 63c51c01e0 monitoring: Auto-refresh tactical overview every 15 seconds
fixes #9626
2015-07-22 13:40:50 +02:00
Eric Lippmann 15cb24c6dc Throw an exception in IdoQuery::getCustomvarColumnName() in case the custom variable has not been joined
Queries extending IdoQuery and using the method getCustomvarColumnName() must be notified in case the custom variable has not been joined.

refs #9692
2015-07-22 12:03:34 +02:00
Eric Lippmann 3ed13366a8 Remove duplicate line in IdoQuery
I introduced this w/ 4522cf5090.
2015-07-22 12:03:34 +02:00
Eric Lippmann 163911ffd7 Indicate empty icinga_programstatus table as problem
fixes #9695
2015-07-21 16:47:17 +02:00
Eric Lippmann 4522cf5090 Add missing return to IdoQuery::getCustomvarColumnName()
Some filter combinations still seem to not work properly.

refs #9692
2015-07-21 15:27:01 +02:00
Johannes Meyer 47fbc24f17 Merge branch 'master' into bugfix/improve-form-notifications-8983
Conflicts:
	library/Icinga/Web/Form.php
	modules/setup/application/forms/AdminAccountPage.php
2015-07-20 15:52:10 +02:00
Johannes Meyer 9a90e2a183 Wizard: Be less hysteric to not to make users upset
fixes #9620
2015-07-15 08:50:39 +02:00
Johannes Meyer 8b4c2c459a comments overview: Improve link titles 2015-07-13 12:51:50 +02:00
Johannes Meyer d6f756c670 downtimes overview: Improve link titles 2015-07-13 12:51:12 +02:00
Johannes Meyer c90da0378d downtimes overview: Fix detail links 2015-07-13 12:17:00 +02:00
Johannes Meyer 3db81a8d0f downtimes-header: Do not show links with a bold font 2015-07-10 15:46:24 +02:00
Johannes Meyer d0a588ef58 downtimes-header: Do not access a non-existent property, again
I don't get it..
2015-07-10 15:43:07 +02:00
Johannes Meyer ac8a2d1673 downtimes-header: Show proper times for fixed downtimes not yet started 2015-07-10 15:41:42 +02:00
Johannes Meyer 831581471c downtimes/show.phtml: Drop redundant link title
Such a title has not any advantage as it contains the same content
as the link label.
2015-07-10 15:17:25 +02:00
Johannes Meyer 3091b8cf5c downtimes/show.phtml: Do not show an (inappropriate) icon in the title 2015-07-10 15:16:16 +02:00
Johannes Meyer 52bde67653 Link: Show the link's label in its title as well 2015-07-10 15:12:56 +02:00
Johannes Meyer 9ca1a6dea6 downtimes-header: Add links for hosts and services 2015-07-10 15:11:59 +02:00
Johannes Meyer 4fd5c43c70 downtimes-header: Show a line-break between an object's name and..
..a downtime's description
2015-07-10 14:44:24 +02:00
Johannes Meyer e8f16d112d downtimes-header: We're listing downtimes rather than showing them 2015-07-10 14:43:36 +02:00
Johannes Meyer 006d2cb537 downtimes-header: Be more efficient when listing downtimes 2015-07-10 14:39:30 +02:00
Johannes Meyer bba57d2bbc downtimes-header: Use <strong> instead of <b> 2015-07-10 14:32:08 +02:00
Johannes Meyer 5ded76536e downtimes-header: Use the correct property to access a service's name
Seems to me that no-one has ever selected multiple service downtimes..
2015-07-10 14:30:07 +02:00
Johannes Meyer e5f62f017f DeleteCommentCommandForm: Show a trash icon instead
The "cancel" icon is, like its name implies, supposed to abort/close
something..
2015-07-10 14:26:39 +02:00
Matthias Jentsch 39df25f043 Fix HTML detection in PluginOutput
refs #9036
2015-07-08 15:16:32 +02:00
Johannes Meyer fc8b51c4be ObjectList: Register columns to select even if we're only counting
We should never apply any pseudo optimizations on a higher level if
already the lower level applies them, as the optimization might not
be valid in every circumstance.

fixes #9573
2015-07-07 15:50:40 +02:00
Matthias Jentsch 604ef87de8 Merge branch 'bugfix/plugin-output-always-escaped-9036'
fixes #9036
2015-07-07 10:24:54 +02:00
Matthias Jentsch 4f884b1529 Revert "Don't use HTMLPurifier in list views to improve performance"
Performance gain turned out to be insignificant. This reverts commit 17bb725f84.

refs #9036
2015-07-07 10:17:04 +02:00
Matthias Jentsch 17bb725f84 Don't use HTMLPurifier in list views to improve performance
refs #9036
2015-07-06 17:14:36 +02:00
Matthias Jentsch b505101694 Comply to coding guidelines 2015-07-06 15:47:04 +02:00
Matthias Jentsch 7bda4ce42b Do not escape certain HTML markup for plugin output
Use specialized escape functions for plugin output that allow certain HTML formatting to be allowed.

refs #9036
2015-07-06 15:36:43 +02:00
Matthias Jentsch 9d2f0be24c Identify perfdata containing html markup properly
refs #9036
2015-07-06 14:43:32 +02:00
Johannes Meyer 107c9ff533 Wizard: Use a unordered list to show requirements instead of nested tables
fixes #9533
2015-07-06 13:37:37 +02:00
Johannes Meyer c8c0e13184 Wizard: Show a textarea on the finish page instead of multiple paragraphs
refs #7911
2015-07-03 16:31:11 +02:00
Johannes Meyer cef9b58029 InstancePage: Show missing fields
fixes #9540
2015-07-03 15:07:58 +02:00
Johannes Meyer 74a916d72a Hide feature commands which are not supported by Icinga 2 from the user
fixes #7930
2015-07-03 14:17:06 +02:00
Johannes Meyer 3e5e6ec64e ToggleInstanceFeaturesCommandForm: Only issue a command for changes 2015-07-03 13:36:24 +02:00
Johannes Meyer 56c4fdf8a1 Wizard: Fix db privilege checks, again
The wizard were not able to verify privileges if some or even all
privileges were granted on database level causing it to grant
redundant privileges on table level.
2015-07-03 10:28:09 +02:00
Johannes Meyer 3aae1acc97 WebWizard: Validate the db schema correctly
This was being validated successfully no matter whether the
schema actually existed or not...
2015-07-02 17:02:12 +02:00
Johannes Meyer 49d4be79ef DbTool: Some coding style fixes 2015-07-02 17:00:04 +02:00
Johannes Meyer 0c1365753e DbTool: Properly escape database wildcards when checking privileges
fixes #9543
2015-07-02 16:58:37 +02:00
Johannes Meyer 2f05ca6332 Wizard: Re-render passwords on the admin account and db creation page
That's not placeholders, actually, but this will be solved in a
different issue. (in a more generic way)

fixes #9545
2015-07-02 11:50:23 +02:00
Johannes Meyer 9feb29d99b LdapDiscoveryPage: Prefer our form error implementation 2015-07-02 11:19:08 +02:00
Johannes Meyer f8034cfb9d DbResourcePage: Prefer our form error implementation 2015-07-02 11:18:45 +02:00
Johannes Meyer 2b11168673 DatabaseCreationPage: Prefer our form error implementation 2015-07-02 11:18:29 +02:00
Johannes Meyer e43abd37a1 DbResourcePage: Drop hidden element `prefix'
That's not a valid configuration option anymore.
2015-07-02 10:31:03 +02:00
Johannes Meyer 3e69ef7e9e WebWizard: Fix condition for page `setup_config_db_resource'
refs #8709
2015-07-02 10:23:27 +02:00
Johannes Meyer f0d7629209 AuthBackendPage: Do only create a resource config if necessary 2015-07-02 10:18:37 +02:00
Johannes Meyer 3b63868ed9 MonitoringWizard: Prefer our form error implementation 2015-07-02 09:45:00 +02:00
Johannes Meyer d69ab427a6 MonitoringWizard: Fix documentation 2015-07-02 09:42:59 +02:00
Johannes Meyer ac78661943 WebWizard: Fix documentation 2015-07-02 09:23:09 +02:00
Johannes Meyer 7795ad4f95 WebWizard: Drop preferences page and include ApplicationConfigForm instead
refs #8709
2015-07-01 16:02:40 +02:00
Johannes Meyer 87cdd49b1c AdminAccountPage: Fix username validation 2015-07-01 14:25:43 +02:00
Johannes Meyer f615db01fe WebWizard: Show db resource config right after choosing db as auth type
refs #8709
2015-07-01 14:24:48 +02:00
Johannes Meyer 0dc604029a AdminAccountPage: Do not put an element's description at the top of the form 2015-06-30 15:10:17 +02:00
Matthias Jentsch aecfb2eb97 Merge branch 'bugfix/multiselection-not-visible-9054'
fixes #9054
fixes #9346
2015-06-30 14:08:19 +02:00
Matthias Jentsch 0fcb054be4 Fix service selection in event history
Add rowaction class to all service rows, to make services selectable again.
2015-06-30 14:07:27 +02:00
Johannes Meyer 2dcbee27bc AdminAccountPage: Add missing form title
refs #8704
2015-06-30 11:38:59 +02:00
Johannes Meyer ae9fa38ac4 AdminAccountPage: Drop unused view script
refs #8704
2015-06-30 11:38:40 +02:00
Johannes Meyer c787eadcfe AdminAccountPage: Use a select input to choose how to define a user
refs #8704
2015-06-30 10:58:17 +02:00
Johannes Meyer 3ea9e50c02 AdminAccountPage: Fetch the entire set of users only if necessary
refs #8704
2015-06-30 09:20:52 +02:00
Matthias Jentsch aec59d9941 Use current filter to highlight active rows instead of storing active rows in JS
Clean up selection code and move it into separate behavior and parse filter query to fetch selectable rows.

refs #9054
refs #9346
2015-06-29 18:48:42 +02:00
Johannes Meyer 9c82a24083 ServicestatussummaryQuery: Do not check a host's state twice
I was sure that this is necessary and that the query involved does
not handle this by itself, which it obviously does. I cannot find
another query I might have mistakenly associated with it though...
2015-06-29 16:19:33 +02:00
Johannes Meyer a2b7b10df8 BackendConfigForm: Validate IDO resources
fixes #9519
2015-06-29 15:51:39 +02:00
Johannes Meyer a1b336f26b IdoResourcePage: Some documentation and style fixes 2015-06-29 15:03:46 +02:00