Commit Graph

7641 Commits

Author SHA1 Message Date
Thomas Gelf 727a2d7141 Paginator: relax requirements to Paginatable
* we need no full query interface here
* introduced new interface "Paginatable"

fixes #9483
2015-07-23 13:48:49 +02:00
Eric Lippmann 75147d6c62 Provide a test user in the SearchDashboardTest
refs #9644
2015-07-23 13:01:05 +02:00
Eric Lippmann b38b3b35b7 Provide a test user in the DashboardTest
refs #9644
2015-07-23 13:00:23 +02:00
Eric Lippmann a34ad0227f Don't load module menu entries if the authenticated user lacks the module permission
refs #9644
2015-07-23 12:59:30 +02:00
Eric Lippmann cccb34e98c Pass authenticated user to the SearchDashboard
refs #9644
2015-07-23 12:58:53 +02:00
Eric Lippmann fd77c30838 Don't load module dashboards if the authenticated user lacks the module permission
refs #9644
2015-07-23 12:57:23 +02:00
Eric Lippmann e8e01257e6 Change interface of SearchDashboard to allow setting a user before calling ::search()
Because search dashlets are provided by modules, the authenticated user's module permissions have to be validated before loading search dashlets provided by modules.

refs #9644
2015-07-23 12:53:08 +02:00
Eric Lippmann b4f4ce4406 Require the module's permission for every module automatically
Module permissions are not required if authentication is disabled on the controller.

refs #9644
2015-07-23 12:51:10 +02:00
Eric Lippmann 7c5b4de087 Fix coding style in RoleForm.php 2015-07-23 12:50:42 +02:00
Eric Lippmann b000ae3a37 Do not require permissions if authentication is not required
refs #9644
2015-07-23 12:50:02 +02:00
Eric Lippmann 593f90f330 Puppet: Fix that the LDAP server is empty when using CentOS 7 2015-07-23 12:40:51 +02:00
Eric Lippmann b4861fe689 Puppet: Set date.timezone for PHP in a separate INI file 2015-07-23 12:40:12 +02:00
Eric Lippmann af6def7d7f Puppet: Use strings for file modes 2015-07-23 12:39:36 +02:00
Eric Lippmann 67af7b5135 Puppet: Don't install icinga2-debuginfo 2015-07-23 12:39:12 +02:00
Eric Lippmann 3ffe657f71 Puppet: Use future parser 2015-07-23 12:37:23 +02:00
Johannes Meyer 1d3a0f63eb BackendConfigForm: Fix that skipping the schema validation is not possible
fixes #9719
2015-07-23 12:25:30 +02:00
Eric Lippmann bf590ed380 Provide module permissions automatically
refs #9644
2015-07-22 15:01:54 +02:00
Eric Lippmann 5dcc307e87 Add namespace for module permissions to the module manager
refs #9644
2015-07-22 14:59:35 +02:00
Eric Lippmann aa567f8cd7 Introduce ModuleActionController::$requiresModulePermission
refs #9644
2015-07-22 14:56:02 +02:00
Eric Lippmann 910dee199f Fix form test 2015-07-22 14:21:53 +02:00
Eric Lippmann a75b1a35c6 monitoring: Don't fail when selecting custom variables while having a group by clause
refs #9692
2015-07-22 13:47:52 +02:00
Eric Lippmann 63c51c01e0 monitoring: Auto-refresh tactical overview every 15 seconds
fixes #9626
2015-07-22 13:40:50 +02:00
Eric Lippmann 13d954a956 Fix rawurlencode call 2015-07-22 13:36:25 +02:00
Eric Lippmann b8c2c33086 Merge branch 'feature/vagrant-centos-7-9453'
resolves #9453
2015-07-22 13:35:18 +02:00
Eric Lippmann 52e352751e Revert "ModuleActionController: fix forward/X-Icinga-Module"
This reverts commit bf82bd4ce1.

We have a not merged branch for this.

refs #9349
2015-07-22 13:34:44 +02:00
Markus Frosch ab8e775188 Fix duplicate headers on forward() inside a controller
This avoids that the JS loader flattening arrays.

refs #9349
2015-07-22 13:34:44 +02:00
Johannes Meyer 1e9ce1d0d5 Merge branch 'feature/support-for-file-uploads-8758'
resolves #8758
2015-07-22 13:32:17 +02:00
Johannes Meyer 54a77b7253 Merge branch 'master' into feature/support-for-file-uploads-8758 2015-07-22 13:30:56 +02:00
Johannes Meyer 0f2351ff1d js: Fix XHR loading of URLs in case window.FormData is not supported
refs #8758
2015-07-22 13:29:44 +02:00
Johannes Meyer a199d36207 Stylesheet: Disable extendend @import statements provided by LESS
fixes #9687
2015-07-22 12:45:10 +02:00
Eric Lippmann 15cb24c6dc Throw an exception in IdoQuery::getCustomvarColumnName() in case the custom variable has not been joined
Queries extending IdoQuery and using the method getCustomvarColumnName() must be notified in case the custom variable has not been joined.

refs #9692
2015-07-22 12:03:34 +02:00
Eric Lippmann 3ed13366a8 Remove duplicate line in IdoQuery
I introduced this w/ 4522cf5090.
2015-07-22 12:03:34 +02:00
Thomas Gelf c5d68995ec forms.less: top-align field lables and related...
...items like icons. They used to be bottom-aligned, resulting in
slightly confusing form layouts when text areas where involved.
2015-07-22 11:03:01 +02:00
Thomas Gelf d44547e469 forms.less: textarea should look like other inputs 2015-07-22 10:57:14 +02:00
Thomas Gelf bf82bd4ce1 ModuleActionController: fix forward/X-Icinga-Module 2015-07-22 10:53:42 +02:00
Johannes Meyer cecd94be50 Merge branch 'master' into feature/support-for-file-uploads-8758 2015-07-22 08:47:24 +02:00
Johannes Meyer c0de2e6ee3 Form: Add missing use statement for the ProgrammingError exception 2015-07-22 08:39:24 +02:00
Eric Lippmann 45ef285e3d RPM: Let php-Icinga require Zend and Zend's MySQL and PostgreSQL adapters
This installs both the MySQL and PostgreSQL libs even if the user only wants to use either MySQL or PostgreSQL. But the depencies installed--mysql-libs and postgresql-libs respectively--are so minimal that this is a good trade off for managing our dependencies atm.

fixes #9314
2015-07-21 17:32:17 +02:00
Eric Lippmann ce2b686252 Add file and line of logged menu item renderer exceptions
fixes #9696
2015-07-21 16:54:23 +02:00
Johannes Meyer b4214dcf32 FormTest: getRedirectUrl now returns an instance of Icinga\Web\Url 2015-07-21 16:49:59 +02:00
Johannes Meyer 8f2849f32a Form: Improve code readability..
..and avoid the necessity to provide another mock when testing
Form::handleRequest().

refs #8758
2015-07-21 16:48:56 +02:00
Eric Lippmann 163911ffd7 Indicate empty icinga_programstatus table as problem
fixes #9695
2015-07-21 16:47:17 +02:00
Johannes Meyer 5e1ea958b4 js: Correctly process the redirectUrl-meta tag for successful frame uploads
refs #8758
2015-07-21 16:38:52 +02:00
Johannes Meyer 93fbb0231c loader.js: Split processRedirectHeader() to allow partly reuse
refs #8758
2015-07-21 16:37:21 +02:00
Johannes Meyer 7c89887773 Form: Provide an absolute url as redirect url for successful frame uploads
refs #8758
2015-07-21 16:35:56 +02:00
Johannes Meyer 6c9819204d Form: Only work with a single type when handling redirect urls
$form->setRedirectUrl('some/url') still works, but $form->getRedirectUrl()
will only return instances of Icinga\Web\Url now.
2015-07-21 16:33:24 +02:00
Johannes Meyer 9471c3c574 js: Make use of the _frameUpload parameter when submitting a form..
..to an iframe. This ensures that stuff like notifications are immediately
visible to the user after successful form submission.

refs #8758
2015-07-21 15:43:47 +02:00
Eric Lippmann 4522cf5090 Add missing return to IdoQuery::getCustomvarColumnName()
Some filter combinations still seem to not work properly.

refs #9692
2015-07-21 15:27:01 +02:00
Johannes Meyer fc481e527b Form: Process request parameter _frameUpload
This parameter is being used to flag a request as form submission issued
by utilizing an iframe. Appending it to a form's action causes no redirection
to take place in case of successful submission and a reduced but still valid
layout to be printed in any way. Redirection must be handled by the client
regarding the meta tag "redirectUrl".

refs #8758
2015-07-21 15:22:24 +02:00
Johannes Meyer 0a9a066749 Form: Do not create a new instance of Url when returning the redirect url
We're shifting parameters and by creating a new instance we'll lose
such changes.

refs #8758
2015-07-21 15:13:56 +02:00