tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
523 Commits 120 Branches 71 Tags 80 MiB
Commit Graph

126 Commits

Author SHA1 Message Date
Eric Lippmann a45409c5f3 Monitoring/Commands/Forms/Tests: Follow our Coding Standards 
refs #4524
 2013-08-16 17:38:50 +02:00
Eric Lippmann 5e85dd1c06 Monitoring/Commands: Fix reschedule next check form tests 
refs #4524
 2013-08-16 17:38:50 +02:00
Eric Lippmann 26f7b740c5 Monitoring/Commands: Fix delay notification form tests 
refs #4524
 2013-08-16 17:38:50 +02:00
Eric Lippmann 9f1da2db1a Monitoring/Commands: Add help messages to the submit passive check result form 
refs #4524
 2013-08-16 17:38:50 +02:00
Eric Lippmann b46df485ae Monitoring/Commands: Add help messages to the schedule downtime form 
refs #4524
 2013-08-16 17:38:50 +02:00
Eric Lippmann 48a393894c Monitoring/Commands: Add help messages to the reschedule next check form 
refs #4524
 2013-08-16 17:38:50 +02:00
Eric Lippmann bcdda6c0c6 Monitoring/Commands: Add help messages to the delay notification form 
refs #4524
 2013-08-16 17:38:50 +02:00
Eric Lippmann 329d63839b Monitoring/Commands: Fix tests 
refs #4524
 2013-08-16 17:38:50 +02:00
Eric Lippmann 3d3fbb123d Monitoring/Commands: Add help messages to the custom notification form 
refs #4524
 2013-08-16 17:38:50 +02:00
Eric Lippmann 9c047f5b72 Monitoring/Commands: Fix typos in forms 
refs #4524
 2013-08-16 17:38:49 +02:00
Eric Lippmann 0af63ea751 Monitoring/Commands: Add help messages to the add comment form 
refs #4524
 2013-08-16 17:38:49 +02:00
Eric Lippmann fb71ecc5ca Monitoring/Commands: Add help messages to the problem acknowledgement form 
refs #4524
 2013-08-16 17:38:49 +02:00
Eric Lippmann 83fb198cd2 CS: Fix violations in MonitoringProperties, NotificationView and StatusQuery 
refs #4187
 2013-08-16 16:32:31 +02:00
Eric Lippmann e5f3a063fb NotificationQuery: Fix PostgreSQL icompatibility 
refs #4187
 2013-08-16 16:23:15 +02:00
Eric Lippmann f4b8b369a8 StatusQuery: Use pipes as concat 
PostgreSQL does not support CONCAT()

refs #4187
 2013-08-16 16:23:15 +02:00
Jannis Moßhammer 3c56f5c53a Remove qUrl, use ListController::query, proper default sorting 
refs #4187
 2013-08-16 16:23:15 +02:00
Johannes Meyer baaf5b81d9 Add mouse-over effect and host/service detail popup 
refs #4187
 2013-08-16 16:23:14 +02:00
Johannes Meyer f89d641b06 Add notification queries and display notification details 
The notification queries to fetch all required details are now implemented
and are used to display data in the overview. Still missing is the host/service
detail popup and some quicklinks. (Contact, Notification command)

refs #4187
 2013-08-16 16:23:14 +02:00
Johannes Meyer 3c2122515a Basic structure for the notification overview 
refs #4187
 2013-08-16 16:23:14 +02:00
Jannis Moßhammer 0b479e3796 Code style fixes, fix documentation, fix tab parameters not being overwritten 
refs #4512
 2013-08-16 15:08:28 +02:00
Jannis Moßhammer b28c7f2f4c Refactor test, tabs and controller 
- Remove unused methods,
- Code style
- Documentation for widgets
- Tabextensions instead of hardcoded tab actions
- Add tests for tabs
- Add missing phpdoc for touched files
- Fix tests

refs #4512
refs #4541
refs #4540
 2013-08-16 15:08:28 +02:00
Eric Lippmann 6d98b923ca CS: Fix docstrings in Icinga/Application/Modules/Module.php and Manager.php 
refs #4530
 2013-08-14 16:08:15 +02:00
Jannis Moßhammer 392e568bf8 Code style fixes: License header, phpdoc tags, psr-2 compliance 
refs #4530
 2013-08-14 16:08:15 +02:00
Jannis Moßhammer be29b8ff8f Make ConfigController and PreferenceController extensible by convention 
- Rename ConfigurationController to ConfigController
- ConfigController and PreferenceController are now subclasses of
  BaseConfigController and BasePreferenceController
- Module and Application Config/Preference Tabs are detected via
  the ControllerTabCollector
- Moved Controller classes to Icinga/Web/Controller (this is why
  so many files are modified)

refs #4530
 2013-08-14 16:08:15 +02:00
Eric Lippmann bd140f2828 CC: Fix phpcs errors of files changed in feature/datetime-element-4440 
refs #4440
 2013-08-12 16:43:10 +02:00
Eric Lippmann 7dea7fcad0 Monitoring/Forms: Replace PHP DateTime usage with DateTimeFactory 
refs #4440
 2013-08-12 16:43:10 +02:00
Eric Lippmann 4d98b64a1b Monitoring/Forms: Fix docstrings 
refs #4440
 2013-08-12 16:43:09 +02:00
Eric Lippmann 7c732ef682 Monitoring/Tests: Fix DateTimePicker element usage 
refs #4440
 2013-08-12 16:43:08 +02:00
Eric Lippmann 1a2ea656fd Monitoring/Forms: Don't use DateTime as PhpDateTime 
refs #4440
 2013-08-12 16:43:08 +02:00
Eric Lippmann 1f10cb3124 Framework: Rename DateTime form element to DateTimePicker 
refs #4440
 2013-08-12 16:43:08 +02:00
Eric Lippmann 93ae6d6811 Framework: mv Icinga\Config\Config to Icinga\Application\Config 
refs #4543
 2013-08-12 15:02:25 +02:00
Jannis Moßhammer 237f7f1e60 Fix service compact view, remove dashboard.ini trash 
refs #4192
 2013-08-08 16:33:42 +02:00
Jannis Moßhammer 2a2966fc56 Fix Config.php relocation, fix header.phtml crashing due to old tab rendering 
refs #4192
 2013-08-07 17:51:52 +02:00
Jannis Moßhammer 488310df37 Fix style and docstrings, exception when removing the last tab 
refs #4192
 2013-08-07 17:45:09 +02:00
Jannis Moßhammer 2b25757e20 Add documentation, add errorhandling and sizing 
The optional width/height parameter can be set in the ini to change the dashboard components
size, documentation has been added and in the error case a message with the configuration is shown

refs #4192
 2013-08-07 17:44:30 +02:00
Jannis Moßhammer f8bb478f0e Update dashboard implementation 
fix javascript naming (icinga-url to icingaurl), fix add form, add remove
button, code style changes

refs #4192
 2013-08-07 17:43:37 +02:00
Jannis Moßhammer b3e0d5e8ce Remove AbstractWidget and make Widget an interface 
As Widget's already denote an abstract concept, the name
'AbstractWidget' is redundant. Also this class didn't do anything except
fetching a view via a singleton (which is now injected into the render method)
and bypassing the PHP class properties by creating a 'properties' array which is
filled with magic getters and setters (which now are simply php class properties)

Further changes:
- toString is removed, as this incorporated a lot of
   application logic which would cause unrecoverable
   errors when throwing exceptions
- renderToHtml is now just render and the view dependency must be
   passed, as a widget shouldn't be responsible for getting
   view instance (this means that <?= $this->tabs ?> is now
   <?= $this->tabs->render($this); ?> in the templates
- Controllers don't have $this->widget anymore as Widgets are
   directly instanciated with their class, allowing better code completion
   and avoiding hidden dependencies, also Widget::create is now removed
   in favor of direct instanciation.

refs #4192
 2013-08-07 17:41:43 +02:00
Matthias Jentsch 56e47fd084 Add an ini writer for configuration files 
Add an ini writer that respects the file structure and the comments that may be
already present in the config file. Move Application/Config.php into
Config/Config.php.

refs #4352
 2013-08-07 15:58:42 +02:00
Eric Lippmann 290c8c5225 CC: Add newline to end of file where missing 
Following command was used:
    $ find application/ library/Icinga/ modules/ -name *.php | xargs sed -i -e :a -e '/./,$!d;/^\n*$/{$d;N;};/\n$/ba;$a\'
 2013-08-07 10:27:50 +02:00
Jannis Moßhammer ff62a82895 Fix dynamic form validation behaviour, fix documentaion, fix correct isValid() call 
- When a dynamic form is modified, no validation is performed, but
  the form is being populated with $this->populate.
- changed parent::isValid to $this->isValid, otherwise no custom validation
  logic could be implemented
- Updated documentation
- Fix CSRF protection by removing the time

refs #4439
 2013-08-06 15:08:54 +02:00
Johannes Meyer 66592ecabf Enable dynamic form elements 
Expire time of the AcknowledgeForm and hours as well as
minutes of the ScheduleDowntimeForm are now dynamic.

refs #4439
 2013-08-06 15:06:20 +02:00
Marius Hein 584198f00c Fix hostlist test 
refs #4516
 2013-08-06 14:06:25 +02:00
Marius Hein 15999eb880 Change _forward to redirect() to keep url history updates 
refs #4382
 2013-08-06 13:39:10 +02:00
Johannes Meyer d78a5338df Rename ConfirmationForm and ConfirmationWithIdentifierForm 
Rename ConfirmationForm to CommandForm and
ConfirmationWithIdentifierForm to CommandWithIdentifierForm.

refs #4439
 2013-08-06 11:14:56 +02:00
Johannes Meyer 5533b632ed Fix code style and make form name non mandatory 
refs #4439
 2013-08-06 11:11:29 +02:00
Johannes Meyer f26af0eb12 Update command form tests 
Update command form tests so that they reflect the new dynamic
functionality and the correct purpose of "isSubmittedAndValid".

refs #4439
 2013-08-06 11:11:28 +02:00
Johannes Meyer 8efbe6f613 Move submit and cancel handling 
Move submit and cancel handling from ConfirmationForm to Form.

refs #4439
 2013-08-06 11:11:28 +02:00
Johannes Meyer fa7379adc7 Enable dynamic form elements 
Expire time of the AcknowledgeForm and hours as well as
minutes of the ScheduleDowntimeForm are now dynamic.

refs #4439
 2013-08-06 11:09:42 +02:00
Johannes Meyer 98e7ab02db Implement dynamic form elements 
Rename "isPostAndValid" to "isSubmittedAndValid" and refactor it.
Add possibility for specific form elements to auto-submit their form.

refs #4439
 2013-08-06 11:09:42 +02:00
Marius Hein c9c5e6ef3c Send commands: Review fixes 
refs #4441
 2013-08-06 09:32:27 +02:00