5a738112ea
Remove isExistingBackend/-Instance
...
It is more efficient to access configuration files only once instead of
accessing them multiple times in different locations.
refs #5525
2014-07-25 16:02:13 +02:00
d7ed6bd249
Adjust removebackend-action to suit the new backend form interface
...
Drops additionally the ConfirmRemovalForm of the monitoring module
as there is already one in icingaweb2's form-set.
refs #5525
2014-07-25 16:00:38 +02:00
a78d11345b
Adjust createbackend-action to suit the new backend form interface
...
refs #5525
2014-07-25 15:58:44 +02:00
b743cf8143
Adjust editbackend-action to suit the new backend-form interface
...
refs #5525
2014-07-25 14:55:36 +02:00
af5a3262be
Revert backslash removal in front of namespace-less use statement
2014-07-25 09:12:12 +02:00
5f7652133e
Fix code-style and documentation
2014-07-25 08:39:27 +02:00
4d199180b3
We do not want to access $_POST directly if it is possible to avoid it
2014-07-17 09:28:10 +02:00
b7f5c8a84d
Fix that the default sort order of a view is not being applied
...
fixes #6644
2014-07-17 09:28:10 +02:00
62da942159
Don't close and re-open php tags, remove unneeded spaces
...
To close and re-open php tags makes no sense if there's nothing between them
2014-07-16 17:54:06 +02:00
1ad263170e
Revert "Small fixes"
...
This reverts commit 8086292b1b
2014-07-16 15:30:20 +02:00
8086292b1b
Small fixes
2014-07-15 18:00:52 +02:00
3105c2059e
Remove license headers from all files
...
refs #6309
2014-07-15 13:43:52 +02:00
b85ac3ab45
Translate labels in the ChartController
2014-07-09 18:13:40 +02:00
8d697a3d8e
Fix coding style
2014-07-09 18:13:40 +02:00
2b05aa9504
monitoring/list: do not apply empty filter
...
Fixes problems with the servicematrix when no filter is applied.
I'm not yet happy with this, calls to where() should automagically
handle existing empty filters.
fixes #6543
2014-07-08 16:36:05 +02:00
7eb0f3c472
Remove @codingStandardsIgnoreStart/-Stop annotations
...
refs #6091
2014-06-30 13:59:58 +02:00
9a1b7179e1
Fix violations of coding guidelines
2014-06-30 12:33:51 +02:00
1532594948
Deduplicate code: lists/hosts.phtml VS lists/hosts-compact.phtml
...
fixes #6541
2014-06-27 11:53:08 +02:00
a4fc6dedea
monitoring/list: fix limit=0 check
...
This used to be fixed, but got accidentally re-broken by last commit
this night.
2014-06-26 16:34:37 +02:00
a91bbd3a75
monitoring/list: add stateType parameter
...
This allows one to show only hard states, useful for support dashboards.
2014-06-26 00:42:38 +02:00
c85a0ac11e
list/limits: special treatment for 0 only, not null
2014-06-26 00:39:10 +02:00
ff9c29472e
monitoring/status: re-introduce comments, problems
...
This re-introduces expensive columns been disabled time ago and adds
even more to it. We are now showing last comment, last ack comment and
service problem count on hosts in list views.
It still costs performance, but seems that we can stand it. I'd like
to add more like this to the host view.
2014-06-25 21:42:24 +02:00
86f70e0a4f
list/services: don't count with no limit
...
This is a performance evaluation right now, we might delegate such
logic to paginator later on. Cuts load time for lists and/or dashlets
with complicated filters by 50% - only for those with limit=0 of course.
2014-06-25 20:45:08 +02:00
ae99dd39fd
Fix intendation in MultiController
...
Use spaces instead of tabs
2014-06-25 15:25:54 +02:00
7b19bd1d99
Improve interface of InlinePie
...
Method setLabel can also accept a simple string and title is mandatory in constructor
2014-06-25 15:21:12 +02:00
35a5431512
Revert "Refractor InlinePie and Perfdata helper"
...
This reverts commit f003c38abd
2014-06-25 14:29:17 +02:00
f003c38abd
Refractor InlinePie and Perfdata helper
...
Refractor InlinePie methods for better usability, fix several coding guideline
issues and fix some typos
2014-06-25 12:41:17 +02:00
4591297e56
SortBox: use POST instead of GET
...
This avoids trouble with complex filter URLs
fixes #6556
2014-06-25 11:00:10 +02:00
b40d0f6a1e
FilterWidget: POST instead of GET
...
Might have been a JS issue, but instead of messing with the URL just
POSTing is easier here - and works. Filters from the search box are
now added flawlessly to the filter tree.
2014-06-25 10:34:09 +02:00
2746b5ff9f
ConfigController: switch over to new config tabs
...
Module configuration now takes place in module detail view and does no
longer pollute our config tabs. Modules are now able to provide a bunch
of own config tabs, we don't really care what they use them for.
2014-06-24 21:31:59 +02:00
ccdf1ca354
monitoring/ConfigController: use notifications
2014-06-24 21:28:01 +02:00
2b2901524c
ConfigController: useless use of render
2014-06-24 21:24:40 +02:00
f75a4430a6
monitoring/config: make use of Config()
...
Thee helper function supports lazy loading, requires less code and is
easier to read.
2014-06-24 21:22:38 +02:00
d5d3f5548f
monitoring/list/hosts: support addcolumns parameter
...
At least it doesn't fail right now, this only works for services so far.
View script still needs to be adjusted, will probably be done with #6541 .
2014-06-24 21:12:55 +02:00
23ed744747
params/_render: replace it everywhere
...
Cleaning up controllers and JS, using headers only and respecting
history.
2014-06-22 20:07:44 +02:00
216f0f3f55
isIframe: clean up, load less html and js
...
We use isIframe only when we have no JS, therefore it makes no sense
to load JS files in an iFrame. Also removed sidebar.
2014-06-22 16:30:06 +02:00
3b84078b2f
Params/_render: get rid of it, start with iframe
2014-06-22 16:18:23 +02:00
2a0e72273a
ChartController: use correct ActionController
...
...and some code cleanup
2014-06-22 14:08:04 +02:00
ef5e1b54fd
Web\Window: fix it's usage, add helper function
...
Improved window handling, fixed controllers using it.
2014-06-22 13:21:21 +02:00
57ad88c38c
monitoring/process: was broken, fix it
...
Stumbled across two issues here:
* It's currently not possible to fetch all (*) columns from a DataView
* Backends are not able to tell their names
Worked around the first issue by naming all columns and implemented a
quick & dirty solution for the second one.
2014-06-21 04:25:02 +02:00
7f53ba11cf
Hook\Grapher: use it in monitoring/show
2014-06-21 04:13:14 +02:00
b3cdeee35d
monitoring/timeline: should benefit from new filter
...
Different changes have been applied:
* Allow integer unix timestamps as parameters for timestamp columns
* Remove alias-rewriting from Url class
* Remove all traces of raw_timestamp
* Use new filters
2014-06-21 03:09:40 +02:00
66f68f4990
monitoring/config: tab doesn't get focus
...
Fixes this. Tab handling is rather strange right now and module tabs
will not scale. We need a better solution for the future.
fixes #6320
2014-06-20 23:22:07 +02:00
127b728a4c
list/notifications: fix query, select columns, style
2014-06-20 19:12:10 +02:00
fb18de1f42
monitoring\CommandController: use new filters
2014-06-20 14:22:48 +02:00
f80b951cec
monitoring/ShowController: remove obsolete function
2014-06-20 14:21:29 +02:00
a8bde7cc14
monitoring/show/services: do not limit result
...
Still a little bit hackish, we will replace this once we have a request
object fully aware of our new UrlParams parser.
fixes #6511
2014-06-20 14:16:36 +02:00
f2c67ea047
MultiControllers: use new filters
...
This makes things easier, no more nested lists - just filters easy
to read and understand
2014-06-20 13:38:58 +02:00
255accb215
monitoring/MultiController: use correct controller
2014-06-20 13:35:25 +02:00
371b66bd8b
monitoring\ListController: handle filter editing
...
Handle filter modifications in one place. We still should try to
abstract this on step farther.
2014-06-20 13:26:10 +02:00
Johannes Meyer
Alexander Klimov
Matthias Jentsch
Thomas Gelf