tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
12,642 Commits 121 Branches 71 Tags 80 MiB
Commit Graph

3892 Commits

Author SHA1 Message Date
Johannes Meyer d4dc282ac8 DashboardContainer: Allow to define a priority for dashlets 
refs #3931
 2019-09-09 14:43:28 +02:00
Johannes Meyer 04b23811be Raise version to 2.7.1 2019-08-14 13:10:19 +02:00
Eric Lippmann c8ed889114 Fix operator in wildcard filter chains 2019-08-13 17:19:45 +02:00
Eric Lippmann 31d3153d2b Support wildcard filters in chains (#3903) 2019-08-12 13:41:38 +02:00
Eric Lippmann 666bdfb4c4 Revert "Fix double query execution" 
This reverts PR 6ea012af7e, reversing
changes made to be5b9f870b.

The reverted commit fixed a double query execution bug by only executing
the query once in either SimpleQuery::hasResult() or upon iteration.

But the fix (b20291a60) introduced two problems:

* Default sort rules no longer work
* Show more links missing

We work with DataView objects in our controllers and views. When
iterating over a DataView, it applies its default sort rules and then
returns the underlying query, see DataView::getIterator().

DataView::hasResult() on the other hand does not apply the default sort
rules. So, if hasResult() is called first, the default sort rules are no
longer applied because the query will be executed only once.
The fix would be as easy as to apply sorting in DataView::hasResult() as
well.

But now the show more part kicks in. We know whether there are more
results because we execute queries with $limit + 1. This is enabled via
SimpleQuery::peekAhead(). Unfortunately, we call
SimpleQuery::peekAhead() ALWAYS after SimpleQuery::hasResult(). And
that's why the show more links are missing because the query is executed
only once with the "wrong" limit.

For now, we just revert the commit in question and postpone a proper fix
for the double execution.
 2019-08-07 13:29:57 +02:00
Eric Lippmann f35946df29 Raise version to 2.7.0 2019-07-30 10:19:53 +02:00
Eric Lippmann b8fb193bdd Add FilterChain::setFilters() 2019-07-30 09:17:25 +02:00
Johannes Meyer b31dd77812
Merge pull request #3676 from Icinga/feature/form-styling 
Improve look of our forms
 2019-07-30 08:26:08 +02:00
Markus Frosch c66d206042 Cleanup executable flags on files 
Some or scripts, but if so just vendor artifacts
 2019-07-30 07:53:54 +02:00
Johannes Meyer 9cdf37410c ApplicationStateMessages: Fix message layout 2019-07-29 10:19:39 +02:00
Johannes Meyer 13ad506393 css: Rename class `icinga-forms` to `icinga-form` 2019-07-29 10:17:59 +02:00
Johannes Meyer 212606de78 setup: Apply new icinga form style 2019-07-29 10:17:59 +02:00
Johannes Meyer 0bc70a840c SortBox: Apply icinga form style 2019-07-29 10:17:59 +02:00
Johannes Meyer 346083109a Apply new form style to the filter editor 2019-07-29 10:17:59 +02:00
Johannes Meyer 05613c413d Enhance toggle-switch, spinner and control-info placement 
tested with Chromium, IE11 (Win7), Edge (Win10)
 2019-07-29 10:17:59 +02:00
Johannes Meyer 115bb80c6a View: Register our own view helper path 
That's a different path than application/views/helpers because this one
uses a namespace so that we're able to extend Zend's view helpers
 2019-07-29 10:17:59 +02:00
Johannes Meyer bc2e7588d7 FormNotifications: Don't ignore warning and error notifications 2019-07-29 10:17:59 +02:00
Johannes Meyer a5f292c2ae Form: Define classes `icinga-forms` and `icinga-controls` by default 2019-07-29 10:17:59 +02:00
Florian Strohmaier f14256a7ee CSS: Adapt form design with filter editor 
refs #3676
 2019-07-29 10:17:59 +02:00
Florian Strohmaier f70f996085 Announcements: Increase font-size and align control layout 
refs #3676
refs #3560
refs #3839
 2019-07-29 10:17:59 +02:00
Florian Strohmaier c492c6bb23 Announcements: Avoid duplicate `id attribute 
refs #3762
 2019-07-29 10:17:59 +02:00
Eric Lippmann c49f5d6a0f Don't override Zend's Checkbox for our toggle switch 2019-07-29 10:17:59 +02:00
Eric Lippmann 41ee36c7e6 Reduce default textarea rows 2019-07-29 10:17:59 +02:00
Jennifer Mourek bf48b6d26b WIP: New form styles 
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
 2019-07-29 10:17:59 +02:00
Johannes Meyer 9d0ef4cf33 Wrap any markdown output with a `<section>` and remove explicit containers 2019-07-23 14:45:32 +02:00
Johannes Meyer 9de9fe8f39 Introduce class RolesConfig 2019-07-23 13:53:29 +02:00
Johannes Meyer 1f0ee9b0d4 IniRepository: Fix wrong documentation for $configs 2019-07-23 13:53:29 +02:00
Johannes Meyer 40529e76ef
Merge pull request #3858 from Icinga/feature/downtime-schedule-times 
Require time output for downtime schedule and end/expire times
 2019-07-18 08:47:55 +02:00
Johannes Meyer fcde2a9eea dashboard: Use the non-translated versions of pane and dashlet names for storage 
This is a dirty quick fix. And calling it *quick* is already an overstatement.
Of course, it's also a breaking change, as **all** non-english users need to
update their dashboard.ini after this change.

Oh, and don't dare to move this over to the new dashboards!

refs #3542
 2019-07-18 08:33:35 +02:00
Johannes Meyer 4fdfb190ad Navigation/DashboardPane: Properly register dashlets as children 
refs #3542
 2019-07-18 08:33:35 +02:00
Johannes Meyer 37a972cf75 dashboard: Differentiate between `name` and `title` 
The former is the original name while title may
be changed by the user. This change is strictly
necessary for the references bug and should also
be introduced when rewriting this mess.

refs #3542
 2019-07-18 08:33:35 +02:00
Johannes Meyer f8d3f43965 js: Drop vendor library tipsy 2019-07-18 07:57:14 +02:00
Johannes Meyer eac3a106ad Render `<title>` tags for line and bar charts instead of tipsy titles 2019-07-18 07:57:14 +02:00
Johannes Meyer c100654412 js: Integrate vendor library jquery-migrate 2019-07-18 07:57:14 +02:00
Johannes Meyer 91e4baa221 Remove remaining special cases for IE8 2019-07-18 07:57:14 +02:00
Jennifer Mourek 07586af41f Remove IE8 & IE9 traces 2019-07-18 07:56:09 +02:00
Florian Strohmaier 7cf620f3f1 JS: Use jquery 3.4.1 
refs #3813
 2019-07-18 07:56:09 +02:00
Jennifer Mourek 55d35b9e5b Remove jquery 1.11 dependency 
refs #3784
 2019-07-18 07:56:09 +02:00
Johannes Meyer e2cddc2d46 js: Introduce storage.js, a localStorage abstraction layer 2019-07-17 13:12:41 +02:00
Johannes Meyer 0574f44bd9 colllapsibleContainer.js: Rename to collapsible.js 2019-07-17 13:12:41 +02:00
Florian Strohmaier b07ffd4987 JS: Implement collapsible-container behavior 2019-07-17 13:12:41 +02:00
Eric Lippmann f9021e8fdd Add $requireTime to timeAgo() and timeSince() too 2019-07-15 10:11:52 +02:00
Johannes Meyer 5145de6b50
Merge pull request #3852 from Icinga/feature/cli-load-enabled-modules 
CLI: Automatically load enabled modules if not disabled
 2019-07-15 08:39:57 +02:00
Johannes Meyer 3edda43bca ActionController: Utilize view variable `$defaultTitle` instead of the constant 
Allows controllers to also customize the default title with translated contents.

refs #3851
 2019-07-15 08:24:44 +02:00
Eric Lippmann 16fbf6d7bd Introduce ConfigFormEventsHook 2019-07-15 07:52:32 +02:00
Eric Lippmann 98b8631db3 Optimize imports 2019-07-12 14:23:41 +02:00
Eric Lippmann 6fa5af4de1 CLI: Automatically load enabled modules if not disabled 2019-07-12 14:23:41 +02:00
Johannes Meyer 5d87f6712e
Merge pull request #3856 from Icinga/feature/send-failed-login-attempts-to-the-audit-log-3855 
Send failed login-attempts to the audit log
 2019-07-12 14:00:09 +02:00
Johannes Meyer 2257eaa0c1
Merge pull request #3849 from Icinga/feature/commonly-accessible-module-hooks-3772 
Add possibility to disable permission checks for hooks
 2019-07-12 13:59:44 +02:00
Johannes Meyer b06103bfc5 NavigationItemRenderer: Don't fail to render an icon if there's none 
fixes #3859
 2019-07-12 07:42:33 +02:00
Johannes Meyer 59fa054d42 AuthChain: Send failed login-attempts to the audit log 
resolves #3855
 2019-07-11 14:41:17 +02:00
Loei Petrus Marogi 617f1b35b3 Add possibility to let hooks always run 
refs #3772
 2019-07-11 13:36:33 +02:00
Eric Lippmann 1351be7da8 Add param to timeUntil() to require time output 
If the time specified in timeUntil() is at least 3 days in the future,
the output will only contain the month and the day. With $requireTime it
will also ouput the time. This is useful for some views, e.g.
scheduled downtimes.
 2019-07-11 13:07:17 +02:00
Niko Martini 7abd1b906b Cli: add version command 
refs #3763
 2019-07-11 08:17:56 +02:00
Johannes Meyer 801a6719b7
Merge pull request #3835 from Icinga/fix/problem-badges-not-visible-if-sidebar-is-collapsed-3568 
ui: Show problem badges in collapsed sidebar
 2019-07-11 08:00:12 +02:00
Johannes Meyer f0b5d8fd8e BadgeNavigationItemRenderer: Round counts to the neareset base 
refs #3568
 2019-07-03 11:29:37 +02:00
Johannes Meyer 559d57d466
Merge pull request #3834 from Icinga/fix/tactical-overview-big-numbers 
Support higher number of problems in the tactical overview
 2019-07-02 15:38:52 +02:00
Johannes Meyer 36524bcd94
Merge pull request #3814 from Icinga/feature/make-notes-and-comments-markdown-aware-3684 
Make notes, comments and announcements markdown aware
 2019-07-02 15:30:21 +02:00
Johannes Meyer 6ea012af7e
Merge pull request #3836 from Icinga/fix/query-double-execution 
Fix double query execution
 2019-07-02 13:56:50 +02:00
Eric Lippmann b20291a606 Fix double query execution 
Our monitoring list views call SimpleQuery::hasResult() first in
order to determine whether there are results to display. This calls
fetchRow() which executes the underlying query the first time. If there
are resulsts, the query is iterated which executes the query again.
With this patch, SimpleQuery::hasResult() makes use of the inner
iterator instead of calling fetchRow(). The query is now executed only
once.
 2019-06-27 15:11:45 +02:00
Johannes Meyer 6aa2cf69c7 HtmlPurifier: Enable cache directory 
refs #3814
 2019-06-27 14:41:13 +02:00
Niko Martini cae8cea482 Support higher number of problems in the tactical overview 
refs #3746
 2019-06-27 11:06:07 +02:00
Johannes Meyer 44c7c427e8 vendor: Update dompdf to version 0.8.3 
refs #3785
 2019-06-27 09:39:41 +02:00
Johannes Meyer 3f7b317ced vendor: Update lessphp to version 0.5.0 
refs #3785
 2019-06-27 09:21:13 +02:00
Johannes Meyer cdaef76faf vendor: Update Parsedown to version 1.7.3 
refs #3785
 2019-06-27 09:20:11 +02:00
Johannes Meyer 0aa32c7ef1 vendor: Update JShrink to version 1.3.2 
refs #3785
 2019-06-27 09:19:36 +02:00
Johannes Meyer 74642d1cf7 FileCache: Add method to prepare sub directories 
refs #3814
 2019-06-25 16:18:26 +02:00
Johannes Meyer bd2060739e announcements: Transform markdown markup 2019-06-25 15:04:04 +02:00
Johannes Meyer 1ac5557187 lib: Introduce Markdown view helper 
refs #3684
 2019-06-25 15:01:35 +02:00
Johannes Meyer dd664aab98 Url: Trim all leading slashes from paths, not just the first 
refs #3829
 2019-06-25 09:18:15 +02:00
Johannes Meyer dbd5e064ff
Merge pull request #3812 from Icinga/fix/cli-css-path 
CLI: Fix CSS path
 2019-06-05 14:09:24 +02:00
Johannes Meyer 40e27f8e2a LdapConnection: Properly render logical NOTs with only single expression 
fixes #3818
 2019-06-05 12:59:36 +02:00
Eric Lippmann b9c2c45af1 CLI: Fix CSS path 
CLI commands which require our LESS parser had no access to our CSS
because the public path was set to the path of the icingacli executable
which is most likely bin.
 2019-06-04 09:43:39 +02:00
Johannes Meyer 09090bcf9f
Merge pull request #3553 from oliverrahner/patch-1 
Enable `$user:local_name$` placeholder in restrictions
 2019-06-04 07:33:51 +02:00
Oliver Rahner 6ad74ef1cc
renamed variable $currentUser$ to $user:local_name$ 
updated docs, too
 2019-06-03 23:56:21 +02:00
Johannes Meyer dcbb477d3a AnnouncementIniRepository: Also fetch column `start` in `findActive()` 2019-05-23 10:05:14 +02:00
Johannes Meyer de82dbe2ab
Merge pull request #3778 from Icinga/fix/browser-language-not-used-3750 
Also adjust env var `LANGUAGE` when setting up the locale
 2019-05-22 12:45:33 +02:00
Johannes Meyer 5d9aa0895f
Merge pull request #3570 from MVKozlov/patch-1 
Return non-zero on display usage
 2019-05-22 12:21:46 +02:00
Max Kozlov 27d12163c4 Icingacli should return UNKNOWN code, showUsage() also should return non-zero 2019-05-21 09:48:38 +03:00
Johannes Meyer 4af672fdfa Translator: Also adjust env var `LANGUAGE` when setting up the locale 
fixes #3750
 2019-05-10 12:33:31 +02:00
Elias Probst 483a9d1935 Typo (`Issueing` > `Issuing`) (#3773) 2019-05-03 15:56:47 +02:00
Johannes Meyer eb7db67dee
Merge pull request #3578 from Icinga/fix/cli-command 
Fix uninitialized array and module in Cli\Command
 2019-04-26 15:55:45 +02:00
Johannes Meyer 498f37d4ff
Command: Function getMainConfig should not deliver module config 
Co-Authored-By: mxhash <mxhash@users.noreply.github.com>
 2019-04-26 14:37:06 +02:00
Johannes Meyer c0e102cedd Release version 2.6.3 
(cherry picked from commit 78d215ce36)
Signed-off-by: Johannes Meyer <johannes.meyer@icinga.com>
 2019-04-24 14:49:21 +02:00
Johannes Meyer 1c0a70d152
Merge pull request #3758 from Icinga/fix/ldap-group-members-not-found-3650 
Fix LDAP group members not found
 2019-04-23 15:02:16 +02:00
Johannes Meyer a2d30a100c LdapQuery: Make all applied filters case-insensitive 
LDAP peforms case-insensitive checks by default so do we now.

fixes #3650
 2019-04-23 14:36:08 +02:00
Johannes Meyer 1d341f9253 LdapConnection: Include the normalized hostname in all informational messages 
refs #3639
 2019-04-23 10:55:23 +02:00
Johannes Meyer d998bd9894 LdapConnection: Normalize the hostname in all cases, not just for LDAPS 
refs #3639
 2019-04-23 10:54:40 +02:00
Johannes Meyer 0be1053197
Merge pull request #3748 from Icinga/feature/sortable-announcements-page-3414 
Sortable announcements page
 2019-04-18 14:51:16 +02:00
Johannes Meyer b50091fc21
Merge pull request #3747 from Icinga/bugfix/setuptimezone 
ApplicationBootstrap#setupTimezone(): ensure a vaild default timezone to be set in any case
 2019-04-17 14:46:22 +02:00
Johannes Meyer 4d0a9fb289 DbConnection: Rename getTimezoneOffset() to defaultTimezoneOffset() 
refs Icinga/icingaweb2-module-director#1837
 2019-04-17 12:30:33 +02:00
Johannes Meyer 9d30cfc3b7 IniParser: Add work-around for php bug 76965 
refs #3733
 2019-04-17 10:00:42 +02:00
Johannes Meyer 14b6e40562 DbConnection: Set current user's timezone on the connection 
resolves #3525
 2019-04-16 15:57:27 +02:00
Johannes Meyer db3cc699f7 ArrayDatasource: Store any type of key as a key column's value 
fixes #3510
 2019-04-16 13:26:48 +02:00
Johannes Meyer 37df008d7f AnnouncementIniRepository: Don't transform retrieved timestamps to DateTime 
refs #3414
 2019-04-16 13:03:16 +02:00
Johannes Meyer 032ca7ae50 SimpleQuery: Fail in case of missing order columns 
refs #3414
 2019-04-16 12:01:49 +02:00
Johannes Meyer e22d7daab6 SimpleQuery: Don't fail to order results based on sequenced column arrays 
refs #3414
 2019-04-16 12:00:55 +02:00
Alexander A. Klimov 5d4cdfe13f ApplicationBootstrap#setupTimezone(): ensure a vaild default timezone to be set in any case 2019-04-16 10:35:36 +02:00
Johannes Meyer 8fc467ca3c
Merge pull request #3714 from ignasr/fix/ldaps-port-3713 
use the correct LDAPS port
 2019-04-12 09:36:33 +02:00
ignasr 12ee9580a9 When using LDAPS, check if the Host field has hostnames with ports and use the value from Port field if not. 2019-04-12 08:57:52 +02:00