Commit Graph

263 Commits

Author SHA1 Message Date
Johannes Meyer ae35650c7e Adjust authentication backend forms to suit.. some form implementation
refs #5525
2014-08-29 15:16:13 +02:00
Marius Hein 436a4d2965 ResourceConfig: Chance createResouce to create
Not useful everywhere. Changed on the best suitable places.

refs #5514
2014-08-28 12:14:55 +02:00
Alexander Fuhr 66062c87b6 Remove unused use Zend_Config 2014-08-28 10:55:06 +02:00
Alexander Klimov 45638b218c Throw IcingaException rather than Exception
fixes #7014
2014-08-27 16:03:15 +02:00
Alexander Klimov 7ff51caed0 Remove leading backslashes from the targets of use statements
- use \Exception;
+ use Exception;
2014-08-27 15:51:49 +02:00
Eric Lippmann 1dea19504f Revert "Remove leading backslashes from the targets of use statements"
This reverts commit 87a5967501.

At least 'modules/doc/run.php' issues a warning about "The use statement with non-compound name 'Zend_Controller_Router_Route' has no effect"
2014-08-27 12:24:11 +02:00
Marius Hein 88698cb05d Hook/TopBar: Rework interface for monitoring top bar
refs #6929
2014-08-27 11:31:48 +02:00
Alexander Klimov 87a5967501 Remove leading backslashes from the targets of use statements
- use \Exception;
+ use Exception;
2014-08-27 11:16:44 +02:00
Alexander Fuhr af0cf48197 Add self provided configuration for dashlets
refs #6639
2014-08-26 10:34:35 +02:00
Johannes Meyer 7b221e2aba It should not be a form's responsibility how its submit button should look..
...in case it's a standard button. No need to be DRY here.

refs #5525
2014-08-22 15:20:54 +02:00
Johannes Meyer 403f745488 Remove obsolete loggingAction
refs #6933
2014-08-22 12:34:33 +02:00
Alexander Fuhr 20cead67a6 Merge branch 'master' into bugfix/modules-menu-provider-6639 2014-08-22 11:44:10 +02:00
Alexander Fuhr f757f69bd1 Change Menu load from config ini files to self provided configuration
refs #6639
2014-08-22 11:10:17 +02:00
Johannes Meyer bc05d2ee64 Merge LoggingForm into GeneralForm
fixes #6933
2014-08-22 11:05:20 +02:00
Thomas Gelf af97db31d7 StaticController: fix gravatar sample img header 2014-08-21 19:10:53 +02:00
Johannes Meyer bb7972aa39 Merge branch 'master' into bugfix/rebuild-form-builder-5525
Conflicts:
	application/controllers/AuthenticationController.php
	application/controllers/ConfigController.php
	application/forms/Authentication/LoginForm.php
	application/forms/Preference/GeneralForm.php
	modules/monitoring/application/controllers/ChartController.php
2014-08-20 13:13:50 +02:00
Thomas Gelf 736113c80c AuthenticationController: show friendlier hints...
...while not disclosing sensitive information. More to come once we
have our setup wizard.

fixes #6534
2014-08-19 18:55:58 +02:00
Alexander Fuhr 2f54ff4797 Fix the unrelated tabs
resolves #6934
2014-08-19 13:18:52 +02:00
Alexander Fuhr c69af6c5d2 Move "modules" to "System" menu
resolves #6934
2014-08-19 11:14:18 +02:00
Thomas Gelf f67d273bbd AuthenticationController: handle redirect parameter
This is a form field instead of a get parameter right now.

fixes #6584
2014-08-19 10:14:46 +02:00
Thomas Gelf 5a6b5172e6 Menu: ignore special params when comparing URLs
This fixes issues on login with dashboard != dashboard?renderLayout
and similar

refs #6699
2014-08-19 10:06:14 +02:00
Johannes Meyer e6bcda260d Redirect after a new resource has been created successfully
refs #5525
2014-08-12 10:42:28 +02:00
Johannes Meyer eea43e9a60 Adjust Icinga\Form\Dashboard\AddUrlForm to suit the new form interface
refs #5525
2014-08-12 09:49:27 +02:00
Marius Hein e2c761a7aa AutoLogin/Logout: Remove own session namespace
Store data in the user and implement interface to left
backends store remote information.

fixes #6461
2014-07-30 12:35:55 +02:00
Alexander Klimov e07f2a2b0d Show an error message if a ConfigurationError is thrown 2014-07-29 12:25:48 +02:00
Marius Hein 8b9d446d2e Autologin: Remove deprecated autologin methods
Remove methods from manager because autologin
is now handled with special backends (AutoLoginBackend).

The session is used to store the status about a remote
user authentication to send a 401 header to the client
upon logout.

refs #6461
2014-07-29 10:48:57 +02:00
Alexander Klimov 644b3a1628 Make it possible to remove an authentication backend
refs #6434
2014-07-25 14:49:05 +02:00
Alexander Klimov c06db7495b Merge remote-tracking branch 'origin/bugfix/rebuild-form-builder-5525' into bugfix/autologin-backend-form-6434 2014-07-25 10:57:08 +02:00
Alexander Klimov 50de21e437 Make it possible to edit an authentication backend
refs #6434
2014-07-25 10:29:33 +02:00
Alexander Klimov af898cc2b3 Prefer switch rather than if - elseif 2014-07-24 17:35:26 +02:00
Johannes Meyer c3731fa79e Adjust removeresource-action to suit the new resource form interface
refs #5525
2014-07-24 16:17:30 +02:00
Alexander Klimov 1902b4f10f Make it possible to create an authentication backend of type autologin
refs #6434
2014-07-24 15:50:01 +02:00
Johannes Meyer 0964316df4 Adjust editresource-action to suit the new resource form interface
refs #5525
2014-07-24 12:37:33 +02:00
Johannes Meyer fd912daa3d Adjust createresource-action to suit the updated resource form interface
refs #5525
2014-07-23 16:39:54 +02:00
Johannes Meyer c8d61f78e7 Fix the config/resource-action's html markup 2014-07-23 12:55:43 +02:00
Johannes Meyer 9cdd891866 Drop ReorderForm and handle its logic in the controller and view instead
refs #5525
2014-07-23 12:35:39 +02:00
Johannes Meyer a73e2ee654 Adjust general config form to suit the new form builder implementation
refs #5525
2014-07-21 14:33:52 +02:00
Johannes Meyer a9f0b95e51 Adjust preferences form to suit the new form builder implementation
refs #5525
2014-07-21 10:20:04 +02:00
Johannes Meyer 7157b11f97 Adjust LoggingForm to suit the "final" form builder implementation
refs #5525
2014-07-18 10:29:23 +02:00
Johannes Meyer 5da14d3fc5 Adjust LoginForm to suit the "final" form builder implementation
refs #5525
2014-07-18 10:23:04 +02:00
Johannes Meyer 1de2d0c14f Merge branch 'master' into bugfix/rebuild-form-builder-5525
Conflicts:
	application/forms/Authentication/LoginForm.php
	library/Icinga/Test/BaseTestCase.php
	library/Icinga/Web/Form.php
	library/Icinga/Web/Form/Decorator/BootstrapForm.php
2014-07-17 13:15:42 +02:00
Johannes Meyer 3105c2059e Remove license headers from all files
refs #6309
2014-07-15 13:43:52 +02:00
Johannes Meyer d22363d365 Fix error messages not being displayed in the preferences configuration 2014-07-10 13:43:49 +02:00
Johannes Meyer 6690410c42 Adjust Icinga\Form\Config\LoggingForm to suit the new form builder
refs #5525
2014-07-10 11:16:31 +02:00
Johannes Meyer 630b36e706 Adjust Icinga\Form\Authentication\LoginForm to suit the new form builder
refs #5525
2014-07-10 11:15:46 +02:00
Johannes Meyer e21b4243ca Fix error message when no authentication method available
The error handling for configuration files has slightly changed (non
existent files are treated as empty) so the authentication chain handling
needed to be adjusted as well.

fixes #6268
2014-07-09 12:53:25 +02:00
Johannes Meyer 82d2f5ac9b Revert "Merge branch 'feature/install-wizard-6136'"
This reverts commit 88d4262e7c, reversing
changes made to 6fae333048.

Conflicts:

	application/controllers/InstallController.php
	library/Icinga/Web/Controller/ActionController.php
2014-07-07 15:09:03 +02:00
Johannes Meyer 143a1e44fe Add a HTML renderer for Icinga\Web\Menu
The menu was being rendered through recursive partials before. The
overhead this fact implicates is not as efficient as standard recursion
so there is now a special renderer for Icinga\Web\Menu utilizing
the RecursiveIteratorIterator

refs #6153
2014-07-03 15:46:46 +02:00
Johannes Meyer f2e5d8afa5 Remove @codeCoverageIgnoreStart/-Stop annotations
refs #6091
2014-06-30 13:58:37 +02:00
Thomas Gelf 3020273b36 ConfigController: re-add devtools action
I accidentally removed it. Don't care about this right now, this is
just a playground.
2014-06-25 20:31:44 +02:00
Thomas Gelf 2b23b259fa ConfigController: notification text fixes
NB: We still have to translate them
2014-06-25 10:50:31 +02:00
Thomas Gelf 2746b5ff9f ConfigController: switch over to new config tabs
Module configuration now takes place in module detail view and does no
longer pollute our config tabs. Modules are now able to provide a bunch
of own config tabs, we don't really care what they use them for.
2014-06-24 21:31:59 +02:00
Thomas Gelf f7d2bdbc78 ConfigController: notifications before redirection
That's how they reach the browser in a nice way
2014-06-24 21:11:48 +02:00
Thomas Gelf 3576263559 config/devtools: playground for developer tools
This is nothing but a prototype right now but could become pretty
useful. We want to allow our users to control most of our developer
tools without deep knowledge about Icinga Web internals.

This first prototype allows allows one to toggle the JS UI debug
window.
2014-06-24 20:50:02 +02:00
Thomas Gelf b7b99cfd67 Widget\AlertMessageBox: fix broken widget
This widget is pretty useless as the error view script can to it's
job. Interestingly nobody missed it, even the render() call was wrong.

I guess we will remove this soon, but for now it's fixed. Looks ugly,
but works.
2014-06-24 20:30:41 +02:00
Thomas Gelf a1acd52ad9 SearchController: disable autorefresh
Makes no sense as search dashlets refresh themselves.

refs #6536
2014-06-23 10:50:55 +02:00
Thomas Gelf 3fc1205175 AuthenticationController: use Auth() helper function 2014-06-22 20:08:55 +02:00
Thomas Gelf 23ed744747 params/_render: replace it everywhere
Cleaning up controllers and JS, using headers only and respecting
history.
2014-06-22 20:07:44 +02:00
Thomas Gelf 78193137f0 config/modules: show metadata, improve usability
Well... I didn't want to commit this before creating single-button
forms for enabling/disabling modules. However part of this accidentally
made it through, so let's finish it.

Still some work to do, but it already looks far better like this.

refs #4095
2014-06-21 02:27:27 +02:00
Thomas Gelf 216c2ca770 Autorefresh: should work also on initial page load
fixes #6296
2014-06-21 01:54:32 +02:00
Thomas Gelf 9411dec5d0 StaticController: improve cache headers
Apache does automagic stuff if we don't care (e.g. pragma). Playing
around with ETags, not happy yet.
2014-06-20 14:53:38 +02:00
Thomas Gelf d2ccc68214 Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
Conflicts:
	modules/monitoring/application/controllers/ListController.php
2014-06-17 09:47:14 +00:00
Eric Lippmann 7215ba4f59 Autologin: Do not require a bogus password in the source code 2014-06-11 15:46:58 +02:00
Eric Lippmann a5e9d6cf0d auth: increase backends tried counter AFTER skipping autologin backends 2014-06-06 09:33:29 +02:00
Thomas Gelf 1fbca25d99 Data\DataArray: use SimpleQuery and new interfaces
Removed ArrayQuery implementation as SimpleQuery is enough here.
Renamed the Datasource class to ArrayDatasource.

refs #6418
2014-06-06 06:21:35 +00:00
Marius Hein 20b43a92f1 Dashboard: Better implementation of handling errors
refs #6412
2014-06-05 16:07:40 +02:00
Marius Hein 151f058286 Dashboard: Display error message on failure
When no (default) configuration is available for dashboards
application dies not very gracefully. Display error message
and guid the user to the solution is a better way.

fixes #6412
2014-06-05 15:20:54 +02:00
Marius Hein 29f593a357 Authentication: Add backend to handle external authentication
Drop external auth configuration from config.ini and move
implementation into a single backend provider named
'autologin'. This provider can strip realm names from
username with a custom regexp.

fixes #6081
2014-06-03 17:59:22 +02:00
Eric Lippmann 086e2b6197 Auth: Log and notify user about authentication backend errors
refs #5685
2014-06-02 15:47:21 +02:00
Eric Lippmann ede403977a Auth: Get password from form only once
Before, the user's password was retrieved for every authentication
backend tried for authentication.
2014-06-02 14:04:45 +02:00
Thomas Gelf f7c5119424 Search: split result and search hint
There was an ugly if/else in the view script, this patch creates two
of them and adds friendlier search suggestions.
2014-05-28 11:13:41 +00:00
Thomas Gelf cfa0251dbf Translation: another bunch of translatable strings
refs #6339
2014-05-27 21:47:13 +00:00
Thomas Gelf 358b2582bc ErrorController: show valid title for exceptions
Multiline strings are not considered being a valid title. This patch
strips all but the first line from the exception message when setting
the title attribute.
2014-05-20 13:40:52 +00:00
Johannes Meyer 1637a19c23 Fix multistep form creation
refs #6136
2014-05-14 12:53:44 +02:00
Johannes Meyer 429e09aae2 Multistep pages should not have random generated names
refs #6136
2014-05-14 12:53:44 +02:00
Johannes Meyer 88e451402f Redirect to /install when the setup.token exists but no config.ini
refs #6136
2014-05-14 12:53:44 +02:00
Johannes Meyer 4cf5fe6fdd Add multistep form
refs #6136
2014-05-14 12:53:44 +02:00
Johannes Meyer e1230eb8ae Add style and view scripts for first prototype
refs #6136
2014-05-14 12:53:44 +02:00
Johannes Meyer 4cf3044a53 Rename Icinga\Logger\Writer\StreamWriter to FileWriter
refs #6038
2014-04-30 11:59:22 +02:00
Johannes Meyer a5faa8bf25 Fix ResourceForm
refs #6038
2014-04-30 10:16:20 +02:00
Johannes Meyer e2ba172a8e Make dashboard components using the ini writer class
fixes #5524
2014-04-29 11:30:53 +02:00
Johannes Meyer 98ca15d1fb Mark less important or non-testable code as skipped for code coverage
refs #6011
2014-04-28 14:06:41 +02:00
Johannes Meyer 3d44c45eb8 Rename EditResourceForm to ResourceForm
refs #6011
2014-04-28 14:06:38 +02:00
Johannes Meyer aaa6a56146 Refactor authentication config form tests and fix auth backend validation
refs #6011
fixes #5712
2014-04-28 14:06:38 +02:00
Thomas Gelf 4a6fe006d8 Show exception message in title 2014-04-17 16:21:48 +00:00
Johannes Meyer 82ca774331 Re-enable setting the current configuration when showing icingaweb/config
fixes #5972
2014-04-08 15:18:14 +02:00
Alexander Klimov cdf1a0b683 Write more class documentation 2014-04-02 13:47:02 +02:00
Alexander Klimov 241fda1196 Small cleanup 2014-04-02 13:47:02 +02:00
Alexander Klimov d38e879d69 Sort application log DESC
resolves #4514
2014-04-02 13:47:02 +02:00
Alexander Klimov e2bfc06d6c Moved application log from monitoring module
refs #4514
2014-04-02 13:47:02 +02:00
Johannes Meyer bafa8cc032 Fix authentication error handling 2014-03-28 14:45:03 +01:00
Thomas Gelf 90665a2711 Re-render page when en/disabling modules and trigger client-side CSS reload 2014-03-26 07:58:57 +00:00
Thomas Gelf ad0432f3be Do not search with empty search string, add servicegroups 2014-03-25 12:30:05 +00:00
Thomas Gelf 440b1cf730 Re-enable search result autorefresh as it should work fine right now 2014-03-25 12:14:26 +00:00
Thomas Gelf f612610fa7 Friendlier error controller, special handling for 404 with disabled module 2014-03-25 12:10:02 +00:00
Thomas Gelf 08c66afec2 Basic styling for 'Add to dashboard' 2014-03-10 01:40:23 +01:00
Thomas Gelf cdc717b88f No search autorefresh unless fixed 2014-03-09 01:56:05 +01:00
Thomas Gelf d729d9381d Temporarily remove 'plus' link from dashboard 2014-03-08 21:39:12 +01:00
Thomas Gelf 13f827a0ef Cleanup preferences, add them to the menu 2014-03-07 17:03:43 +00:00
Thomas Gelf 95189fbf46 Fix layout re-rendering after login (thank you, automerge) 2014-03-06 11:07:24 +00:00