Commit Graph

4223 Commits

Author SHA1 Message Date
raviks789 bd0fb8c154 Remove the use of unavailable property `$this->lessc->importDisabled`
The functionality to set import to disabled is removed in `lessc`. Hence the code where this
property is used has been removed from `LessCompiler`.
2023-08-23 10:53:13 +02:00
raviks789 8e3c456327 Fix parameter name mismatch in `View::escape` method
The mismatch arises after migration from ZF1 to ZF-future.
2023-08-23 10:53:13 +02:00
raviks789 695fe25891 Remove dead code from `Visitor.php`
The method `Visitor::visitColor` seems like a dead code and contains dynamic property
allocation. Hence, this method has been removed.
2023-08-23 10:53:13 +02:00
raviks789 825f3a9b7f Avoid use of dynamic properties deprecated in PHP 8.2 2023-08-23 10:53:13 +02:00
Alexander A. Klimov 6de4bd6e7e Explicitly add Module#configdir as (non-dynamic) property
W/o this the login page, if on PHP 8.2, says:

Deprecated: Creation of dynamic property Icinga\Application\Modules\Module::$configdir is deprecated in /usr/share/icingaweb2/library/Icinga/Application/Modules/Module.php on line 264

This breaks modules (if any) which use the property and not the getter.
2023-08-23 10:53:13 +02:00
Sukhwinder Dhillon 847ba4f395 PdfExport: Fix false positive `! empty($this->content)` 2023-08-22 12:44:46 +02:00
raviks789 8b99852fc2
Remove unused `FilterWidget::class` (#5061) 2023-08-21 15:35:17 +02:00
Johannes Meyer 4a52a653e4 js: Always load redirects to their designated target
The server applies the redirection magic now, but only
for compatibility reasons.

resolves #4881
2023-08-11 16:08:00 +02:00
Johannes Meyer 65b3006adf Check if `\Throwable` instead of `\Exception`..
..everywhere else...

fixes #5079
2023-08-10 14:12:06 +02:00
Johannes Meyer 0a6db983f3 IcingaException: Expect `\Throwable` instead `\Exception` 2023-08-09 15:53:49 +02:00
raviks789 8a17c56345 Remove requiring vendor dependencies
Also avoid autoloading vendor.
2023-08-09 15:16:16 +02:00
raviks789 50bd5cfdc9 Remove `librarary/vendor` directory
The vendor dependencies will be moved to `composer.json` in `icinga-php-thirdparty`.
2023-08-09 15:16:16 +02:00
Johannes Meyer 597cb5c94d tests: Use a real app for bootstrapping
Makes the tests less isolated, but streamlines
the autoloading and other stuff in a way that's
more maintainable than before.
2023-07-05 09:24:49 +02:00
Johannes Meyer 82d39be642 BaseTestCase: Refactor request and response mocking 2023-07-04 17:05:06 +02:00
Johannes Meyer 08bfc4f596 BaseTestCase: Drop timezone setup, the app will do it 2023-07-04 17:05:06 +02:00
Johannes Meyer 531479a92e BaseTestCase: Deprecate directory properties 2023-07-04 17:05:06 +02:00
Johannes Meyer 3f447cb954 BaseTestCase: Remove `t` and `mt` function declarations 2023-07-04 17:05:06 +02:00
Johannes Meyer e7adc06497 ApplicationBootstrap: Process `ICINGAWEB_MODULES_DIR` by default 2023-07-04 16:08:41 +02:00
Sukhwinder Dhillon 5000d3117b IcingaException: Only use `vsprintf()` if `$args` given
If the passed message contains a `%`, but no `$args`, `vsprintf()` throws an error.
2023-06-22 15:03:14 +02:00
raviks789 f74041e00a Javascript: Add `copy-to-clipboard` behavior
Utilizes `CopyToClipboard.js` from ipl-web
2023-06-20 12:06:27 +02:00
Johannes Meyer 693bed1710 Raise version to 2.11.4 2023-01-26 09:42:18 +01:00
Johannes Meyer 0803a1bbdc test: Support multiple paths in `ICINGAWEB_MODULES_DIR` 2023-01-18 12:07:11 +01:00
Yonas Habteab 6d2a585de9 TemporaryLocalFileStorage: Fix unexpected crash in destructor 2023-01-16 14:15:43 +01:00
Johannes Meyer 8837fea7a4 Libraries: Only attempt a partial match if the library name contains a slash
fixes #4971
2023-01-12 09:54:42 +01:00
Valentina Da Rold 963c3168b1 Check if url is external in validation function
refs: #4970
2023-01-11 14:09:43 +01:00
Johannes Meyer d0a83a646c Release version 2.11.3 2022-12-14 13:21:01 +01:00
Johannes Meyer f67499c74d Pdf: Use dompdf's new autoloader 2022-12-07 15:03:58 +01:00
Johannes Meyer bb54956dbb vendor: Upgrade dompdf to v2.0.1 2022-12-07 15:03:58 +01:00
Johannes Meyer d53d730aa3 HTMLPurifier: Fix file flags 2022-12-07 14:59:44 +01:00
Johannes Meyer 7df5045420 vendor: Upgrade HTMLPurifier to v4.16.0 2022-12-07 14:52:32 +01:00
Johannes Meyer b89da2f865 Visitor: Force light mode when printing pages 2022-12-07 11:57:48 +01:00
Johannes Meyer b1574e4bee ConfigMenu: Fix incorrect shared navigation url
fixes #4953
2022-12-07 11:57:23 +01:00
Johannes Meyer 3187a4e549 InternalUrlValidator: Also check the scheme 2022-12-07 11:56:43 +01:00
mrzo2s45 bdb9fd299b Fix missing escape of double quotes in CSV output.
refs #4910
2022-11-07 12:59:28 +01:00
Johannes Meyer 6ef968bb96 Raise version to v2.11.2 2022-11-04 12:14:40 +01:00
Yonas Habteab 8cb0976c5b CommentParser: Wrap descriptions after the available screen columns
Well, what should I say, the PHP code sniffer allows us up to 120 characters
line length and when you code/format based on these rules, e.g the description
of a cli command, it will mess everything up when you run `icingacli module --help`.
So, we can just wrap the output after the available screen columns.
2022-10-25 08:47:38 +02:00
Johannes Meyer 314545f3a7 PrivilegeAudit: Expand defined privileges when exporting to PDF
refs #4862
2022-10-10 10:42:45 +02:00
Johannes Meyer 503f9b7316 PrivilegeAudit: Use the `<details>` tag 2022-10-10 10:42:45 +02:00
Johannes Meyer 78f5fd4648 Dashlet: Drop `view` parameter from title urls
refs https://github.com/Icinga/icingadb-web/issues/463
2022-10-10 10:39:47 +02:00
Eric Lippmann c133cbe4f8
Fix LDAP pagination for PHP7.3+ (#4901)
* Ldap: Read and update cookie values for paged requests also with PHP 7.3+

* Ldap: Provide server-side sort control directly with the request with PHP 7.3+
2022-10-10 09:55:47 +02:00
Johannes Meyer 225d43b45f Release version 2.11.1 2022-07-06 14:48:48 +02:00
Sukhwinder Dhillon 21e4c68a58 Format.php: Handle null values 2022-07-06 14:43:16 +02:00
Sukhwinder Dhillon f0f2835708 Module: Don't pass null as param to `class_exists()` 2022-07-05 15:42:15 +02:00
Johannes Meyer 947aa91c48 DbQuery: Don't call `timestampForSql()` in `valueToTimestamp()`
We can't call it implicitly, not all filter columns support
date time strings, especially in postgresql..
2022-07-05 09:55:32 +02:00
Johannes Meyer dcf194bc4c Raise version to 2.11.0 2022-06-30 13:47:07 +02:00
Yonas Habteab c29ac9842d Call: Don't precompile arg values when it's not an array
The CSS/LESS callable argument values may not always be an array, but also an object or whateever,
in this case we don't need to precompile the values as they could never be a variable.
2022-06-30 12:15:01 +02:00
Yonas Habteab 9ac1a00e94 Remove some unused codes & adjust the license headers 2022-06-30 12:15:01 +02:00
Yonas Habteab 5a04480245 Check for deferred color prop when defining variable variable & some fixlets for naming issue 2022-06-30 12:15:01 +02:00
Yonas Habteab a2932bd5ce Visitor: Transform less tree calls & variable definitions into our own classes 2022-06-30 12:15:00 +02:00
Yonas Habteab 7ac2dccbd1 Introduce `DeferredColorProp` class 2022-06-30 12:15:00 +02:00