Commit Graph

2258 Commits

Author SHA1 Message Date
Alexander A. Klimov a817d9070e Move setupSortControl() from Monitoring_ListController to Icinga\Web\Controller 2015-04-10 11:36:25 +02:00
Johannes Meyer 8477859dc1 Fix that the user isn't being notified that no events were found for an object 2015-04-10 09:51:08 +02:00
Johannes Meyer 3d7e418032 ContactQuery: Provide case insensitive filter column `service_host'
refs #8613
2015-04-10 09:50:26 +02:00
Johannes Meyer 6d03b2fe8f DataView\Contact: Add missing filter columns
refs #8613
2015-04-10 09:49:47 +02:00
Johannes Meyer 0ec1a18844 ContactQuery: Fix query column `service' not referencing a service's name
refs #8613
2015-04-10 09:48:22 +02:00
Johannes Meyer 52dcecfd08 ContactQuery: Change query column `contact_name' to be case sensitive
...and provide `contact' as case-insensitive alternative.

refs #8613
2015-04-10 09:46:41 +02:00
Johannes Meyer f00adc2138 ContactQuery: Provide ci query columns for aliases and email addresses
refs #8613
2015-04-10 09:45:23 +02:00
Johannes Meyer 3c47ba11eb monitoring/show/contact: Require `contact_name' instead of `contact'
refs #8613
2015-04-10 09:39:39 +02:00
Johannes Meyer 3d09615851 Fix that the user isn't being notified that no events were found
empty() seems not work if subqueries are involved.
2015-04-09 15:30:21 +02:00
Johannes Meyer ea874f8402 *historyQuery: Remove COLLATE from `host_name' and `service_description'
refs #8613
2015-04-09 15:29:01 +02:00
Johannes Meyer 51bf5cfbc8 *historyQuery: Drop redundant query columns
refs #8613
2015-04-09 15:13:59 +02:00
Johannes Meyer 9e79419eb1 EventHistoryQuery: Provide `hostgroup_name' as alternative to `hostgroup'
This can't be queried though until #7274 has been resolved.

refs #8613
2015-04-09 14:44:10 +02:00
Johannes Meyer ec67c28629 DataView\EventHistory: Do not permit `host' and `service' to be queried
refs #8613
2015-04-09 14:41:10 +02:00
Johannes Meyer b7e1c2d518 EventHistoryQuery: Remove COLLATE from the column `service_description'
refs #8613
2015-04-09 14:40:12 +02:00
Johannes Meyer ae10e01ed6 EventHistoryQuery: Remove COLLATE from the column `host_name'
refs #8613
2015-04-09 14:39:47 +02:00
Johannes Meyer 044a15d113 Alertsummary: Do not fetch more columns than necessary.. 2015-04-09 14:29:26 +02:00
Johannes Meyer 2c38ccda5c EventHistoryQuery: Drop column `service_host_name'
refs #8613
2015-04-09 14:19:31 +02:00
Johannes Meyer 84a2727523 Eventhistory: Fetch object names using their columns with initial collation
refs #8613
2015-04-09 14:17:27 +02:00
Johannes Meyer bc6a086ff8 DataView\Comment: Do not permit `comment_author' to be queried
refs #8163
2015-04-09 13:08:49 +02:00
Johannes Meyer 5372dfb7f1 Fetch a comment's author using `comment_author_name'
refs #8613
2015-04-09 13:07:50 +02:00
Johannes Meyer 21c76010d4 CommentQuery: Add `comment_author_name' as additional query column
refs #8613
2015-04-09 13:06:38 +02:00
Johannes Meyer 8ed1c8eeb6 DataView\Comment: Add `service_host_name' as allowed query column
refs #8613
2015-04-09 12:56:31 +02:00
Johannes Meyer 002b820835 CommentQuery: Provide `service_host' additionally to `service_host_name'
refs #8613
2015-04-09 12:55:57 +02:00
Johannes Meyer 480f5516d6 DataView\Comment: Do not permit querying `host' and `service'
refs #8613
2015-04-09 12:53:28 +02:00
Johannes Meyer cb95f53dba CommentQuery: Fetch and display object names with their initial collation
i.e. `host_name' instead of `comment_host' alias `host'
and `service_description' instead of `comment_service' alias `service'.

refs #8613
2015-04-09 12:49:06 +02:00
Johannes Meyer 1e6f292910 Use `servicegroup_name' instead of `servicegroup' to filter services
refs #8613
2015-04-09 11:43:51 +02:00
Johannes Meyer e5eca97169 Use `hostgroup_name' instead of `hostgroup' to filter hosts and services
refs #8613
2015-04-09 11:43:21 +02:00
Johannes Meyer f7550f55c1 Permit to filter hosts and services by hostgroup_name and servicegroup_name
refs #8613
2015-04-09 11:41:56 +02:00
Johannes Meyer 7d984665d6 Use `host_name' to decide whether to show a service's host or not
`host' might match multiple hosts even if no * is being part of the filter.

refs #8613
2015-04-09 11:12:09 +02:00
Johannes Meyer cee189a5fc Adjust command links so that they'll use `service_description'
...instead of `service'

refs #8613
2015-04-09 10:28:34 +02:00
Johannes Meyer b9aee47d1f Adjust command links so that they'll use `host_name' instead of `host'
refs #8613
2015-04-09 10:27:41 +02:00
Johannes Meyer 09ab601942 Require `service_description' instead of `service' to show a particular service
`service' implies that it is possible to provide case-less identifiers which is
*not* possible.

refs #8613
2015-04-08 16:49:52 +02:00
Johannes Meyer b93d18a0fc Require `host_name' instead of `host' to show or list particular objects
`host' implies that it is possible to provide case-less identifiers which is
*not* possible.

refs #8613
2015-04-08 16:25:29 +02:00
Johannes Meyer 13596ec70f ShowController: Remove obsolete use statements 2015-04-08 15:21:16 +02:00
Alexander A. Klimov 20b09d3bda Inherit from Icinga\Web\Controller rather than from Icinga\Web\Controller\ModuleActionController 2015-04-08 15:13:59 +02:00
Johannes Meyer c56c5655bd Do not permit querying columns with changed collation and a valid alternative
refs #8613
2015-04-08 14:51:04 +02:00
Johannes Meyer 9557585f6a Add an additional column for servicegroup names with unchanged collation
refs #8613
2015-04-08 14:49:18 +02:00
Johannes Meyer c476ee6855 Add an additional column for hostgroup names with unchanged collation
refs #8613
2015-04-08 14:42:57 +02:00
Johannes Meyer 98c76a693e Do not adjust the collation when querying service descriptions
refs #8613
2015-04-08 14:41:13 +02:00
Johannes Meyer b449127680 Do not adjust the collation when querying host names
refs #8613
2015-04-08 14:40:34 +02:00
Johannes Meyer 1835479738 Setup: Fix that the mysql privilege checks are not working in the wizard
Missed to commit this yesterday as part of the fix for #8929

refs #8929
2015-04-08 08:55:08 +02:00
Johannes Meyer 2882e2fd5e Setup: Fix that not any privilege checks are working in the wizard
fixes #8929
2015-04-07 16:14:03 +02:00
Alexander Klimov 967a2e82dc Use (only) "@return $this" in fluent interfaces' documentation 2015-04-07 14:24:11 +02:00
Eric Lippmann 06d9e4113c Fix that sending multiple commands over SSH failed
The config object has to cloned before unsetting the transport because else the
transport is removed for all subsequent calls to CommandTransport::fromConfig().

fixes #8815
2015-04-01 13:53:44 +02:00
Eric Lippmann 5745c1fec4 Fix code style in the Perfdata view helper 2015-03-30 12:12:58 +02:00
Eric Lippmann 09d713be0d Fix PHPDoc of the Perfdata view helper 2015-03-30 12:10:58 +02:00
Eric Lippmann 8c46e5e285 Use View::translate() instead of t() in the Perfdata view helper
refs #7330
2015-03-30 12:08:26 +02:00
Eric Lippmann 83408ee21b Use Controller::translate() instead of mt() in the AlertsummaryController
refs #7330
2015-03-30 12:04:58 +02:00
Eric Lippmann be53f4f9bc Use Controller::translate() instead of t()/mt() in the ChartController
refs #7330
2015-03-30 12:04:05 +02:00
Eric Lippmann 820862d546 Use Controller::translate() instead of t() in the AlertsummaryController
refs #7330
2015-03-30 11:58:48 +02:00
Eric Lippmann ab1dc1faa0 Do not translate format strings 2015-03-30 11:28:05 +02:00
Eric Lippmann 0a7e76d190 Fix typo in Perfdata::formatLabel()'s PHPDoc 2015-03-30 11:27:17 +02:00
Matthias Jentsch 5383999ef7 Add warning to links that open in a new window
Add warning on mouseover / focus as recommended by as recommended by WCAG20 G201

refs #7937
2015-03-19 10:49:28 +01:00
Eric Lippmann f1cdc8c904 Sort host and service overview by display_name by default
refs #8716
2015-03-13 17:19:56 +01:00
Eric Lippmann dbb5aba737 Sort by host_display_name too when sorting by host_severity
refs #8716
2015-03-13 17:14:14 +01:00
Eric Lippmann 03d85ac6ae Sort by service_display_name too when sorting by service_severity
refs #8716
2015-03-13 17:13:52 +01:00
Eric Lippmann 7ddd8d7ad2 Add support for order next to the column to DataView::getSortRules()
refs #8716
2015-03-13 17:12:16 +01:00
Eric Lippmann e17f9d7ebe Sort host overview by severity by default ...
... as indicated by the sort control.
2015-03-13 17:08:36 +01:00
Thomas Gelf f038a89fa5 locale/it_IT: a few modifications, compile catalog 2015-03-13 17:06:42 +01:00
Davide Demuru 7ca7b2e141 locale/it_IT: refresh translation
Signed-off-by: Thomas Gelf <thomas@gelf.net>
2015-03-13 17:01:49 +01:00
Thomas Gelf 2c5c795057 locale/de_DE: a few strings for detail view 2015-03-13 16:55:01 +01:00
Thomas Gelf d82b73a2fe details - notifications: show a bell 2015-03-13 16:07:20 +01:00
Thomas Gelf 499b9b149a details - notifications: shorter link text 2015-03-13 16:06:19 +01:00
Johannes Meyer 44b1255bbc Do not open a new column when removing an acknowledgement 2015-03-13 14:13:09 +01:00
Marius Hein e90200160f Monitoring permission: Fixing typo in configuration.php
refs #8644
2015-03-13 11:47:49 +01:00
Johannes Meyer f4e5a7f666 Do not try to set a title on a set of tabs
That's not working anymore since the title related changes were reverted
2015-03-13 11:31:24 +01:00
Thomas Gelf edf55728cb monitoring/list: fix addcolumns VS addColumns
refs #8641
2015-03-13 09:07:02 +01:00
Thomas Gelf 697d4aff27 doc/search: do not break on "ill-formed" docs
We got ugly exceptions for non-obvious errors such as missing titles
2015-03-13 08:57:45 +01:00
Thomas Gelf 6bf8849d98 doc/search: do not search with less than 3 chars
Please consider this a quickfix to avoid mass results while typing in
the global search field. We need farther improvements here:
* compact mode: e.g. title/first match on one row
* show a hint when less than 3 chars have been provided
* allow two chars once we fixed the above
2015-03-13 08:57:45 +01:00
Johannes Meyer 99610bc1bd Avoid sub-tables when showing comments or downtimes in the detail view
fixes #8625
2015-03-13 08:32:50 +01:00
Eric Lippmann 32487e4e21 Ignore settings from instances.ini that don't have a setter on the transport class used
fixes #8543
2015-03-13 03:41:33 +01:00
Eric Lippmann ce3c2507ef Show reachability in the host and service detail view
refs #6875
2015-03-13 00:26:45 +01:00
Eric Lippmann 1c8c49e732 Select service_is_reachable in the service detail view
refs #6875
2015-03-13 00:26:02 +01:00
Eric Lippmann 37823f0415 Select host_is_reachable in the host detail view
refs #6875
2015-03-13 00:25:44 +01:00
Eric Lippmann a4731ebbb3 Select is_reachable from host and service status
refs #6875
2015-03-13 00:25:08 +01:00
Eric Lippmann 2e2dd7cd00 Raise priorities of the monitoring search URLs
refs #8668
2015-03-12 18:51:32 +01:00
Eric Lippmann 3970d7dec2 Lower doc modules search priority
refs #8668
2015-03-12 18:09:43 +01:00
Eric Lippmann 5749ff72b1 Fix typo in configuration.php 2015-03-12 16:48:29 +01:00
Eric Lippmann be041435d3 Merge branch 'bugfix/unnecessary-joins-8614'
fixes #8614
2015-03-12 16:47:10 +01:00
Marius Hein cb28f00c4d Merge branch 'master' into feature/custom-notification-command-8644 2015-03-12 16:45:57 +01:00
Marius Hein ddd280d57b Fix permission send-custom-notification
refs #8644
2015-03-12 16:40:32 +01:00
Eric Lippmann 53626ccfeb Merge branch 'master' into bugfix/unnecessary-joins-8614 2015-03-12 16:40:16 +01:00
Eric Lippmann 7156bd7dfb Fetch object comments by host_name and service_description
refs #8614
2015-03-12 16:39:20 +01:00
Eric Lippmann 29b5e4fd43 Add host_name and service_description columns w/o collation to the comment query
refs #8614
2015-03-12 16:38:32 +01:00
Eric Lippmann 112f8eb2f9 Remove COLLATE from host_name and service_description in the Contactgroup query
refs #8614
refs #8613
2015-03-12 16:33:28 +01:00
Eric Lippmann 7212434856 Remove COLLATE from host_name and service_description in the Contact query
refs #8614
refs #8613
2015-03-12 16:32:05 +01:00
Marius Hein df3d81e181 SendCustomNotificationCommand: Update phpdoc strings
refs #8644
2015-03-12 16:30:11 +01:00
Johannes Meyer b37757ca6e Disable the LdapDiscoveryConfirmPage
As long as the discovery code does not report multiple results, as it should,
actually, it's useless to demand the user to confirm the result.

resolves #8602
refs #8725
refs #8708
2015-03-12 16:14:58 +01:00
Eric Lippmann b74ef2527a CSS: Remove .sort-box ...
... because we don't use it
2015-03-12 16:08:47 +01:00
Eric Lippmann 8563d5ed3f PHPDoc: Use @var instead of @type
Becasue of too many kittens PSR-5 backed off of deprecating @var.
So that's the way we go too.
2015-03-12 16:08:47 +01:00
Eric Lippmann 90971f2caf Revert "Merge branch 'feature/organize-headings-7976'"
This reverts commit ea2a17a76c, reversing
changes made to e72de8dfe1.

refs #7976
fixes #8647
2015-03-12 16:08:34 +01:00
Marius Hein ddc8dd5d4c Add command send custom notification to monitoring module
refs #8644
2015-03-12 16:08:22 +01:00
Thomas Gelf 16ca8d0654 StatusQuery: fix join on wrong alias
Looks like a copy & paste error, resulted in hosts been shown multiple
times.

fixes #8699
2015-03-12 09:46:38 +01:00
Eric Lippmann 361afdcf13 Use ! empty in favor of count > 0 in the MonitoredObjectController
refs #8614
2015-03-11 14:08:43 +01:00
Eric Lippmann 2286ab1846 Merge branch 'master' into bugfix/unnecessary-joins-8614 2015-03-11 13:38:07 +01:00
Eric Lippmann 0286641369 Don't fetch comments and downtimes twice in an object's detail view
The controller counts comments and downtimes on the object, which will automatically fetch comments and downtimes.
After that came a call to MonitoredObject::populate() which again fetched comments and downtimes.
Now the object is populated before counting comments and dowtimes.

refs #8614
2015-03-11 13:32:54 +01:00
Eric Lippmann b501fef62b Rearrange columns in the Host object
refs #8614
2015-03-11 13:10:55 +01:00
Eric Lippmann ef4970c0c1 Don't select host_process_performance_data twice in the host detail view
refs #8614
2015-03-11 13:08:53 +01:00
Eric Lippmann 84f56f4e51 Don't select host_problem in the host detail view
The column host_problem is not used in the host detail view.

refs #8614
2015-03-11 13:08:11 +01:00
Eric Lippmann 37d09511c6 Don't select host_modified_host_attributes in the host detail view
The column host_modified_host_attributes is not used in the host detail view.

refs #8614
2015-03-11 13:07:33 +01:00