tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
2,854 Commits 121 Branches 71 Tags 80 MiB
Commit Graph

887 Commits

Author SHA1 Message Date
Johannes Meyer 7b221e2aba It should not be a form's responsibility how its submit button should look.. 
...in case it's a standard button. No need to be DRY here.

refs #5525
 2014-08-22 15:20:54 +02:00
Johannes Meyer 5028ec7b0b Avoid NIH 
It's useless to have specific getters and setters if generic methods from the
baseclass can be used as well to accomplish the same task.

refs #6641
 2014-08-22 12:30:13 +02:00
Johannes Meyer 75a0c17933 Ensure that all forms have a name 
refs #5525
 2014-08-22 12:15:02 +02:00
Johannes Meyer 2b879b344f Do not populate using createElements() and fix documentation blocks 
refs #5525
 2014-08-22 12:04:14 +02:00
Alexander Klimov d1b1bc368f Monitoring_ConfigController: don't use SecurityForm::isSubmittedAndValid() 
refs #5525
 2014-08-21 11:51:49 +02:00
Alexander Klimov b81e96574a SecurityForm: replace create() with createElements() and add addSubmitButton() 
refs #5525
 2014-08-21 11:48:07 +02:00
Johannes Meyer 11063495b2 Merge branch 'master' into bugfix/rebuild-form-builder-5525 
Conflicts:
	modules/monitoring/application/controllers/ConfigController.php
 2014-08-21 10:22:16 +02:00
Thomas Gelf a8d33d90e2 Monitoring\Object: fix a couple of cv-related issues 
* Don't throw exceptions with no config
* Provide a secure default if not configured
* Improve code readability
 2014-08-20 13:36:03 +02:00
Johannes Meyer bb7972aa39 Merge branch 'master' into bugfix/rebuild-form-builder-5525 
Conflicts:
	application/controllers/AuthenticationController.php
	application/controllers/ConfigController.php
	application/forms/Authentication/LoginForm.php
	application/forms/Preference/GeneralForm.php
	modules/monitoring/application/controllers/ChartController.php
 2014-08-20 13:13:50 +02:00
Alexander Klimov bb65fb396a Merge branch 'bugfix/sensitive-custom-vars-6641' 
fixes #6641
 2014-08-20 12:29:45 +02:00
Alexander Klimov 78b98a7d67 SecurityForm: Add helptext 
refs #6641
 2014-08-20 12:21:11 +02:00
Johannes Meyer 09dfcca0bc Merge branch 'master' into bugfix/styled-history-views-6637 2014-08-20 11:39:03 +02:00
Johannes Meyer 4ceecf1146 Let comment view look more standardized and add limit control 
refs #6637
 2014-08-20 11:34:24 +02:00
Alexander Klimov 071937910b Monitoring/Object: filter protected customvars 
Move the responsibility from the viewscript to Monitoring/Object

refs #6641
 2014-08-19 18:46:37 +02:00
Alexander Fuhr ba748cbc4a Refactor multiSelect and highlight 
refs #6705
 2014-08-19 18:33:28 +02:00
Alexander Klimov ea0248ecf4 Remove '{{SAVE_ICON}}', tiny design fixes 
refs #6641
 2014-08-19 17:54:22 +02:00
Alexander Fuhr 6fe47bf5b0 Fix rows highlighting after refresh 
fixes #6705
 2014-08-19 17:32:17 +02:00
Johannes Meyer 3573908071 Let downtime view look more list-like and fix downtime end calculation 
refs #6637
 2014-08-19 17:03:35 +02:00
Alexander Klimov 3e079efe2a SecurityForm: replace `customvars' with `protected_customvars' 
refs #6641
 2014-08-19 14:51:30 +02:00
Alexander Fuhr 7035099468 Fix the host_unhandled_service_count error 
fixes #6833
 2014-08-19 14:43:24 +02:00
Alexander Klimov 65473ac8ee Monitoring config: use SecurityForm 
refs #6641
 2014-08-19 14:04:00 +02:00
Alexander Klimov 1ba3954b95 Monitoring config: implement SecurityForm 
refs #6641
 2014-08-19 14:02:26 +02:00
Alexander Klimov 6b468b7f9b Monitoring_ConfigController: make writeConfiguration's parameter `file' non-required 
refs #6641
 2014-08-19 13:51:10 +02:00
Alexander Klimov 0464099764 Monitoring: implement "Security" config tab 2014-08-19 11:19:30 +02:00
Johannes Meyer 332be22f7e Fix object history dates make output look similar to the event history 
refs #6637
 2014-08-18 15:32:12 +02:00
Johannes Meyer bbddb9ed87 Add limit-control and fix indentation of the eventhistory view 
refs #6637
 2014-08-18 15:30:59 +02:00
Johannes Meyer 043688e514 Make event history view more fancier 
refs #6637
 2014-08-15 17:03:03 +02:00
Johannes Meyer cae84a5d7f Fix float formatting of timeline circle margins and widths 
fixes #6926
 2014-08-15 13:39:02 +02:00
Johannes Meyer 54461f9319 Treat hard states more severe than soft states 
fixes #6571
 2014-08-15 12:40:56 +02:00
Johannes Meyer dc8181cdc5 Escape linefeeds and carriage returns in commands and show them as html 
fixes #6088
 2014-08-14 10:23:04 +02:00
Johannes Meyer b5d6481c12 Make it possible to translate the process info view 
refs #6610
 2014-08-13 15:52:33 +02:00
Johannes Meyer 7311ab964e Do not set the full url from the request as action with form parameters 
Setting an url with parameters named like form elements in a form with
method POST causes Zend to ignore any POST data because GET will be
processed with higher priority.

fixes #6806
 2014-08-13 14:50:21 +02:00
Johannes Meyer fe63ce664f Make use if 'ignore´ instead of explicitly unsetting array keys 
refs #5525
 2014-08-12 13:57:28 +02:00
Johannes Meyer f23bf912eb Remove obsolete use statements 2014-08-12 09:49:52 +02:00
Johannes Meyer be14844fa8 Merge EditInstanceForm with CreateInstanceForm and rename it 
As with the backend form, a user might like to change the name of an
instance. The new form and its actions are also adjusted to suit the new form interface.

refs #5525
 2014-08-11 14:49:42 +02:00
Thomas Gelf 96925487bd CLI/monitoring/list: fix DataView-related exception 
This uses the renamed DataView serviceStatus instead of the former
status and fixes the problem that CLI still assumed to have fetch
and count function on the DataView.

fixes #6777
 2014-07-31 17:24:56 +02:00
Thomas Gelf 51484ebf88 monitoring/Perfdata: ignore invalid min/max 
key=23;0;0;0;0 and key=23;;;; lead to division by zero exceptions
This should fix this by ignoring empty strings for min/max (formerly
it got "converted" to float(0)) and also ignores min == max.

fixes #6828
 2014-07-31 16:52:34 +02:00
Johannes Meyer 5a738112ea Remove isExistingBackend/-Instance 
It is more efficient to access configuration files only once instead of
accessing them multiple times in different locations.

refs #5525
 2014-07-25 16:02:13 +02:00
Johannes Meyer d7ed6bd249 Adjust removebackend-action to suit the new backend form interface 
Drops additionally the ConfirmRemovalForm of the monitoring module
as there is already one in icingaweb2's form-set.

refs #5525
 2014-07-25 16:00:38 +02:00
Johannes Meyer a78d11345b Adjust createbackend-action to suit the new backend form interface 
refs #5525
 2014-07-25 15:58:44 +02:00
Johannes Meyer b743cf8143 Adjust editbackend-action to suit the new backend-form interface 
refs #5525
 2014-07-25 14:55:36 +02:00
Johannes Meyer 488ea4633d Merge EditBackendForm with CreateBackendForm and rename it 
It is not necessary to distinct between whether a backend is created or
edited as a user perhaps likes to change the name of a backend directly
instead of the need to remove and recreate it.

refs #5525
 2014-07-25 14:50:53 +02:00
Johannes Meyer af5a3262be Revert backslash removal in front of namespace-less use statement 2014-07-25 09:12:12 +02:00
Johannes Meyer 26d42da635 Re-add getResourcesByType as simplified version 
refs #5525
 2014-07-25 08:58:50 +02:00
Johannes Meyer a6bd802e3e Remove unnecessary properties and its getters/setters 
refs #5525
 2014-07-25 08:58:11 +02:00
Johannes Meyer 5f7652133e Fix code-style and documentation 2014-07-25 08:39:27 +02:00
Alexander Klimov a4b7204e23 Contactgroups view: correct links to contacts detail pages 
fixes #6514
 2014-07-23 13:10:09 +02:00
Alexander Klimov a2809552f2 Do not use htmlspecialchars in view scripts 
fixes #6759
 2014-07-23 12:41:05 +02:00
Eric Lippmann 9269a0cbd5 Revert "Do not use htmlspecialchars in view scripts" 
This reverts commit 607aa9b203.

`Perfdata::escape()' does not exist. But `Perfdata::view::escape()' does.
 2014-07-23 12:29:27 +02:00
Alexander Klimov 607aa9b203 Do not use htmlspecialchars in view scripts 
fixes #6759
 2014-07-23 12:12:49 +02:00