Commit Graph

5177 Commits

Author SHA1 Message Date
Sukhwinder Dhillon e3ce1c4b2d (Hosts/Services)Controller: Cannot check `ObjectList` instance with `! empty()` 2023-08-23 10:53:15 +02:00
Sukhwinder Dhillon 5d5b767afe Setup Module (finish.phtml): Add empty array if $report is null 2023-08-23 10:53:15 +02:00
Sukhwinder Dhillon 6f04c54f3c ListController::createTabs(): Add missing return statement 2023-08-23 10:53:15 +02:00
Sukhwinder Dhillon ee9d139a3a PhpDoc: Fix incorrect `@param` and `@return` type hints 2023-08-23 10:53:15 +02:00
Sukhwinder Dhillon 8d55385e38 HealthController: Add return statement in new line because `render()` returns nothing 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon 63556849c9 HostnotificationQuery: Fix `Variable '$$concattedContacts' is probably undefined` 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon 8960324fcd ResourceStep: Fix `Variable '$dbHtml, $ldapHtml' are probably undefined` 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon e5981ed2b5 GeneralConfigStep: Fix `Variable '$typeDescription, $typeSpecificHtml' are probably undefined` 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon 07e272f3cc RequirementsRenderer: Add `$tags` explicitly as non-dynamic property 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon 8cfc40affe RequirementSet: Fix `sprintf` args 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon b755650256 Requirement: Fix exception throw 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon dae38414f8 AuthBackendPage: Fix `Variable '$backendForm' is probably undefined` 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon 01352cf6c2 AdminAccountPage: Fix `Variable '$groups, $users' are probably undefined` 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon d1bfde0dc5 ConfigCommand: Fix `Variable '$webserver' is probably undefined` and import missing `Exception` class 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon 7adc25ba38 TimeRange: Fix class name case 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon 0901e841a3 PerfData: Fix method name case 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon 92c647e883 CustomVarRendererHook: Remove unused param $object 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon 84589f8833 BackendStep: Fix `Variable '$$resourceTitle, $resourceHtml' is probably undefined` 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon c1bdec65f4 ServicenotificationQuery: Fix `Variable '$$concattedContacts' is probably undefined` 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon 9f3a9a006e IdoQuery: Fix method name case and var name type 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon edb9500805 EventgridQuery: Remove duplicate array entry 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon be060edd9f AllcontactsQuery: Add `$baseQuery` explicitly as non-dynamic property 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon 7cd89490cc (EventOverview/StateHistory)Form: Method `getValue()` expects only one param 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon 4341a32c1f ProcessCheckResultCommandForm: Fix `Variable '$object' is probably undefined` 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon 3db461ed62 ListController: Fix method name case 2023-08-23 10:53:14 +02:00
Sukhwinder Dhillon 9d5bf610eb ModuleController: Fix typo in global var name 2023-08-23 10:53:14 +02:00
raviks789 e0f02c1d62 `CustomVarTable`: Import `Closure`
The property `$hookApplier` is of type `Closure`, hence it has been imported.
2023-08-23 10:53:14 +02:00
raviks789 4bfa2355b7 `DocSectionRenderer`: Replace fully qualified names of classes with class names
The classes in PHPDoc are imported and their fully qualified names are replaced with their class names.
2023-08-23 10:53:13 +02:00
raviks789 acf3b7d340 `DocSearchIterator`: PHPDoc for `$section` is moved above the variable declaration in method `accept()` 2023-08-23 10:53:13 +02:00
raviks789 4bece296e5 `MonitoringFlags`: Import class `MonitoredObject` 2023-08-23 10:53:13 +02:00
raviks789 a780d9790b Declare property `$view` for helpers in monitoring modules
The property `$view` with type `Icinga\Web\View` is declared for helpers in `modules/monitoring/application/views/helpers`
directory.
2023-08-23 10:53:13 +02:00
raviks789 d22d2fb1e0 `HoststatussummaryQuery`: Fix name case for `HoststatusQuery` 2023-08-23 10:53:13 +02:00
raviks789 b481a771d0 `ServicestatussummaryQuery`: Fix name case for `ServicestatusQuery` 2023-08-23 10:53:13 +02:00
raviks789 caede2aaa9 `MonitoringBackend`: Import interface `QueryInterface`
The return type of `modules/monitoring/library/Monitoring/Backend/MonitoringBackend::query()` is `Icinga\Data\QueryInterface`.
Hence this interface is imported in `MonitoringBackend::class`.
2023-08-23 10:53:13 +02:00
raviks789 a68e0595ff `CommandTransport`: Fix return type for method `createTransport()`
`Icinga\Module\Monitoring\Command\Transport\CommandTransport::createTransport()` also returns `Icinga\Module\Monitoring\Command\Transport\ApiCommandTransport::class`.
Hence it is added to the method's return type in PHPDoc.
2023-08-23 10:53:13 +02:00
raviks789 d7518388d8 `RemoteCommandFile`: Define parameter `$resource` as nullable for method `setResource()` 2023-08-23 10:53:13 +02:00
raviks789 3d61fe6bf2 `MonitoringWizard`: Fix type for parameter `$page` of method `setupPage()`
The `$page` parameter for `Icinga\Module\Monitoring\MonitoringWizard::setupPage()` can also be
`Icinga\Module\Setup\Forms\RequirementsPage` or `Icinga\Module\Setup\Forms\SummaryPage`.
2023-08-23 10:53:13 +02:00
raviks789 209bf62a56 `DbTool`: Import class `Zend_Db_Adapter_Pdo_Abstract`
Since `DbTool::zendconn` is of type `Zend_Db_Adapter_Pdo_Abstract`, it has to be imported.
2023-08-23 10:53:13 +02:00
raviks789 1b1182d9b9 `Macro`: Import generic class `stdClass`
Generic empty class `stdClass` is imported as it is one of the return type for `Macro::resolveMacro()`
2023-08-23 10:53:13 +02:00
raviks789 8b6f9fbfed `ObjectList`: Fix return type for `getScheduledDowntimes()` 2023-08-23 10:53:13 +02:00
raviks789 30c26f16fe `ObjectList`: Include `\Icinga\Data\Filter\FilterChain` as return type in `getFilter()` 2023-08-23 10:53:13 +02:00
raviks789 b813e0badb `Perfdata`: Fix return type for method `convert()` 2023-08-23 10:53:13 +02:00
raviks789 8fe428f987 `CustomVarTable`: Cast `$wrapper` to `ipl\Html\HtmlDocument` using inline `@var` in `renderGroup()` 2023-08-23 10:53:13 +02:00
raviks789 baeba7c27a `AdminAccountPage`: Cast `$query` to `LdapQuery` using inline `@var` 2023-08-23 10:53:13 +02:00
raviks789 9e0c8ef76a `RequirementsRenderer`: Cast `$currentSet` to `RequirementSet` in `beginChildren()` using inline @var 2023-08-23 10:53:13 +02:00
raviks789 7677a0bc4e `WebWizard`: Access `Form::getName()` with correct name case in `getNewPage()` 2023-08-23 10:53:13 +02:00
raviks789 ea2166be6d `WebWizard`: Import exception `InvalidArgumentException` 2023-08-23 10:53:13 +02:00
raviks789 fc321ddc49 `WebWizard`: Use inline `@var` to cast setup pages to correct type 2023-08-23 10:53:13 +02:00
raviks789 aa5da53c9d `Webserver`: Fix name case of return type for `createInstance()` method 2023-08-23 10:53:13 +02:00
raviks789 c0145890a3 `ArrayToTextTableHelper`: Update PHPDoc for constructor 2023-08-23 10:53:13 +02:00