0695d5900c
Merge branch 'master' into feature/less-costly-count-queries-for-history-views-8615
2015-08-06 13:11:28 +02:00
528382098e
db: Respect group by for count queries, really
...
Missed that Johannes introduced DbQuery::getGroup().
refs #9828
2015-08-06 10:46:40 +02:00
a0d5509f19
DbQuery: Drop attribute $maxCount
...
It's not used anywhere and completely useless the way it's implemented.
2015-08-05 10:54:14 +02:00
064e821383
lib: Fix wrong count for queries having a group by clause
...
fixes #9828
2015-08-04 16:25:34 +02:00
16e54d3987
DbQuery: Be less error-prone while calling array_search
2015-07-31 11:05:23 +02:00
f4054d575b
Add Inspection API to db connection
...
refs #9641
2015-07-16 15:29:45 +02:00
9595809dfa
SimpleQuery: Deep clone the filter when cloning the query
2015-06-24 14:33:11 +02:00
6d48de6cf5
DbConnection: Do not accept configuration for table prefixes
...
fixes #9418
2015-06-22 13:32:34 +02:00
d5ae135415
DbQuery: Add select() method to access self::$select publicly
2015-06-19 14:05:12 +02:00
1169793213
IdoQuery: Add prototype for dynamic GROUP BY clauses
2015-06-18 09:36:04 +02:00
386447b847
DbQuery: Add getter for GROUP BY clauses
...
Allows to override this in a child to provide group by clauses not
until they are actually required.
refs #9009
2015-06-18 09:29:58 +02:00
b8efe314a0
DbQuery: Ignore wildcard only filters
...
This increases query performance vastly, since LIKE '%' comparisons
prevent the dbms from utilizing an index.
2015-06-15 13:59:46 +02:00
8cbb83d630
Merge branch 'master' into feature/monitoring-restrictions-9009
2015-06-05 15:29:16 +02:00
ae78613443
lib: Add sub query mode to the DbQuery
...
refs #9009
2015-06-03 14:13:15 +02:00
119b2fdddb
DbQuery: Allow to join additional tables
...
This should just be the beginning of such additions, there is still a group(),
distinct(), etc missing..
2015-05-28 13:52:00 +02:00
58d78f59f3
DbQuery: Initialize self::$select as early as possible
...
I'd like to use Zend's implementation instead of re-inventing the wheel just
because someone decided to only work with a copy of it in the frameworks
query but do exactly the opposite in the monitoring module's IDO query...
2015-05-28 13:49:36 +02:00
ec556edc65
Merge branch 'master' into feature/user-and-group-management-8826
2015-05-26 09:28:35 +02:00
54354b17bf
DbConnection: Replicate the fix for #9211
2015-05-26 09:26:55 +02:00
83a6e85b5d
lib: Don't render empty filters to SQL
...
Else we are presented with syntax errors.
fixes #9211
2015-05-22 13:53:57 +02:00
093857641a
DbConnection: Cast a queries count to integer forcefully
2015-05-20 09:30:23 +02:00
f305a334d5
DbConnection: Drop param $columnIndex in fetchColumn(), it's unused
2015-05-19 09:48:20 +02:00
a1276fd709
Benchmark all queries by default, not only db queries
2015-05-19 09:41:18 +02:00
7b6ca0826b
DbQuery: Let the DbConnection do the count query
2015-05-19 09:34:22 +02:00
0e0341f78a
It's the connection which provides a cursor, not the query
2015-05-18 16:01:58 +02:00
7d08dd2765
DbConnection: Adjust insert and update to support custom type definitions
...
This strips the custom insert and update implementataions in
DbUserBackend down so that it does not need to do such low level stuff...
refs #8826
2015-05-13 09:15:18 +02:00
3aaa6d39a1
DbConnection: Make it possible to insert, update and delete table rows
...
refs #8826
2015-05-11 13:25:50 +02:00
ecd059dec5
DbConnection: select() returns a DbQuery, not a Query
2015-05-04 11:13:38 +02:00
967a2e82dc
Use (only) "@return $this" in fluent interfaces' documentation
2015-04-07 14:24:11 +02:00
6bae2e0a53
Note that our license is GPL v2 or any later version in our license header instead of pointing to the license's URL
2015-02-04 10:52:27 +01:00
5b4fab0750
Add license header
...
This time without syntax errors hopefully :)
2015-02-03 16:27:59 +01:00
5fa2e3cfdc
Revert "Add license header"
...
This reverts commit 338d067aba
2015-02-03 16:16:26 +01:00
338d067aba
Add license header
...
fixes #7788
2015-02-03 15:51:04 +01:00
38957e340b
Fix that DbQuery::renderFilter produces invalid filters
...
fixes #7749
2014-11-20 11:58:22 +01:00
7621f6642d
Adjust usages of Icinga\Application\Config
...
refs #7147
2014-11-18 13:11:52 +01:00
b2a55f0998
Db\DbQuery: do not expose applyFilterSql
2014-11-16 17:09:51 +01:00
5ea2f33efb
Db\DbQuery: add NOT LIKE support
2014-11-16 17:08:50 +01:00
90f1ab06b4
Db\DbQuery: add "deep" clone support
...
Still far from being complete, Zend_Db_Select makes life really hard for
us. More to come...
2014-11-16 17:06:26 +01:00
94f8597271
Add existing GROUPBYs to count queries
2014-11-13 16:42:11 +01:00
0e34001568
Use automatically a subquery when counting with groups
2014-11-13 16:42:11 +01:00
77f5bc3932
Use GROUPBY instead of DISTINCT and subqueries when counting
2014-11-13 16:42:11 +01:00
0d4d4930a9
Db\DbConnection: benchmark single row fetches
2014-11-11 21:07:02 +01:00
7b99b74ae1
Prefer Icinga\Application\Config instead of Zend_Config
...
refs #7147
2014-11-07 13:53:03 +01:00
2b67683e00
DbConnection::__construct(): Set prefix if configured
2014-10-20 13:43:03 +02:00
afc97b1cac
Fix the duplicate entries in monitoring list shows
...
refs #7057
refs #7344
fixes #7057
2014-10-08 12:30:08 +02:00
97d2a920db
Implement GROUP BY clause functionality
2014-10-06 11:34:04 +02:00
64d41ac5a3
filter: Make `DbQuery::applyFilterSql()' public
...
I want to use that function in a module :)
2014-10-01 12:51:28 +02:00
90dbcdbbfb
The stupid `DbQuery::isTimestamp()' hack must return false
...
This a fix for modules using our query / filter combination since `return $this;' renders all columns as timestamps.
2014-09-19 14:29:29 +02:00
30f391035c
Postgres/DbQuery: Add orderfields to select
...
refs #6896
2014-09-01 10:00:04 +02:00
45638b218c
Throw IcingaException rather than Exception
...
fixes #7014
2014-08-27 16:03:15 +02:00
9c5878cbbe
ConfigurationError: extend IcingaException
...
refs #6931
2014-08-22 11:46:11 +02:00
2a204897b4
DbQuery: improve method description
...
Not English mine this was, copy paste did I ;)
2014-07-18 16:48:52 +02:00
209894d857
DbQuery: add dummy isTimestamp function
...
Not the best solution, but helps for now.
fixes #6675
2014-07-18 16:35:29 +02:00
3105c2059e
Remove license headers from all files
...
refs #6309
2014-07-15 13:43:52 +02:00
b3cdeee35d
monitoring/timeline: should benefit from new filter
...
Different changes have been applied:
* Allow integer unix timestamps as parameters for timestamp columns
* Remove alias-rewriting from Url class
* Remove all traces of raw_timestamp
* Use new filters
2014-06-21 03:09:40 +02:00
a904ff51aa
monitoring/eventhistory: improve query performance
...
This takes care of timestamp columns, modifies queries in a way not
depending on db functions, filters are passed through to subqueries
for better performance.
2014-06-20 19:14:34 +02:00
7cd696b31b
Data/queries: adjust to fit new filters
...
Slight changes to get our queries working with new filter implementation.
2014-06-17 12:34:02 +00:00
7b77083c89
Data\Db\DbConnection: relax timeout, persistance
...
Raised connection timeout, helps when talking to DB servers behind
weak links. Please note that I'm not sure whether this really is a
better default.
While it doesn't matter with local sockets, connection overhead will
have an impact with remote database servers. We have to reconnect with
every single request. Persistent connections seem to be no longer as
errorprone as they used to be, but I'd still refuse to switch them on
by default.
What we need is a config setting for connection persistancy and wizards
strongly suggesting to use this when working with remote db servers.
2014-06-17 09:53:59 +00:00
e056310378
Data\Db\DbConnection: one more legacy class name
...
Fixed, Query is now DbQuery
2014-06-17 09:52:32 +00:00
9e1e502fc8
Data\Db\DbConnection: implement fromResourceName
...
This allows to instantiate DB connections with less code in our
controllers.
2014-06-17 09:51:37 +00:00
db3accc704
Data\Db: rename Query and Connection to Db...
...
Class names in namespaces should not be chosen as once we didn't have
such. The fact that we already did "use Db\Connection as DbConnection"
is the best hint that naming was wrong.
So this patch renames Db\Connection to Db\DbConnection and does the
same with DbQuery. DbQuery has been adjusted to fit our new SimpleQuery
and to handle the new Filter implementation.
2014-06-06 06:43:13 +00:00
12b57c6d95
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
...
Conflicts:
modules/monitoring/library/Monitoring/Backend/Ido/Query/ContactgroupQuery.php
modules/monitoring/library/Monitoring/Backend/Ido/Query/IdoQuery.php
modules/monitoring/library/Monitoring/Backend/Ido/Query/StatusQuery.php
modules/monitoring/library/Monitoring/Controller.php
2014-05-20 23:15:11 +00:00
e6d80ae1f6
IDO Queries: performance quickfixes
...
Will be obsoleted by the new filter implementation, but for now it
helps a little bit
2014-05-20 13:27:58 +00:00
820b6b7a8d
Data\BaseQuery: rename to Data\SimpleQuery
...
BaseQuery should no longer be abstract but be usable as is as soon as
we stripped ResultSet-specific tasks. As "Base" suggests something that
must be extended, the name no longer fits. So this is SimpleQuery right
now.
2014-05-07 11:55:35 +00:00
8532622fab
Db: Implement missing fetch*() functions on connection level
...
The BaseQuery forwards fetch*() function calls to its datasource with the
query as first parameter since the datasource implements the actual fetching functionality.
There's no interface for fetch*() functions on the datasource level yet.
2014-04-15 17:44:34 +02:00
1a2577dd47
Db/Connection: Replace getConnection() with getDpAdapter()
...
For readability getConnection() is deprecated in favor of getDpAdapter()
since Db/Connection is already the connection.
2014-04-15 17:37:44 +02:00
c85ade39c0
Create count and select database queries separately
...
The previous implementation always created both the count
and the select query.
For readability the property baseQuery has been renamed to select which the
IDO queries must take into account.
2014-04-15 17:21:10 +02:00
862b50264a
Fix that the queryfilter parser cannot handle integer values
2014-04-01 11:44:24 +02:00
b168cf878d
Fix type specification in DowntimestarthistoryQuery
...
refs #4190
2014-04-01 11:44:23 +02:00
1604f4728b
Fix that the TreeToSqlParser cannot handle partial conjunction nodes
2014-03-19 09:11:25 +01:00
e355415164
Fix that queryfilters are being ignored by the parser
2014-03-19 09:11:25 +01:00
eae4cd3b2a
Add support for distinct database queries
...
refs #4180
2014-03-19 09:11:24 +01:00
0a5c2c5bd7
Make filtering/sorting of the servicematrix work
...
refs #4180
2014-03-19 09:11:24 +01:00
7fc47ef961
Increase DB-Connection default timeout, 2 secs are sometimes too harsh
2014-03-17 16:17:55 +00:00
68357e9ca2
Fix coding style
2014-02-21 14:07:32 +01:00
d63fee064d
Make sure DB profiler is disabled per default to avoid memory leaks
2014-02-14 13:51:28 +00:00
32c897c0c9
Added some benchmark noise to DB queries
...
We need this to track down current performance issues, refs #5534
2014-01-22 12:36:44 +00:00
ad7e4451eb
There is no "The" and no "Optional" Data class
2014-01-22 12:34:46 +00:00
ca1d50ae53
Rename Icinga 2 Web to Icinga Web 2
2013-10-23 15:11:06 +02:00
dc5182d4bf
CommandHandler now uses Status/HostView, fix sql IN-Query bug
2013-10-23 10:19:55 +02:00
c4f3e78c02
Fix filter behaviour, fix statusdat filter
...
refs #4469
2013-10-21 17:04:39 +02:00
f350011028
Add Status.dat backend
...
refs #3801
2013-10-20 15:16:44 +02:00
6095a71a8d
CS Fixes
...
refs #4868
2013-10-17 21:40:02 +02:00
44be5e85da
Refactoring and Query and IDO code,
...
the Monitoring/View code was completly dropped in favor of
the DataView implementations, as new Backends otherwise
would require to implement two seperate query logics
refs #3801
2013-10-17 19:54:58 +02:00
b89d61add3
Monitoring: Refactor data views (WIP)
...
refs #4663
2013-10-09 09:20:16 +02:00
24f64e6d30
Fix conflicts from rebase, using inet_aton with pgsql, PHP strict standards violations, CS compliance
...
refs #4255
2013-09-17 15:12:18 +02:00
1d1214b8b9
Implemented conservative count, implemented count 'cache'
2013-09-17 10:36:04 +02:00
0f48d0e2d6
Added fetchColumn, it was missing
2013-09-16 17:02:30 +02:00
3908974698
We need to set Db fetchMode as it has previously been done
2013-09-16 17:02:30 +02:00
35fd9fd391
CS: Remove whitespaces at end of line
...
find application/ library/ test/ modules/ -name *.php | xargs sed -i 's/\s\+$//'
2013-09-04 18:27:16 +02:00
aac1d69ed2
Fix count query ignoring joins
...
Count queries were created before the required columns were added,
so they often returned more values than a resultset really offers
refs #4589
2013-09-02 18:42:05 +02:00
3a8a3b8f2c
Monitoring backend: Change database objects to DbAdapterFactory
...
refs #4575
2013-08-19 18:29:26 +02:00
06fc3e395e
NO_ZERO_IN_DATE is available since MySQL 5.0.2
...
refs #4255
2013-08-02 15:10:09 +02:00
457f9b8f50
Db: Set MySQL server SQL modes to behave closer to ANSI SQL
...
refs #4413
2013-07-29 18:37:59 +02:00
f2c6a66de7
Code cleanup, fixed and extended MySQL SQL_MODE
2013-07-29 13:24:25 +00:00
705127a95e
Make sql-queries more standard compliant
...
The connection now uses ONLY_FULL_GROUP_BY when connecting and
also forces ANSI SQL, this is reflected in the query codebase.
Also the comment count fields are added in this commit.
refs #4179
2013-07-15 13:21:48 +02:00
54ccb9b12a
Move libraries from incubator to working tree for evaluation
...
Add all untested files from incubator's library/Icinga to working
tree library/Icinga
refs #4257
2013-06-07 15:46:33 +02:00
Johannes Meyer
Eric Lippmann
Matthias Jentsch
Alexander Klimov
Thomas Gelf
Alexander Fuhr
Marius Hein
Jannis Moßhammer
Thomas Gelf