tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
3,417 Commits 117 Branches 71 Tags 80 MiB
Commit Graph

180 Commits

Author SHA1 Message Date
Johannes Meyer ceeb3a9ff8 Fix createElements() not returning self where applicable 
refs #5525
 2014-09-09 13:24:39 +02:00
Johannes Meyer 6bde740d21 Fix Icinga\Form\ConfigForm show config feature not available for modules 
refs #5525
 2014-09-09 13:22:51 +02:00
Johannes Meyer 31978e1236 Fix LdapBackendFormTest 
refs #5525
 2014-09-09 10:36:42 +02:00
Johannes Meyer f53519c54d Rename ConfigForm::setConfig() to ConfigForm::setIniConfig() 
We do not want to override Zend_Form::setConfig() so this renaming is
required. set*Ini*Config() because ConfigForm::save() utilizes an ini-writer
to persist the configuration to disk.

refs #5525
 2014-09-08 13:31:25 +02:00
Johannes Meyer 930e6e7d71 We shouldn't require Form::createElements() to return self 
refs #5525
 2014-09-08 09:24:53 +02:00
Johannes Meyer 7215e273f6 Fix AddUrlForm::createElements() not returning self 2014-09-08 09:10:59 +02:00
Johannes Meyer ae9e5a40cc Merge branch 'master' into bugfix/rebuild-form-builder-5525 
Conflicts:
	application/forms/Preference/GeneralForm.php
 2014-09-08 08:46:53 +02:00
Marius Hein 7b73adbf89 Timezone detection: Add discoverd value to preference form 
refs #6078
 2014-09-05 15:24:13 +02:00
Johannes Meyer fc72ddfbc8 Adjust Preferences/GeneralForm to use handleRequest() &. Co. 
refs #5525
 2014-09-05 10:21:24 +02:00
Johannes Meyer 54a834266c Form::createElements() should add elements instead of returning them 
In case createElements() would still return the elements while requiring
the caller to add them to the form all form dependent configurations get
lost. (displaygroups, belongTo, ...) Wizards or parent forms can still
retrieve only input relevant fields by just calling createElements() and
getElements().

refs #5525
 2014-09-03 12:21:31 +02:00
Johannes Meyer 5ce9bef689 Replace usages of the `helptext' form element option with `description' 
refs #5525
 2014-09-02 17:03:51 +02:00
Johannes Meyer 95c839a8bd Remove remaining usages of the ElementWrapper- and HelpText-Decorator 
refs #5525
 2014-09-02 16:50:59 +02:00
Johannes Meyer 2d86e6ba3b Rename ResourceForm and make it use handleRequest() & Co. 
refs #5525
 2014-09-02 16:25:03 +02:00
Johannes Meyer 5b14d8fed3 Fix that the force_creation checkbox disappears after another error 
Once the user enters invalid data after he tried to save a backend without
success (because the backend was not successfully validated) the shown
checkbox disappeared in this case regardless of whether it was checked
or not.

refs #5525
 2014-09-02 16:25:03 +02:00
Johannes Meyer 39bb01b433 Rename Icinga\Web\Form::onShow() to onRequest() 
onShow() is misleading because at the time this method is being called the
form is neither shown nor created.

refs #5525
 2014-09-02 16:19:45 +02:00
Johannes Meyer deebb64869 Adjust Icinga\Form\Config\General* to use handleRequest() & Co. 
refs #5525
 2014-09-01 16:16:56 +02:00
Johannes Meyer 0e63e36ec0 Move Icinga\Form\Config\ConfirmRemovalForm to Icinga\Form 
This is a generic form not necessarily being used just for configuration
purposes.

refs #5525
 2014-09-01 15:11:09 +02:00
Johannes Meyer fb5685bac3 Merge branch 'master' into bugfix/rebuild-form-builder-5525 
Conflicts:
	application/forms/Config/Authentication/BaseBackendForm.php
	application/forms/Config/Authentication/DbBackendForm.php
	application/forms/Config/Authentication/LdapBackendForm.php
	application/forms/Config/Authentication/ReorderForm.php
	application/forms/Config/LoggingForm.php
	application/forms/Config/ResourceForm.php
	application/forms/Preference/GeneralForm.php
	library/Icinga/Application/Config.php
	library/Icinga/Web/Form.php
	modules/monitoring/application/controllers/ConfigController.php
	modules/monitoring/application/forms/Config/Backend/CreateBackendForm.php
	modules/monitoring/application/forms/Config/Instance/CreateInstanceForm.php
	modules/monitoring/application/forms/Config/Instance/EditInstanceForm.php
	modules/monitoring/application/forms/Config/SecurityForm.php
 2014-08-29 16:05:56 +02:00
Johannes Meyer ae35650c7e Adjust authentication backend forms to suit.. some form implementation 
refs #5525
 2014-08-29 15:16:13 +02:00
Johannes Meyer 364c7c0858 Add base form class for configuration forms 
refs #5525
 2014-08-29 12:25:25 +02:00
Marius Hein e345aa257a Platform: Drop *Available function 
Create a function extensionLoaded and change usages.

refs #5514
 2014-08-28 12:14:55 +02:00
Marius Hein 436a4d2965 ResourceConfig: Chance createResouce to create 
Not useful everywhere. Changed on the best suitable places.

refs #5514
 2014-08-28 12:14:55 +02:00
Marius Hein 22e17e9901 ResourceFactory: Move available function to platform 
refs #5514
 2014-08-28 12:14:54 +02:00
Alexander Klimov 45638b218c Throw IcingaException rather than Exception 
fixes #7014
 2014-08-27 16:03:15 +02:00
Alexander Klimov 7ff51caed0 Remove leading backslashes from the targets of use statements 
- use \Exception;
+ use Exception;
 2014-08-27 15:51:49 +02:00
Eric Lippmann 1dea19504f Revert "Remove leading backslashes from the targets of use statements" 
This reverts commit 87a5967501.

At least 'modules/doc/run.php' issues a warning about "The use statement with non-compound name 'Zend_Controller_Router_Route' has no effect"
 2014-08-27 12:24:11 +02:00
Alexander Klimov 87a5967501 Remove leading backslashes from the targets of use statements 
- use \Exception;
+ use Exception;
 2014-08-27 11:16:44 +02:00
Johannes Meyer 7b221e2aba It should not be a form's responsibility how its submit button should look.. 
...in case it's a standard button. No need to be DRY here.

refs #5525
 2014-08-22 15:20:54 +02:00
Johannes Meyer a0b2c0b454 Fix another documentation block 2014-08-22 12:18:26 +02:00
Johannes Meyer 75a0c17933 Ensure that all forms have a name 
refs #5525
 2014-08-22 12:15:02 +02:00
Johannes Meyer 2b879b344f Do not populate using createElements() and fix documentation blocks 
refs #5525
 2014-08-22 12:04:14 +02:00
Johannes Meyer bc05d2ee64 Merge LoggingForm into GeneralForm 
fixes #6933
 2014-08-22 11:05:20 +02:00
Johannes Meyer bb7972aa39 Merge branch 'master' into bugfix/rebuild-form-builder-5525 
Conflicts:
	application/controllers/AuthenticationController.php
	application/controllers/ConfigController.php
	application/forms/Authentication/LoginForm.php
	application/forms/Preference/GeneralForm.php
	modules/monitoring/application/controllers/ChartController.php
 2014-08-20 13:13:50 +02:00
Thomas Gelf 0d3fb9e7a5 LoginForm: explicitely remove renderLayout 
Should prevent against rare race conditions.

refs #6584
 2014-08-19 11:35:51 +02:00
Thomas Gelf 1cffbc9034 LoginForm: add "redirect" POST field 
Instead of blindly trusting the redirect parameter in the URL this
creates a hidden form field and explicitely set's the form action
to the current URL without the redirect parameter.

refs #6584
 2014-08-19 09:30:54 +02:00
Johannes Meyer 4ddc0e718b Report the default language also as being available for setting up the locale 
fixes #6905
 2014-08-14 10:48:52 +02:00
Johannes Meyer fe63ce664f Make use if 'ignore´ instead of explicitly unsetting array keys 
refs #5525
 2014-08-12 13:57:28 +02:00
Johannes Meyer eea43e9a60 Adjust Icinga\Form\Dashboard\AddUrlForm to suit the new form interface 
refs #5525
 2014-08-12 09:49:27 +02:00
Johannes Meyer a627571b87 Drop obsolete button elements 
refs #5525
 2014-08-11 10:46:45 +02:00
Johannes Meyer f0a99274e6 Access backend information by using getValue() instead of getConfig() 
refs #5525
 2014-08-11 10:46:08 +02:00
Johannes Meyer 5203f82b80 Fix message translation 2014-08-11 10:44:21 +02:00
Johannes Meyer a37e65be52 Fix coding style 2014-08-11 10:43:54 +02:00
Johannes Meyer d260c3fb94 Do not overwrite __construct() in forms, there's init() for that purpose 
refs #5525
 2014-08-11 10:39:13 +02:00
Johannes Meyer c36e30af1e Remove DbBackendForm::getConfig as it's not used anywhere 
refs #5525
 2014-08-11 09:13:41 +02:00
Alexander Klimov 4e1e845675 DbBackendForm: replace create with createElements and getResources with __construct 
refs #5525
 2014-07-29 12:22:43 +02:00
Alexander Klimov 5e6ef57590 LdapBackendForm: replace create with createElements and getResources with __construct 
refs #5525
 2014-07-29 12:21:58 +02:00
Alexander Klimov ed10e49bb6 Add AutologinBackendForm 
fixes #6434
 2014-07-25 14:51:42 +02:00
Johannes Meyer 26a78dc387 Remove properties from ConfirmRemovalForm and update it 
Which object should be removed needs not to be a part of a form but is
accessible from the url's query string which should be in the action of the
form.

refs #5525
 2014-07-24 16:20:01 +02:00
Johannes Meyer 9c434fe8bf Make isValid more compact and fix coding style 
refs #5525
 2014-07-24 09:05:10 +02:00
Johannes Meyer edf49d091e Rewrite addForceCreationCheckbox and move it downwards 
We should not instantiate form elements directly without any specific
reason.

refs #5525
 2014-07-24 08:57:49 +02:00