Commit Graph

835 Commits

Author SHA1 Message Date
Johannes Meyer 94d727dbb8 Fix error in Icinga\Web\Form in case the label decorator is missing
Zend_Form::getDecorator() returns false instead of null in case the
decorator is not found.
2015-01-22 09:21:50 +01:00
Johannes Meyer 10eacf9682 Allow jumping to already visited pages
This was already possible using just the base implementation of Wizard
but since WebWizard has optional pages it did not work with pages that
had such an optional page as previous page.

refs #8191
2015-01-21 15:39:06 +01:00
Johannes Meyer 64a8006973 Add Wizard::isComplete()
Wizard::isFinished() is not applicable in case a wizard is a child of another
wizard. Wizard::isComplete() fulfills the need to check whether a user went
through a wizard entirely.

refs #8191
2015-01-21 13:56:53 +01:00
Johannes Meyer 1f6a81aefb Add Wizard::skipPage()
Required to not to duplicate code in custom wizards and to avoid errors
when detecting the direction.

refs #8191
2015-01-21 13:07:08 +01:00
Johannes Meyer 2288e2a687 Add support for nested wizards
The amount of vertical dimensions is not limited as well as the location a
nested wizard can occur in the main wizard's order. In case a custom
implementation is used as nested wizard, all core functionalities are
still being utilized.

refs #8191
2015-01-20 15:54:14 +01:00
Eric Lippmann a1a36301fe View: Add string helpers 2015-01-19 14:20:57 +01:00
Eric Lippmann 50bbf77d0c Fix module domain detection in Form::getTranslationDomain()
The usage of preg_replace had two errors:
1) The regular expression was wrong
2) $matches[0] always contains the full matched string, not the first parenthesized subpattern

The correct version of preg_replace would've been:

if (preg_match('/^Icinga\\\\Module\\\\([A-Za-z]+)\\\\/', get_called_class(), $matches) === 1) {
    return strtolower($matches[1]);
}

But since there's no benefit of using a regular expression here except less speed, I replaced it
with using explode.

refs #7551
2014-12-30 10:08:33 +01:00
Matthias Jentsch a1950aabba Fix some obsolete or wrong docstrings 2014-12-29 16:27:28 +01:00
Matthias Jentsch 4cf8da4bb9 Do not focus logout menu item after a recurring login
Implement new MenuItemRenderer made for pages that are not part
of the regular site navigation and should trigger a complete site reload
instead of handling it via XHR.
2014-12-29 16:20:05 +01:00
Boden Garman 5e40ce2088 Only check the session save path is writable if the session handler is 'files'
fixes #8053

Signed-off-by: Eric Lippmann <eric.lippmann@netways.de>
2014-12-29 09:37:47 +01:00
Eric Lippmann 7f5ba135ee Revert "Relax session storage check to the `files' save handler"
This reverts commit f7d11ce11f.

Sorry mate but a guy on GitHub was faster ;)

refs #8053
2014-12-29 09:37:07 +01:00
Matthias Jentsch 41c101d99f Use neutral default color in perfdata piecharts
If nothing is known about the state of the monitoring object, the piecharts should neither indicate OK nor Critical.
2014-12-23 16:12:25 +01:00
Matthias Jentsch cda5a6a903 Streamline chart implementation
Define sparkline layout through CSS class and remove label/tooltip formatting.

fixes #7077
2014-12-23 15:26:45 +01:00
Matthias Jentsch 64a2acd12e Do not display labels for single data sets in perfdata piecharts
Display generic chart titles for the whole piechart that only contain title and percentage and don't style perfdata piecharts using HTML properties.

refs #7077
refs #6200
refs #7304
2014-12-23 15:14:17 +01:00
Johannes Meyer f7d11ce11f Relax session storage check to the `files' save handler
fixes #8053
2014-12-22 11:02:48 +01:00
Johannes Meyer 6d263ae316 Do NOT fetch the translation domain from the request in Form::translate(..)
It might be the case that a module is using a library form...

refs #7551
2014-12-19 13:07:51 +01:00
Johannes Meyer cf43b81400 Use the class namespace instead of the request in Form::translate(Plural)
refs #7551
2014-12-19 12:08:54 +01:00
Johannes Meyer e5d2d4cec2 Add module-aware Form::translate and Form::translatePlural
refs #7551
2014-12-19 11:29:24 +01:00
Eric Lippmann 4dfac28393 lib: Fix PHPDoc of Form::setOnSuccess() 2014-12-18 17:21:06 +01:00
Johannes Meyer 7710fd7b0e Hide unsupported export formats
refs #8112
2014-12-18 16:20:41 +01:00
Johannes Meyer 3fde78f2b3 Enable the dompdf float support and fix our list's layout 2014-12-15 13:56:19 +01:00
Johannes Meyer bca28a5ae2 Display inline pie-charts also in views exported to PDF
fixes #6463
2014-12-15 13:55:20 +01:00
Thomas Gelf cddb68bffb ActionController: shift global parameters globally 2014-12-03 10:40:48 +01:00
Eric Lippmann d41602a67c Rearrange imports in Menu.php 2014-11-25 16:11:01 +01:00
Eric Lippmann eed10159fd Menu: Don't render sub menus when a dot appears in the label
I guess this was intended to be a feature. Turns out to be a bug though :)

fixes #7772
2014-11-21 17:39:18 +01:00
Eric Lippmann d84318d8b8 Fix Menu's PHPDoc
Don't use @var and don't use @return self for fluent interfaces.
2014-11-21 17:13:39 +01:00
Eric Lippmann 99ad72a0da Remove the Help decorator 2014-11-20 13:50:40 +01:00
Marius Hein bdc0321f62 Dashboard: Fix wrong URL
refs #7751
2014-11-20 13:41:12 +01:00
Eric Lippmann bb664a87ea Fix ugly positioning of help icons
If an element has a description, the description is now added to the element's label as title.
The CSS class has-feedback ensurers that the help icon is rendererd. If everything is working fine,
I'll the remove the super duper Help decorator.
2014-11-20 13:25:58 +01:00
Marius Hein e600dc8adb Dashboard: Rename component to dashlet
refs #7751
2014-11-20 12:08:50 +01:00
Thomas Gelf fa44197947 Dashboard: fix complex urls 2014-11-19 16:45:15 +01:00
Eric Lippmann 2830b13082 Merge branch 'master' into feature/security-gui-5647 2014-11-19 16:31:26 +01:00
Marius Hein 32af89e0a7 Merge remote-tracking branch 'origin/master' into bugfix/broken-badges-7736 2014-11-19 15:28:27 +01:00
Eric Lippmann a2818bd937 Merge branch 'master' into feature/security-gui-5647 2014-11-19 14:13:26 +01:00
Matthias Jentsch 48699cacf4 Fix navigation layout in firefox and chrome
Hover css still broken

refs #7736
2014-11-19 12:15:18 +01:00
Marius Hein dbc1b1ce3e Merge remote-tracking branch 'origin/master' into feature/add-to-dashboard-4537 2014-11-19 11:48:22 +01:00
Marius Hein a40f357f3c Dashboard: Show error message when can not write to file
refs #4537
2014-11-19 11:47:31 +01:00
Thomas Gelf 47d81ccf7b css: allow to override vendor styles
* no more hovered icon underline
* simulate padding for headers in .controls
2014-11-19 10:33:57 +01:00
Marius Hein a5411c7a1c Dashboard: Fix reading and disabled system dashboards
refs #4537
2014-11-19 10:33:41 +01:00
Marius Hein cfb0ca1be0 Merge remote-tracking branch 'origin/master' into feature/add-to-dashboard-4537 2014-11-19 10:21:50 +01:00
Thomas Gelf 704a87c0f2 FilterEditor: make active element fit hover colors 2014-11-19 10:07:30 +01:00
Thomas Gelf eb823c4045 Widget\FilterEditor: fix root element stripping 2014-11-19 09:53:25 +01:00
Thomas Gelf c6ffdb3862 Widget\FilterEditor: fix failing parameter checking 2014-11-19 09:44:47 +01:00
Marius Hein 5ace5fd2dc Dashboard: Change icons
refs #4537
2014-11-18 17:47:57 +01:00
Eric Lippmann aef81a56d6 Merge branch 'master' into feature/security-gui-5647
Conflicts:
	library/Icinga/Application/Config.php
	library/Icinga/File/Ini/IniWriter.php
	library/Icinga/Web/Form.php
	library/Icinga/Web/Menu.php
2014-11-18 17:08:25 +01:00
Eric Lippmann f2717b6d26 Introduce Form::setOnSuccess() in favor of overriding the constructor
Zend_Form uses setters for options if a respective setter method exists.
It is not necessary to override the constructor for introducing new options.

Conflicts:
	library/Icinga/Web/Form.php
2014-11-18 17:02:39 +01:00
Marius Hein 10cfecf2ec Merge remote-tracking branch 'origin/master' into feature/add-to-dashboard-4537
Conflicts:
	application/controllers/DashboardController.php
	library/Icinga/Web/Form.php
	library/Icinga/Web/Widget/Dashboard.php
2014-11-18 16:36:42 +01:00
Bernd Erk 07c0180b1c Merge branch 'master' into feature/redesign-7144 2014-11-18 16:36:19 +01:00
Marius Hein 80871313e4 Dashboard: Remove actions
refs #4537
2014-11-18 16:28:04 +01:00
Johannes Meyer 1cbdd2b51c Fix that hidden elements are getting ovewritten when validating a form
This works by "disabling" hidden elements which causes the browser not
to submit them. Due to a bug in Zend we need to manually ensure that
Form::isValid does not overwrite the value of disabled elements with null.

fixes #7717
2014-11-18 15:06:46 +01:00
Johannes Meyer 760bf1a020 Disable partial validation of forms by default 2014-11-18 15:06:46 +01:00
Alexander Fuhr 38ef33276a Replace description decorator through help decorator
refs #7696
resolves #7696
2014-11-18 14:58:54 +01:00
Alexander Fuhr 4a4fbaee8e Add Help decorator for icon help description
refs #7696
2014-11-18 14:58:05 +01:00
Johannes Meyer c288a68ed5 Merge branch 'master' into bugfix/drop-zend-config-7147
Conflicts:
	application/forms/LdapDiscoveryForm.php
2014-11-18 13:21:18 +01:00
Johannes Meyer 7621f6642d Adjust usages of Icinga\Application\Config
refs #7147
2014-11-18 13:11:52 +01:00
Marius Hein 8805e4af4b Merge remote-tracking branch 'origin/master' into feature/add-to-dashboard-4537 2014-11-18 12:52:02 +01:00
Marius Hein 3e58ec2530 Dashboard: Use new controller actions
refs #4537
2014-11-18 12:51:28 +01:00
Eric Lippmann f9d7062476 Form: Add our element and decorator paths instead of calling createIcingaFormElement
createIcingaFormElement lacks all stuff applied in Zend_Form::createElement().
2014-11-18 12:51:06 +01:00
Gunnar Beutner 9a79cd58e9 Re-enable auto-refresh 2014-11-18 10:48:33 +01:00
Eric Lippmann e3629a7f41 Number element: Use is_numeric in favor of Zend's float validator
The float validator uses Zend_Locale which we have stripped in our vendor library thus leading to erroneous validation.
Further we'll use php-intl instead of Zend_Locale one day :)

fixes #7692
2014-11-18 10:31:40 +01:00
Marius Hein cbcd276b44 Dashboard: Rewrite forms and controller [WIP]
refs #4537
2014-11-18 10:04:41 +01:00
Eric Lippmann 47414f3528 Introduce Form::setOnSuccess() in favor of overriding the constructor
Zend_Form uses setters for options if a respective setter method exists.
It is not necessary to override the constructor for introducing new options.
2014-11-18 10:00:58 +01:00
Marius Hein bec0085683 Dashboard: Add urls to any dashboard (form)
refs #4537
2014-11-18 09:59:24 +01:00
Marius Hein 769e8f2636 Dashboard/Component: Add remove link
refs #4537
2014-11-18 09:59:23 +01:00
Marius Hein b679c1e770 Dashboard: Refactor search/replace implementation
refs #4537
2014-11-18 09:59:23 +01:00
Marius Hein 979bec24a5 Dashboard: Write user dashboards to disk
refs #4537
2014-11-18 09:59:23 +01:00
Marius Hein f6a2f6515d Dashboard: Introduce user flag widget
Fix: Do not render disabled components.

refs #4537
2014-11-18 09:59:23 +01:00
Marius Hein af799d42dc Widget/Dashboard: Cleanup object and remove unused stuff
refs #4537
2014-11-18 09:59:23 +01:00
Bernd Erk f83bcbfd2b updates current font set and changes service and reporting icons 2014-11-17 17:08:08 +01:00
Bernd Erk 878aa81d98 Changes conf icon in menu 2014-11-17 17:08:08 +01:00
Thomas Gelf 0cea370a5c Widget\Tab: fix tagParams check breaking tabs 2014-11-16 19:37:11 +01:00
Thomas Gelf 2e1cc8ed35 Widget\Tabs: use icon font 2014-11-16 14:41:22 +01:00
Thomas Gelf 9e0e3f12e3 FilterChain: addFilter should return itself 2014-11-16 02:49:33 +01:00
Thomas Gelf 387928de02 Filter: support 'q' searches
This makes the overall search play nice with the FilterEditor and
reduces code in the action controller. Still some work to do, but
seems to be pretty fine right now.
2014-11-16 02:40:28 +01:00
Thomas Gelf 5630374058 FilterEditor: handle ignoreParams correctly 2014-11-16 00:19:28 +01:00
Thomas Gelf e0bf021fb9 FilterEditor: apply submitted changes do filter 2014-11-15 23:49:37 +01:00
Thomas Gelf b1f82bd025 FilterEditor: add request handle support 2014-11-15 23:49:06 +01:00
Thomas Gelf 7da87b7341 FilterEditor: split render function and clean up 2014-11-15 23:48:17 +01:00
Thomas Gelf 0e4a8575a9 FilterEditor: new helper for text inputs 2014-11-15 23:46:36 +01:00
Thomas Gelf 1c5cba9ddf FilterEditor: don't sort all select's
Columns are now sorted separately, so that's fine
2014-11-15 23:45:03 +01:00
Thomas Gelf 2eb2fa51da FilterEditor: cache available columns 2014-11-15 23:43:13 +01:00
Thomas Gelf 1d4ea88251 FilterEditor: clean up selectColumn 2014-11-15 23:42:15 +01:00
Thomas Gelf e6ded2eb3c FilterEditor: use new id helper in selectSign 2014-11-15 23:39:21 +01:00
Thomas Gelf 934a0a4914 FilterEditor: helper function for op dropdown 2014-11-15 23:38:36 +01:00
Thomas Gelf c700e86008 FilterEditor: add helper rendering new filters 2014-11-15 23:37:31 +01:00
Thomas Gelf 711b1a5224 FilterEditor: elementId helper method for inputs 2014-11-15 23:34:21 +01:00
Thomas Gelf 7993ad2fde FilterEditor: add a couple of link generators
remove/add/strip/cancel
2014-11-15 23:32:38 +01:00
Thomas Gelf d6e3f06997 FilterEditor: readability 2014-11-15 23:31:17 +01:00
Thomas Gelf 4a38c069f3 FilterEditor: do not export removal function 2014-11-15 23:30:06 +01:00
Thomas Gelf 8858069514 FilterEditor: addTo method for special operations
Removed obsolete mark function
2014-11-15 23:27:58 +01:00
Thomas Gelf ee16391720 FilterEditor: no title, add cancel button 2014-11-15 23:24:55 +01:00
Thomas Gelf dcc0c213b2 FilterEditor: add redirect support
Not the cleanest way, could be improved
2014-11-15 23:18:50 +01:00
Thomas Gelf ac483a0fe6 FilterEditor: add compact search render support
We show the search box and a filter preview while not modifying the
filter
2014-11-15 23:11:55 +01:00
Thomas Gelf 44d5ee8fa0 FilterEditor: make constructor parameter optional
...and use new setters
2014-11-15 23:02:38 +01:00
Thomas Gelf c5ca3b633c FilterEditor: allow additional parameter control
We may want to keep additional parameters in our url and ignore other
ones when the filter changes
2014-11-15 22:57:25 +01:00
Thomas Gelf 269f4b4c83 FilterEditor: allow to set the query from outside
Query will be used to provide a column list
2014-11-15 22:55:26 +01:00
Thomas Gelf 118abbe980 FilterEditor: url-setter and protected lazy-shortcut 2014-11-15 22:54:40 +01:00
Thomas Gelf e75d0aa10e FilterEditor: add getter and setter for Filter
We will shift quite some logic over here
2014-11-15 22:52:55 +01:00
Thomas Gelf a75bfd1dfb FilterEditor: add failsafe string cast 2014-11-15 22:50:35 +01:00
Thomas Gelf 0fd4a094ea Web\Request: the request should know the URL 2014-11-15 22:40:29 +01:00