4d199180b3
We do not want to access $_POST directly if it is possible to avoid it
2014-07-17 09:28:10 +02:00
b7f5c8a84d
Fix that the default sort order of a view is not being applied
...
fixes #6644
2014-07-17 09:28:10 +02:00
62da942159
Don't close and re-open php tags, remove unneeded spaces
...
To close and re-open php tags makes no sense if there's nothing between them
2014-07-16 17:54:06 +02:00
1ad263170e
Revert "Small fixes"
...
This reverts commit 8086292b1b
2014-07-16 15:30:20 +02:00
8086292b1b
Small fixes
2014-07-15 18:00:52 +02:00
3105c2059e
Remove license headers from all files
...
refs #6309
2014-07-15 13:43:52 +02:00
b85ac3ab45
Translate labels in the ChartController
2014-07-09 18:13:40 +02:00
8d697a3d8e
Fix coding style
2014-07-09 18:13:40 +02:00
2b05aa9504
monitoring/list: do not apply empty filter
...
Fixes problems with the servicematrix when no filter is applied.
I'm not yet happy with this, calls to where() should automagically
handle existing empty filters.
fixes #6543
2014-07-08 16:36:05 +02:00
7eb0f3c472
Remove @codingStandardsIgnoreStart/-Stop annotations
...
refs #6091
2014-06-30 13:59:58 +02:00
9a1b7179e1
Fix violations of coding guidelines
2014-06-30 12:33:51 +02:00
1532594948
Deduplicate code: lists/hosts.phtml VS lists/hosts-compact.phtml
...
fixes #6541
2014-06-27 11:53:08 +02:00
a4fc6dedea
monitoring/list: fix limit=0 check
...
This used to be fixed, but got accidentally re-broken by last commit
this night.
2014-06-26 16:34:37 +02:00
a91bbd3a75
monitoring/list: add stateType parameter
...
This allows one to show only hard states, useful for support dashboards.
2014-06-26 00:42:38 +02:00
c85a0ac11e
list/limits: special treatment for 0 only, not null
2014-06-26 00:39:10 +02:00
ff9c29472e
monitoring/status: re-introduce comments, problems
...
This re-introduces expensive columns been disabled time ago and adds
even more to it. We are now showing last comment, last ack comment and
service problem count on hosts in list views.
It still costs performance, but seems that we can stand it. I'd like
to add more like this to the host view.
2014-06-25 21:42:24 +02:00
86f70e0a4f
list/services: don't count with no limit
...
This is a performance evaluation right now, we might delegate such
logic to paginator later on. Cuts load time for lists and/or dashlets
with complicated filters by 50% - only for those with limit=0 of course.
2014-06-25 20:45:08 +02:00
ae99dd39fd
Fix intendation in MultiController
...
Use spaces instead of tabs
2014-06-25 15:25:54 +02:00
7b19bd1d99
Improve interface of InlinePie
...
Method setLabel can also accept a simple string and title is mandatory in constructor
2014-06-25 15:21:12 +02:00
35a5431512
Revert "Refractor InlinePie and Perfdata helper"
...
This reverts commit f003c38abd
2014-06-25 14:29:17 +02:00
f003c38abd
Refractor InlinePie and Perfdata helper
...
Refractor InlinePie methods for better usability, fix several coding guideline
issues and fix some typos
2014-06-25 12:41:17 +02:00
4591297e56
SortBox: use POST instead of GET
...
This avoids trouble with complex filter URLs
fixes #6556
2014-06-25 11:00:10 +02:00
b40d0f6a1e
FilterWidget: POST instead of GET
...
Might have been a JS issue, but instead of messing with the URL just
POSTing is easier here - and works. Filters from the search box are
now added flawlessly to the filter tree.
2014-06-25 10:34:09 +02:00
2746b5ff9f
ConfigController: switch over to new config tabs
...
Module configuration now takes place in module detail view and does no
longer pollute our config tabs. Modules are now able to provide a bunch
of own config tabs, we don't really care what they use them for.
2014-06-24 21:31:59 +02:00
ccdf1ca354
monitoring/ConfigController: use notifications
2014-06-24 21:28:01 +02:00
2b2901524c
ConfigController: useless use of render
2014-06-24 21:24:40 +02:00
f75a4430a6
monitoring/config: make use of Config()
...
Thee helper function supports lazy loading, requires less code and is
easier to read.
2014-06-24 21:22:38 +02:00
d5d3f5548f
monitoring/list/hosts: support addcolumns parameter
...
At least it doesn't fail right now, this only works for services so far.
View script still needs to be adjusted, will probably be done with #6541 .
2014-06-24 21:12:55 +02:00
23ed744747
params/_render: replace it everywhere
...
Cleaning up controllers and JS, using headers only and respecting
history.
2014-06-22 20:07:44 +02:00
216f0f3f55
isIframe: clean up, load less html and js
...
We use isIframe only when we have no JS, therefore it makes no sense
to load JS files in an iFrame. Also removed sidebar.
2014-06-22 16:30:06 +02:00
3b84078b2f
Params/_render: get rid of it, start with iframe
2014-06-22 16:18:23 +02:00
2a0e72273a
ChartController: use correct ActionController
...
...and some code cleanup
2014-06-22 14:08:04 +02:00
ef5e1b54fd
Web\Window: fix it's usage, add helper function
...
Improved window handling, fixed controllers using it.
2014-06-22 13:21:21 +02:00
57ad88c38c
monitoring/process: was broken, fix it
...
Stumbled across two issues here:
* It's currently not possible to fetch all (*) columns from a DataView
* Backends are not able to tell their names
Worked around the first issue by naming all columns and implemented a
quick & dirty solution for the second one.
2014-06-21 04:25:02 +02:00
7f53ba11cf
Hook\Grapher: use it in monitoring/show
2014-06-21 04:13:14 +02:00
b3cdeee35d
monitoring/timeline: should benefit from new filter
...
Different changes have been applied:
* Allow integer unix timestamps as parameters for timestamp columns
* Remove alias-rewriting from Url class
* Remove all traces of raw_timestamp
* Use new filters
2014-06-21 03:09:40 +02:00
66f68f4990
monitoring/config: tab doesn't get focus
...
Fixes this. Tab handling is rather strange right now and module tabs
will not scale. We need a better solution for the future.
fixes #6320
2014-06-20 23:22:07 +02:00
127b728a4c
list/notifications: fix query, select columns, style
2014-06-20 19:12:10 +02:00
fb18de1f42
monitoring\CommandController: use new filters
2014-06-20 14:22:48 +02:00
f80b951cec
monitoring/ShowController: remove obsolete function
2014-06-20 14:21:29 +02:00
a8bde7cc14
monitoring/show/services: do not limit result
...
Still a little bit hackish, we will replace this once we have a request
object fully aware of our new UrlParams parser.
fixes #6511
2014-06-20 14:16:36 +02:00
f2c67ea047
MultiControllers: use new filters
...
This makes things easier, no more nested lists - just filters easy
to read and understand
2014-06-20 13:38:58 +02:00
255accb215
monitoring/MultiController: use correct controller
2014-06-20 13:35:25 +02:00
371b66bd8b
monitoring\ListController: handle filter editing
...
Handle filter modifications in one place. We still should try to
abstract this on step farther.
2014-06-20 13:26:10 +02:00
0642c9d33c
monitoring/list/hosts: filter-related cleanup
2014-06-20 13:24:32 +02:00
21febddad2
Widget\Filter*: rudimentary filter widgets
...
Initial implementation, more to come
2014-06-17 14:00:38 +00:00
a53f589a6b
monitoring/controllers: filter-related cleanup
2014-06-17 13:48:26 +00:00
a42b66ab14
monitoring/show/services: QUERY_STRING voodoo
...
Looks less ugly than before, still ugly nonetheless. Will be better
once we care about request routing by ourselves.
2014-06-17 13:17:13 +00:00
304c7d146b
monitoring/show/history: pagination count
...
Fixes it as it didn't work, raised default row count to 50
2014-06-17 13:14:58 +00:00
3ccfe347f3
Monitoring\Object: replace fromRequest with params
...
This is only a temporary solution, the Monitoring\Object should be
fetched from the backend created in our front controller.
2014-06-17 13:10:54 +00:00
0ecd527e8c
monitoring/list: make use of new params
...
This brings our lists back to life and makes our filters work again.
2014-06-17 13:05:18 +00:00
58d4ddcb4c
monitoring/list: no need to declare $this->backend
...
This happens in the monitoring base controller right now
2014-06-17 13:03:05 +00:00
d2ccc68214
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
...
Conflicts:
modules/monitoring/application/controllers/ListController.php
2014-06-17 09:47:14 +00:00
97c55d8dad
monitoring/list: clean up and fit new filters
...
refs #6418
2014-06-06 07:37:37 +00:00
defa02a609
Debug: Remove garbage statement for debug purposes
2014-06-06 09:28:46 +02:00
3adf7752c4
Data\Db\DbQuery: rename also in monitoring module
...
refs #6418
2014-06-06 06:51:11 +00:00
bfe6a1593a
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
2014-06-06 05:32:54 +00:00
29f593a357
Authentication: Add backend to handle external authentication
...
Drop external auth configuration from config.ini and move
implementation into a single backend provider named
'autologin'. This provider can strip realm names from
username with a custom regexp.
fixes #6081
2014-06-03 17:59:22 +02:00
cfa0251dbf
Translation: another bunch of translatable strings
...
refs #6339
2014-05-27 21:47:13 +00:00
12b57c6d95
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
...
Conflicts:
modules/monitoring/library/Monitoring/Backend/Ido/Query/ContactgroupQuery.php
modules/monitoring/library/Monitoring/Backend/Ido/Query/IdoQuery.php
modules/monitoring/library/Monitoring/Backend/Ido/Query/StatusQuery.php
modules/monitoring/library/Monitoring/Controller.php
2014-05-20 23:15:11 +00:00
cff577fb83
ShowController: don't show a random service
...
When you chose a host and clicked on "Services" the GUI used to show
a random (the first) service. Made no sense, should work as expected
right now.
2014-05-20 13:57:28 +00:00
339460fee4
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
2014-05-09 16:29:54 +00:00
6523af711c
Monitoring_ListController: autorefresh matrix...
...
...and notification views
fixes #6152
2014-05-09 16:01:47 +00:00
820b6b7a8d
Data\BaseQuery: rename to Data\SimpleQuery
...
BaseQuery should no longer be abstract but be usable as is as soon as
we stripped ResultSet-specific tasks. As "Base" suggests something that
must be extended, the name no longer fits. So this is SimpleQuery right
now.
2014-05-07 11:55:35 +00:00
bc4783099a
Monitoring/ListController: Sort `hostStatus' view from request params
...
The `hostAction()' lacked ordering because the action no longer uses `HostStatusView::fromRequest()'.
2014-05-07 10:25:48 +02:00
068e07109b
Monitoring/ListController: Operate on the `hostStatus' view instead of the query
...
The monitoring module's ListController should only operate on data views instead of queries.
Thus the applyRestrictions() method now expects a data view instead of a query. Further since
filters are subject to change the applyRestrictions() method now does nothing.
The `hostsAction()' no longer uses `DataView::fromRequest()' but selects the data view from
a monitoring backend. `DataView::fromRequest()' orders the underlying query which must be reworked
in the current scenario.
2014-05-07 09:40:23 +02:00
cfdb695c94
Monitoring/ListController: Remove variable activeRowHref from view
...
The variable grapher activeRowHref is not being used anywhere.
2014-05-07 09:29:58 +02:00
3afcf277bd
Monitoring/ListController: Remove variable grapher from view
...
The variable grapher retrieved as first available grapher hook is not being
used anywhere.
2014-05-07 09:27:42 +02:00
e2ba172a8e
Make dashboard components using the ini writer class
...
fixes #5524
2014-04-29 11:30:53 +02:00
290fe9eeb5
Rewrite test for Icinga\Web\Hook
...
refs #6011
2014-04-28 14:06:40 +02:00
1db9b1ede4
Move non-factory functions from DateTimeFactory to Icinga\Util\Format
2014-04-28 14:06:39 +02:00
c641988233
Preserve multiselection during refresh
...
refs #5765
2014-04-28 09:48:06 +02:00
b791883fa8
Fix configuration checkboxes and colors in piecharts
...
refs #5765
2014-04-28 09:48:06 +02:00
b16c6efa05
Add PieChart to display hosts and services, improve layout and fix flag
...
checkboxes
refs #5765
2014-04-28 09:48:06 +02:00
081b5072a6
Fix layout of MultiController views
...
refs #5765
2014-04-28 09:48:06 +02:00
cb630d45ad
Fix issues issues with javascript multiselection
...
refs #5765
2014-04-28 09:48:05 +02:00
3b2bb3c4fc
Move functions to perform single, multi and range-selection into the ui module
...
refs #5765
2014-04-28 09:48:05 +02:00
6d303f1c42
Add abillity for multi and range-selection to events.js
...
Add the abillity to select multiple rows, with a multi-selection using the
CTRL-key or a range-selection using the shift-key. Also fix several issues in
the Multi-Controller of the Backend.
refs #5765
2014-04-28 09:48:05 +02:00
139023571f
Fix exception on 404 in monitoring/show/
2014-04-09 08:44:51 +02:00
ae2d61682f
Fix how the timeline processes dates
...
refs #4190
2014-04-02 10:53:39 +02:00
21b9c1f4af
Fix that filters are not preserved on timeline element urls
...
refs #4190
2014-04-01 14:26:10 +02:00
80b4e3bf33
Add infinite scrolling to the timeline
...
refs #4190
2014-04-01 11:46:44 +02:00
14ed3b6fe2
Fix that the timeline does not accept timestamps as start and end
...
refs #4190
2014-04-01 11:46:44 +02:00
8e7d1dd8f6
Improve timeline style
...
refs #4190
2014-04-01 11:46:44 +02:00
3d658a664c
Do not use logarithm base from session if the timeline is not being extended
...
refs #4190
2014-04-01 11:46:43 +02:00
f7c6cd3c2a
Make it possible to set a minimum circle width
...
refs #4190
2014-04-01 11:46:43 +02:00
f5e4331d71
Add timeline view script and styles
...
refs #4190
2014-04-01 11:46:43 +02:00
66c3dd26e5
Be window aware when calculating circle widths
...
refs #4190
2014-04-01 11:44:25 +02:00
5d86eab8c4
Do not register context switch on first load
...
refs #4190
2014-04-01 11:44:25 +02:00
18b5f715c5
Refactor timeline components
...
refs #4190
2014-04-01 11:44:25 +02:00
b22f3f6b47
The timeline object is NOT a form
...
refs #4190
2014-04-01 11:44:24 +02:00
5e945e3194
Make interval selection being a widget
...
refs #4190
2014-04-01 11:44:24 +02:00
aade2ab7f6
Move timeline classes into the monitoring module
...
refs #4190
2014-04-01 11:44:24 +02:00
0a146b4bb4
Clientside scrolling implementation [WIP]
...
refs #4190
2014-04-01 11:44:24 +02:00
25f4b50ce7
Implement timeline rendering
...
refs #4190
2014-04-01 11:44:24 +02:00
8e65fc7281
Fix some bugs in the TimelineController
...
refs #4190
2014-04-01 11:44:24 +02:00
40f70eb572
Fix license header
...
refs #4190
2014-04-01 11:44:24 +02:00
a589460de3
Make TimeEntry creation more flexible
...
TimeEntry objects are now created with the fromArray
constructor instead of the default one.
refs #4190
2014-04-01 11:44:23 +02:00
f93d67dfa3
Add timeline controller
...
refs #4190
2014-04-01 11:44:23 +02:00
8d29620350
Rename state history links
2014-03-27 09:47:52 +00:00
Johannes Meyer
Alexander Klimov
Matthias Jentsch
Thomas Gelf
Marius Hein
Eric Lippmann