Matthias Jentsch
c1338898a6
Fix errors in function comments and move IniEditor into single class file
...
refs #4352
2013-08-07 15:58:51 +02:00
Matthias Jentsch
56e47fd084
Add an ini writer for configuration files
...
Add an ini writer that respects the file structure and the comments that may be
already present in the config file. Move Application/Config.php into
Config/Config.php.
refs #4352
2013-08-07 15:58:42 +02:00
Matthias Jentsch
edebbf93ab
Add an IniWriter that preserves the comments in already existing files
...
Add a function to create diffs between two object, add a
FileEditor to edit files line-by-line and add the class PropertyDiff to
describe a single property change.
refs #4352
2013-08-07 15:56:42 +02:00
Eric Lippmann
290c8c5225
CC: Add newline to end of file where missing
...
Following command was used:
$ find application/ library/Icinga/ modules/ -name *.php | xargs sed -i -e :a -e '/./,$!d;/^\n*$/{$d;N;};/\n$/ba;$a\'
2013-08-07 10:27:50 +02:00
Jannis Moßhammer
ab1673f198
Merge branch 'feature/dynamic-forms-4439'
...
resolves #4439
2013-08-06 15:22:30 +02:00
Jannis Moßhammer
ff62a82895
Fix dynamic form validation behaviour, fix documentaion, fix correct isValid() call
...
- When a dynamic form is modified, no validation is performed, but
the form is being populated with $this->populate.
- changed parent::isValid to $this->isValid, otherwise no custom validation
logic could be implemented
- Updated documentation
- Fix CSRF protection by removing the time
refs #4439
2013-08-06 15:08:54 +02:00
Johannes Meyer
66592ecabf
Enable dynamic form elements
...
Expire time of the AcknowledgeForm and hours as well as
minutes of the ScheduleDowntimeForm are now dynamic.
refs #4439
2013-08-06 15:06:20 +02:00
Johannes Meyer
f5162189dd
Implement dynamic form elements
...
Rename "isPostAndValid" to "isSubmittedAndValid" and refactor it.
Add possibility for specific form elements to auto-submit their form.
refs #4439
2013-08-06 15:03:25 +02:00
Johannes Meyer
1b9885f274
Merge branch 'bugfix/fix-hostlist-test-4516'
...
fixes #4516
2013-08-06 14:06:49 +02:00
Marius Hein
584198f00c
Fix hostlist test
...
refs #4516
2013-08-06 14:06:25 +02:00
Johannes Meyer
7ba6d4a74f
Merge branch 'bugfix/forward-fix-4382'
...
fixes #4382
2013-08-06 13:40:19 +02:00
Marius Hein
15999eb880
Change _forward to redirect() to keep url history updates
...
refs #4382
2013-08-06 13:39:10 +02:00
Johannes Meyer
4befc9be94
Merge branch 'feature/preferences-backend-4069'
...
resolves #4069
2013-08-06 12:04:16 +02:00
Marius Hein
27ae3ceb35
Merge branch 'feature/dynamic-forms-4439'
...
fixes #4439
2013-08-06 11:46:15 +02:00
Johannes Meyer
d78a5338df
Rename ConfirmationForm and ConfirmationWithIdentifierForm
...
Rename ConfirmationForm to CommandForm and
ConfirmationWithIdentifierForm to CommandWithIdentifierForm.
refs #4439
2013-08-06 11:14:56 +02:00
Johannes Meyer
3ad4a4281d
Add missing form tests and update documentation
...
refs #4439
2013-08-06 11:11:29 +02:00
Johannes Meyer
5533b632ed
Fix code style and make form name non mandatory
...
refs #4439
2013-08-06 11:11:29 +02:00
Johannes Meyer
f26af0eb12
Update command form tests
...
Update command form tests so that they reflect the new dynamic
functionality and the correct purpose of "isSubmittedAndValid".
refs #4439
2013-08-06 11:11:28 +02:00
Johannes Meyer
8efbe6f613
Move submit and cancel handling
...
Move submit and cancel handling from ConfirmationForm to Form.
refs #4439
2013-08-06 11:11:28 +02:00
Johannes Meyer
fa7379adc7
Enable dynamic form elements
...
Expire time of the AcknowledgeForm and hours as well as
minutes of the ScheduleDowntimeForm are now dynamic.
refs #4439
2013-08-06 11:09:42 +02:00
Johannes Meyer
98e7ab02db
Implement dynamic form elements
...
Rename "isPostAndValid" to "isSubmittedAndValid" and refactor it.
Add possibility for specific form elements to auto-submit their form.
refs #4439
2013-08-06 11:09:42 +02:00
Jannis Moßhammer
cc77a55435
Merge branch 'feature/send-commands-4441'
...
resolves #4441
2013-08-06 09:58:42 +02:00
Marius Hein
c9c5e6ef3c
Send commands: Review fixes
...
refs #4441
2013-08-06 09:32:27 +02:00
Jannis Moßhammer
a58c933a29
Code style and comment fixes
...
refs #4441
2013-08-06 09:32:27 +02:00
Jannis Moßhammer
7675ea0514
Call commandhandler from commandcontroller actions
...
The CommandController now implements the calls to the specific
command methods and sends commands to the icinga process
refs #4441
2013-08-06 09:31:13 +02:00
Jannis Moßhammer
1894054929
Implement first commands, fix obsessing state
...
refs #4441
2013-08-06 09:30:25 +02:00
Jannis Moßhammer
029ff17cec
Add documentation for instances.ini
...
refs #4441
2013-08-06 09:27:37 +02:00
Jannis Moßhammer
c2781f4969
Fix test cases for Confirmation forms
...
refs #4441
2013-08-06 09:27:37 +02:00
Jannis Moßhammer
4f1e6ec720
Code style and comment fixes
...
refs #4441
2013-08-06 09:27:37 +02:00
Jannis Moßhammer
81c2f3b9de
Add list of objects that are affected by a command
...
refs #4441
2013-08-06 09:27:37 +02:00
Jannis Moßhammer
b44de95caa
Call commandhandler from commandcontroller actions
...
The CommandController now implements the calls to the specific
command methods and sends commands to the icinga process
refs #4441
2013-08-06 09:27:37 +02:00
Jannis Moßhammer
2091f63c3b
Implement first commands, fix obsessing state
...
refs #4441
2013-08-06 09:27:37 +02:00
Jannis Moßhammer
d6bbed3a54
Extract the transport functions from the CommandPipe
...
- The CommandPipe class now delegates submission of commands to
the Transport classes (LocalPipe or SecureShell)
- Added SSH options for non-interactive mode
- Refactored tests
refs #4441
2013-08-06 09:27:37 +02:00
Marius Hein
512676ec1a
User preferences: Review fixes
...
refs #4069
2013-08-05 16:56:03 +02:00
Marius Hein
8f1a3b228b
User preferences: remove test code
...
refs #4096
2013-08-05 16:56:03 +02:00
Marius Hein
944c9c13e9
User preferences: Doc fixes
...
refs #4069
2013-08-05 16:56:03 +02:00
Marius Hein
cc9b18376d
User preferences: Add doc, fix initial session write
...
refs #4069
2013-08-05 16:56:03 +02:00
Marius Hein
6112189b0c
User preferences: Add database store
...
refs #4069
2013-08-05 16:56:03 +02:00
Marius Hein
f3ed73175b
User preferences: Session store and glue to build instance
...
refs #4069
2013-08-05 16:56:02 +02:00
Marius Hein
6d1f349616
User preferences: Implement interfaces and ini store
...
refs #4069
2013-08-05 16:56:02 +02:00
Johannes Meyer
9b292e6711
Merge branch 'bugfix/session-path-for-tests-4461'
...
resolves #4461
2013-08-05 14:52:50 +02:00
Jannis Moßhammer
5a82c37ed1
Fix session test save path not being writable for vagrant user
...
The tests now try to write to /tmp and are skipped if this folder
is not writable. Also the test has been refactored a bit (comments,
assertion messages)
regs #4461
2013-08-02 15:35:05 +02:00
Jannis Moßhammer
ce4ea10a0a
Merge branch 'feature/validate-NO_ZERO_IN_DATE-4255'
...
fixes #4255
2013-08-02 15:11:24 +02:00
Thomas Gelf
06fc3e395e
NO_ZERO_IN_DATE is available since MySQL 5.0.2
...
refs #4255
2013-08-02 15:10:09 +02:00
Jannis Moßhammer
e9b002bdcd
Merge branch 'feature/downtime-overview-4188'
...
fixes #4188
2013-08-02 14:53:39 +02:00
Matthias Jentsch
e47954b471
dd downtime overview
...
Add the downtime overview view, add the downtimes controller action, fix issues
with the the DowntimeQuery and add the new fields to the DowntimeView. Fix
issues in the ShowController that occur due to the changes in the DowntimeQuery.
refs #4188
2013-08-02 14:48:16 +02:00
Eric Lippmann
23121c2d76
Merge branch 'feature/refactor-url-4381'
2013-08-02 13:15:03 +02:00
Jannis Moßhammer
5c3eb1d796
Style fixes and addParam test
...
refs #4381
2013-08-02 13:14:56 +02:00
Jannis Moßhammer
50ca1aec1a
Refactor URL class and test
...
The constructor of the class is now private, instantiation happens
with Url::fromRequest and Url::fromPath. Also updated all occurences
of Url and fixed the Qlink helper to not overwrite the baseUrl with null
values
refs #4381
2013-08-02 13:14:55 +02:00
Eric Lippmann
e24d3ca031
Merge branch 'feature/testdoc-4263'
2013-08-02 13:14:43 +02:00