dd500578c9
Url: Fix @return hints
...
Before, sublcasses of Url suffered from @return Url hints. This is
@return static now.
2020-01-14 14:26:14 +01:00
6a8f17faf2
OutputFormat: Just provide the pdf export if there's a hook available
...
Calling `isSupported()` is bad here since there may be IO involved.
2020-01-14 11:01:53 +01:00
9fe43dda5f
ActionController: Drop method `handlerBrowserWindows()`
2020-01-14 10:14:02 +01:00
855bb8ae72
Properly handle window id's and container id's
2020-01-14 10:14:02 +01:00
2d3fc218db
Window: Differentiate between window and container id
2020-01-14 10:14:02 +01:00
d459e58aca
Response: Add methods to override the client's window id
2020-01-14 10:14:02 +01:00
5a58279995
ActionController: Don't render exceptions as PDF
2020-01-10 14:11:52 +01:00
5943e6bde9
Pdf: Restore previous state after rendering content
...
In case an exception occurs its output was previously merged
with the rendered content or even PDF..
2020-01-10 14:11:40 +01:00
4157821c89
IcingaCheckbox: Don't `display:none` the checkbox but add `.sr-only` to it
2019-12-05 16:12:41 +01:00
7b488d7f93
swag: Fix violations of PSR-12
...
PSR-2 has been deprecated and phpcs v3.5.3
now checks for the successor PSR-12
2019-12-04 11:28:08 +01:00
0442c4f0ab
View: Ignore setting `short_open_tag`
...
Adjusting class `Zend_View_Stream` according to https://www.php.net/manual/en/migration74.incompatible.php#migration74.incompatible.core.stream-wrappers
didn't work. (*syntax error, unexpected end of file* after every last php statement in phtml files)
So.. since `<?= ?>` instructions are permanently available since PHP 5.4 (https://www.php.net/manual/en/language.basic-syntax.phptags.php )
we'll just omit using a custom stream wrapper now.
2019-12-04 09:35:24 +01:00
9b1dc44130
FilterEditor: Also trim trailing whitespace from search values
...
Simple values are wrapped with `*` anyway, so trimming all
whitespace doesn't pose an issue. (Even if inserted intentionally)
This doesn't apply to qualified search values. (e.g. `host = abc `)
resolves #4002
2019-12-03 10:33:00 +01:00
9f4e29b56c
JS/CSS: Load modal behavior and styles
2019-11-04 12:46:30 +01:00
c196631f5a
Add Markdown::line()
2019-10-31 14:41:39 +01:00
52d830170f
LessCompiler: Put required assets into a module's css block
...
We have to include these there otherwise mixins from assets
can't be used.
2019-10-01 15:30:17 +02:00
d699191629
Let modules provide css/js assets to be used by other modules ( #3961 )
2019-09-25 09:53:53 +02:00
f98f988aff
Remove tristate form element
2019-09-23 08:36:24 +02:00
9cdf37410c
ApplicationStateMessages: Fix message layout
2019-07-29 10:19:39 +02:00
13ad506393
css: Rename class `icinga-forms` to `icinga-form`
2019-07-29 10:17:59 +02:00
212606de78
setup: Apply new icinga form style
2019-07-29 10:17:59 +02:00
0bc70a840c
SortBox: Apply icinga form style
2019-07-29 10:17:59 +02:00
346083109a
Apply new form style to the filter editor
2019-07-29 10:17:59 +02:00
05613c413d
Enhance toggle-switch, spinner and control-info placement
...
tested with Chromium, IE11 (Win7), Edge (Win10)
2019-07-29 10:17:59 +02:00
115bb80c6a
View: Register our own view helper path
...
That's a different path than application/views/helpers because this one
uses a namespace so that we're able to extend Zend's view helpers
2019-07-29 10:17:59 +02:00
bc2e7588d7
FormNotifications: Don't ignore warning and error notifications
2019-07-29 10:17:59 +02:00
a5f292c2ae
Form: Define classes `icinga-forms` and `icinga-controls` by default
2019-07-29 10:17:59 +02:00
f14256a7ee
CSS: Adapt form design with filter editor
...
refs #3676
2019-07-29 10:17:59 +02:00
f70f996085
Announcements: Increase font-size and align control layout
...
refs #3676
refs #3560
refs #3839
2019-07-29 10:17:59 +02:00
c492c6bb23
Announcements: Avoid duplicate `id attribute
...
refs #3762
2019-07-29 10:17:59 +02:00
c49f5d6a0f
Don't override Zend's Checkbox for our toggle switch
2019-07-29 10:17:59 +02:00
41ee36c7e6
Reduce default textarea rows
2019-07-29 10:17:59 +02:00
bf48b6d26b
WIP: New form styles
...
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2019-07-29 10:17:59 +02:00
9d0ef4cf33
Wrap any markdown output with a `<section>` and remove explicit containers
2019-07-23 14:45:32 +02:00
40529e76ef
Merge pull request #3858 from Icinga/feature/downtime-schedule-times
...
Require time output for downtime schedule and end/expire times
2019-07-18 08:47:55 +02:00
fcde2a9eea
dashboard: Use the non-translated versions of pane and dashlet names for storage
...
This is a dirty quick fix. And calling it *quick* is already an overstatement.
Of course, it's also a breaking change, as **all** non-english users need to
update their dashboard.ini after this change.
Oh, and don't dare to move this over to the new dashboards!
refs #3542
2019-07-18 08:33:35 +02:00
4fdfb190ad
Navigation/DashboardPane: Properly register dashlets as children
...
refs #3542
2019-07-18 08:33:35 +02:00
37a972cf75
dashboard: Differentiate between `name` and `title`
...
The former is the original name while title may
be changed by the user. This change is strictly
necessary for the references bug and should also
be introduced when rewriting this mess.
refs #3542
2019-07-18 08:33:35 +02:00
f8d3f43965
js: Drop vendor library tipsy
2019-07-18 07:57:14 +02:00
c100654412
js: Integrate vendor library jquery-migrate
2019-07-18 07:57:14 +02:00
07586af41f
Remove IE8 & IE9 traces
2019-07-18 07:56:09 +02:00
7cf620f3f1
JS: Use jquery 3.4.1
...
refs #3813
2019-07-18 07:56:09 +02:00
55d35b9e5b
Remove jquery 1.11 dependency
...
refs #3784
2019-07-18 07:56:09 +02:00
e2cddc2d46
js: Introduce storage.js, a localStorage abstraction layer
2019-07-17 13:12:41 +02:00
0574f44bd9
colllapsibleContainer.js: Rename to collapsible.js
2019-07-17 13:12:41 +02:00
b07ffd4987
JS: Implement collapsible-container behavior
2019-07-17 13:12:41 +02:00
f9021e8fdd
Add $requireTime to timeAgo() and timeSince() too
2019-07-15 10:11:52 +02:00
3edda43bca
ActionController: Utilize view variable `$defaultTitle` instead of the constant
...
Allows controllers to also customize the default title with translated contents.
refs #3851
2019-07-15 08:24:44 +02:00
b06103bfc5
NavigationItemRenderer: Don't fail to render an icon if there's none
...
fixes #3859
2019-07-12 07:42:33 +02:00
1351be7da8
Add param to timeUntil() to require time output
...
If the time specified in timeUntil() is at least 3 days in the future,
the output will only contain the month and the day. With $requireTime it
will also ouput the time. This is useful for some views, e.g.
scheduled downtimes.
2019-07-11 13:07:17 +02:00
801a6719b7
Merge pull request #3835 from Icinga/fix/problem-badges-not-visible-if-sidebar-is-collapsed-3568
...
ui: Show problem badges in collapsed sidebar
2019-07-11 08:00:12 +02:00
f0b5d8fd8e
BadgeNavigationItemRenderer: Round counts to the neareset base
...
refs #3568
2019-07-03 11:29:37 +02:00
6aa2cf69c7
HtmlPurifier: Enable cache directory
...
refs #3814
2019-06-27 14:41:13 +02:00
74642d1cf7
FileCache: Add method to prepare sub directories
...
refs #3814
2019-06-25 16:18:26 +02:00
bd2060739e
announcements: Transform markdown markup
2019-06-25 15:04:04 +02:00
1ac5557187
lib: Introduce Markdown view helper
...
refs #3684
2019-06-25 15:01:35 +02:00
dd664aab98
Url: Trim all leading slashes from paths, not just the first
...
refs #3829
2019-06-25 09:18:15 +02:00
b9c2c45af1
CLI: Fix CSS path
...
CLI commands which require our LESS parser had no access to our CSS
because the public path was set to the path of the icingacli executable
which is most likely bin.
2019-06-04 09:43:39 +02:00
dcbb477d3a
AnnouncementIniRepository: Also fetch column `start` in `findActive()`
2019-05-23 10:05:14 +02:00
37df008d7f
AnnouncementIniRepository: Don't transform retrieved timestamps to DateTime
...
refs #3414
2019-04-16 13:03:16 +02:00
3fe810ecf9
Form: Properly preserve defaults from DateTimePicker elements
...
fixes #3612
2019-04-10 10:51:36 +02:00
915c7b8fe5
Merge pull request #3504 from Icinga/fix/collapsible-sidebar-issues-3187
...
Fix collapsible sidebar issues
2019-03-21 09:09:27 +01:00
b3b80fdc31
Make active first-level nav items better distinguishable
2019-03-20 11:07:39 +01:00
61b0d8aa90
Add icon with first letter of the li if there is no icon set else default to icon-circle
2019-03-20 11:07:39 +01:00
9571d1059f
Fix URLs in our image helper having multiple params
2019-01-25 09:20:55 +01:00
4e6b936862
helpers/url: Properly escape image urls
2018-10-10 09:44:11 +02:00
7d47875241
Introduce PdfexportHook
2018-07-18 14:22:18 +02:00
84622bf27b
Fix some XSS vulnerabilities
...
Only a real issue with <= IE9 as other browsers properly escape
urls prior transmission.
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2018-07-16 09:53:30 +02:00
6cddd6beed
Merge pull request #3508 from Icinga/fix/filter-entries-are-deleted-when-pushing-enter-3454
...
FilterEditor: Add a hidden submit button to the start of the form's m…
2018-07-10 09:28:35 +02:00
47405127d0
Add config to hide/show pplication state messages
...
refs #2835
2018-07-09 16:28:28 +02:00
d18d05ccee
Introduce ApplicationStateHook
...
refs #2835
2018-07-09 16:28:25 +02:00
6e6251604b
FilterEditor: Add a hidden submit button to the start of the form's markup
...
When pushing enter our JS mimics what a browser would do. And that is
pushing the first submit button found in the form. Without this, that's
a delete button of the first logical junction. (the root condition)
fixes #3454
2018-07-06 10:41:49 +02:00
189b519135
Merge pull request #3486 from Icinga/fix/request-parses-json-without-respecting-content-type-3484
...
Fix that Request parses json without respecting content type
2018-07-05 13:19:27 +02:00
1f677e64f6
ActionController: Force HTTP redirects in method redirectHttp()
...
That's what its name implies, right? The counterpart is redirectXhr(),
which does still its job. redirectNow() on the other hand is for the
lazy people.
2018-07-04 14:44:03 +02:00
8cbff87af1
Request: Parse the POST body only as JSON if it's really JSON
...
refs #3484
2018-07-04 11:09:11 +02:00
842e5603a1
Request: Introduce method extractMediaType
...
refs #3484
2018-07-04 11:09:11 +02:00
6f1d8668a0
Fix line exceeds 120 characters
2018-06-22 11:04:48 +02:00
ee60a8df99
Don't let AutoRefreshForm handle API requests
...
refs #2749
2018-06-22 11:03:07 +02:00
235e75d054
Form: handle API requests as expected
...
refs #2749
2018-06-22 11:03:07 +02:00
880a0a254f
DateTimePicker: support *nix timestamps
...
refs #2749
2018-06-22 11:03:07 +02:00
a444b8adf5
Request: support JSON as POST data format
...
refs #2749
2018-06-22 11:03:07 +02:00
906c1668a4
Split Json::encode() into Json::encode() and Json::sanitize()
...
refs #2635
2018-06-21 16:01:53 +02:00
02b60633ff
Auto-sanitize only in the monitoring module
...
refs #2635
2018-06-20 18:05:12 +02:00
1a94a21263
Prefer Json::encode() over json_encode()
...
refs #2635
2018-06-20 18:05:11 +02:00
96303f53f8
Merge pull request #3213 from Icinga/feature/drop-php-5-3-support
...
Drop PHP 5.3 support
2018-05-08 03:03:36 -04:00
4bea67e756
Merge pull request #3315 from Icinga/bugfix/php-7-2-support-3185
...
Don't call session_start() after ini_set()
2018-05-07 05:44:52 -04:00
fc1f6e13ab
Drop PHP 5.3 support
2018-05-07 11:36:54 +02:00
71cb682832
Re-introduce class Icinga\Web\Menu
...
refs #2338
2018-04-30 10:24:57 +02:00
1b15048636
Drop obsolete Icinga\Web\Menu classes
...
refs #2338
2018-04-27 14:28:20 +02:00
571b34c8cd
Drop obsolete class Icinga\Web\Menu\BadgeMenuItemRenderer
...
refs #2338
2018-04-27 14:11:03 +02:00
059088c089
Drop obsolete class Icinga\Web\Menu\SummaryMenuItemRenderer
...
refs #2338
2018-04-27 14:10:35 +02:00
d71982e333
Drop obsolete class Icinga\Web\Menu\PermittedMenuItemFilter
...
refs #2338
2018-04-27 14:10:00 +02:00
1c4ebda037
Drop obsolete class Icinga\Web\MenuRenderer
...
refs #2338
2018-04-27 14:04:49 +02:00
1280137eae
Merge branch 'bugfix/form-number-inclusive-range'
2018-04-12 14:32:38 +02:00
5cf51a70c8
Numeric input: validate inclusive ranges
2018-04-12 14:25:10 +02:00
5f24fffe7d
Merge pull request #3412 from Icinga/bugfix/filter-editor-expand-upon-auto-refresh-2964
...
Preserve collapsed FilterEditor subtrees across auto-refreshes
2018-04-06 14:55:19 +02:00
41b105136d
Preserve collapsed FilterEditor subtrees across auto-refreshes
...
refs #2964
2018-04-06 13:54:51 +02:00
72f0e809ae
Pane: Add setter for $name
...
refs #2901
2018-04-06 11:08:20 +02:00
b5dde96746
FilterEditor: save changes on element addition
...
refs #2900
2018-04-04 12:20:52 +02:00
dadd2c80f6
Don't call session_start() after ini_set()
...
refs #3185
2018-01-24 17:38:20 +01:00
72ec132f25
Correct interfaces to conform to PHP 7.2+
2018-01-24 11:50:10 +01:00
e59fa13786
Announcements: Render HTML in announcment messages
...
refs #2641
2018-01-19 16:12:53 +01:00
3b9d8697ed
Introduce class Icinga\Web\Helper\HtmlPurifier
...
refs #2641
2018-01-19 16:12:53 +01:00
362a5b1721
Merge pull request #3271 from Icinga/bugfix/fix-internalurlvalidator
...
InternalUrlValidator: prevent circumvention by URLs on the same VHost
2018-01-18 09:58:32 +01:00
5f441f3ad1
Don't fail to render the whole dashboard in case of a broken dashlet
2018-01-17 13:48:14 +01:00
c2f74d49cb
InternalUrlValidator: prevent circumvention by URLs on the same VHost
2018-01-16 15:40:08 +01:00
705f3a49d9
Merge pull request #3180 from Icinga/feature/url-static-self
...
Url: prefer static over self
2018-01-16 10:52:25 +01:00
a1709a0670
Fix unneccessary log message
...
refs #3189
2017-12-19 15:58:25 +01:00
788272fad7
PhpSession: conform to PHP 7.1
...
refs #3208
2017-12-13 13:38:51 +01:00
810c02a41f
Url: prefer static over self
2017-12-04 10:48:52 +01:00
6409bdc074
Implement persistent "Show more" spoilers
2017-11-27 14:18:42 +01:00
b6b87796ed
Menu: Link to the navigation dashboard if menu entry has children but no URL
2017-11-21 22:55:45 +01:00
e7ca817e81
Make Navigation::findItem() public
...
We need this method public for the navigation dashbaord.
2017-11-21 22:55:45 +01:00
21dbe4ec47
Only render icons of root navigation items
...
The upcoming navigation dashboard creates its links from the menu items in configuration.php.
Now, we encourage users to specify icons for second-level menu items but do not want render them in our menu.
2017-11-21 22:55:45 +01:00
3660606ca1
Allow to set a description for navigation items
...
We will introduce a navigation dashboard for root menu items which do not a have a URL but children.
2017-11-21 22:55:45 +01:00
df1e7683c8
Merge pull request #3041 from Icinga/feature/auto-detaching-dom-elements-3039
...
Implement auto-detaching DOM elements
2017-11-21 16:48:59 +01:00
2493cb8d63
Fix incorrect uses of translation around sprintf
2017-11-21 15:47:46 +01:00
c7ffb41b02
Implement togglable flyover
...
refs #3024
2017-11-21 14:05:12 +01:00
b000c1ae4a
Implement auto-detaching DOM elements
...
refs #3039
2017-11-21 13:17:55 +01:00
71fe12393d
Persist X-Icinga-WindowId across auto-refreshes
2017-11-21 11:30:36 +01:00
bdcb6389d8
Add user preference for default number of items per page
...
refs #2859
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-11-15 16:56:43 +01:00
73a6750489
Make phpcs and PhpStorm happy w/ intentional switch, case fall-throughs
...
Unfortunately, PhpStorm does not regonise PSR2 fall-through comments.
On the other hand, phpcs does not support the @noinspection phpdoc comment (/**).
The fix is a mix of PSR2 comments and @noinspection tags in code comments.
2017-11-08 10:25:28 +01:00
c3ef50978a
style: Fix minor styleguide issues for PHPCS
2017-11-08 10:06:45 +01:00
1f5f610b04
Add newlines to AnnouncementIniRepository.php
2017-11-07 14:48:46 +01:00
5ec14bdb9d
Remove inheritdoc tags in AnnouncementIniRepository.php
2017-11-07 12:50:30 +01:00
2e1bac81ff
Form: Create the form as part of method `setDefaults'
...
We don't care anymore about the BC in Zend version 1.12.7.
Hence we'll happily override setDefaults now. Yay!
refs #2998
2017-10-23 15:10:50 +02:00
d348d95e5e
Revert "Form: Don't prevent disabled elements from getting overwritten.."
...
This reverts commit eb343009bb#2998
2017-10-23 15:10:37 +02:00
c22efa4519
UrlValidator: translate error message
2017-10-20 14:27:33 +02:00
f70fc6e98d
Fix not working SomeType[string] in code docs
...
refs #2980
2017-09-29 12:08:14 +02:00
46014558e6
Merge pull request #2946 from Icinga/bugfix/enhance-code-autocompletion-in-ides-2945
...
Enhance code autocompletion in IDEs
2017-09-08 15:45:25 +02:00
ade0744701
Merge pull request #2923 from Icinga/bugfix/is-not-a-valid-number
...
Form/Element/Number: The field should be valid when empty
2017-09-08 15:32:48 +02:00
356e194612
Enhance code autocompletion in IDEs
...
refs #2945
2017-09-07 11:22:46 +02:00
beb3326631
StyleSheet/JavaScript: Also include Cache-Control when answering with a 304
...
Without Cache-Control, the browser may invalidate its cached file and we're
serving the file again on the next request.
refs #2917
2017-08-22 09:33:28 +02:00
6702ccb2a7
FileCache: Ignore compression suffix when checking cache made of multiple files
...
refs #2917
2017-08-22 09:31:56 +02:00
7b7bfb5a5d
FileCache: Use the correct variable when checking a file's modification time
...
refs #2917
2017-08-22 08:38:13 +02:00
1d06d4e3c4
Form/Element/Number: The field should be valid when empty
2017-08-17 13:20:51 +02:00
eb343009bb
Form: Don't prevent disabled elements from getting overwritten..
...
..if someone just utilizes populate() programatically.
refs #2509
2017-07-13 13:53:48 +02:00
ed5ba14df2
Form: Register form notifications as custom error messages for API requests
...
I'd have liked to fix how we transmit validation messages in such cases,
but for compatibilty reasons this has to suffice..
2017-07-13 13:00:24 +02:00
96c96df636
Form: Don't transmit duplicate error messages
...
Zend_Form::getMessages() already returns custom error messages,
if there are any
2017-07-13 12:59:23 +02:00
b93dc06f5b
ActionController: Let the repsonse itself set its headers
...
The only header that is now set by the ActionController is X-Icinga-Title,
all others are delegated to Icinga\Web\Response.
2017-07-13 12:56:03 +02:00
0d52bb421f
ActionController: Don't re-enable the layout when just setting XHR layout
...
In case someone doesn't want the layout, we should not force it, especially
not for XHR requests.
2017-07-12 16:54:52 +02:00
c0d82fa2cc
Rephrase autosumbit tooltips
...
fixes #1507
2017-07-04 13:59:02 +02:00
53091384cd
Remove unused attributes from the date time picker element
2017-07-04 10:32:30 +02:00
a5990d4de8
Add date and time form elements
2017-07-03 15:03:26 +02:00
f6166b3ab6
ActionController: Allow to control which inline view script to use
...
This also affects that rerendering the layout does only have any effect
in case of XHR requests and is not overwritten anymore in this case.
Since this property was previously private, this should not break anything.
2017-06-28 11:14:01 +02:00
22223acf1d
Controllers: Make all private properties protected
...
Controllers are neither library stuff nor any vital part that need to be
protected from too adventurous module developers.
2017-06-28 09:51:28 +02:00
8ee6e763a6
ActionController: Ensure to utilize the response to redirect and exit
2017-06-19 09:11:12 +02:00
df04c0f837
ActionController: Introduce constant DEFAULT_TITLE
...
Controllers are now allowed to fully customize the page title.
2017-06-09 11:13:37 +02:00
8a890a4a82
ActionController: Allow controllers to customize the login route
2017-05-19 08:39:11 +02:00
b0221c5e13
Form: Preserve default if element has attribute 'disabled'
...
fixes #2509
2017-02-14 10:18:56 +01:00
96f0a8c24e
FilterEditor: escape values correctly
...
refs #12330
2017-02-09 17:50:49 +01:00
Eric Lippmann
Johannes Meyer
Florian Strohmaier
Jennifer Mourek
Alexander A. Klimov
lippserd
Markus Frosch
Noah Hilverling