53 Commits

Author SHA1 Message Date
Alexander A. Klimov
ff6fbdf5f2 Censor arguments in stack traces
refs #2810
2018-01-22 10:28:47 +01:00
Alexander A. Klimov
c650e5c1e3 /error/error: show the whole exception chain 2018-01-19 11:39:22 +01:00
Johannes Meyer
375920f761 Use a more sophisticated inheritance and interface structure for HTTP exceptions (#2881)
HttpExceptionInterface now identifies HTTP exceptions, BaseHttpExceptions supersedes
HttpException as new superclass for other more concrete Exceptions and HttpException
is now a generic class to create new HTTP exceptions on the fly.

resolves #2880
2017-07-05 06:26:58 +02:00
Johannes Meyer
08095ad5e8 ErrorController: Set $this->rerenderLayout in init()
Solves the issue that when being redirected directly after login
or any other route which causes the layout being rerendered, we
are only presented with the inline layout of the error controller.
2017-06-29 09:51:24 +02:00
Johannes Meyer
0fd5e8e4e8 ErrorController: Log the full stacktrace in case of unhandled exceptions 2016-10-13 12:06:23 +02:00
Jennifer Mourek
d98732f663 ErrorController: Don't log exceptions other than HTTP 500
fixes #12760
2016-10-12 12:17:29 +02:00
Alexander A. Klimov
474803fee4 Change all license headers to only reflect a file's year of creation
refs #11000
2016-02-08 15:41:00 +01:00
Eric Lippmann
ec177e78e5 Make error messages accessible 2016-01-25 07:44:48 +01:00
Eric Lippmann
c227bcc94d Rename error layout for guests and support theming
refs #10705
2015-12-10 13:34:54 +01:00
Alexander A. Klimov
8e29fe92a5 Use a login-like layout for error messages displayed to non-authenticated users
refs #10009
2015-09-25 17:40:00 +02:00
Alexander A. Klimov
cd319f8c7d Let the error page look like the login page when a non-authenticated user requests a non-existent page
refs #10009
2015-09-22 18:25:57 +02:00
Eric Lippmann
26d1a04e48 api: Use JsonResponse in the ErrorController
refs #9606
2015-09-07 13:37:00 +02:00
Eric Lippmann
0f8c28d749 Merge branch 'master' into feature/api-9606 2015-09-07 11:33:44 +02:00
Eric Lippmann
1419c8a601 Add missing alias in the ErrorController after namespacing
refs #5786
2015-08-27 13:25:46 +02:00
Eric Lippmann
3809ca1b43 Namespace the ErrorController
refs #5786
2015-08-27 13:25:23 +02:00
Eric Lippmann
30add41572 Handle the HttpBadRequestException in the error controller
refs #9606
2015-08-24 15:59:25 +02:00
Eric Lippmann
1c5a784022 lib: Move Request::sendJson() to Response::sendJson()
refs #9606
2015-08-20 16:05:45 +02:00
Eric Lippmann
870b73ae09 lib: Rename Request::getIsApiRequest() to ::isApiRequest()
There's no setter involved.

refs #9606
2015-08-20 16:02:25 +02:00
Eric Lippmann
e914b733cd Handle API requests in the ErrorController
refs #9606
2015-08-20 15:49:37 +02:00
Eric Lippmann
124173f3c8 Don't provide helpful error messages for unauthenticated users
fixes #6952
2015-05-28 13:17:00 +02:00
Eric Lippmann
d2bb74a2f9 lib: Move HttpNotFoundException beneath the Http Exception namespace
refs #6281
2015-05-22 09:25:49 +02:00
Eric Lippmann
3f608fda24 Handle the HttpMethodNotAllowedException in the ErrorController
refs #6281
2015-05-22 09:15:52 +02:00
Eric Lippmann
5e520e7b59 Don't display a error message as title too
refs #6281
2015-05-21 16:57:43 +02:00
Eric Lippmann
03b4de3253 Handle the HttpNotFoundException in the ErrorController
refs #6281
2015-05-21 16:56:27 +02:00
Eric Lippmann
ce9110d22d Revert "Add proper respond http codes to service and host controller"
This reverts commit 6df031dc786256e0bd42f8047d6c308e90abedf6.

I revert this commit for the following reasons:
- MissingParameterException must not be thrown manually because we have UrlParams::getRequired() which was UrlParams::req() before.
- The commit introduces the untranslated string 'host or service'.
- 4xx are client, not server errors.
- Copy and paste code for the stack trace handling in the ErrorController.

refs #6281
2015-05-21 16:14:02 +02:00
Alexander Fuhr
6df031dc78 Add proper respond http codes to service and host controller
fixes #6281
2015-05-06 14:21:46 +02:00
Eric Lippmann
25736cf76e Return HTTP 400 on MissingParameterException
refs #8886
2015-04-07 12:27:19 +02:00
Eric Lippmann
6bae2e0a53 Note that our license is GPL v2 or any later version in our license header instead of pointing to the license's URL 2015-02-04 10:52:27 +01:00
Eric Lippmann
5b4fab0750 Add license header
This time without syntax errors hopefully :)
2015-02-03 16:27:59 +01:00
Eric Lippmann
5fa2e3cfdc Revert "Add license header"
This reverts commit 338d067aba41dd6e9178cebec5433eecd614196e.
2015-02-03 16:16:26 +01:00
Eric Lippmann
338d067aba Add license header
fixes #7788
2015-02-03 15:51:04 +01:00
Marius Hein
8c24dde17b Error Controller: Move close tab creation to template 2015-02-02 12:08:20 +01:00
Marius Hein
6ec2ee753d Render error messages in the container itself
fixes #6280
2015-01-30 14:50:25 +01:00
Eric Lippmann
d42017018f Return HTTP 403 in case a SecurityException was thrown 2015-01-30 09:31:05 +01:00
Eric Lippmann
16352fc10c Move Logger to the Application namespace
fixes #7148
2014-10-31 10:27:17 +01:00
Marius Hein
751d2e6d11 ErrorController: Log exception and stacktrace
refe #5896
2014-09-01 10:00:04 +02:00
Johannes Meyer
3105c2059e Remove license headers from all files
refs #6309
2014-07-15 13:43:52 +02:00
Johannes Meyer
f2e5d8afa5 Remove @codeCoverageIgnoreStart/-Stop annotations
refs #6091
2014-06-30 13:58:37 +02:00
Thomas Gelf
358b2582bc ErrorController: show valid title for exceptions
Multiline strings are not considered being a valid title. This patch
strips all but the first line from the exception message when setting
the title attribute.
2014-05-20 13:40:52 +00:00
Johannes Meyer
98ca15d1fb Mark less important or non-testable code as skipped for code coverage
refs #6011
2014-04-28 14:06:41 +02:00
Thomas Gelf
4a6fe006d8 Show exception message in title 2014-04-17 16:21:48 +00:00
Alexander Klimov
cdf1a0b683 Write more class documentation 2014-04-02 13:47:02 +02:00
Thomas Gelf
f612610fa7 Friendlier error controller, special handling for 404 with disabled module 2014-03-25 12:10:02 +00:00
Markus Frosch
971a87c608 Fixed executable flags on normal files.
Refs #5040
2014-02-18 09:42:13 +01:00
Eric Lippmann
b9357af893 The ErrorController must not require authentication 2014-02-14 12:12:46 +01:00
Eric Lippmann
2242973568 XHR: Force redirect to login if session is expired
resolves #5507
2014-01-23 16:03:47 +01:00
Eric Lippmann
4473008d65 Show error message and stack trace on exceptions
refs #5507
2014-01-22 14:57:54 +01:00
Eric Lippmann
ca1d50ae53 Rename Icinga 2 Web to Icinga Web 2 2013-10-23 15:11:06 +02:00
Eric Lippmann
aff2398c81 Application/Controllers: Follow our Coding Standards
refs #4512
2013-08-16 15:08:28 +02:00
Jannis Moßhammer
be29b8ff8f Make ConfigController and PreferenceController extensible by convention
- Rename ConfigurationController to ConfigController
- ConfigController and PreferenceController are now subclasses of
  BaseConfigController and BasePreferenceController
- Module and Application Config/Preference Tabs are detected via
  the ControllerTabCollector
- Moved Controller classes to Icinga/Web/Controller (this is why
  so many files are modified)

refs #4530
2013-08-14 16:08:15 +02:00