3902 Commits

Author SHA1 Message Date
Eric Lippmann
39a5b3f64a Refuse to enable modules prefixed w/ icingaweb2-module-
fixes #10870
2016-11-16 16:21:35 +01:00
Eric Lippmann
1cdef234a1 Revert "Module: Drop deprecated method registerHook and arg $key of method provideHook"
This reverts commit f1a1f411922f993e53780f5b5f3b17fc425814b1.

It makes absolutely sense to remove depcreated code, but this removal introduces too many problems while not being really necessary.
Some of our modules and modules written by others still rely on the deprecated code. A upgrade of Icinga Web 2 would break many running systems out there.
Before removing this code we should upgrade our modules and notify the authors of other modules about the deprecation.
Further, we should maintain something like a deprecation info file because nobody reads @deprecated tags.
All of the above will not protect us from systems where modules aren't up to date. We also have to implement a mechanism where it is still possible to disable faulty modules.
2016-11-16 16:17:42 +01:00
Eric Lippmann
f7e5cd3b71 Check the correct return type in case preg_replace fails in ExternalBackend.php 2016-11-16 14:10:31 +01:00
Johannes Meyer
3a816ce0f7 ExternalBackend: Don't throw an error if it's not possible to clean usernames 2016-11-16 12:04:46 +01:00
Johannes Meyer
0bd00ba3d0 ExternalBackend: Simplify how remote users are identified
refs #12164
2016-11-16 11:55:54 +01:00
Johannes Meyer
e75bfbc197 Response: Add ;charset=UTF-8 to the default content type
resolves #13117
2016-11-15 13:30:16 +01:00
Johannes Meyer
7d98025d7d Merge branch 'bugfix/hooks-don-t-respect-module-permissions-12396'
fixes #12396
2016-11-14 09:46:08 +01:00
Johannes Meyer
f1a1f41192 Module: Drop deprecated method registerHook and arg $key of method provideHook 2016-11-11 16:15:59 +01:00
Johannes Meyer
5bce7dc9b8 Hook: Check a user's module permission before providing it's hook instances
refs #12396
2016-11-11 16:15:16 +01:00
Alexander A. Klimov
1cd2cfbdc9 Revert "Make hooks respect module permissions"
This reverts commit 4d2e6d2d8709da9168af824c36458dd5857b08a8.
2016-11-11 11:14:23 +01:00
Johannes Meyer
f7a8524dce DbUserGroupBackend: Group by group.id when joining group memberships
Prevents duplicate results in case a group has multiple members.
2016-11-11 09:19:59 +01:00
Johannes Meyer
3a619eb8c7 DbConnection: Don't ignore asterisks when rendering filters
refs #11885
2016-11-11 09:18:53 +01:00
Johannes Meyer
634a69aec9 DbConnection: Explicitly check for NULL when rendering unequal filters
resolves #12852
2016-11-11 09:17:58 +01:00
Eric Lippmann
403e8d6912 Update HTMLPurifier to version 4.8.0 and let the Web 2 rpm depend on it 2016-11-10 16:04:49 +01:00
Eric Lippmann
c1d7d7005b Update dompdf to version 0.7.0 and let the Web 2 rpm depend on it 2016-11-10 14:59:18 +01:00
Johannes Meyer
0152a5941d DbQuery: Fix wrong operator precedence when rendering unequal filters
fixes #13107
refs #12852
2016-11-10 13:10:31 +01:00
Alexander A. Klimov
14363e52f4 Revert "Merge branch 'feature/emit-log-messages-in-the-webserver-s-log-11652'"
This reverts commit f27e8c059d1d34925e4ecd33fb7aa70004abbbc3.

refs #11652
2016-11-09 11:48:17 +01:00
Johannes Meyer
0ef81a2e0b Response: Use a constant for the default content type
There is already setHeader() to adjust this dynamically.

refs #12161
2016-11-09 11:38:04 +01:00
Eric Lippmann
2b060d9bd4 Challenge API requests only if the controller requires auth
fixes #12580
2016-11-07 10:40:38 +01:00
Alexander A. Klimov
d9330486e9 Replace ExternalBackend::getRemoteUserEnvvars() with an attribute
refs #12164
2016-11-04 17:27:36 +01:00
Alexander A. Klimov
f27e8c059d Merge branch 'feature/emit-log-messages-in-the-webserver-s-log-11652'
resolves #11652
2016-11-04 17:15:06 +01:00
Alexander A. Klimov
1fd0896a7d Merge branch 'feature/inirepository-should-support-multiple-tables-13034'
resolves #13034
2016-11-04 10:37:44 +01:00
Johannes Meyer
ad79e67550 IniRepository: Reduce complexity of method getDataSource
refs #13034
2016-11-04 10:17:37 +01:00
Johannes Meyer
c44e164de9 IniRepository: Introduce method createConfig
refs #13034
2016-11-04 10:16:45 +01:00
Johannes Meyer
a0db5bea87 IniRepository: Don't call getDataSource over and over again
refs #13034
2016-11-04 10:15:56 +01:00
Johannes Meyer
3c5fe76cc0 IniRepository: Directly pass the key column to method extractSectionName
refs #13034
2016-11-04 10:04:42 +01:00
Johannes Meyer
ac3e182f0d IniRepository: Make key column validation in the constructor more readable
refs #13034
2016-11-04 09:59:37 +01:00
Johannes Meyer
ca689bc944 IniRepository: Improve documentation of attribute $configs
refs #13034
2016-11-04 09:57:56 +01:00
Johannes Meyer
df47026792 Repository: Fix documentation of method getDataSource
refs #13034
2016-11-04 09:56:53 +01:00
Alexander A. Klimov
1f74cee21b Merge branch 'bugfix/hosts-without-services-are-hidden-from-restricted-roles-12852'
fixes #12852
fixes #10537
2016-11-03 19:27:30 +01:00
Alexander A. Klimov
bd7851d15c IniRepository: improve initialization of per-table datasources
refs #13034
2016-11-03 18:05:05 +01:00
Alexander A. Klimov
38602379be Repository: allow not to provide a datasource for all tables
refs #13034
2016-11-03 16:12:09 +01:00
Alexander A. Klimov
e5b24eb467 IniRepository: fix doc and method order
refs #13034
2016-11-03 16:00:20 +01:00
Alexander A. Klimov
fb3f3ed788 IniRepository: add support for per-table datasources
refs #13034
2016-11-03 15:06:37 +01:00
Alexander A. Klimov
e655699917 Repository: add support for per-table datasources
refs #13034
2016-11-03 14:35:18 +01:00
Alexander A. Klimov
a85d259b0a PhpWriter: replace newlines in the message only if PHP logs to Syslog
refs #11652
2016-11-03 14:06:02 +01:00
Alexander A. Klimov
8952434393 PhpWriter: prefix messages with the app name as in Syslog
refs #11652
2016-11-03 12:35:40 +01:00
Alexander A. Klimov
a24999ff7f PhpWriter: throw an exception on logging failure
refs #11652
2016-11-03 12:16:48 +01:00
Alexander A. Klimov
ca8e4ea924 Conform to code style guidelines
refs #11652
2016-11-03 12:01:03 +01:00
Johannes Meyer
4a791e6204 IniRepository: Don't fail if there is no trigger to be found 2016-11-02 13:25:37 +01:00
Johannes Meyer
82c7a51050 IniRepository: Don't require a key column before the onInsert trigger
fixes #13005
2016-10-31 08:37:15 +01:00
Johannes Meyer
d207dcbd03 Url: Throw ProgrammingError when trying to use Url::from* on the CLI
refs #7051
2016-10-28 11:47:45 +02:00
Johannes Meyer
957ad9361f IniRepository: Add support for triggers 2016-10-27 15:11:21 +02:00
Johannes Meyer
f644860529 IniRepository: Fix that method update and delete fail without filter 2016-10-27 15:09:00 +02:00
Alexander A. Klimov
5212b6bab9 IniRepository: don't persist the key column as regular column 2016-10-26 10:27:30 +02:00
Alexander A. Klimov
418a428f1e Merge branch 'feature/allow-to-configure-the-syslog-facility-11214'
resolves #11214
2016-10-24 11:58:21 +02:00
Alexander A. Klimov
00af3d61b7 LoggingConfigForm: provide less Syslog facilities
refs #11214
2016-10-24 10:43:27 +02:00
Alexander A. Klimov
52e6293b96 Allow to configure the Syslog facility
refs #11214
2016-10-21 17:09:22 +02:00
Alexander A. Klimov
4d2e6d2d87 Make hooks respect module permissions
refs #12396
2016-10-20 18:28:19 +02:00
Alexander A. Klimov
7d94c1fddb DbQuery: handle strange NULL comparision results
refs #12852
2016-10-20 15:40:33 +02:00