Eric Lippmann 666bdfb4c4 Revert "Fix double query execution"
This reverts PR 6ea012af7e0fe409ecbff2b1e455d237a5f44d69, reversing
changes made to be5b9f870b5124df4516dfac39383810efec6899.

The reverted commit fixed a double query execution bug by only executing
the query once in either SimpleQuery::hasResult() or upon iteration.

But the fix (b20291a60) introduced two problems:

* Default sort rules no longer work
* Show more links missing

We work with DataView objects in our controllers and views. When
iterating over a DataView, it applies its default sort rules and then
returns the underlying query, see DataView::getIterator().

DataView::hasResult() on the other hand does not apply the default sort
rules. So, if hasResult() is called first, the default sort rules are no
longer applied because the query will be executed only once.
The fix would be as easy as to apply sorting in DataView::hasResult() as
well.

But now the show more part kicks in. We know whether there are more
results because we execute queries with $limit + 1. This is enabled via
SimpleQuery::peekAhead(). Unfortunately, we call
SimpleQuery::peekAhead() ALWAYS after SimpleQuery::hasResult(). And
that's why the show more links are missing because the query is executed
only once with the "wrong" limit.

For now, we just revert the commit in question and postpone a proper fix
for the double execution.
2019-08-07 13:29:57 +02:00
2016-02-08 15:54:48 +01:00
2019-08-05 15:47:17 +02:00
2018-12-05 14:57:38 +01:00
2019-07-30 10:19:53 +02:00
2018-12-05 14:57:38 +01:00
2019-07-30 10:19:53 +02:00
2013-07-03 14:17:48 +02:00
2018-12-05 14:57:37 +01:00
2019-07-02 12:03:05 +02:00
2019-05-06 12:52:30 +02:00
2019-07-30 10:19:53 +02:00

Icinga Web 2

Build Status Github Tag

Icinga Logo

  1. About
  2. License
  3. Installation
  4. Documentation
  5. Support
  6. Contributing

About

Icinga Web 2 is the next generation open source monitoring web interface, framework and command-line interface developed by the Icinga Project, supporting Icinga 2, Icinga Core and any other monitoring backend compatible with the IDO database.

Icinga Web 2 with Graphite Icinga Web 2 Sidebar Collapsed

License

Icinga Web 2 and the Icinga Web 2 documentation are licensed under the terms of the GNU General Public License Version 2, you will find a copy of this license in the COPYING file included in the source package.

Installation

For installing Icinga Web 2 please check the installation chapter in the documentation.

Documentation

The documentation is located in the doc/ directory and also available on icinga.com/docs.

Support

Check the project website for status updates. Join the community channels for questions or ask an Icinga partner for professional support.

Contributing

There are many ways to contribute to Icinga -- whether it be sending patches, testing, reporting bugs, or reviewing and updating the documentation. Every contribution is appreciated!

Please continue reading in the contributing chapter.

Security Issues

For reporting security issues please visit this page.

Description
A lightweight and extensible web interface to keep an eye on your environment. Analyse problems and act on them.
Readme GPL-2.0 74 MiB
Languages
PHP 81.7%
HTML 9.1%
JavaScript 5.6%
Less 3.6%